47135 2010-10-04 17:26:20 -0700 Implement ApplicationCacheHost::stopLoadingInFrame(Frame*) for Chromium 2011-03-15 16:15:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hclam michaeln michaeln oldest_to_newest 289324 0 hclam 2010-10-04 17:26:20 -0700 WebKit r69041 added this new method. Since we have a separate implementation of the file we need to implement it correctly. 289856 1 michaeln 2010-10-05 13:52:35 -0700 I see, we just need an empty impl of the new method... void ApplicatinCacheHost::stopLoadingInFrame(Frame*) { // N/A to the chromium port which doesn't use webcore's loader. } So the build fix is the real fix (modulo the comment). 360509 2 84355 michaeln 2011-03-01 18:55:21 -0800 Created attachment 84355 cleanup 360964 3 84355 michaeln 2011-03-02 12:06:02 -0800 Comment on attachment 84355 cleanup nm... i'll just commit these unreviewed 368021 4 michaeln 2011-03-15 16:15:23 -0700 the code comment has been changed 84355 2011-03-01 18:55:21 -0800 2011-03-02 12:06:02 -0800 cleanup cleanup.txt text/plain 3504 michaeln SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MDA4MSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDMtMDEgIE1pY2hhZWwgTm9yZG1hbiAgPG1pY2hhZWxuQGdvb2dsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xlYW51cCBh IGNvZGUgY29tbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ3MTM1CisKKyAgICAgICAgKiBzcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QXBwbGljYXRpb25DYWNoZUhvc3Q6OnN0b3BMb2FkaW5nSW5GcmFt ZSk6CisKIDIwMTEtMDMtMDEgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCShyZXZpc2lvbiA4 MDA3NykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU5LDcgKzI1OSw5IEBAIHZvaWQgQXBwbGljYXRpb25D YWNoZUhvc3Q6OnN0b3BEZWZlcnJpbmcKIAogdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6c3Rv cExvYWRpbmdJbkZyYW1lKEZyYW1lKiBmcmFtZSkKIHsKLSAgICAvLyBGSVhNRTogSW1wbGVtZW50 IHRoaXMgbWV0aG9kLgorICAgIC8vIE4vQSB0byB0aGUgY2hyb21pdW0gcG9ydCwgdXBkYXRlIGpv YnMgZG8gbm90IHJ1biBpbiB0aGUgY2hpbGQgcHJvY2Vzcy4KKyAgICAvLyBUaGlzIG1ldGhvZCBp cyBpbnRlbmRlZCB0byBzdG9wQ2FjaGVPclVwZ3JhZGVBdHRlbXB0SW5GcmFtZSB0byBhdm9pZAor ICAgIC8vIGEgY3Jhc2ggb24gZnJhbWUgY2xvc2UuCiB9CiAKIHZvaWQgQXBwbGljYXRpb25DYWNo ZUhvc3Q6OmRpc3BhdGNoRE9NRXZlbnQoRXZlbnRJRCBpZCwgaW50IHRvdGFsLCBpbnQgZG9uZSkK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDgwMDgxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDEgIE1pY2hhZWwgTm9yZG1hbiAg PG1pY2hhZWxuQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBleHBlY3RhdGlvbnMgdXBkYXRlLgorICAgICAgICBT S0lQIGEgY291cGxlIG9mIGFwcGNhY2hlIHRlc3RzIHRoYXQgZG9uJ3QgYXBwbHkgdG8gb3VyIHBv cnQuCisgICAgICAgIE9uZSBoYXZpbmcgdG8gZG8gd2l0aCBxdW90YXMgd2hpY2ggYXJlIGhhbmRs ZWQgZGlmZmVyZW50bHksCisgICAgICAgIGFuZCBhbm90aGVyIHdpdGggdGhlIGJsb2NraW5nIG9m IGNyb3NzLW9yaWdpbiBodHRwcyByZXNvdXJjZXMsCisgICAgICAgIHdoaWNoIGFyZSBhbGxvd2Vk IGluIGNocm9taXVtIHByb3ZpZGVkIHRoZSByZXNvdXJjZSBkb2Vzbid0IGhhdmUKKyAgICAgICAg YSAibm8tc3RvcmUiIGhlYWRlci4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0wMy0wMSAgVG9ueSBHZW50aWxjb3JlICA8dG9ueWdA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZXhwZWN0YXRpb25zCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0CShyZXZpc2lvbiA4MDA3NykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMTcxNyw4ICsxNzE3LDEyIEBA IEJVR0NSMjg0NCBNQUMgTElOVVggOiBodHRwL3Rlc3RzL2FwcGNhY2gKIEJVR0NSMjg0NCBTS0lQ IDogaHR0cC90ZXN0cy9hcHBjYWNoZS9pZGVtcG90ZW50LXVwZGF0ZS5odG1sID0gRkFJTAogQlVH Q1IyODQ0IFNLSVAgOiBodHRwL3Rlc3RzL2FwcGNhY2hlL3RvcC1mcmFtZS0yLmh0bWwgPSBGQUlM CiAKLS8vIFRoaXMgdGVzdCBmYWlscyBiZWNhdXNlIHRoZXJlIGlzIG5vIHNldEFwcENhY2hlTWF4 aW11bVNpemUgQVBJIHlldC4KKy8vIFNraXAgYXBwY2FjaGUgcXVvdGEgcmVsYXRlZCB0ZXN0cy4K IEJVR0NSMjg0NCBTS0lQIDogaHR0cC90ZXN0cy9hcHBjYWNoZS9tYXgtc2l6ZS5odG1sID0gRkFJ TAorQlVHV0s0MzQ1OSBTS0lQIDogaHR0cC90ZXN0cy9hcHBjYWNoZS9vcmlnaW4tcXVvdGEuaHRt bCA9IFRFWFQgTUlTU0lORworCisvLyBTa2lwIGFuIG92ZXJseSByZXN0cmljdGl2ZSBjcm9zcy1v cmlnaW4gSFRUUFMgdGVzdAorQlVHQ1I2OTU5NCBTS0lQIDogaHR0cC90ZXN0cy9hcHBjYWNoZS9k aWZmZXJlbnQtaHR0cHMtb3JpZ2luLXJlc291cmNlLW1haW4uaHRtbCA9IEZBSUwKIAogLy8gRmxh a2luZXNzIGRvY3VtZW50ZWQgYXJvdW5kIFdlYmtpdCBSb2xsIDUxNjgxOjUxNzExCiBCVUdDUjI4 NDQgU0tJUCA6IGh0dHAvdGVzdHMvYXBwY2FjaGUvNDA0LW1hbmlmZXN0Lmh0bWwgPSBUSU1FT1VU IFBBU1MKQEAgLTIzMjAsOSArMjMyNCw2IEBAIEJVR0NSNDk5NzAgOiBwbGF0Zm9ybS9jaHJvbWl1 bS9wbHVnaW5zL2MKIC8vIEZsYWt5IHNpbmNlIFdlYktpdCByNjM5OTQKIEJVR1dLNDI5NjQgV0lO IExJTlVYIDogdGFibGVzL21vemlsbGFfZXhwZWN0ZWRfZmFpbHVyZXMvYnVncy9idWc4OTMxNS5o dG1sID0gUEFTUyBGQUlMCiAKLS8vIEFwcGxpY2F0aW9uIENhY2hlIFF1b3RhcwotQlVHV0s0MzQ1 OSA6IGh0dHAvdGVzdHMvYXBwY2FjaGUvb3JpZ2luLXF1b3RhLmh0bWwgPSBURVhUIE1JU1NJTkcK LQogLy8gRml4ZWQgb25seSBvbiBNYWMKIC8vIFRoaXMgdGVzdCBoYXMgbm90IGxhbmRlZCB5ZXQs IHRob3VnaCB0aGUgZml4IGhhcy4KIC8vQlVHV0s0MTk2OCBMSU5VWCBXSU4gOiBzdmcvaGl0dGVz dC9zdmctcmVjdC1oaXQuaHRtbCA9IFRFWFQK