47132 2010-10-04 16:35:14 -0700 Remove unused CachedResource::Status values 2010-10-05 11:25:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth commit-queue xan.lopez oldest_to_newest 289286 0 japhet 2010-10-04 16:35:14 -0700 CachedResource::New and CachedResource::NotCached are not in use. 289291 1 69716 japhet 2010-10-04 16:38:57 -0700 Created attachment 69716 patch 289381 2 69716 xan.lopez 2010-10-04 21:14:31 -0700 Comment on attachment 69716 patch Maybe you can change m_status to be unsigned m_status : 2; now. 289483 3 69716 commit-queue 2010-10-05 01:04:15 -0700 Comment on attachment 69716 patch Rejecting patch 69716 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build', '--no-clean', '--no-update', '--build', '--build-style=both', '--quiet']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/4147076 289771 4 69716 japhet 2010-10-05 11:25:34 -0700 Comment on attachment 69716 patch Clearing cq+, I just landed this http://trac.webkit.org/changeset/69125 69716 2010-10-04 16:38:57 -0700 2010-10-05 11:25:34 -0700 patch cr.txt text/plain 2230 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTA1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMDQgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgdW51c2VkIENhY2hlZFJlc291cmNlOjpTdGF0dXMgdmFsdWVzIChOZXcgYW5kIE5vdENh Y2hlZCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NzEzMgorCisgICAgICAgIFJlZmFjdG9yIG9ubHksIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAq IGxvYWRlci9DYWNoZWRSZXNvdXJjZS5oOgorICAgICAgICAqIGxvYWRlci9DYWNoZWRSZXNvdXJj ZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZUxvYWRlcjo6Y2hl Y2tDYWNoZU9iamVjdFN0YXR1cyk6CisKIDIwMTAtMTAtMDQgIEVucmljYSBDYXN1Y2NpICA8ZW5y aWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IFdlYkNvcmUvbG9hZGVyL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2xvYWRlci9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDY5MDM3KQor KysgV2ViQ29yZS9sb2FkZXIvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNDcsMTkgKzM0Nyw5IEBACiB2b2lkIENhY2hlZFJlc291cmNlTG9hZGVyOjpjaGVja0Nh Y2hlT2JqZWN0U3RhdHVzKENhY2hlZFJlc291cmNlKiByZXNvdXJjZSkKIHsKICAgICAvLyBSZXR1 cm4gZnJvbSB0aGUgZnVuY3Rpb24gZm9yIG9iamVjdHMgdGhhdCB3ZSBkaWRuJ3QgbG9hZCBmcm9t IHRoZSBjYWNoZSBvciBpZiB3ZSBkb24ndCBoYXZlIGEgZnJhbWUuCi0gICAgaWYgKCFyZXNvdXJj ZSB8fCAhZnJhbWUoKSkKKyAgICBpZiAoIXJlc291cmNlIHx8ICFmcmFtZSgpIHx8IHJlc291cmNl LT5zdGF0dXMoKSAhPSBDYWNoZWRSZXNvdXJjZTo6Q2FjaGVkKQogICAgICAgICByZXR1cm47CiAK LSAgICBzd2l0Y2ggKHJlc291cmNlLT5zdGF0dXMoKSkgewotICAgICAgICBjYXNlIENhY2hlZFJl c291cmNlOjpDYWNoZWQ6Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBDYWNoZWRS ZXNvdXJjZTo6Tm90Q2FjaGVkOgotICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpVbmtub3du OgotICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpOZXc6Ci0gICAgICAgIGNhc2UgQ2FjaGVk UmVzb3VyY2U6OlBlbmRpbmc6Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgfQotCiAgICAgLy8g RklYTUU6IElmIHRoZSBXZWJLaXQgY2xpZW50IGNoYW5nZXMgb3IgY2FuY2VscyB0aGUgcmVxdWVz dCwgV2ViQ29yZSBkb2VzIG5vdCByZXNwZWN0IHRoaXMgYW5kIGNvbnRpbnVlcyB0aGUgbG9hZC4K ICAgICBmcmFtZSgpLT5sb2FkZXIoKS0+bG9hZGVkUmVzb3VyY2VGcm9tTWVtb3J5Q2FjaGUocmVz b3VyY2UpOwogfQpJbmRleDogV2ViQ29yZS9sb2FkZXIvQ2FjaGVkUmVzb3VyY2UuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9DYWNoZWRSZXNvdXJjZS5oCShyZXZpc2lvbiA2OTAzNykK KysrIFdlYkNvcmUvbG9hZGVyL0NhY2hlZFJlc291cmNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY3 LDkgKzY3LDcgQEAKICAgICB9OwogCiAgICAgZW51bSBTdGF0dXMgewotICAgICAgICBOb3RDYWNo ZWQsICAgIC8vIHRoaXMgVVJMIGlzIG5vdCBjYWNoZWQKICAgICAgICAgVW5rbm93biwgICAgICAv LyBsZXQgY2FjaGUgZGVjaWRlIHdoYXQgdG8gZG8gd2l0aCBpdAotICAgICAgICBOZXcsICAgICAg ICAgIC8vIGluc2VydGluZyBuZXcgaXRlbQogICAgICAgICBQZW5kaW5nLCAgICAgIC8vIG9ubHkg cGFydGlhbGx5IGxvYWRlZAogICAgICAgICBDYWNoZWQgICAgICAgIC8vIHJlZ3VsYXIgY2FzZQog ICAgIH07Cg==