47111 2010-10-04 14:01:27 -0700 stencil support should be optional in tests context*.html 2010-11-09 20:24:21 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo enne cmarrin commit-queue enne kbr oldest_to_newest 289122 0 zmo 2010-10-04 14:01:27 -0700 Currently if stencil buffer is not supported, these tests will fail. They should pass instead. 289126 1 enne 2010-10-04 14:05:24 -0700 Thanks for filing this so that we can track it. kbr had mentioned to me that updating the spec regarding the stencil buffer had been discussed at the Khronos face-to-face. I was going to wait until the spec had been updated to make the test match that. If it's the case that the only addition is to make it acceptable for the stencil buffer to be provided even if it was not requested, then we could go ahead and update this test now. 289334 2 kbr 2010-10-04 18:09:36 -0700 The spec has finally been updated (apologies for this taking so long) so please feel free to go ahead with this work. 306798 3 enne 2010-11-09 08:03:55 -0800 Stencil support is now optional in context-attributes-alpha-etc.html. I will go ahead and remove the now redundant context-attributes.html test. 306818 4 73382 enne 2010-11-09 09:00:26 -0800 Created attachment 73382 Patch 306840 5 cmarrin 2010-11-09 09:56:35 -0800 Remind me about our policy regarding stencil. Support for it is required in OpenGL ES 2.0, isn't it? 306852 6 enne 2010-11-09 10:09:53 -0800 (In reply to comment #5) > Remind me about our policy regarding stencil. Support for it is required in OpenGL ES 2.0, isn't it? In the past, context-attributes.html used to test various permutations of default attributes and non-default attributes, verifying that the defaults and the requests were as expected in getContextAttributes. As per section 2.1 of the WebGL spec, context creation attributes are now requests and not requirements. There is no way to test (in a layout or conformance test) what the defaults are anymore. So, context-attributes.html is now redundant when compared to context-attributes-alpha-depth-stencil.html and I'd like to remove it. In a technical sense, support for stencil is not required by the spec as it stands. In a practical sense, given the "the implementation should make a best effort" language, it should be supported everywhere. 306873 7 cmarrin 2010-11-09 10:54:30 -0800 (In reply to comment #6) > (In reply to comment #5) > > Remind me about our policy regarding stencil. Support for it is required in OpenGL ES 2.0, isn't it? > > In the past, context-attributes.html used to test various permutations of default attributes and non-default attributes, verifying that the defaults and the requests were as expected in getContextAttributes. > > As per section 2.1 of the WebGL spec, context creation attributes are now requests and not requirements. There is no way to test (in a layout or conformance test) what the defaults are anymore. So, context-attributes.html is now redundant when compared to context-attributes-alpha-depth-stencil.html and I'd like to remove it. > > In a technical sense, support for stencil is not required by the spec as it stands. In a practical sense, given the "the implementation should make a best effort" language, it should be supported everywhere. I'm not sure if the spec says that stencil support is optional. Certainly there is language in the attributes section about the fact that the attributes are requests rather than requirements. But by that logic depth buffer support would also be optional. Is that true? I was unable to find any requirements in the OpenGL or OpenGL ES 2.0 specs about minimum drawing buffer requirements. Section 6.3 Framebuffer Object Attachments talks about combinations of stencil and depth buffers, but implies that some combination will always work. But that language could be made more clear as well. 306881 8 enne 2010-11-09 11:09:07 -0800 (In reply to comment #7) > I'm not sure if the spec says that stencil support is optional. Certainly there is language in the attributes section about the fact that the attributes are requests rather than requirements. But by that logic depth buffer support would also be optional. Is that true? "The passed attributes are requests, not requirements. The WebGL implementation does not guarantee that they will be obeyed, but should make a best effort to honor them." By my reading of that language, depth support is optional if for some reason the implementation's "best effort" couldn't support it. This seems unlikely to ever occur. > Section 6.3 Framebuffer Object Attachments talks about combinations of stencil and depth buffers, but implies that some combination will always work. But that language could be made more clear as well. I think this is already specified in section 2.1: "Combinations of attributes not supported by the WebGL implementation or graphics hardware shall not cause a failure to create a WebGLRenderingContext." 306883 9 enne 2010-11-09 11:12:32 -0800 Additionally, I think this is a secondary discussion. I believe that my attached patch brings the conformance tests into alignment with the current spec. I would like to get it reviewed and committed. Chris, if you want to change the language of the spec (and then change the tests to reflect that), we should have that conversation elsewhere. 307095 10 73382 kbr 2010-11-09 17:57:14 -0800 Comment on attachment 73382 Patch As Adrienne points out, the WebGL spec is deliberately written so that implementations that don't have stencil buffer support can be compliant. The context-attributes-alpha-depth-stencil-antialias.html test verifies that all of the configurations in this test produce a valid WebGL context (and do more work with the context than this test does) so I think that removing it is fine. r=me 307145 11 73382 commit-queue 2010-11-09 20:24:16 -0800 Comment on attachment 73382 Patch Clearing flags on attachment: 73382 Committed r71713: <http://trac.webkit.org/changeset/71713> 307146 12 commit-queue 2010-11-09 20:24:21 -0800 All reviewed patches have been landed. Closing bug. 73382 2010-11-09 09:00:26 -0800 2010-11-09 20:24:16 -0800 Patch bug-47111-20101109090025.patch text/plain 5476 enne ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwZDQ4MzZlNmI2ZmRhNThkNzE1YTM1M2QxYjc1ODRkMjkxZTYyZmVjLi44OTI1OGZi NmNlM2Y0ZGJlZTI4MzAyNGZiZmM2MDlhNTIwM2VmNmNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDkgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmluZyBjb250ZXh0 LWF0dHJpYnV0ZXMuaHRtbCB3ZWJnbCB0ZXN0IGFzIGl0IGlzIG5vdyByZWR1bmRhbnQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzExMQorCisgICAg ICAgICogZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dDog UmVtb3ZlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9jb250ZXh0LWF0dHJpYnV0ZXMu aHRtbDogUmVtb3ZlZC4KKwogMjAxMC0xMS0wOCAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCB1cGRhdGluZyBDaHJvbWl1bSBleHBlY3Rh dGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9jb250ZXh0 LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wv Y29udGV4dC1hdHRyaWJ1dGVzLWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMzVlOGI5ZDljZmNmODYzZTU1YjQyYzQyZmQ0ZTNiNGRjNGI5NzRiOS4uMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy93ZWJnbC9jb250ZXh0LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CisrKyAvZGV2L251bGwK QEAgLTEsMzkgKzAsMCBAQAotVGVzdCBwYXNzaW5nIGRvd24gYW5kIGZldGNoaW5nIG9mIFdlYkdM Q29udGV4dEF0dHJpYnV0ZXMKLQotT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi1UZXN0IGRl ZmF1bHQgdmFsdWVzCi1QQVNTIGNvbnRleHQgPSBjcmVhdGUzRENvbnRleHQobnVsbCkgaXMgbm9u LW51bGwuCi1QQVNTIGF0dHJpYnMgPSBjb250ZXh0LmdldENvbnRleHRBdHRyaWJ1dGVzKCkgaXMg bm9uLW51bGwuCi1QQVNTIGF0dHJpYnMuZGVwdGggaXMgdHJ1ZQotUEFTUyBhdHRyaWJzLmFscGhh IGlzIHRydWUKLVBBU1MgYXR0cmlicy5zdGVuY2lsIGlzIGZhbHNlCi1QQVNTIGF0dHJpYnMuYW50 aWFsaWFzID09IHRydWUgfHwgYXR0cmlicy5hbnRpYWxpYXMgPT0gZmFsc2UgaXMgdHJ1ZQotUEFT UyBhdHRyaWJzLnByZW11bHRpcGxpZWRBbHBoYSBpcyB0cnVlCi1UZXN0IGN1c3RvbWl6ZWQgdmFs dWVzCi1QQVNTIGNvbnRleHQgPSBjcmVhdGUzRENvbnRleHQobnVsbCwgeyBzdGVuY2lsOiBmYWxz ZSwgYW50aWFsaWFzOiBmYWxzZSB9KSBpcyBub24tbnVsbC4KLVBBU1MgYXR0cmlicyA9IGNvbnRl eHQuZ2V0Q29udGV4dEF0dHJpYnV0ZXMoKSBpcyBub24tbnVsbC4KLVBBU1MgYXR0cmlicy5kZXB0 aCBpcyB0cnVlCi1QQVNTIGF0dHJpYnMuYWxwaGEgaXMgdHJ1ZQotUEFTUyBhdHRyaWJzLnN0ZW5j aWwgaXMgZmFsc2UKLVBBU1MgYXR0cmlicy5hbnRpYWxpYXMgaXMgZmFsc2UKLVBBU1MgYXR0cmli cy5wcmVtdWx0aXBsaWVkQWxwaGEgaXMgdHJ1ZQotVGVzdCBjdXN0b21pemVkIHZhbHVlcwotUEFT UyBjb250ZXh0ID0gY3JlYXRlM0RDb250ZXh0KG51bGwsIHsgZGVwdGg6IGZhbHNlLCBzdGVuY2ls OiB0cnVlLCBhbnRpYWxpYXM6IGZhbHNlIH0pIGlzIG5vbi1udWxsLgotUEFTUyBhdHRyaWJzID0g Y29udGV4dC5nZXRDb250ZXh0QXR0cmlidXRlcygpIGlzIG5vbi1udWxsLgotUEFTUyBhdHRyaWJz LmRlcHRoID09IGF0dHJpYnMuc3RlbmNpbCBpcyB0cnVlCi1QQVNTIGF0dHJpYnMuYWxwaGEgaXMg dHJ1ZQotUEFTUyBhdHRyaWJzLmFudGlhbGlhcyBpcyBmYWxzZQotUEFTUyBhdHRyaWJzLnByZW11 bHRpcGxpZWRBbHBoYSBpcyB0cnVlCi1UZXN0IGN1c3RvbWl6ZWQgdmFsdWVzCi1QQVNTIGNvbnRl eHQgPSBjcmVhdGUzRENvbnRleHQobnVsbCwgeyBwcmVtdWx0aXBsaWVkQWxwaGE6IGZhbHNlLCBh bnRpYWxpYXM6IGZhbHNlIH0pIGlzIG5vbi1udWxsLgotUEFTUyBhdHRyaWJzID0gY29udGV4dC5n ZXRDb250ZXh0QXR0cmlidXRlcygpIGlzIG5vbi1udWxsLgotUEFTUyBhdHRyaWJzLmRlcHRoIGlz IHRydWUKLVBBU1MgYXR0cmlicy5hbHBoYSBpcyB0cnVlCi1QQVNTIGF0dHJpYnMuc3RlbmNpbCA9 PSB0cnVlIHx8IGF0dHJpYnMuc3RlbmNpbCA9PSBmYWxzZSBpcyB0cnVlCi1QQVNTIGF0dHJpYnMu YW50aWFsaWFzIGlzIGZhbHNlCi1QQVNTIGF0dHJpYnMucHJlbXVsdGlwbGllZEFscGhhID09IHRy dWUgfHwgYXR0cmlicy5wcmVtdWx0aXBsaWVkQWxwaGEgPT0gZmFsc2UgaXMgdHJ1ZQotUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBMRVRFCi0KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2NvbnRleHQtYXR0cmlidXRlcy5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLmh0bWwKZGVs ZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDI2OGQxNTNmNDVmMTE2YTBmNWY3OTE3OTlmNDQw N2I5NjA2YWFlNjYuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4dC1hdHRyaWJ1dGVzLmh0bWwK KysrIC9kZXYvbnVsbApAQCAtMSw2MSArMCwwIEBACi08aHRtbD4KLTxoZWFkPgotPGxpbmsgcmVs PSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3Mi Lz4KLTxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2Ny aXB0PgotPHNjcmlwdCBzcmM9InJlc291cmNlcy93ZWJnbC10ZXN0LmpzIj48L3NjcmlwdD4KLTwv aGVhZD4KLTxib2R5PgotPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgotPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+Ci0KLTxzY3JpcHQ+Ci1kZXNjcmlwdGlvbigiVGVzdCBwYXNzaW5nIGRvd24g YW5kIGZldGNoaW5nIG9mIFdlYkdMQ29udGV4dEF0dHJpYnV0ZXMiKTsKLQotZGVidWcoIlRlc3Qg ZGVmYXVsdCB2YWx1ZXMiKTsKLXZhciBjb250ZXh0OwotdmFyIGF0dHJpYnM7Ci1zaG91bGRCZU5v bk51bGwoImNvbnRleHQgPSBjcmVhdGUzRENvbnRleHQobnVsbCkiKTsKLXNob3VsZEJlTm9uTnVs bCgiYXR0cmlicyA9IGNvbnRleHQuZ2V0Q29udGV4dEF0dHJpYnV0ZXMoKSIpOwotc2hvdWxkQmUo ImF0dHJpYnMuZGVwdGgiLCAidHJ1ZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuYWxwaGEiLCAidHJ1 ZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuc3RlbmNpbCIsICJmYWxzZSIpOwotLy8gQW50aWFsaWFz IGlzIHJlcXVlc3RlZCBieSBkZWZhdWx0LCBidXQgbWlnaHQgb3IgbWlnaHQgbm90IGJlIHN1cHBv cnRlZC4KLXNob3VsZEJlKCJhdHRyaWJzLmFudGlhbGlhcyA9PSB0cnVlIHx8IGF0dHJpYnMuYW50 aWFsaWFzID09IGZhbHNlIiwgInRydWUiKTsKLXNob3VsZEJlKCJhdHRyaWJzLnByZW11bHRpcGxp ZWRBbHBoYSIsICJ0cnVlIik7Ci0KLWRlYnVnICgiVGVzdCBjdXN0b21pemVkIHZhbHVlcyIpOwot c2hvdWxkQmVOb25OdWxsKCJjb250ZXh0ID0gY3JlYXRlM0RDb250ZXh0KG51bGwsIHsgc3RlbmNp bDogZmFsc2UsIGFudGlhbGlhczogZmFsc2UgfSkiKTsKLXNob3VsZEJlTm9uTnVsbCgiYXR0cmli cyA9IGNvbnRleHQuZ2V0Q29udGV4dEF0dHJpYnV0ZXMoKSIpOwotc2hvdWxkQmUoImF0dHJpYnMu ZGVwdGgiLCAidHJ1ZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuYWxwaGEiLCAidHJ1ZSIpOwotc2hv dWxkQmUoImF0dHJpYnMuc3RlbmNpbCIsICJmYWxzZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuYW50 aWFsaWFzIiwgImZhbHNlIik7Ci1zaG91bGRCZSgiYXR0cmlicy5wcmVtdWx0aXBsaWVkQWxwaGEi LCAidHJ1ZSIpOwotCi1kZWJ1ZygiVGVzdCBjdXN0b21pemVkIHZhbHVlcyIpOwotLy8gKHN0ZW5j aWwgPT0gdHJ1ZSAmJiBkZXB0aCA9PSBmYWxzZSkgaXMgbm90IHN1cHBvcnRlZC4KLS8vIERlZmF1 bHQgZGVwdGggdG8gdHJ1ZSBpZiBFWFRfcGFja2VkX2RlcHRoX3N0ZW5jaWwgaXMgc3VwcG9ydGVk LgotLy8gT3RoZXJ3aXNlLCBib3RoIGRlcHRoIGFuZCBzdGVuY2lsIHNob3VsZCBiZSBmYWxzZS4K LXNob3VsZEJlTm9uTnVsbCgiY29udGV4dCA9IGNyZWF0ZTNEQ29udGV4dChudWxsLCB7IGRlcHRo OiBmYWxzZSwgc3RlbmNpbDogdHJ1ZSwgYW50aWFsaWFzOiBmYWxzZSB9KSIpOwotc2hvdWxkQmVO b25OdWxsKCJhdHRyaWJzID0gY29udGV4dC5nZXRDb250ZXh0QXR0cmlidXRlcygpIik7Ci1zaG91 bGRCZSgiYXR0cmlicy5kZXB0aCA9PSBhdHRyaWJzLnN0ZW5jaWwiLCAidHJ1ZSIpOwotc2hvdWxk QmUoImF0dHJpYnMuYWxwaGEiLCAidHJ1ZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuYW50aWFsaWFz IiwgImZhbHNlIik7Ci1zaG91bGRCZSgiYXR0cmlicy5wcmVtdWx0aXBsaWVkQWxwaGEiLCAidHJ1 ZSIpOwotCi1kZWJ1ZygiVGVzdCBjdXN0b21pemVkIHZhbHVlcyIpOwotLy8gKHByZW11bHRpcGxp ZWRBbHBoYSA9PSBmYWxzZSkgaXMgbm90IHN1cHBvcnRlZCBieSBtb3N0IGltcGxlbWVudGF0aW9u cyB5ZXQKLXNob3VsZEJlTm9uTnVsbCgiY29udGV4dCA9IGNyZWF0ZTNEQ29udGV4dChudWxsLCB7 IHByZW11bHRpcGxpZWRBbHBoYTogZmFsc2UsIGFudGlhbGlhczogZmFsc2UgfSkiKTsKLXNob3Vs ZEJlTm9uTnVsbCgiYXR0cmlicyA9IGNvbnRleHQuZ2V0Q29udGV4dEF0dHJpYnV0ZXMoKSIpOwot c2hvdWxkQmUoImF0dHJpYnMuZGVwdGgiLCAidHJ1ZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuYWxw aGEiLCAidHJ1ZSIpOwotc2hvdWxkQmUoImF0dHJpYnMuc3RlbmNpbCA9PSB0cnVlIHx8IGF0dHJp YnMuc3RlbmNpbCA9PSBmYWxzZSIsICJ0cnVlIik7Ci1zaG91bGRCZSgiYXR0cmlicy5hbnRpYWxp YXMiLCAiZmFsc2UiKTsKLXNob3VsZEJlKCJhdHRyaWJzLnByZW11bHRpcGxpZWRBbHBoYSA9PSB0 cnVlIHx8IGF0dHJpYnMucHJlbXVsdGlwbGllZEFscGhhID09IGZhbHNlIiwgInRydWUiKTsKLQot c3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKLTwvc2NyaXB0PgotCi08c2NyaXB0IHNyYz0iLi4v Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Ci08L2JvZHk+Ci08L2h0 bWw+Cg==