47096 2010-10-04 11:17:41 -0700 [GTK] Interior scrollbars do not draw their background properly 2010-10-05 10:03:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 289015 0 mrobinson 2010-10-04 11:17:41 -0700 This only manifests in a very few GTK+ themes -- I've only been able to reproduce it so far with the default GTK+ theme. The issue here is that the code that draws the scrolled window background behind the scrollbar is using gtk_paint_box instead of gtk_paint_shadow. The latter is the correct behavior, which can be observed in gtkscrolledwindow.c in the GTK+ sources. 289017 1 69649 mrobinson 2010-10-04 11:26:00 -0700 Created attachment 69649 Patch for this issue 289366 2 69649 xan.lopez 2010-10-04 20:31:03 -0700 Comment on attachment 69649 Patch for this issue One day we'll get rid of GTK+ themes and the world will be a better place. 289372 3 mrobinson 2010-10-04 20:51:19 -0700 Thanks for the review! For posterity, I should correct my previous statement to say that I can only reproduce this issue with the default Ubuntu 9.10 theme. 289686 4 69649 mrobinson 2010-10-05 10:03:21 -0700 Comment on attachment 69649 Patch for this issue Clearing flags on attachment: 69649 Committed r69119: <http://trac.webkit.org/changeset/69119> 289687 5 mrobinson 2010-10-05 10:03:25 -0700 All reviewed patches have been landed. Closing bug. 69649 2010-10-04 11:26:00 -0700 2010-10-05 10:03:21 -0700 Patch for this issue bug-47096-20101004112558.patch text/plain 4060 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWZjNDZkZTlmZWNhOTZmYzg4NzQzNzRmMjc1NGM2Yjc0NjZmNWZiZS4uZjU5NjcxMTMzMzFhZDRh MWM0ZDk5NTFhYjY0NDM2M2Y3OGExM2U0OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMC0xMC0wNCAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gSW50ZXJpb3Igc2Nyb2xsYmFycyBk byBub3QgZHJhdyB0aGVpciBiYWNrZ3JvdW5kIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzA5NgorCisgICAgICAgIENvcnJlY3QgdGhl IG1ldGhvZCB0aGF0IHRoZSBHVEsrIHRoZW1lIGRyYXdpbmcgY29kZSB1c2VzIHRvCisgICAgICAg IGRyYXcgc2Nyb2xsZWQgd2luZG93IGJhY2tncm91bmRzLiBOb3cgaXQgdXNlcyBndGtfcGFpbnRf c2hhZG93LAorICAgICAgICB0aGUgc2FtZSBhcyB0aGUgYWN0dWFsIGNvZGUgZnJvbSBHVEsrLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGlzIHZlcnkgaGFyZCB0byB3cml0ZSB0ZXN0 cyBmb3IuIFRoZSBidWcgb25seQorICAgICAgICBtYW5pZmVzdHMgb24gc29tZSBHVEsrIHRoZW1l cyBhbmQgd2UgaGF2ZSBubyB0ZXN0IGhhcm5lc3MgbWVjaGFuaXNtCisgICAgICAgIGZvciB0ZXN0 aW5nIHJlbmRlcmluZyB3aXRoIG5vbi1kZWZhdWx0IEdUSysgdGhlbWVzLgorCisgICAgICAgICog cGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbGJhclRoZW1lR3RrOjpwYWludFNjcm9sbGJhckJhY2tncm91bmQpOiBObyBsb25nZXIKKyAg ICAgICAgaW5pdGlhbGl6ZSB0aGUgd2lkZ2V0IHN0YXRlLCBhcyBpdCdzIHVudXNlZCBieSB0aGUg Y2FsbGVlLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVHdGs6OnBhaW50KTogUmVt b3ZlIGFuIGluYWNjdXJhdGUgY29tbWVudC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvZ3RrMmRy YXdpbmcuYzoKKyAgICAgICAgKG1vel9ndGtfc2Nyb2xsZWRfd2luZG93X3BhaW50KTogUGFpbnQg c2Nyb2xsZWQgd2luZG93IGJhY2tncm91bmRzCisgICAgICAgIHdpdGggZ3RrX3BhaW50X3NoYWRv dyBpbnN0ZWFkIG9mIGd0a19wYWludF9ib3guCisKIDIwMTAtMDktMjggIE1hcnRpbiBSb2JpbnNv biAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIE1vcmUgR1RLKyBidWlsZCBmaXhl cyBhZnRlciByNjg1MjEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxi YXJUaGVtZUd0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5j cHAKaW5kZXggMmU5NDJmZTMzNWQyMjhlMTk0NDYxMGQwMWZiNmU1ZTE2NWE1MTdlOS4uMTliODk3 Y2YwMmEzOTQ5NGVmZTIzY2VhOTM5ZjE0OTI0MjNkNGMyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcApAQCAtMjIxLDE0ICsyMjEsOCBAQCB2b2lkIFNjcm9s bGJhclRoZW1lR3RrOjpwYWludFRyYWNrQmFja2dyb3VuZChHcmFwaGljc0NvbnRleHQqIGNvbnRl eHQsIFNjcm9sbGJhcgogCiB2b2lkIFNjcm9sbGJhclRoZW1lR3RrOjpwYWludFNjcm9sbGJhckJh Y2tncm91bmQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBTY3JvbGxiYXIqIHNjcm9sbGJhcikK IHsKKyAgICAvLyBUaGlzIGlzIHVudXNlZCBieSB0aGUgbW96X2d0a19zY3JvbGxlY2Rfd2luZG93 X3BhaW50LgogICAgIEd0a1dpZGdldFN0YXRlIHN0YXRlOwotICAgIHN0YXRlLmZvY3VzZWQgPSBG QUxTRTsKLSAgICBzdGF0ZS5pc0RlZmF1bHQgPSBGQUxTRTsKLSAgICBzdGF0ZS5jYW5EZWZhdWx0 ID0gRkFMU0U7Ci0gICAgc3RhdGUuZGlzYWJsZWQgPSBGQUxTRTsKLSAgICBzdGF0ZS5hY3RpdmUg PSBUUlVFOwotICAgIHN0YXRlLmluSG92ZXIgPSBGQUxTRTsKLQogICAgIEludFJlY3QgZnVsbFNj cm9sbGJhclJlY3QgPSBJbnRSZWN0KHNjcm9sbGJhci0+eCgpLCBzY3JvbGxiYXItPnkoKSwgc2Ny b2xsYmFyLT53aWR0aCgpLCBzY3JvbGxiYXItPmhlaWdodCgpKTsKICAgICBzdGF0aWNfY2FzdDxS ZW5kZXJUaGVtZUd0ayo+KFJlbmRlclRoZW1lOjpkZWZhdWx0VGhlbWUoKS5nZXQoKSktPnBhaW50 TW96aWxsYUd0a1dpZGdldChNT1pfR1RLX1NDUk9MTEVEX1dJTkRPVywgY29udGV4dCwgZnVsbFNj cm9sbGJhclJlY3QsICZzdGF0ZSwgMCk7CiB9CkBAIC0zMDMsNyArMjk3LDYgQEAgYm9vbCBTY3Jv bGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFyKiBzY3JvbGxiYXIsIEdyYXBoaWNzQ29udGV4 dCogZ3JhcGhpY3NDb24KICAgICAgICAgICAgIHNjcm9sbE1hc2sgfD0gVGh1bWJQYXJ0OwogICAg IH0KIAotICAgIC8vIFBhaW50IHRoZSBzY3JvbGxiYXIgYmFja2dyb3VuZCAob25seSB1c2VkIGJ5 IGN1c3RvbSBDU1Mgc2Nyb2xsYmFycykuCiAgICAgcGFpbnRTY3JvbGxiYXJCYWNrZ3JvdW5kKGdy YXBoaWNzQ29udGV4dCwgc2Nyb2xsYmFyKTsKIAogICAgIGlmIChzY3JvbGxNYXNrICYgVHJhY2tC R1BhcnQpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsyZHJhd2luZy5jIGIv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvZ3RrMmRyYXdpbmcuYwppbmRleCBmZDc3MGQyZmUwN2IyYzU1 ZjExMzRmZmE3YjRmYzcxZjIwM2JiYzYyLi5kZmM1OTI0ODJlOWUyMWNjMGI4NDUxMDkzN2Q0NWMw YjdjYWJjZWY4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsyZHJhd2luZy5j CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0azJkcmF3aW5nLmMKQEAgLTEwOTgsOCArMTA5 OCw2IEBAIHN0YXRpYyBnaW50CiBtb3pfZ3RrX3Njcm9sbGVkX3dpbmRvd19wYWludChHZGtEcmF3 YWJsZSogZHJhd2FibGUsIEdka1JlY3RhbmdsZSogcmVjdCwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIEdka1JlY3RhbmdsZSogY2xpcHJlY3QsIEd0a1dpZGdldFN0YXRlKiBzdGF0ZSkK IHsKLSAgICBHdGtTdGF0ZVR5cGUgc3RhdGVfdHlwZSA9IENvbnZlcnRHdGtTdGF0ZShzdGF0ZSk7 Ci0gICAgR3RrU2hhZG93VHlwZSBzaGFkb3dfdHlwZSA9IChzdGF0ZS0+YWN0aXZlKSA/ICBHVEtf U0hBRE9XX0lOIDogR1RLX1NIQURPV19PVVQ7CiAgICAgR3RrU3R5bGUqIHN0eWxlOwogICAgIEd0 a0FsbG9jYXRpb24gYWxsb2NhdGlvbjsKICAgICBHdGtXaWRnZXQqIHdpZGdldDsKQEAgLTExMTYs OSArMTExNCw5IEBAIG1vel9ndGtfc2Nyb2xsZWRfd2luZG93X3BhaW50KEdka0RyYXdhYmxlKiBk cmF3YWJsZSwgR2RrUmVjdGFuZ2xlKiByZWN0LAogCiAgICAgc3R5bGUgPSBndGtfd2lkZ2V0X2dl dF9zdHlsZSh3aWRnZXQpOwogICAgIFRTT2Zmc2V0U3R5bGVHQ3Moc3R5bGUsIHJlY3QtPnggLSAx LCByZWN0LT55IC0gMSk7Ci0gICAgZ3RrX3BhaW50X2JveChzdHlsZSwgZHJhd2FibGUsIHN0YXRl X3R5cGUsIHNoYWRvd190eXBlLCBjbGlwcmVjdCwKLSAgICAgICAgICAgICAgICAgIHdpZGdldCwg InNjcm9sbGVkX3dpbmRvdyIsIHJlY3QtPnggLSAxLCByZWN0LT55IC0gMSwKLSAgICAgICAgICAg ICAgICAgIHJlY3QtPndpZHRoICsgMiwgcmVjdC0+aGVpZ2h0ICsgMik7CisgICAgZ3RrX3BhaW50 X3NoYWRvdyhzdHlsZSwgZHJhd2FibGUsIEdUS19TVEFURV9OT1JNQUwsIEdUS19TSEFET1dfSU4s CisgICAgICAgICAgICAgICAgICAgICBjbGlwcmVjdCwgZ1BhcnRzLT5zY3JvbGxlZFdpbmRvd1dp ZGdldCwgInNjcm9sbGVkX3dpbmRvdyIsCisgICAgICAgICAgICAgICAgICAgICByZWN0LT54LCBy ZWN0LT55LCByZWN0LT53aWR0aCwgcmVjdC0+aGVpZ2h0KTsKICAgICByZXR1cm4gTU9aX0dUS19T VUNDRVNTOwogfQogCg==