47092 2010-10-04 08:55:51 -0700 Removed unused callback in webkitwebview 2010-10-09 03:28:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue xan.lopez oldest_to_newest 288957 0 69639 cgarcia 2010-10-04 08:55:51 -0700 Created attachment 69639 Remove unused callback In webkit_web_view_forward_context_menu_event() a callback is connected for the destroy signal of the popup menu, but the menu is never destroyed so the callback never gets called. If it were called it would crash since NULL is passed as user_data, so I think it's safe to just remove the callback. 289515 1 69639 xan.lopez 2010-10-05 03:08:56 -0700 Comment on attachment 69639 Remove unused callback Looks good, but we need the ChangeLog. 290902 2 70063 cgarcia 2010-10-07 03:05:43 -0700 Created attachment 70063 Updated patch It just adds a changelog entry 290926 3 70063 xan.lopez 2010-10-07 04:59:03 -0700 Comment on attachment 70063 Updated patch I think it's worth explaining in the comment why it's never called. We reuse the same menu always, holding a ref to it, so it's not destroyed when withdrawn by the user. 291600 4 70237 cgarcia 2010-10-08 06:20:09 -0700 Created attachment 70237 Another update Includes the explation suggested by Xan to ChangeLog 291603 5 70239 cgarcia 2010-10-08 06:23:03 -0700 Created attachment 70239 Another iteration I forgot the [GTK] prefix in the changelog, sorry. 292077 6 70239 xan.lopez 2010-10-09 02:39:50 -0700 Comment on attachment 70239 Another iteration Great, thanks. 292086 7 70239 commit-queue 2010-10-09 03:28:31 -0700 Comment on attachment 70239 Another iteration Clearing flags on attachment: 70239 Committed r69444: <http://trac.webkit.org/changeset/69444> 292087 8 commit-queue 2010-10-09 03:28:36 -0700 All reviewed patches have been landed. Closing bug. 69639 2010-10-04 08:55:51 -0700 2010-10-07 03:05:43 -0700 Remove unused callback unused-callback.diff text/plain 1146 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNzYyODg4YS4uOWQzN2Q5MCAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTIwOCwxMSArMjA4LDYgQEAgc3RhdGlj IHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMoV2ViS2l0V2ViVmlldyog d2ViVmlldywgV2ViS2l0V2UKIAogc3RhdGljIEd0a0lNQ29udGV4dCogd2Via2l0X3dlYl92aWV3 X2dldF9pbV9jb250ZXh0KFdlYktpdFdlYlZpZXcqKTsKIAotc3RhdGljIHZvaWQgZGVzdHJveV9t ZW51X2NiKEd0a09iamVjdCogb2JqZWN0LCBncG9pbnRlciBkYXRhKQotewotICAgIFdFQktJVF9X RUJfVklFVyhkYXRhKS0+cHJpdi0+Y3VycmVudE1lbnUgPSAwOwotfQotCiBzdGF0aWMgdm9pZCBQ b3B1cE1lbnVQb3NpdGlvbkZ1bmMoR3RrTWVudSogbWVudSwgZ2ludCAqeCwgZ2ludCAqeSwgZ2Jv b2xlYW4gKnB1c2hJbiwgZ3BvaW50ZXIgdXNlckRhdGEpCiB7CiAgICAgV2ViS2l0V2ViVmlldyog dmlldyA9IFdFQktJVF9XRUJfVklFVyh1c2VyRGF0YSk7CkBAIC0zMDgsMTAgKzMwMyw2IEBAIHN0 YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21lbnVfZXZlbnQo V2ViS2l0V2ViVmlldyogd2ViVmllCiAgICAgcHJpdi0+bGFzdFBvcHVwWFBvc2l0aW9uID0gZXZl bnQuZ2xvYmFsWCgpOwogICAgIHByaXYtPmxhc3RQb3B1cFlQb3NpdGlvbiA9IGV2ZW50Lmdsb2Jh bFkoKTsKIAotICAgIGdfc2lnbmFsX2Nvbm5lY3QobWVudSwgImRlc3Ryb3kiLAotICAgICAgICAg ICAgICAgICAgICAgR19DQUxMQkFDSyhkZXN0cm95X21lbnVfY2IpLAotICAgICAgICAgICAgICAg ICAgICAgTlVMTCk7Ci0KICAgICBndGtfbWVudV9wb3B1cChtZW51LCBOVUxMLCBOVUxMLAogICAg ICAgICAgICAgICAgICAgICZQb3B1cE1lbnVQb3NpdGlvbkZ1bmMsCiAgICAgICAgICAgICAgICAg ICAgd2ViVmlldywgZXZlbnQuYnV0dG9uKCkgKyAxLCBndGtfZ2V0X2N1cnJlbnRfZXZlbnRfdGlt ZSgpKTsK 70063 2010-10-07 03:05:43 -0700 2010-10-08 06:20:09 -0700 Updated patch remove-callback.diff text/plain 2043 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYzYwMmFjMS4uYzhkZjk1MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0wNyAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gUmVtb3ZlZCB1bnVzZWQg Y2FsbGJhY2sgaW4gd2Via2l0d2VidmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDcwOTIKKworICAgICAgICBJbiB3ZWJraXRfd2ViX3ZpZXdfZm9y d2FyZF9jb250ZXh0X21lbnVfZXZlbnQoKSBhIGNhbGxiYWNrIGlzIGNvbm5lY3RlZAorICAgICAg ICBmb3IgdGhlIGRlc3Ryb3kgc2lnbmFsIG9mIHRoZSBwb3B1cCBtZW51LCBidXQgdGhlIG1lbnUg aXMgbmV2ZXIKKyAgICAgICAgZGVzdHJveWVkIHNvIHRoZSBjYWxsYmFjayBuZXZlciBnZXRzIGNh bGxlZC4gSWYgaXQgd2VyZSBjYWxsZWQgaXQgd291bGQKKyAgICAgICAgY3Jhc2ggc2luY2UgTlVM TCBpcyBwYXNzZWQgYXMgdXNlcl9kYXRhLCBzbyBJIHRoaW5rIGl0J3Mgc2FmZSB0byBqdXN0Cisg ICAgICAgIHJlbW92ZSB0aGUgY2FsbGJhY2suCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vi dmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21lbnVf ZXZlbnQpOgorCiAyMDEwLTA5LTI4ICBKZW5uIEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRyeSBUaXRvdi4KZGlmZiAtLWdpdCBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAKaW5kZXggN2M3MzRmOS4uNjIzNWI4ZCAxMDA2NDQKLS0tIGEvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAKQEAgLTIwOCwxMSArMjA4LDYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dl Yl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMoV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0 V2UKIAogc3RhdGljIEd0a0lNQ29udGV4dCogd2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0 KFdlYktpdFdlYlZpZXcqKTsKIAotc3RhdGljIHZvaWQgZGVzdHJveV9tZW51X2NiKEd0a09iamVj dCogb2JqZWN0LCBncG9pbnRlciBkYXRhKQotewotICAgIFdFQktJVF9XRUJfVklFVyhkYXRhKS0+ cHJpdi0+Y3VycmVudE1lbnUgPSAwOwotfQotCiBzdGF0aWMgdm9pZCBQb3B1cE1lbnVQb3NpdGlv bkZ1bmMoR3RrTWVudSogbWVudSwgZ2ludCAqeCwgZ2ludCAqeSwgZ2Jvb2xlYW4gKnB1c2hJbiwg Z3BvaW50ZXIgdXNlckRhdGEpCiB7CiAgICAgV2ViS2l0V2ViVmlldyogdmlldyA9IFdFQktJVF9X RUJfVklFVyh1c2VyRGF0YSk7CkBAIC0zMDgsMTAgKzMwMyw2IEBAIHN0YXRpYyBnYm9vbGVhbiB3 ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21lbnVfZXZlbnQoV2ViS2l0V2ViVmlldyog d2ViVmllCiAgICAgcHJpdi0+bGFzdFBvcHVwWFBvc2l0aW9uID0gZXZlbnQuZ2xvYmFsWCgpOwog ICAgIHByaXYtPmxhc3RQb3B1cFlQb3NpdGlvbiA9IGV2ZW50Lmdsb2JhbFkoKTsKIAotICAgIGdf c2lnbmFsX2Nvbm5lY3QobWVudSwgImRlc3Ryb3kiLAotICAgICAgICAgICAgICAgICAgICAgR19D QUxMQkFDSyhkZXN0cm95X21lbnVfY2IpLAotICAgICAgICAgICAgICAgICAgICAgTlVMTCk7Ci0K ICAgICBndGtfbWVudV9wb3B1cChtZW51LCBOVUxMLCBOVUxMLAogICAgICAgICAgICAgICAgICAg ICZQb3B1cE1lbnVQb3NpdGlvbkZ1bmMsCiAgICAgICAgICAgICAgICAgICAgd2ViVmlldywgZXZl bnQuYnV0dG9uKCkgKyAxLCBndGtfZ2V0X2N1cnJlbnRfZXZlbnRfdGltZSgpKTsK 70237 2010-10-08 06:20:09 -0700 2010-10-08 06:23:03 -0700 Another update unusedcb.diff text/plain 1953 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYzYwMmFjMS4uOTdiYzcyYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0wOCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCB1bnVzZWQgY2FsbGJh Y2sgaW4gd2Via2l0d2VidmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDcwOTIKKworICAgICAgICBJbiB3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9j b250ZXh0X21lbnVfZXZlbnQoKSBhIGNhbGxiYWNrIGlzCisgICAgICAgIGNvbm5lY3RlZCBmb3Ig dGhlIGRlc3Ryb3kgc2lnbmFsIG9mIHRoZSBwb3B1cCBtZW51LCBob3dldmVyIHdlCisgICAgICAg IHJldXNlIHRoZSBzYW1lIG1lbnUgYWx3YXlzLCBob2xkaW5nIGEgcmVmIHRvIGl0LCBzbyBpdCdz IG5vdAorICAgICAgICBkZXN0cm95ZWQgd2hlbiB3aXRoZHJhd24gYnkgdGhlIHVzZXIuCisKKyAg ICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3Zp ZXdfZm9yd2FyZF9jb250ZXh0X21lbnVfZXZlbnQpOgorCiAyMDEwLTA5LTI4ICBKZW5uIEJyYWl0 aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRy eSBUaXRvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3Bw IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggN2M3MzRmOS4uNjIz NWI4ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysr IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTIwOCwxMSArMjA4LDYg QEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMoV2ViS2l0 V2ViVmlldyogd2ViVmlldywgV2ViS2l0V2UKIAogc3RhdGljIEd0a0lNQ29udGV4dCogd2Via2l0 X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KFdlYktpdFdlYlZpZXcqKTsKIAotc3RhdGljIHZvaWQg ZGVzdHJveV9tZW51X2NiKEd0a09iamVjdCogb2JqZWN0LCBncG9pbnRlciBkYXRhKQotewotICAg IFdFQktJVF9XRUJfVklFVyhkYXRhKS0+cHJpdi0+Y3VycmVudE1lbnUgPSAwOwotfQotCiBzdGF0 aWMgdm9pZCBQb3B1cE1lbnVQb3NpdGlvbkZ1bmMoR3RrTWVudSogbWVudSwgZ2ludCAqeCwgZ2lu dCAqeSwgZ2Jvb2xlYW4gKnB1c2hJbiwgZ3BvaW50ZXIgdXNlckRhdGEpCiB7CiAgICAgV2ViS2l0 V2ViVmlldyogdmlldyA9IFdFQktJVF9XRUJfVklFVyh1c2VyRGF0YSk7CkBAIC0zMDgsMTAgKzMw Myw2IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21l bnVfZXZlbnQoV2ViS2l0V2ViVmlldyogd2ViVmllCiAgICAgcHJpdi0+bGFzdFBvcHVwWFBvc2l0 aW9uID0gZXZlbnQuZ2xvYmFsWCgpOwogICAgIHByaXYtPmxhc3RQb3B1cFlQb3NpdGlvbiA9IGV2 ZW50Lmdsb2JhbFkoKTsKIAotICAgIGdfc2lnbmFsX2Nvbm5lY3QobWVudSwgImRlc3Ryb3kiLAot ICAgICAgICAgICAgICAgICAgICAgR19DQUxMQkFDSyhkZXN0cm95X21lbnVfY2IpLAotICAgICAg ICAgICAgICAgICAgICAgTlVMTCk7Ci0KICAgICBndGtfbWVudV9wb3B1cChtZW51LCBOVUxMLCBO VUxMLAogICAgICAgICAgICAgICAgICAgICZQb3B1cE1lbnVQb3NpdGlvbkZ1bmMsCiAgICAgICAg ICAgICAgICAgICAgd2ViVmlldywgZXZlbnQuYnV0dG9uKCkgKyAxLCBndGtfZ2V0X2N1cnJlbnRf ZXZlbnRfdGltZSgpKTsK 70239 2010-10-08 06:23:03 -0700 2010-10-09 03:28:31 -0700 Another iteration unusedcb.diff text/plain 1959 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYzYwMmFjMS4uYWJmOGZlZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0wOCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gUmVtb3ZlZCB1bnVzZWQg Y2FsbGJhY2sgaW4gd2Via2l0d2VidmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDcwOTIKKworICAgICAgICBJbiB3ZWJraXRfd2ViX3ZpZXdfZm9y d2FyZF9jb250ZXh0X21lbnVfZXZlbnQoKSBhIGNhbGxiYWNrIGlzCisgICAgICAgIGNvbm5lY3Rl ZCBmb3IgdGhlIGRlc3Ryb3kgc2lnbmFsIG9mIHRoZSBwb3B1cCBtZW51LCBob3dldmVyIHdlCisg ICAgICAgIHJldXNlIHRoZSBzYW1lIG1lbnUgYWx3YXlzLCBob2xkaW5nIGEgcmVmIHRvIGl0LCBz byBpdCdzIG5vdAorICAgICAgICBkZXN0cm95ZWQgd2hlbiB3aXRoZHJhd24gYnkgdGhlIHVzZXIu CisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRf d2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21lbnVfZXZlbnQpOgorCiAyMDEwLTA5LTI4ICBKZW5u IEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERtaXRyeSBUaXRvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggN2M3MzRm OS4uNjIzNWI4ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTIwOCwxMSAr MjA4LDYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMo V2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0V2UKIAogc3RhdGljIEd0a0lNQ29udGV4dCog d2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KFdlYktpdFdlYlZpZXcqKTsKIAotc3RhdGlj IHZvaWQgZGVzdHJveV9tZW51X2NiKEd0a09iamVjdCogb2JqZWN0LCBncG9pbnRlciBkYXRhKQot ewotICAgIFdFQktJVF9XRUJfVklFVyhkYXRhKS0+cHJpdi0+Y3VycmVudE1lbnUgPSAwOwotfQot CiBzdGF0aWMgdm9pZCBQb3B1cE1lbnVQb3NpdGlvbkZ1bmMoR3RrTWVudSogbWVudSwgZ2ludCAq eCwgZ2ludCAqeSwgZ2Jvb2xlYW4gKnB1c2hJbiwgZ3BvaW50ZXIgdXNlckRhdGEpCiB7CiAgICAg V2ViS2l0V2ViVmlldyogdmlldyA9IFdFQktJVF9XRUJfVklFVyh1c2VyRGF0YSk7CkBAIC0zMDgs MTAgKzMwMyw2IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250 ZXh0X21lbnVfZXZlbnQoV2ViS2l0V2ViVmlldyogd2ViVmllCiAgICAgcHJpdi0+bGFzdFBvcHVw WFBvc2l0aW9uID0gZXZlbnQuZ2xvYmFsWCgpOwogICAgIHByaXYtPmxhc3RQb3B1cFlQb3NpdGlv biA9IGV2ZW50Lmdsb2JhbFkoKTsKIAotICAgIGdfc2lnbmFsX2Nvbm5lY3QobWVudSwgImRlc3Ry b3kiLAotICAgICAgICAgICAgICAgICAgICAgR19DQUxMQkFDSyhkZXN0cm95X21lbnVfY2IpLAot ICAgICAgICAgICAgICAgICAgICAgTlVMTCk7Ci0KICAgICBndGtfbWVudV9wb3B1cChtZW51LCBO VUxMLCBOVUxMLAogICAgICAgICAgICAgICAgICAgICZQb3B1cE1lbnVQb3NpdGlvbkZ1bmMsCiAg ICAgICAgICAgICAgICAgICAgd2ViVmlldywgZXZlbnQuYnV0dG9uKCkgKyAxLCBndGtfZ2V0X2N1 cnJlbnRfZXZlbnRfdGltZSgpKTsK