47085 2010-10-04 07:15:35 -0700 Web Inspector: set XHR breakpoint from resource panel 2022-02-28 00:08:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned apavlov bweinstein dulowiskotic1234 joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 288923 0 podivilov 2010-10-04 07:15:35 -0700 Web Inspector: set XHR breakpoint from resource panel Add "Set Breakpoint" item to XHR resource context menu. 288924 1 69631 podivilov 2010-10-04 07:17:06 -0700 Created attachment 69631 Patch. 288928 2 69631 apavlov 2010-10-04 07:27:23 -0700 Comment on attachment 69631 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=69631&action=review > WebCore/inspector/front-end/ResourcesPanel.js:1255 > + var resource = null; Seems like there's no need to initialize this explicitly > WebCore/inspector/front-end/ResourcesPanel.js:1268 > + if (resource && resource.category.name === "xhr") { (... && resource.category === WebInspector.resourceCategories.xhr) looks cleaner 289617 3 69787 podivilov 2010-10-05 08:20:34 -0700 Created attachment 69787 Patch. Comments addressed. 289629 4 69787 yurys 2010-10-05 08:37:31 -0700 Comment on attachment 69787 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=69787&action=review > WebCore/inspector/front-end/ResourcesPanel.js:1271 > + contextMenu.appendItem(WebInspector.UIString("Set Breakpoint"), WebInspector.breakpointManager.createXHRBreakpoint.bind(WebInspector.breakpointManager, resource.url)); We may want to be more specific about the nature of the breakpoint to set. 290131 5 podivilov 2010-10-06 01:18:28 -0700 Committed r69180: <http://trac.webkit.org/changeset/69180> 290137 6 podivilov 2010-10-06 01:27:06 -0700 (In reply to comment #4) > (From update of attachment 69787 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69787&action=review > > > WebCore/inspector/front-end/ResourcesPanel.js:1271 > > + contextMenu.appendItem(WebInspector.UIString("Set Breakpoint"), WebInspector.breakpointManager.createXHRBreakpoint.bind(WebInspector.breakpointManager, resource.url)); > > We may want to be more specific about the nature of the breakpoint to set. I've accidentally committed it with "Set Breakpoint". Let me fix the wording in a separate patch. 69631 2010-10-04 07:17:06 -0700 2010-10-05 08:20:34 -0700 Patch. patch text/plain 2781 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDk2MDJkYS4uODM3YmU0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0wNCAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgIlNldCBCcmVha3BvaW50 IiBpdGVtIHRvIFhIUiByZXNvdXJjZSBjb250ZXh0IG1lbnUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzA4NQorCisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNv dXJjZXNQYW5lbC5wcm90b3R5cGUuX2NvbnRleHRNZW51KToKKwogMjAxMC0xMC0wMyAgS2VudCBU YW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQg Zml4IGZvciByNjg5OTYuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2Vz UGFuZWwuanMKaW5kZXggYWEwMjFmZi4uMmE5OWJhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtMTI1MCwxNyArMTI1MCwyNyBAQCBXZWJJ bnNwZWN0b3IuUmVzb3VyY2VzUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgX2NvbnRleHRNZW51 OiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0gICAgICAgIC8vIGNyZWF0ZUJsb2JVUkwgaXMgZW5h YmxlZCBjb25kaXRpb25hbGx5LCBkbyBub3QgZXhwb3NlIHJlc291cmNlIGV4cG9ydCBpZiBpdCdz IG5vdCBhdmFpbGFibGUuCi0gICAgICAgIGlmICh0eXBlb2Ygd2luZG93LmNyZWF0ZUJsb2JVUkwg IT09ICJmdW5jdGlvbiIgfHwgIVByZWZlcmVuY2VzLnJlc291cmNlRXhwb3J0RW5hYmxlZCkKLSAg ICAgICAgICAgIHJldHVybjsKLQogICAgICAgICB2YXIgY29udGV4dE1lbnUgPSBuZXcgV2ViSW5z cGVjdG9yLkNvbnRleHRNZW51KCk7CiAgICAgICAgIHZhciByZXNvdXJjZVRyZWVJdGVtID0gZXZl bnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoInJlc291cmNlLXNpZGViYXIt dHJlZS1pdGVtIik7Ci0gICAgICAgIGlmIChyZXNvdXJjZVRyZWVJdGVtICYmIHJlc291cmNlVHJl ZUl0ZW0udHJlZUVsZW1lbnQpIHsKLSAgICAgICAgICAgIHZhciByZXNvdXJjZSA9IHJlc291cmNl VHJlZUl0ZW0udHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3Q7Ci0gICAgICAgICAgICBjb250 ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiRXhwb3J0IHRvIEhBUiIp LCB0aGlzLl9leHBvcnRSZXNvdXJjZS5iaW5kKHRoaXMsIHJlc291cmNlKSk7CisgICAgICAgIHZh ciByZXNvdXJjZSA9IG51bGw7CisgICAgICAgIGlmIChyZXNvdXJjZVRyZWVJdGVtICYmIHJlc291 cmNlVHJlZUl0ZW0udHJlZUVsZW1lbnQpCisgICAgICAgICAgICByZXNvdXJjZSA9IHJlc291cmNl VHJlZUl0ZW0udHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3Q7CisKKyAgICAgICAgdmFyIG5l ZWRTZXBhcmF0b3IgPSBmYWxzZTsKKyAgICAgICAgLy8gY3JlYXRlQmxvYlVSTCBpcyBlbmFibGVk IGNvbmRpdGlvbmFsbHksIGRvIG5vdCBleHBvc2UgcmVzb3VyY2UgZXhwb3J0IGlmIGl0J3Mgbm90 IGF2YWlsYWJsZS4KKyAgICAgICAgaWYgKHR5cGVvZiB3aW5kb3cuY3JlYXRlQmxvYlVSTCA9PT0g ImZ1bmN0aW9uIiAmJiBQcmVmZXJlbmNlcy5yZXNvdXJjZUV4cG9ydEVuYWJsZWQpIHsKKyAgICAg ICAgICAgIGlmIChyZXNvdXJjZSkKKyAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJ dGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiRXhwb3J0IHRvIEhBUiIpLCB0aGlzLl9leHBvcnRS ZXNvdXJjZS5iaW5kKHRoaXMsIHJlc291cmNlKSk7CisgICAgICAgICAgICBjb250ZXh0TWVudS5h cHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiRXhwb3J0IGFsbCB0byBIQVIiKSwgdGhp cy5fZXhwb3J0QWxsLmJpbmQodGhpcykpOworICAgICAgICAgICAgbmVlZFNlcGFyYXRvciA9IHRy dWU7CisgICAgICAgIH0KKworICAgICAgICBpZiAocmVzb3VyY2UgJiYgcmVzb3VyY2UuY2F0ZWdv cnkubmFtZSA9PT0gInhociIpIHsKKyAgICAgICAgICAgIGlmIChuZWVkU2VwYXJhdG9yKQorICAg ICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOworICAgICAgICAgICAg Y29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNldCBCcmVha3Bv aW50IiksIFdlYkluc3BlY3Rvci5icmVha3BvaW50TWFuYWdlci5jcmVhdGVYSFJCcmVha3BvaW50 LmJpbmQoV2ViSW5zcGVjdG9yLmJyZWFrcG9pbnRNYW5hZ2VyLCByZXNvdXJjZS51cmwpKTsKICAg ICAgICAgfQotICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0 cmluZygiRXhwb3J0IGFsbCB0byBIQVIiKSwgdGhpcy5fZXhwb3J0QWxsLmJpbmQodGhpcykpOwor CiAgICAgICAgIGNvbnRleHRNZW51LnNob3coZXZlbnQpOwogICAgIH0sCiAK 69787 2010-10-05 08:20:34 -0700 2022-02-28 00:08:19 -0800 Patch. patch text/plain 2801 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzNjOWNmMS4uMTQ3NWU5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0wNCAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgIlNldCBCcmVha3BvaW50 IiBpdGVtIHRvIFhIUiByZXNvdXJjZSBjb250ZXh0IG1lbnUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzA4NQorCisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNv dXJjZXNQYW5lbC5wcm90b3R5cGUuX2NvbnRleHRNZW51KToKKwogMjAxMC0xMC0wNSAgS3dhbmcg WXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IENz YWJhIE9zenRyb2dvbsOhYy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9SZXNvdXJjZXNQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZXNQYW5lbC5qcwppbmRleCAxOTM5ZWZjLi4xYzY1ZGEzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCkBAIC0xMjUwLDE3ICsxMjUwLDI3IEBAIFdl Ykluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICBfY29udGV4dE1l bnU6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgLy8gY3JlYXRlQmxvYlVSTCBpcyBl bmFibGVkIGNvbmRpdGlvbmFsbHksIGRvIG5vdCBleHBvc2UgcmVzb3VyY2UgZXhwb3J0IGlmIGl0 J3Mgbm90IGF2YWlsYWJsZS4KLSAgICAgICAgaWYgKHR5cGVvZiB3aW5kb3cuY3JlYXRlQmxvYlVS TCAhPT0gImZ1bmN0aW9uIiB8fCAhUHJlZmVyZW5jZXMucmVzb3VyY2VFeHBvcnRFbmFibGVkKQot ICAgICAgICAgICAgcmV0dXJuOwotCiAgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5ldyBXZWJJ bnNwZWN0b3IuQ29udGV4dE1lbnUoKTsKICAgICAgICAgdmFyIHJlc291cmNlVHJlZUl0ZW0gPSBl dmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhDbGFzcygicmVzb3VyY2Utc2lkZWJh ci10cmVlLWl0ZW0iKTsKLSAgICAgICAgaWYgKHJlc291cmNlVHJlZUl0ZW0gJiYgcmVzb3VyY2VU cmVlSXRlbS50cmVlRWxlbWVudCkgewotICAgICAgICAgICAgdmFyIHJlc291cmNlID0gcmVzb3Vy Y2VUcmVlSXRlbS50cmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdDsKLSAgICAgICAgICAgIGNv bnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFeHBvcnQgdG8gSEFS IiksIHRoaXMuX2V4cG9ydFJlc291cmNlLmJpbmQodGhpcywgcmVzb3VyY2UpKTsKKyAgICAgICAg dmFyIHJlc291cmNlOworICAgICAgICBpZiAocmVzb3VyY2VUcmVlSXRlbSAmJiByZXNvdXJjZVRy ZWVJdGVtLnRyZWVFbGVtZW50KQorICAgICAgICAgICAgcmVzb3VyY2UgPSByZXNvdXJjZVRyZWVJ dGVtLnRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0OworCisgICAgICAgIHZhciBuZWVkU2Vw YXJhdG9yID0gZmFsc2U7CisgICAgICAgIC8vIGNyZWF0ZUJsb2JVUkwgaXMgZW5hYmxlZCBjb25k aXRpb25hbGx5LCBkbyBub3QgZXhwb3NlIHJlc291cmNlIGV4cG9ydCBpZiBpdCdzIG5vdCBhdmFp bGFibGUuCisgICAgICAgIGlmICh0eXBlb2Ygd2luZG93LmNyZWF0ZUJsb2JVUkwgPT09ICJmdW5j dGlvbiIgJiYgUHJlZmVyZW5jZXMucmVzb3VyY2VFeHBvcnRFbmFibGVkKSB7CisgICAgICAgICAg ICBpZiAocmVzb3VyY2UpCisgICAgICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkV4cG9ydCB0byBIQVIiKSwgdGhpcy5fZXhwb3J0UmVzb3Vy Y2UuYmluZCh0aGlzLCByZXNvdXJjZSkpOworICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5k SXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkV4cG9ydCBhbGwgdG8gSEFSIiksIHRoaXMuX2V4 cG9ydEFsbC5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAgIG5lZWRTZXBhcmF0b3IgPSB0cnVlOwor ICAgICAgICB9CisKKyAgICAgICAgaWYgKHJlc291cmNlICYmIHJlc291cmNlLmNhdGVnb3J5ID09 PSBXZWJJbnNwZWN0b3IucmVzb3VyY2VDYXRlZ29yaWVzLnhocikgeworICAgICAgICAgICAgaWYg KG5lZWRTZXBhcmF0b3IpCisgICAgICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJh dG9yKCk7CisgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5V SVN0cmluZygiU2V0IEJyZWFrcG9pbnQiKSwgV2ViSW5zcGVjdG9yLmJyZWFrcG9pbnRNYW5hZ2Vy LmNyZWF0ZVhIUkJyZWFrcG9pbnQuYmluZChXZWJJbnNwZWN0b3IuYnJlYWtwb2ludE1hbmFnZXIs IHJlc291cmNlLnVybCkpOwogICAgICAgICB9Ci0gICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0 ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFeHBvcnQgYWxsIHRvIEhBUiIpLCB0aGlzLl9leHBv cnRBbGwuYmluZCh0aGlzKSk7CisKICAgICAgICAgY29udGV4dE1lbnUuc2hvdyhldmVudCk7CiAg ICAgfSwKIAo=