47080 2010-10-04 05:40:58 -0700 Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in extension API 2010-10-06 01:13:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov loislo pfeldman yurys oldest_to_newest 288886 0 caseq 2010-10-04 05:40:58 -0700 Since we now expose native browser extension API to WebInspector extensions, it would be useful for the extensions to know tab id of inspected page -- this way, native extension mechanisms may be used to inject CSS and scripts. It is suggested to expose inspected page's tab id as webInspector.inspectedWindow.tabId property. 288890 1 69621 caseq 2010-10-04 05:48:48 -0700 Created attachment 69621 patch 289002 2 69621 webkit.review.bot 2010-10-04 10:42:46 -0700 Comment on attachment 69621 patch Rejecting patch 69621 from commit-queue. caseq@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 290129 3 caseq 2010-10-06 01:13:39 -0700 Committed manually r69098: http://trac.webkit.org/changeset/69098 69621 2010-10-04 05:48:48 -0700 2010-10-04 10:42:46 -0700 patch tabId text/plain 3301 caseq ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDk2MDJkYS4uZDk2NTM2MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0wNCAgQW5kcmV5IEtvc3lh a292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDaHJvbWl1bV1bRXh0ZW5zaW9uIEFQ SV0gcHJvdmlkZSB0YWIgaWQgb2YgaW5zcGVjdGVkIHRhYiBpbiBleHRlbnNpb24gQVBJCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzA4MAorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIuanM6IEFkZGVkIHN1cHBv cnQgZm9yIHBsYXRmb3JtLXNwZWNpZmljIGV4dGVuc2lvbnMgQVBJLgorICAgICAgICAoV2ViSW5z cGVjdG9yLkV4dGVuc2lvblNlcnZlci5wcm90b3R5cGUuX2J1aWxkRXh0ZW5zaW9uQVBJSW5qZWN0 ZWRTY3JpcHQpOgorCiAyMDEwLTEwLTAzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXggZm9yIHI2ODk5Ni4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIuanMgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uU2VydmVyLmpzCmluZGV4IGM4YTk1YTAu LjcyZDlhODkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNp b25TZXJ2ZXIuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblNl cnZlci5qcwpAQCAtMzM1LDEyICszMzUsMTMgQEAgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblNlcnZl ci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgaWYgKHR5cGVvZiBwcm9wVmFsdWUgPT09ICJu dW1iZXIiKQogICAgICAgICAgICAgICAgICByZXNvdXJjZVR5cGVzW3Byb3BOYW1lXSA9IFdlYklu c3BlY3Rvci5SZXNvdXJjZS5UeXBlLnRvU3RyaW5nKHByb3BWYWx1ZSk7CiAgICAgICAgIH0KLQor ICAgICAgICB2YXIgcGxhdGZvcm1BUEkgPSBXZWJJbnNwZWN0b3IuYnVpbGRQbGF0Zm9ybUV4dGVu c2lvbkFQSSA/IFdlYkluc3BlY3Rvci5idWlsZFBsYXRmb3JtRXh0ZW5zaW9uQVBJKCkgOiAiIjsK ICAgICAgICAgcmV0dXJuICIoZnVuY3Rpb24oKXsgIiArCiAgICAgICAgICAgICAidmFyIHByaXZh dGUgPSB7fTsiICsKICAgICAgICAgICAgICIoIiArIFdlYkluc3BlY3Rvci5jb21tb25FeHRlbnNp b25TeW1ib2xzLnRvU3RyaW5nKCkgKyAiKShwcml2YXRlKTsiICsKICAgICAgICAgICAgICIoIiAr IFdlYkluc3BlY3Rvci5pbmplY3RlZEV4dGVuc2lvbkFQSS50b1N0cmluZygpICsgIikuYXBwbHko dGhpcywgYXJndW1lbnRzKTsiICsKICAgICAgICAgICAgICJ3ZWJJbnNwZWN0b3IucmVzb3VyY2Vz LlR5cGVzID0gIiArIEpTT04uc3RyaW5naWZ5KHJlc291cmNlVHlwZXMpICsgIjsiICsKKyAgICAg ICAgICAgIHBsYXRmb3JtQVBJICsKICAgICAgICAgICAgICJ9KSI7CiAgICAgfSwKIApkaWZmIC0t Z2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggZTZjODAwYi4uOWM3NmNlYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTAtMDQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBbQ2hyb21pdW1dW0V4dGVuc2lvbiBBUEldIHByb3ZpZGUgdGFiIGlkIG9mIGluc3BlY3RlZCB0 YWIgaW4gZXh0ZW5zaW9uIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDcwODAKKworICAgICAgICAqIHNyYy9qcy9EZXZUb29scy5qczogQWRkZWQg YSB3YXkgZm9yIGV4dGVuc2lvbiB0byBnZXQgdGFiSWQgb2YgaW5zcGVjdGVkIHdpbmRvdy4KKyAg ICAgICAgKFdlYkluc3BlY3Rvci5wbGF0Zm9ybUV4dGVuc2lvbkFQSSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuYnVpbGRQbGF0Zm9ybUV4dGVuc2lvbkFQSSk6CisgICAgICAgIChXZWJJbnNwZWN0 b3Iuc2V0SW5zcGVjdGVkVGFiSWQpOgorCiAyMDEwLTEwLTAxICBNaWhhaSBQYXJwYXJpdGEgIDxt aWhhaXBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZXZUb29scy5qcyBiL1dlYktpdC9j aHJvbWl1bS9zcmMvanMvRGV2VG9vbHMuanMKaW5kZXggYTY2ZTE3NC4uNGMyMzA1NyAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZXZUb29scy5qcworKysgYi9XZWJLaXQvY2hy b21pdW0vc3JjL2pzL0RldlRvb2xzLmpzCkBAIC0xNjIsMyArMTYyLDI1IEBAIFdlYkluc3BlY3Rv ci5yZXNldFRvb2xiYXJDb2xvcnMgPSBmdW5jdGlvbigpCiAKIH0KIAorLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KKy8vIFBsYXRmb3JtLXNw ZWNpZmljIFdlYkluc3BlY3RvciBleHRlbnNpb25zIHN1cHBvcnQuIC8vCisvLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLworCitXZWJJbnNwZWN0 b3IucGxhdGZvcm1FeHRlbnNpb25BUEkgPSBmdW5jdGlvbih0YWJJZCkKK3sKKyAgICBmdW5jdGlv biBnZXRUYWJJZCgpCisgICAgeworICAgICAgICByZXR1cm4gdGFiSWQ7CisgICAgfQorICAgIHdl Ykluc3BlY3Rvci5pbnNwZWN0ZWRXaW5kb3cuX19wcm90b19fLl9fZGVmaW5lR2V0dGVyX18oInRh YklkIiwgZ2V0VGFiSWQpOworfQorCitXZWJJbnNwZWN0b3IuYnVpbGRQbGF0Zm9ybUV4dGVuc2lv bkFQSSA9IGZ1bmN0aW9uKCkKK3sKKyAgICByZXR1cm4gIigiICsgV2ViSW5zcGVjdG9yLnBsYXRm b3JtRXh0ZW5zaW9uQVBJICsgIikoIiArIFdlYkluc3BlY3Rvci5faW5zcGVjdGVkVGFiSWQgKyAi KTsiOworfQorCitXZWJJbnNwZWN0b3Iuc2V0SW5zcGVjdGVkVGFiSWQgPSBmdW5jdGlvbih0YWJJ ZCkKK3sKKyAgICBXZWJJbnNwZWN0b3IuX2luc3BlY3RlZFRhYklkID0gdGFiSWQ7Cit9Cg==