47057 2010-10-03 02:15:31 -0700 ASSERT(m_state = Open); is bad news bears 2010-10-03 11:46:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth ap darin oldest_to_newest 288754 0 abarth 2010-10-03 02:15:31 -0700 ASSERT(m_state = Open); is bad news bears 288755 1 69586 abarth 2010-10-03 02:16:59 -0700 Created attachment 69586 Patch 288756 2 69586 zecke 2010-10-03 02:20:11 -0700 Comment on attachment 69586 Patch With gcc 4.5 would write a plugin to inspect basic blocks for ASSERTs... Good catch!!!! 288757 3 abarth 2010-10-03 02:22:59 -0700 Committed r68986: <http://trac.webkit.org/changeset/68986> 288769 4 darin 2010-10-03 10:33:08 -0700 Good to fix, but nearly harmless; the effect is local to the assertion. In a debug build we simply lose the assertion; but if the assertion was true then the statement has no effect. In a release build the expression is not even compiled. 288773 5 abarth 2010-10-03 11:19:16 -0700 Sure, but the bad case is if the assertion is false. Then the statement masks the problem in Debug builds, but Release builds behave differently. 288776 6 ap 2010-10-03 11:46:21 -0700 Good catch! 69586 2010-10-03 02:16:59 -0700 2010-10-03 02:20:11 -0700 Patch bug-47057-20101003021658.patch text/plain 1307 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODk4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NF UlQobV9zdGF0ZSA9IE9wZW4pOyBpcyBiYWQgbmV3cyBiZWFycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcwNTcKKworICAgICAgICBBZGRlZCBieSBh cCAocmV2aWV3IGJ5IGRhcmluKSBpbiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81 MDk1MQorICAgICAgICBUb28gYmFkIHRoZSBjb21waWxlciBkb2Vzbid0IGNhdGNoIHRoZXNlIGVy cm9ycy4gIEkgZG9uJ3QgYmVsaWV2ZSB0aGlzCisgICAgICAgIGlzIHBvc3NpYmxlIHRvIHRlc3Qu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZTo6d3JpdGVTdHJlYW1D YWxsYmFjayk6CisKIDIwMTAtMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZOZXQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJlYW1IYW5kbGVDRk5ldC5j cHAJKHJldmlzaW9uIDY4OTgzKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1NvY2tl dFN0cmVhbUhhbmRsZUNGTmV0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTY1LDcgKzU2NSw3IEBA IHZvaWQgU29ja2V0U3RyZWFtSGFuZGxlOjp3cml0ZVN0cmVhbUNhbGwKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICB9CiAKLSAgICAgICAgQVNTRVJUKG1fc3RhdGUgPSBPcGVuKTsKKyAgICAg ICAgQVNTRVJUKG1fc3RhdGUgPT0gT3Blbik7CiAgICAgICAgIEFTU0VSVChtX2Nvbm5lY3RpbmdT dWJzdGF0ZSA9PSBDb25uZWN0ZWQpOwogCiAgICAgICAgIHNlbmRQZW5kaW5nRGF0YSgpOwo=