47056 2010-10-03 01:34:56 -0700 All the WebSocket tests crash 2010-10-03 11:44:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth ap ukai zecke oldest_to_newest 288750 0 abarth 2010-10-03 01:34:56 -0700 All the WebSocket tests crash 288751 1 69584 abarth 2010-10-03 01:36:04 -0700 Created attachment 69584 Patch 288752 2 69585 abarth 2010-10-03 01:58:03 -0700 Created attachment 69585 Patch 288753 3 abarth 2010-10-03 02:00:45 -0700 Committed r68985: <http://trac.webkit.org/changeset/68985> 288775 4 ap 2010-10-03 11:44:51 -0700 See comments in bug 47055 - this code looked correct. RS=me to roll out both changes, unless they magically fixed buildbots, in which case we'd have to investigate locally. 69584 2010-10-03 01:36:04 -0700 2010-10-03 01:57:59 -0700 Patch bug-47056-20101003013603.patch text/plain 1852 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODk4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwg dGhlIFdlYlNvY2tldCB0ZXN0cyBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDcwNTYKKworICAgICAgICBNb3JlIGNvZGUgdGhhdCB0cmllcyB0 byBob2xkIG9udG8gdGVtcG9yYXJpZXMgd2l0aCByZWZlcmVuY2VzLgorCisgICAgICAgICogd2Vi c29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlNvY2tl dENoYW5uZWw6OmRpZE9wZW4pOgorCiAyMDEwLTEwLTAzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDog V2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAkocmV2aXNpb24gNjg5ODMpCisr KyBXZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE1NCwxMCArMTU0LDEyIEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkT3BlbihTb2Nr ZXRTdHIKICAgICBpZiAoIW1fY29udGV4dCkKICAgICAgICAgcmV0dXJuOwogI2lmIEVOQUJMRShJ TlNQRUNUT1IpCi0gICAgaWYgKEluc3BlY3RvckNvbnRyb2xsZXIqIGNvbnRyb2xsZXIgPSBtX2Nv bnRleHQtPmluc3BlY3RvckNvbnRyb2xsZXIoKSkKLSAgICAgICAgY29udHJvbGxlci0+d2lsbFNl bmRXZWJTb2NrZXRIYW5kc2hha2VSZXF1ZXN0KGlkZW50aWZpZXIoKSwgbV9oYW5kc2hha2UuY2xp ZW50SGFuZHNoYWtlUmVxdWVzdCgpKTsKKyAgICBpZiAoSW5zcGVjdG9yQ29udHJvbGxlciogY29u dHJvbGxlciA9IG1fY29udGV4dC0+aW5zcGVjdG9yQ29udHJvbGxlcigpKSB7CisgICAgICAgIFdl YlNvY2tldEhhbmRzaGFrZVJlcXVlc3QgY2xpZW50SGFuZHNoYWtlUmVxdWVzdCA9IG1faGFuZHNo YWtlLmNsaWVudEhhbmRzaGFrZVJlcXVlc3QoKTsKKyAgICAgICAgY29udHJvbGxlci0+d2lsbFNl bmRXZWJTb2NrZXRIYW5kc2hha2VSZXF1ZXN0KGlkZW50aWZpZXIoKSwgY2xpZW50SGFuZHNoYWtl UmVxdWVzdCk7CisgICAgfQogI2VuZGlmCi0gICAgY29uc3QgQ1N0cmluZyYgaGFuZHNoYWtlTWVz c2FnZSA9IG1faGFuZHNoYWtlLmNsaWVudEhhbmRzaGFrZU1lc3NhZ2UoKTsKKyAgICBDU3RyaW5n IGhhbmRzaGFrZU1lc3NhZ2UgPSBtX2hhbmRzaGFrZS5jbGllbnRIYW5kc2hha2VNZXNzYWdlKCk7 CiAgICAgaWYgKCFoYW5kbGUtPnNlbmQoaGFuZHNoYWtlTWVzc2FnZS5kYXRhKCksIGhhbmRzaGFr ZU1lc3NhZ2UubGVuZ3RoKCkpKSB7CiAgICAgICAgIG1fY29udGV4dC0+YWRkTWVzc2FnZShKU01l c3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBFcnJvck1lc3NhZ2VMZXZlbCwgIkVycm9yIHNl bmRpbmcgaGFuZHNoYWtlIG1lc3NhZ2UuIiwgMCwgbV9oYW5kc2hha2UuY2xpZW50T3JpZ2luKCkp OwogICAgICAgICBoYW5kbGUtPmNsb3NlKCk7Cg== 69585 2010-10-03 01:58:03 -0700 2010-10-03 01:58:43 -0700 Patch bug-47056-20101003015801.patch text/plain 1511 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODk4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwg dGhlIFdlYlNvY2tldCB0ZXN0cyBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDcwNTYKKworICAgICAgICBNb3JlIGNvZGUgdGhhdCB0cmllcyB0 byBob2xkIG9udG8gdGVtcG9yYXJpZXMgd2l0aCByZWZlcmVuY2VzLgorCisgICAgICAgICogd2Vi c29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlNvY2tl dENoYW5uZWw6OmRpZE9wZW4pOgorCiAyMDEwLTEwLTAzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDog V2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAkocmV2aXNpb24gNjg5ODMpCisr KyBXZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE1Nyw3ICsxNTcsNyBAQCB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZE9wZW4oU29ja2V0 U3RyCiAgICAgaWYgKEluc3BlY3RvckNvbnRyb2xsZXIqIGNvbnRyb2xsZXIgPSBtX2NvbnRleHQt Pmluc3BlY3RvckNvbnRyb2xsZXIoKSkKICAgICAgICAgY29udHJvbGxlci0+d2lsbFNlbmRXZWJT b2NrZXRIYW5kc2hha2VSZXF1ZXN0KGlkZW50aWZpZXIoKSwgbV9oYW5kc2hha2UuY2xpZW50SGFu ZHNoYWtlUmVxdWVzdCgpKTsKICNlbmRpZgotICAgIGNvbnN0IENTdHJpbmcmIGhhbmRzaGFrZU1l c3NhZ2UgPSBtX2hhbmRzaGFrZS5jbGllbnRIYW5kc2hha2VNZXNzYWdlKCk7CisgICAgQ1N0cmlu ZyBoYW5kc2hha2VNZXNzYWdlID0gbV9oYW5kc2hha2UuY2xpZW50SGFuZHNoYWtlTWVzc2FnZSgp OwogICAgIGlmICghaGFuZGxlLT5zZW5kKGhhbmRzaGFrZU1lc3NhZ2UuZGF0YSgpLCBoYW5kc2hh a2VNZXNzYWdlLmxlbmd0aCgpKSkgewogICAgICAgICBtX2NvbnRleHQtPmFkZE1lc3NhZ2UoSlNN ZXNzYWdlU291cmNlLCBMb2dNZXNzYWdlVHlwZSwgRXJyb3JNZXNzYWdlTGV2ZWwsICJFcnJvciBz ZW5kaW5nIGhhbmRzaGFrZSBtZXNzYWdlLiIsIDAsIG1faGFuZHNoYWtlLmNsaWVudE9yaWdpbigp KTsKICAgICAgICAgaGFuZGxlLT5jbG9zZSgpOwo=