47054 2010-10-02 16:33:16 -0700 execCommand('FormatBlock') does not preserve inline styles of the replaced block elements 2026-02-27 13:57:24 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Normal --- 1 rniwa joanne_pan2 ahmad.saleem792 ayg enrica karlcow tony webkit-bug-importer oldest_to_newest 288728 0 rniwa 2010-10-02 16:33:16 -0700 Reproduction steps: 1. Go to http://www.mozilla.org/editor/midasdemo/ 2. Paste <div style="color: red;">hello</div> in HTML source mode 3. Chante the format to "h1" in WYSIWYG mode Expected result: <h1 style="color:red;">hello</h1> or <h1><span style="color:red;">hello</span></h1> Actual result: <h1>hello</h1> 453182 1 ayg 2011-08-18 11:28:46 -0700 This is handled in the spec by "record the values"/"restore the values": http://aryeh.name/spec/editing/editing.html#the-formatblock-command http://aryeh.name/spec/editing/editing.html#record-the-values Basically, for each node in a node list, "record the values" records any inline style that's specified on that node or that it's inheriting from an ancestor. Then "restore the values" checks each node for whether it has the same value, and if not, sets it. I call them every time I move nodes around in a way that might change what styles they inherit. 1920273 2 ahmad.saleem792 2022-12-17 12:51:19 -0800 Fixed in following commit - https://src.chromium.org/viewvc/blink?view=revision&revision=163137 1925125 3 ahmad.saleem792 2023-01-12 13:27:19 -0800 I tried - https://github.com/WebKit/WebKit/pull/8536 to merge Blink patch but it is not suitable and we need to account for following comment from rniwa: ''' I don't think the code change as currently proposed makes much sense. For one, there is mismatch between outerBlock vs blockNode. For another, we shouldn't be just copying style attribute. We need to get the computed style and apply that style to the block if we're failing to preserve the style in this command. e.g. using EditingStyle::prepareToApplyAt and ApplyStyleCommand. ''' 2184652 4 karlcow 2026-02-24 18:06:16 -0800 See the unofficial draft https://w3c.github.io/editing/docs/execCommand/ https://w3c.github.io/editing/docs/execCommand/#the-formatblock-command And https://wpt.fyi/results/editing/run/formatblock.html%3F2001-3000?label=master&label=experimental&aligned&q=formatblock%20safari%3Afail%20chrome%3Apass https://wpt.fyi/results/editing/run/formatblock.html%3F4001-5000?label=master&label=experimental&aligned&q=formatblock%20safari%3Afail%20chrome%3Apass https://wpt.fyi/results/editing/other/formatblock-preserving-selection.tentative.html%3FstyleWithCSS%3Dfalse%26block%3Dh1?label=master&label=experimental&aligned&q=formatblock%20safari%3Afail%20chrome%3Apass https://wpt.fyi/results/editing/other/formatblock-preserving-selection.tentative.html%3FstyleWithCSS%3Dtrue%26block%3Dh1?label=master&label=experimental&aligned&q=formatblock%20safari%3Afail%20chrome%3Apass 2184933 5 webkit-bug-importer 2026-02-25 13:38:42 -0800 <rdar://problem/171199434> 2184934 6 joanne_pan2 2026-02-25 13:39:16 -0800 Pull request: https://github.com/WebKit/WebKit/pull/59448 2184978 7 joanne_pan2 2026-02-25 15:17:17 -0800 Progress is being tracked by: rdar://157657531 2184986 8 joanne_pan2 2026-02-25 16:07:34 -0800 <rdar://problem/157657531> 2185031 9 ahmad.saleem792 2026-02-25 17:40:03 -0800 (In reply to Ahmad Saleem from comment #2) > Fixed in following commit - > https://src.chromium.org/viewvc/blink?view=revision&revision=163137 This link is dead - replacement link - https://chromium.googlesource.com/chromium/src.git/+/8d5a72610a8b98fdd885f3a033e8734acba6c78c 2185658 10 ews-feeder 2026-02-27 13:57:21 -0800 Committed 308365@main (51dde913fc8d): <https://commits.webkit.org/308365@main> Reviewed commits have been landed. Closing PR #59448 and removing active labels.