47045 2010-10-01 23:26:23 -0700 Sunspider 0.9.1 harness doesn't actually close() its test documents 2011-07-02 18:35:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www2.webkit.org/perf/sunspider-0.9.1/sunspider-0.9.1/driver.html P2 Normal --- 0 bzbarsky mjs jwalden+bwo mjs oldest_to_newest 288657 0 bzbarsky 2010-10-01 23:26:23 -0700 The step that goes to the next test looks like this: testFrame.contentDocument.open(); testFrame.contentDocument.write(testContents[testIndex]); testFrame.contentDocument.close; Note the lack of parens after "close". 431658 1 99565 mjs 2011-07-02 17:35:03 -0700 Created attachment 99565 Patch 431671 2 mjs 2011-07-02 18:35:37 -0700 Committed r90333: <http://trac.webkit.org/changeset/90333> 99565 2011-07-02 17:35:03 -0700 2011-07-02 18:22:32 -0700 Patch bug-47045-20110702173501.patch text/plain 2009 mjs SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBQZXJmb3JtYW5jZVRlc3RzL1N1blNwaWRlci9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMzI4KQor KysgUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMDIgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxl LmNvbT4KKworICAgICAgICBTdW5zcGlkZXIgMC45LjEgaGFybmVzcyBkb2Vzbid0IGFjdHVhbGx5 IGNsb3NlKCkgaXRzIHRlc3QgZG9jdW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NzA0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaG9zdGVkL3ZlcnNpb25zLmh0bWw6CisgICAgICAgICogcmVz b3VyY2VzL2RyaXZlci1URU1QTEFURS5odG1sOgorCiAyMDExLTA3LTAyICBNYWNpZWogU3RhY2hv d2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgTm90IFJldmlld2VkLiAKSW5kZXg6IFBl cmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL2hvc3RlZC92ZXJzaW9ucy5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL2hvc3RlZC92ZXJzaW9ucy5odG1sCShyZXZp c2lvbiA5MDMyMykKKysrIFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL2hvc3RlZC92ZXJzaW9u cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBAIG9mIHRoZSB0ZXN0IGNvbnRl bnQ6PC9wPgogPHVsPgogPGxpPjxhIGhyZWY9InN1bnNwaWRlci0wLjkvZHJpdmVyLmh0bWwiPlZl cnNpb24gMC45PC9hPjwvbGk+CiA8bGk+PGEgaHJlZj0ic3Vuc3BpZGVyLTAuOS4xL2RyaXZlci5o dG1sIj5WZXJzaW9uIDAuOS4xPC9hPjwvbGk+Cis8bGk+PGEgaHJlZj0ic3Vuc3BpZGVyLTEuMC9k cml2ZXIuaHRtbCI+VmVyc2lvbiAxLjA8L2E+PC9saT4KIDwvdWw+CiAKIDwvYm9keT4KSW5kZXg6 IFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL3Jlc291cmNlcy9kcml2ZXItVEVNUExBVEUuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL1N1blNwaWRlci9yZXNvdXJjZXMvZHJp dmVyLVRFTVBMQVRFLmh0bWwJKHJldmlzaW9uIDkwMzIzKQorKysgUGVyZm9ybWFuY2VUZXN0cy9T dW5TcGlkZXIvcmVzb3VyY2VzL2RyaXZlci1URU1QTEFURS5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC03MCwxMiArNzAsMTIgQEAgZnVuY3Rpb24gcmVhbGx5TmV4dCgpIAogICAgIGlmICh0ZXN0SW5k ZXggPCB0ZXN0cy5sZW5ndGgpIHsKICAgICAgICAgdGVzdEZyYW1lLmNvbnRlbnREb2N1bWVudC5v cGVuKCk7CiAgICAgICAgIHRlc3RGcmFtZS5jb250ZW50RG9jdW1lbnQud3JpdGUodGVzdENvbnRl bnRzW3Rlc3RJbmRleF0pOwotICAgICAgICB0ZXN0RnJhbWUuY29udGVudERvY3VtZW50LmNsb3Nl OworICAgICAgICB0ZXN0RnJhbWUuY29udGVudERvY3VtZW50LmNsb3NlKCk7CiAgICAgfSBlbHNl IGlmICgrK2N1cnJlbnRSZXBlYXQgPCByZXBlYXRDb3VudCkgeyAKICAgICAgICAgdGVzdEluZGV4 ID0gMDsKICAgICAgICAgdGVzdEZyYW1lLmNvbnRlbnREb2N1bWVudC5vcGVuKCk7CiAgICAgICAg IHRlc3RGcmFtZS5jb250ZW50RG9jdW1lbnQud3JpdGUodGVzdENvbnRlbnRzW3Rlc3RJbmRleF0p OwotICAgICAgICB0ZXN0RnJhbWUuY29udGVudERvY3VtZW50LmNsb3NlOworICAgICAgICB0ZXN0 RnJhbWUuY29udGVudERvY3VtZW50LmNsb3NlKCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgZmlu aXNoKCk7CiAgICAgfQo=