47025 2010-10-01 15:50:55 -0700 [BREWMP] Use PlatformRefPtr instead of OwnPtr in FileSystem 2010-10-05 10:01:20 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned commit-queue oldest_to_newest 288541 0 skyul 2010-10-01 15:50:55 -0700 PlatformRefPtr is a better choice here because all Brew MP instances are reference counted. 288545 1 69532 skyul 2010-10-01 15:52:59 -0700 Created attachment 69532 Patch 289343 2 69532 tkent 2010-10-04 18:34:37 -0700 Comment on attachment 69532 Patch ok 289683 3 69532 commit-queue 2010-10-05 10:01:16 -0700 Comment on attachment 69532 Patch Clearing flags on attachment: 69532 Committed r69118: <http://trac.webkit.org/changeset/69118> 289684 4 commit-queue 2010-10-05 10:01:20 -0700 All reviewed patches have been landed. Closing bug. 69532 2010-10-01 15:52:59 -0700 2010-10-05 10:01:16 -0700 Patch refptr.patch text/plain 3850 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODkzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTAtMDEgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBVc2UgUGxhdGZvcm1SZWZQdHIgaW5zdGVhZCBvZiBPd25QdHIgaW4gRmlsZVN5 c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcw MjUKKworICAgICAgICBQbGF0Zm9ybVJlZlB0ciBpcyBhIGJldHRlciBjaG9pY2UgaGVyZSBiZWNh dXNlIGFsbCBCcmV3IE1QIGluc3RhbmNlcyBhcmUKKyAgICAgICAgcmVmZXJlbmNlIGNvdW50ZWQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9icmV3L0ZpbGVTeXN0ZW1CcmV3LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmdldEZpbGVTaXplKToKKyAgICAgICAgKFdlYkNvcmU6OmZpbGVFeGlzdHMpOgor ICAgICAgICAoV2ViQ29yZTo6ZGVsZXRlRmlsZSk6CisgICAgICAgIChXZWJDb3JlOjpkZWxldGVF bXB0eURpcmVjdG9yeSk6CisgICAgICAgIChXZWJDb3JlOjpjYW5vbmljYWxQYXRoKToKKyAgICAg ICAgKFdlYkNvcmU6Om1ha2VBbGxEaXJlY3Rvcmllcyk6CisgICAgICAgIChXZWJDb3JlOjpvcGVu VGVtcG9yYXJ5RmlsZSk6CisKIDIwMTAtMTAtMDEgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOYXRlIENoYXBpbi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vYnJldy9GaWxlU3lzdGVtQnJldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9icmV3L0ZpbGVTeXN0ZW1CcmV3LmNwcAkocmV2aXNpb24gNjg4OTIpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL2JyZXcvRmlsZVN5c3RlbUJyZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNyw5ICszNyw4IEBACiAjaW5jbHVkZSA8QUVFRmlsZS5oPgogI2luY2x1ZGUgPEFFRVN0ZExp Yi5oPgogCi0jaW5jbHVkZSA8d3RmL093blB0ci5oPgotI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRy Lmg+CiAjaW5jbHVkZSA8d3RmL1JhbmRvbU51bWJlci5oPgorI2luY2x1ZGUgPHd0Zi9icmV3L1Jl ZlB0ckJyZXcuaD4KICNpbmNsdWRlIDx3dGYvYnJldy9TaGVsbEJyZXcuaD4KICNpbmNsdWRlIDx3 dGYvdGV4dC9DU3RyaW5nLmg+CiAKQEAgLTQ3LDcgKzQ2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogCiBib29sIGdldEZpbGVTaXplKGNvbnN0IFN0cmluZyYgcGF0aCwgbG9uZyBsb25nJiByZXN1 bHQpCiB7Ci0gICAgT3duUHRyPElGaWxlTWdyPiBmaWxlTWdyID0gY3JlYXRlSW5zdGFuY2U8SUZp bGVNZ3I+KEFFRUNMU0lEX0ZJTEVNR1IpOworICAgIFBsYXRmb3JtUmVmUHRyPElGaWxlTWdyPiBm aWxlTWdyID0gY3JlYXRlUmVmUHRySW5zdGFuY2U8SUZpbGVNZ3I+KEFFRUNMU0lEX0ZJTEVNR1Ip OwogICAgIEZpbGVJbmZvIGluZm87CiAKICAgICBpZiAoSUZJTEVNR1JfR2V0SW5mbyhmaWxlTWdy LmdldCgpLCBwYXRoLnV0ZjgoKS5kYXRhKCksICZpbmZvKSA9PSBTVUNDRVNTKSB7CkBAIC02Nywy MSArNjYsMjEgQEAgYm9vbCBnZXRGaWxlTW9kaWZpY2F0aW9uVGltZShjb25zdCBTdHJpbgogCiBi b29sIGZpbGVFeGlzdHMoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAgIE93blB0cjxJRmlsZU1n cj4gZmlsZU1nciA9IGNyZWF0ZUluc3RhbmNlPElGaWxlTWdyPihBRUVDTFNJRF9GSUxFTUdSKTsK KyAgICBQbGF0Zm9ybVJlZlB0cjxJRmlsZU1ncj4gZmlsZU1nciA9IGNyZWF0ZVJlZlB0ckluc3Rh bmNlPElGaWxlTWdyPihBRUVDTFNJRF9GSUxFTUdSKTsKIAogICAgIHJldHVybiAoSUZJTEVNR1Jf VGVzdChmaWxlTWdyLmdldCgpLCBwYXRoLnV0ZjgoKS5kYXRhKCkpID09IFNVQ0NFU1MpOwogfQog CiBib29sIGRlbGV0ZUZpbGUoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAgIE93blB0cjxJRmls ZU1ncj4gZmlsZU1nciA9IGNyZWF0ZUluc3RhbmNlPElGaWxlTWdyPihBRUVDTFNJRF9GSUxFTUdS KTsKKyAgICBQbGF0Zm9ybVJlZlB0cjxJRmlsZU1ncj4gZmlsZU1nciA9IGNyZWF0ZVJlZlB0cklu c3RhbmNlPElGaWxlTWdyPihBRUVDTFNJRF9GSUxFTUdSKTsKIAogICAgIHJldHVybiAoSUZJTEVN R1JfUmVtb3ZlKGZpbGVNZ3IuZ2V0KCksIHBhdGgudXRmOCgpLmRhdGEoKSkgPT0gU1VDQ0VTUyk7 CiB9CiAKIGJvb2wgZGVsZXRlRW1wdHlEaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBwYXRoKQogewot ICAgIE93blB0cjxJRmlsZU1ncj4gZmlsZU1nciA9IGNyZWF0ZUluc3RhbmNlPElGaWxlTWdyPihB RUVDTFNJRF9GSUxFTUdSKTsKKyAgICBQbGF0Zm9ybVJlZlB0cjxJRmlsZU1ncj4gZmlsZU1nciA9 IGNyZWF0ZVJlZlB0ckluc3RhbmNlPElGaWxlTWdyPihBRUVDTFNJRF9GSUxFTUdSKTsKIAogICAg IHJldHVybiAoSUZJTEVNR1JfUm1EaXIoZmlsZU1nci5nZXQoKSwgcGF0aC51dGY4KCkuZGF0YSgp KSA9PSBTVUNDRVNTKTsKIH0KQEAgLTExMCw3ICsxMDksNyBAQCBDU3RyaW5nIGZpbGVTeXN0ZW1S ZXByZXNlbnRhdGlvbihjb25zdCBTCiAKIHN0YXRpYyBTdHJpbmcgY2Fub25pY2FsUGF0aChjb25z dCBTdHJpbmcmIHBhdGgpCiB7Ci0gICAgT3duUHRyPElGaWxlTWdyPiBmaWxlTWdyID0gY3JlYXRl SW5zdGFuY2U8SUZpbGVNZ3I+KEFFRUNMU0lEX0ZJTEVNR1IpOworICAgIFBsYXRmb3JtUmVmUHRy PElGaWxlTWdyPiBmaWxlTWdyID0gY3JlYXRlUmVmUHRySW5zdGFuY2U8SUZpbGVNZ3I+KEFFRUNM U0lEX0ZJTEVNR1IpOwogCiAgICAgLy8gR2V0IHRoZSBidWZmZXIgc2l6ZSByZXF1aXJlZCB0byBy ZXNvbHZlIHRoZSBwYXRoLgogICAgIGludCBjYW5vblBhdGhMZW47CkBAIC0xNjMsNyArMTYyLDcg QEAgc3RhdGljIGJvb2wgbWFrZUFsbERpcmVjdG9yaWVzKElGaWxlTWdyKgogCiBib29sIG1ha2VB bGxEaXJlY3Rvcmllcyhjb25zdCBTdHJpbmcmIHBhdGgpCiB7Ci0gICAgT3duUHRyPElGaWxlTWdy PiBmaWxlTWdyID0gY3JlYXRlSW5zdGFuY2U8SUZpbGVNZ3I+KEFFRUNMU0lEX0ZJTEVNR1IpOwor ICAgIFBsYXRmb3JtUmVmUHRyPElGaWxlTWdyPiBmaWxlTWdyID0gY3JlYXRlUmVmUHRySW5zdGFu Y2U8SUZpbGVNZ3I+KEFFRUNMU0lEX0ZJTEVNR1IpOwogCiAgICAgcmV0dXJuIG1ha2VBbGxEaXJl Y3RvcmllcyhmaWxlTWdyLmdldCgpLCBjYW5vbmljYWxQYXRoKHBhdGgpKTsKIH0KQEAgLTE5Myw3 ICsxOTIsNyBAQCBDU3RyaW5nIG9wZW5UZW1wb3JhcnlGaWxlKGNvbnN0IGNoYXIqIHByCiAgICAg Ly8gdXNlICJmczovfi90bXAiIGFzIG91ciB0ZW1wb3JhcnkgZGlyZWN0b3J5LgogICAgIFN0cmlu ZyB0ZW1wUGF0aCgiZnM6L34vdG1wIik7CiAKLSAgICBPd25QdHI8SUZpbGVNZ3I+IGZpbGVNZ3Ig PSBjcmVhdGVJbnN0YW5jZTxJRmlsZU1ncj4oQUVFQ0xTSURfRklMRU1HUik7CisgICAgUGxhdGZv cm1SZWZQdHI8SUZpbGVNZ3I+IGZpbGVNZ3IgPSBjcmVhdGVSZWZQdHJJbnN0YW5jZTxJRmlsZU1n cj4oQUVFQ0xTSURfRklMRU1HUik7CiAKICAgICAvLyBDcmVhdGUgdGhlIHRlbXBvcmFyeSBkaXJl Y3RvcnkgaWYgaXQgZG9lcyBub3QgZXhpc3QuCiAgICAgSUZJTEVNR1JfTWtEaXIoZmlsZU1nci5n ZXQoKSwgdGVtcFBhdGgudXRmOCgpLmRhdGEoKSk7Cg==