46979 2010-10-01 05:29:53 -0700 [WINCE] Use alphaBlendIfSupported in GraphicsContext 2010-10-01 06:07:26 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 46974 1 paroga paroga aroben oldest_to_newest 288190 0 paroga 2010-10-01 05:29:53 -0700 see patch 288194 1 69456 paroga 2010-10-01 05:32:08 -0700 Created attachment 69456 Patch 288196 2 69456 aroben 2010-10-01 05:52:29 -0700 Comment on attachment 69456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69456&action=review > WebCore/platform/graphics/wince/GraphicsContextWinCE.cpp:341 > + if (!alphaBlendIfSupported(m_dc, origRect.x(), origRect.y(), origRect.width(), origRect.height(), hdc, 0, 0, bmpRect.right, bmpRect.bottom, blend)) > + ASSERT_NOT_REACHED(); Another way to do this without a branch is: bool success = alphaBlendIfSupported(...); ASSERT_UNUSED(success, success); 288201 3 69456 paroga 2010-10-01 06:06:48 -0700 Comment on attachment 69456 Patch Clearing flags on attachment: 69456 Manually committed r68882: <http://trac.webkit.org/changeset/68882> 288202 4 paroga 2010-10-01 06:07:26 -0700 All reviewed patches have been landed. Closing bug. 69456 2010-10-01 05:32:08 -0700 2010-10-01 06:06:48 -0700 Patch bug-46979.patch text/plain 2741 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWQ4MzhhNS4uMzI5MWMyNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0wMSAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFVzZSBhbHBoYUJsZW5kSWZTdXBwb3J0ZWQgaW4g R3JhcGhpY3NDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00Njk3OQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhp Y3NDb250ZXh0V2luQ0UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0UGxh dGZvcm1Qcml2YXRlOjpwYWludEJhY2tUcmFuc3BhcmVudExheWVyQml0bWFwKToKKwogMjAxMC0x MC0wMSAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3dpbmNlL0dyYXBoaWNzQ29udGV4dFdpbkNFLmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luQ0UuY3BwCmluZGV4IGNjNjk5ZTQu LmU1ZmM0MzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3Jh cGhpY3NDb250ZXh0V2luQ0UuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu Y2UvR3JhcGhpY3NDb250ZXh0V2luQ0UuY3BwCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqICBDb3B5 cmlnaHQgKEMpIDIwMDctMjAwOSBUb3JjaCBNb2JpbGUgSW5jLgorICogIENvcHlyaWdodCAoQykg MjAxMCBQYXRyaWNrIEdhbnN0ZXJlciA8cGFyb2dhQHBhcm9nYS5jb20+CiAgKgogICogIFRoaXMg bGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IK ICAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFs IFB1YmxpYwpAQCAtMjQsNiArMjUsNyBAQAogI2luY2x1ZGUgIkFmZmluZVRyYW5zZm9ybS5oIgog I2luY2x1ZGUgIkNoYXJhY3Rlck5hbWVzLmgiCiAjaW5jbHVkZSAiRm9udC5oIgorI2luY2x1ZGUg IkdESUV4dHJhcy5oIgogI2luY2x1ZGUgIkdseXBoQnVmZmVyLmgiCiAjaW5jbHVkZSAiR3JhZGll bnQuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHRQcml2YXRlLmgiCkBAIC0zMjIsOCArMzI0 LDcgQEAgcHVibGljOgogICAgICAgICBpZiAoaGRjID09IG1fZGMpCiAgICAgICAgICAgICByZXR1 cm47CiAKLSNpZiAhZGVmaW5lZChOT19BTFBIQUJMRU5EKQotICAgICAgICBpZiAoYWxwaGFQYWlu dCA9PSBBbHBoYVBhaW50T3RoZXIpIHsKKyAgICAgICAgaWYgKGFscGhhUGFpbnQgPT0gQWxwaGFQ YWludE90aGVyICYmIGhhc0FscGhhQmxlbmRTdXBwb3J0KCkpIHsKICAgICAgICAgICAgIEFTU0VS VChibXAgJiYgYm1wLT5ieXRlcygpICYmIGJtcC0+aXMzMmJpdCgpKTsKICAgICAgICAgICAgIHVu c2lnbmVkKiBwaXhlbHMgPSAodW5zaWduZWQqKWJtcC0+Ynl0ZXMoKTsKICAgICAgICAgICAgIGNv bnN0IHVuc2lnbmVkKiBjb25zdCBwaXhlbHNFbmQgPSBwaXhlbHMgKyBibXAtPmJpdG1hcEluZm8o KS5udW1QaXhlbHMoKTsKQEAgLTMzMiwxMyArMzMzLDEzIEBAIHB1YmxpYzoKICAgICAgICAgICAg ICAgICArK3BpeGVsczsKICAgICAgICAgICAgIH0KICAgICAgICAgfQotICAgICAgICBpZiAobV9v cGFjaXR5IDwgMS4gfHwgYWxwaGFQYWludCA9PSBBbHBoYVBhaW50T3RoZXIpIHsKKyAgICAgICAg aWYgKChtX29wYWNpdHkgPCAxLiB8fCBhbHBoYVBhaW50ID09IEFscGhhUGFpbnRPdGhlcikgJiYg aGFzQWxwaGFCbGVuZFN1cHBvcnQoKSkgewogICAgICAgICAgICAgY29uc3QgQkxFTkRGVU5DVElP TiBibGVuZCA9IHsgQUNfU1JDX09WRVIsIDAKICAgICAgICAgICAgICAgICAsIG1fb3BhY2l0eSA+ PSAxLiA/IDI1NSA6IChCWVRFKShtX29wYWNpdHkgKiAyNTUpCiAgICAgICAgICAgICAgICAgLCBh bHBoYVBhaW50ID09IEFscGhhUGFpbnROb25lID8gMCA6IEFDX1NSQ19BTFBIQSB9OwotICAgICAg ICAgICAgQWxwaGFCbGVuZChtX2RjLCBvcmlnUmVjdC54KCksIG9yaWdSZWN0LnkoKSwgb3JpZ1Jl Y3Qud2lkdGgoKSwgb3JpZ1JlY3QuaGVpZ2h0KCksIGhkYywgMCwgMCwgYm1wUmVjdC5yaWdodCwg Ym1wUmVjdC5ib3R0b20sIGJsZW5kKTsKKyAgICAgICAgICAgIGlmICghYWxwaGFCbGVuZElmU3Vw cG9ydGVkKG1fZGMsIG9yaWdSZWN0LngoKSwgb3JpZ1JlY3QueSgpLCBvcmlnUmVjdC53aWR0aCgp LCBvcmlnUmVjdC5oZWlnaHQoKSwgaGRjLCAwLCAwLCBibXBSZWN0LnJpZ2h0LCBibXBSZWN0LmJv dHRvbSwgYmxlbmQpKQorICAgICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAg ICAgICB9IGVsc2UKLSNlbmRpZgogICAgICAgICAgICAgU3RyZXRjaEJsdChtX2RjLCBvcmlnUmVj dC54KCksIG9yaWdSZWN0LnkoKSwgb3JpZ1JlY3Qud2lkdGgoKSwgb3JpZ1JlY3QuaGVpZ2h0KCks IGhkYywgMCwgMCwgYm1wUmVjdC5yaWdodCwgYm1wUmVjdC5ib3R0b20sIFNSQ0NPUFkpOwogICAg IH0KIAo=