46960 2010-09-30 22:48:34 -0700 Specify ALWAYS_INLINE at function declaration not function definition 2010-10-01 10:50:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 0 psolanki webkit-unassigned commit-queue ggaren psolanki webkit.review.bot oldest_to_newest 288063 0 psolanki 2010-09-30 22:48:34 -0700 Take for example the following code in FastMalloc.cpp template <bool crashOnFailure> void* malloc(size_t); void* fastMalloc(size_t size) { return malloc<true>(size); } template <bool crashOnFailure> ALWAYS_INLINE void* malloc(size_t size) { ... } We need to have the ALWAYS_INLINE be on the declaration, otherwise the compiler may not inline the call to malloc<true>(size) in fastMalloc(). There are other instances of this in the code as well. Patch coming up. 288065 1 psolanki 2010-09-30 22:50:03 -0700 <rdar://problem/8498709> 288076 2 69426 psolanki 2010-09-30 23:40:24 -0700 Created attachment 69426 Patch 288080 3 psolanki 2010-09-30 23:42:10 -0700 From other files, I see that the practice seems to be to add ALWAYS_INLINE to both definition and declaration so thats what I've done in my patch. 288081 4 webkit.review.bot 2010-09-30 23:42:26 -0700 Attachment 69426 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:2188: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/FastMalloc.cpp:2191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/FastMalloc.cpp:2292: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/FastMalloc.cpp:2297: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/FastMalloc.cpp:2310: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 288322 5 69426 ggaren 2010-10-01 10:18:44 -0700 Comment on attachment 69426 Patch Consider these docs: http://gcc.gnu.org/onlinedocs/gcc/Inline.html http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Attribute-Syntax.html#Attribute-Syntax http://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Function-Attributes.html I'm pretty sure that ALWAYS_INLINE is only needed at the declaration site, not the definition site. Even so, this patch is good, so r=me. 288341 6 69426 commit-queue 2010-10-01 10:50:47 -0700 Comment on attachment 69426 Patch Clearing flags on attachment: 69426 Committed r68899: <http://trac.webkit.org/changeset/68899> 288342 7 commit-queue 2010-10-01 10:50:52 -0700 All reviewed patches have been landed. Closing bug. 69426 2010-09-30 23:40:24 -0700 2010-10-01 10:50:47 -0700 Patch bug-46960-20100930234022.patch text/plain 6516 psolanki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiMTJjYzllZjkxZWY5ODA2NmRiZTJlZGNhMTEyY2E2MDk0OTQ3Y2YzLi5l MDUxZTFhNjQzYTFhZmYwMDdhOTM1ZTU5NDJiZDE3YWIzY2ZlYzUwIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDktMzAgIFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBTcGVj aWZ5IEFMV0FZU19JTkxJTkUgYXQgZnVuY3Rpb24gZGVjbGFyYXRpb24gbm90IGZ1bmN0aW9uIGRl ZmluaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ2OTYwCisKKyAgICAgICAgRm9yIGZ1bmN0aW9ucyBkZWZpbmVkIHdpdGggQUxXQVlTX0lOTElO RSwgYWRkIHRoZSBhdHRyaWJ1dGUgdG8gdGhlIGRlY2xhcmF0aW9uIGFzIHdlbGwuCisKKyAgICAg ICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaDoKKyAgICAgICAgKiB3dGYvRmFz dE1hbGxvYy5jcHA6CisKIDIwMTAtMDktMzAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oIGIvSmF2YVNj cmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgKaW5kZXggMmFmYTBjNGNl MTAxZTgwOTU5OTRiNWQ0MzhiNjk0NjQ5OWE4ZjU3Ni4uODYxNzExYWM2YWJhOGZmMTFkMmFhZmM3 MDVlY2I3OGRjY2ZjMzhmNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVy L0J5dGVjb2RlR2VuZXJhdG9yLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5 dGVjb2RlR2VuZXJhdG9yLmgKQEAgLTQyNCw4ICs0MjQsOCBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgdm9pZCBlbWl0T3Bjb2RlKE9wY29kZUlEKTsKICAgICAgICAgdm9pZCByZXRyaWV2ZUxh c3RCaW5hcnlPcChpbnQmIGRzdEluZGV4LCBpbnQmIHNyYzFJbmRleCwgaW50JiBzcmMySW5kZXgp OwogICAgICAgICB2b2lkIHJldHJpZXZlTGFzdFVuYXJ5T3AoaW50JiBkc3RJbmRleCwgaW50JiBz cmNJbmRleCk7Ci0gICAgICAgIHZvaWQgcmV3aW5kQmluYXJ5T3AoKTsKLSAgICAgICAgdm9pZCBy ZXdpbmRVbmFyeU9wKCk7CisgICAgICAgIEFMV0FZU19JTkxJTkUgdm9pZCByZXdpbmRCaW5hcnlP cCgpOworICAgICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgcmV3aW5kVW5hcnlPcCgpOwogCiAgICAg ICAgIFBhc3NSZWZQdHI8TGFiZWw+IGVtaXRDb21wbGV4SnVtcFNjb3BlcyhMYWJlbCogdGFyZ2V0 LCBDb250cm9sRmxvd0NvbnRleHQqIHRvcFNjb3BlLCBDb250cm9sRmxvd0NvbnRleHQqIGJvdHRv bVNjb3BlKTsKIApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3Bw IGIvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCmluZGV4IDFlNTM3Yjk5ODFkYjIz MjhiOTExZDQwOGExNzFmN2U5ZTFmMWQzMDAuLmJiYmRhZjI2Y2E3MmVhZGY2NmZiZWNhMjY0MDA3 OTI3YmY4YjAwMjYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNw cAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAKQEAgLTIxODUsMTAgKzIx ODUsMTAgQEAgY2xhc3MgVENNYWxsb2NfVGhyZWFkQ2FjaGUgewogICAvLyBUb3RhbCBieXRlIHNp emUgaW4gY2FjaGUKICAgc2l6ZV90IFNpemUoKSBjb25zdCB7IHJldHVybiBzaXplXzsgfQogCi0g IHZvaWQqIEFsbG9jYXRlKHNpemVfdCBzaXplKTsKKyAgQUxXQVlTX0lOTElORSB2b2lkKiBBbGxv Y2F0ZShzaXplX3Qgc2l6ZSk7CiAgIHZvaWQgRGVhbGxvY2F0ZSh2b2lkKiBwdHIsIHNpemVfdCBz aXplX2NsYXNzKTsKIAotICB2b2lkIEZldGNoRnJvbUNlbnRyYWxDYWNoZShzaXplX3QgY2wsIHNp emVfdCBhbGxvY2F0aW9uU2l6ZSk7CisgIEFMV0FZU19JTkxJTkUgdm9pZCBGZXRjaEZyb21DZW50 cmFsQ2FjaGUoc2l6ZV90IGNsLCBzaXplX3QgYWxsb2NhdGlvblNpemUpOwogICB2b2lkIFJlbGVh c2VUb0NlbnRyYWxDYWNoZShzaXplX3QgY2wsIGludCBOKTsKICAgdm9pZCBTY2F2ZW5nZSgpOwog ICB2b2lkIFByaW50KCkgY29uc3Q7CkBAIC0yMjg5LDEyICsyMjg5LDEyIEBAIGNsYXNzIFRDTWFs bG9jX0NlbnRyYWxfRnJlZUxpc3QgewogICAvLyBSRVFVSVJFUzogbG9ja18gaXMgaGVsZAogICAv LyBSZWxlYXNlIGFuIG9iamVjdCB0byBzcGFucy4KICAgLy8gTWF5IHRlbXBvcmFyaWx5IHJlbGVh c2UgbG9ja18uCi0gIHZvaWQgUmVsZWFzZVRvU3BhbnModm9pZCogb2JqZWN0KTsKKyAgQUxXQVlT X0lOTElORSB2b2lkIFJlbGVhc2VUb1NwYW5zKHZvaWQqIG9iamVjdCk7CiAKICAgLy8gUkVRVUlS RVM6IGxvY2tfIGlzIGhlbGQKICAgLy8gUG9wdWxhdGUgY2FjaGUgYnkgZmV0Y2hpbmcgZnJvbSB0 aGUgcGFnZSBoZWFwLgogICAvLyBNYXkgdGVtcG9yYXJpbHkgcmVsZWFzZSBsb2NrXy4KLSAgdm9p ZCBQb3B1bGF0ZSgpOworICBBTFdBWVNfSU5MSU5FIHZvaWQgUG9wdWxhdGUoKTsKIAogICAvLyBS RVFVSVJFUzogbG9jayBpcyBoZWxkLgogICAvLyBUcmllcyB0byBtYWtlIHJvb20gZm9yIGEgVENF bnRyeS4gIElmIHRoZSBjYWNoZSBpcyBmdWxsIGl0IHdpbGwgdHJ5IHRvCkBAIC0yMzA3LDcgKzIz MDcsNyBAQCBjbGFzcyBUQ01hbGxvY19DZW50cmFsX0ZyZWVMaXN0IHsKICAgLy8ganVzdCBpdGVy YXRlcyBvdmVyIHRoZSBzaXplY2xhc3NlcyBidXQgZG9lcyBzbyB3aXRob3V0IHRha2luZyBhIGxv Y2suCiAgIC8vIFJldHVybnMgdHJ1ZSBvbiBzdWNjZXNzLgogICAvLyBNYXkgdGVtcG9yYXJpbHkg bG9jayBhICJyYW5kb20iIHNpemUgY2xhc3MuCi0gIHN0YXRpYyBib29sIEV2aWN0UmFuZG9tU2l6 ZUNsYXNzKHNpemVfdCBsb2NrZWRfc2l6ZV9jbGFzcywgYm9vbCBmb3JjZSk7CisgIHN0YXRpYyBB TFdBWVNfSU5MSU5FIGJvb2wgRXZpY3RSYW5kb21TaXplQ2xhc3Moc2l6ZV90IGxvY2tlZF9zaXpl X2NsYXNzLCBib29sIGZvcmNlKTsKIAogICAvLyBSRVFVSVJFUzogbG9ja18gaXMgKm5vdCogaGVs ZC4KICAgLy8gVHJpZXMgdG8gc2hyaW5rIHRoZSBDYWNoZS4gIElmIGZvcmNlIGlzIHRydWUgaXQg d2lsbCByZWxhc2Ugb2JqZWN0cyB0bwpAQCAtMzcwNSw3ICszNzA1LDcgQEAgZXh0ZXJuICJDIgog I2RlZmluZSBkb19tYWxsb2MgZG9fbWFsbG9jPGNyYXNoT25GYWlsdXJlPgogCiB0ZW1wbGF0ZSA8 Ym9vbCBjcmFzaE9uRmFpbHVyZT4KLXZvaWQqIG1hbGxvYyhzaXplX3QpOworQUxXQVlTX0lOTElO RSB2b2lkKiBtYWxsb2Moc2l6ZV90KTsKIAogdm9pZCogZmFzdE1hbGxvYyhzaXplX3Qgc2l6ZSkK IHsKQEAgLTM3NjYsNyArMzc2Niw3IEBAIHZvaWQgZnJlZSh2b2lkKiBwdHIpIHsKIGV4dGVybiAi QyIgCiAjZWxzZQogdGVtcGxhdGUgPGJvb2wgY3Jhc2hPbkZhaWx1cmU+Ci12b2lkKiBjYWxsb2Mo c2l6ZV90LCBzaXplX3QpOworQUxXQVlTX0lOTElORSB2b2lkKiBjYWxsb2Moc2l6ZV90LCBzaXpl X3QpOwogCiB2b2lkKiBmYXN0Q2FsbG9jKHNpemVfdCBuLCBzaXplX3QgZWxlbV9zaXplKQogewpA QCAtMzgzMCw3ICszODMwLDcgQEAgdm9pZCBjZnJlZSh2b2lkKiBwdHIpIHsKIGV4dGVybiAiQyIg CiAjZWxzZQogdGVtcGxhdGUgPGJvb2wgY3Jhc2hPbkZhaWx1cmU+Ci12b2lkKiByZWFsbG9jKHZv aWQqLCBzaXplX3QpOworQUxXQVlTX0lOTElORSB2b2lkKiByZWFsbG9jKHZvaWQqLCBzaXplX3Qp OwogCiB2b2lkKiBmYXN0UmVhbGxvYyh2b2lkKiBvbGRfcHRyLCBzaXplX3QgbmV3X3NpemUpCiB7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGI4OTE4OWM5NDVhOGJlNDQ0MDNmYTFmMmViNTU3YzAyZWZmMDU3OTIuLmRmMDI5MzFjNWQ5MjMz MzBkNmIwMTUxYzk2YmM3MjhkOTlhZmQ3OTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMzAgIFBy YXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBTcGVjaWZ5IEFMV0FZU19JTkxJTkUgYXQgZnVuY3Rp b24gZGVjbGFyYXRpb24gbm90IGZ1bmN0aW9uIGRlZmluaXRpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2OTYwCisKKyAgICAgICAgRm9yIGZ1bmN0 aW9ucyBkZWZpbmVkIHdpdGggQUxXQVlTX0lOTElORSwgYWRkIHRoZSBhdHRyaWJ1dGUgdG8gdGhl IGRlY2xhcmF0aW9uIGFzIHdlbGwuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5o OgorICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVJdGVyYXRvci5oOgorICAgICAgICAqIHJlbmRl cmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oOgorCiAyMDEwLTA5LTMwICBNYXJpbyBTYW5jaGV6IFBy YWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwg QmF0ZXMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmggYi9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmgKaW5kZXggMmJjYTJmNGQwZDk2ZjA1ODMwOTQxMjVl ZjMxMjAxZTI2Yzg5MGU4Yi4uNWY3MGUwNTRlYTE2OTg1NzQ0MGZmZDc5MDcyOTIxOGE2NDJiYmIz MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCisrKyBiL1dlYkNv cmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaApAQCAtMTA5LDcgKzEwOSw3IEBAIHB1YmxpYzoKICAg ICBwcml2YXRlOgogICAgICAgICB2b2lkIGluaXRGb3JTdHlsZVJlc29sdmUoRWxlbWVudCosIFJl bmRlclN0eWxlKiBwYXJlbnRTdHlsZSA9IDAsIFBzZXVkb0lkID0gTk9QU0VVRE8pOwogICAgICAg ICB2b2lkIGluaXRFbGVtZW50KEVsZW1lbnQqKTsKLSAgICAgICAgUmVuZGVyU3R5bGUqIGxvY2F0 ZVNoYXJlZFN0eWxlKCk7CisgICAgICAgIEFMV0FZU19JTkxJTkUgUmVuZGVyU3R5bGUqIGxvY2F0 ZVNoYXJlZFN0eWxlKCk7CiAgICAgICAgIE5vZGUqIGxvY2F0ZUNvdXNpbkxpc3QoRWxlbWVudCog cGFyZW50LCB1bnNpZ25lZCBkZXB0aCA9IDEpOwogICAgICAgICBib29sIGNhblNoYXJlU3R5bGVX aXRoRWxlbWVudChOb2RlKik7CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL0lubGlu ZUl0ZXJhdG9yLmggYi9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVJdGVyYXRvci5oCmluZGV4IDBm NTM5MDEwMmU1NTI5OGI3ZmZhN2JiNWRiZWRkNzRlYWE2NWM2MTIuLjI3MDM2NGY4NDgzYjU2Zjg1 NmQ2NjI1OWM2ZDdlNDU3YWY2NjdmYzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL0lu bGluZUl0ZXJhdG9yLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lSXRlcmF0b3IuaApA QCAtNTMsNyArNTMsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBhdEVuZCgpIGNvbnN0OwogCiAgICAg VUNoYXIgY3VycmVudCgpIGNvbnN0OwotICAgIFdURjo6VW5pY29kZTo6RGlyZWN0aW9uIGRpcmVj dGlvbigpIGNvbnN0OworICAgIEFMV0FZU19JTkxJTkUgV1RGOjpVbmljb2RlOjpEaXJlY3Rpb24g ZGlyZWN0aW9uKCkgY29uc3Q7CiAKICAgICBSZW5kZXJCbG9jayogYmxvY2s7CiAgICAgUmVuZGVy T2JqZWN0KiBvYmo7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJT dHlsZS5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAppbmRleCA4ODlk M2I4YzUzZGVhOWZmMzBkYzMzZWU4YTg5MmZiYTAxNzhiYTE0Li45NWUzYjA4NjBmYmEzYmRkZTQ3 MWZjYmQyYzYyMzhjZjBmZjE1MTJjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxl LmgKQEAgLTMwNiwxMCArMzA2LDEwIEBAIHByb3RlY3RlZDoKICAgICB9CiAKIHByaXZhdGU6Ci0g ICAgUmVuZGVyU3R5bGUoKTsKKyAgICBBTFdBWVNfSU5MSU5FIFJlbmRlclN0eWxlKCk7CiAgICAg Ly8gdXNlZCB0byBjcmVhdGUgdGhlIGRlZmF1bHQgc3R5bGUuCi0gICAgUmVuZGVyU3R5bGUoYm9v bCk7Ci0gICAgUmVuZGVyU3R5bGUoY29uc3QgUmVuZGVyU3R5bGUmKTsKKyAgICBBTFdBWVNfSU5M SU5FIFJlbmRlclN0eWxlKGJvb2wpOworICAgIEFMV0FZU19JTkxJTkUgUmVuZGVyU3R5bGUoY29u c3QgUmVuZGVyU3R5bGUmKTsKIAogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFJlbmRl clN0eWxlPiBjcmVhdGUoKTsK