46946 2010-09-30 17:30:49 -0700 The WebSocket server should flush its logs 2010-09-30 23:41:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric ukai oldest_to_newest 287956 0 abarth 2010-09-30 17:30:49 -0700 The WebSocket server should flush its logs 287957 1 69403 abarth 2010-09-30 17:32:29 -0700 Created attachment 69403 Patch 287959 2 69403 eric 2010-09-30 17:36:23 -0700 Comment on attachment 69403 Patch I feel like this might get us into other trouble. It seems the real fix is to fix the third_party code we're using a websocket server. http://docs.python.org/using/cmdline.html#envvar-PYTHONUNBUFFERED is another way to do the same thing. Maybe that's clearer? 287960 3 69403 eric 2010-09-30 17:38:30 -0700 Comment on attachment 69403 Patch Seems this should have a FIXME to remove the -u once the third_party stuff is fixed. Or maybe this is the right long-term solution? Unclear. I guess it only affects stdout, stdin, and stderr. 287968 4 abarth 2010-09-30 17:50:30 -0700 It's not a work around for third_party stuff. It's because we call terminate process on the server instead of letting it shutdown gracefully. 287969 5 abarth 2010-09-30 17:51:53 -0700 Environment variables are sadness. 288077 6 69403 commit-queue 2010-09-30 23:41:32 -0700 Comment on attachment 69403 Patch Clearing flags on attachment: 69403 Committed r68866: <http://trac.webkit.org/changeset/68866> 288078 7 commit-queue 2010-09-30 23:41:37 -0700 All reviewed patches have been landed. Closing bug. 69403 2010-09-30 17:32:29 -0700 2010-09-30 23:41:32 -0700 Patch bug-46946-20100930173228.patch text/plain 1529 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY4ODU0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMzAgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgV2ViU29ja2V0IHNlcnZlciBzaG91bGQgZmx1c2ggaXRzIGxvZ3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2OTQ2CisKKyAgICAg ICAgVGhlIFdlYlNvY2tldCBzZXJ2ZXIgbG9ncyBhcmUgdHJ1bmNhdGVkIGJlY2F1c2UgdGhlIGRy aXZlciBqdXN0CisgICAgICAgIHRlcm1pbmF0ZXMgdGhlIGNoaWxkLiAgSXQgc2hvdWxkIHJ1biBQ eXRob24gd2l0aG91dCBidWZmZXJpbmcgc28gd2UgY2FuCisgICAgICAgIHNlZSB0aGUgZW5kIG9m IHRoZSBsb2cuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3dlYnNvY2tldF9zZXJ2ZXIucHk6CisKIDIwMTAtMDktMjkgIEpvbiBIb25leWN1dHQgIDxqaG9u ZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQyIG9uIFdpbmRvd3Mgc2hvdWxkIHVz ZSBXaW5kb3dzIGZvbnRzIGZvciB0aGUgdmFyaW91cyBzdGFuZGFyZApJbmRleDogV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2Vic29ja2V0X3NlcnZlci5weQkocmV2aXNpb24gNjg4NDApCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYnNvY2tldF9zZXJ2ZXIucHkJ KHdvcmtpbmcgY29weSkKQEAgLTE2NCw3ICsxNjQsNyBAQCBjbGFzcyBQeVdlYlNvY2tldChodHRw X3NlcnZlci5MaWdodHRwZCk6CiAgICAgICAgIHB5d2Vic29ja2V0X3NjcmlwdCA9IG9zLnBhdGgu am9pbihweXdlYnNvY2tldF9iYXNlLCAnbW9kX3B5d2Vic29ja2V0JywKICAgICAgICAgICAgICdz dGFuZGFsb25lLnB5JykKICAgICAgICAgc3RhcnRfY21kID0gWwotICAgICAgICAgICAgcHl0aG9u X2ludGVycCwgcHl3ZWJzb2NrZXRfc2NyaXB0LAorICAgICAgICAgICAgcHl0aG9uX2ludGVycCwg Jy11JywgcHl3ZWJzb2NrZXRfc2NyaXB0LAogICAgICAgICAgICAgJy0tc2VydmVyLWhvc3QnLCAn MTI3LjAuMC4xJywKICAgICAgICAgICAgICctLXBvcnQnLCBzdHIoc2VsZi5fcG9ydCksCiAgICAg ICAgICAgICAnLS1kb2N1bWVudC1yb290Jywgc2VsZi5fbGF5b3V0X3Rlc3RzLAo=