<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46932</bug_id>
          
          <creation_ts>2010-09-30 13:33:49 -0700</creation_ts>
          <short_desc>Fix root-lr-basic.html to have correct results.</short_desc>
          <delta_ts>2010-09-30 13:37:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dave Hyatt">hyatt</reporter>
          <assigned_to name="Dave Hyatt">hyatt</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>287773</commentid>
    <comment_count>0</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2010-09-30 13:33:49 -0700</bug_when>
    <thetext>Fix root-lr-basic.html to have correct results by adding a few more height() -&gt; logicalHeight() calls.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287775</commentid>
    <comment_count>1</comment_count>
      <attachid>69373</attachid>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2010-09-30 13:34:44 -0700</bug_when>
    <thetext>Created attachment 69373
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>287778</commentid>
    <comment_count>2</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2010-09-30 13:37:23 -0700</bug_when>
    <thetext>Fixed in r68820.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>69373</attachid>
            <date>2010-09-30 13:34:44 -0700</date>
            <delta_ts>2010-09-30 13:36:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>4745</size>
            <attacher name="Dave Hyatt">hyatt</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2ODgxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMzAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCBm
YXN0L2Jsb2NrZmxvdy9yb290LWxyLWJhc2ljLmh0bWwgcmVzdWx0cyB0byBiZSBjb3JyZWN0IGJ5
IHBhdGNoaW5nIGEgZmV3IG1vcmUKKwloZWlnaHQoKSBjYWxscyB0byBiZSBsb2dpY2FsSGVpZ2h0
KCkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6UmVuZGVyQmxvY2s6OmNvbGxhcHNlTWFyZ2lucyk6CisgICAgICAgIChXZWJDb3JlOjpS
ZW5kZXJCbG9jazo6aGFuZGxlQWZ0ZXJTaWRlT2ZCbG9jayk6CisKIDIwMTAtMDktMzAgIENyaXMg
TmVja2FyICA8Y2RuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB
ZGxlci4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDY4ODE3KQor
KysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x
NTA5LDcgKzE1MDksNyBAQCBpbnQgUmVuZGVyQmxvY2s6OmNvbGxhcHNlTWFyZ2lucyhSZW5kZXJC
CiAgICAgaWYgKG1hcmdpbkluZm8ucXVpcmtDb250YWluZXIoKSAmJiBtYXJnaW5JbmZvLmF0QmVm
b3JlU2lkZU9mQmxvY2soKSAmJiAocG9zVG9wIC0gbmVnVG9wKSkKICAgICAgICAgbWFyZ2luSW5m
by5zZXRNYXJnaW5CZWZvcmVRdWlyayh0b3BRdWlyayk7CiAKLSAgICBpbnQgYmVmb3JlQ29sbGFw
c2VZID0gaGVpZ2h0KCk7CisgICAgaW50IGJlZm9yZUNvbGxhcHNlWSA9IGxvZ2ljYWxIZWlnaHQo
KTsKICAgICBpbnQgeXBvcyA9IGJlZm9yZUNvbGxhcHNlWTsKICAgICBpZiAoY2hpbGQtPmlzU2Vs
ZkNvbGxhcHNpbmdCbG9jaygpKSB7CiAgICAgICAgIC8vIFRoaXMgY2hpbGQgaGFzIG5vIGhlaWdo
dC4gIFdlIG5lZWQgdG8gY29tcHV0ZSBvdXIKQEAgLTE1MjksMjAgKzE1MjksMjAgQEAgaW50IFJl
bmRlckJsb2NrOjpjb2xsYXBzZU1hcmdpbnMoUmVuZGVyQgogICAgICAgICAgICAgLy8gaXMgY29y
cmVjdCwgc2luY2UgaXQgY291bGQgaGF2ZSBvdmVyZmxvd2luZyBjb250ZW50CiAgICAgICAgICAg
ICAvLyB0aGF0IG5lZWRzIHRvIGJlIHBvc2l0aW9uZWQgY29ycmVjdGx5IChlLmcuLCBhIGJsb2Nr
IHRoYXQKICAgICAgICAgICAgIC8vIGhhZCBhIHNwZWNpZmllZCBoZWlnaHQgb2YgMCBidXQgdGhh
dCBhY3R1YWxseSBoYWQgc3ViY29udGVudCkuCi0gICAgICAgICAgICB5cG9zID0gaGVpZ2h0KCkg
KyBjb2xsYXBzZWRUb3BQb3MgLSBjb2xsYXBzZWRUb3BOZWc7CisgICAgICAgICAgICB5cG9zID0g
bG9naWNhbEhlaWdodCgpICsgY29sbGFwc2VkVG9wUG9zIC0gY29sbGFwc2VkVG9wTmVnOwogICAg
IH0KICAgICBlbHNlIHsKICAgICAgICAgaWYgKGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5CZWZvcmVD
b2xsYXBzZSgpID09IE1TRVBBUkFURSkgewotICAgICAgICAgICAgc2V0TG9naWNhbEhlaWdodCho
ZWlnaHQoKSArIG1hcmdpbkluZm8ubWFyZ2luKCkgKyBjaGlsZC0+bWFyZ2luVG9wKCkpOwotICAg
ICAgICAgICAgeXBvcyA9IGhlaWdodCgpOworICAgICAgICAgICAgc2V0TG9naWNhbEhlaWdodChs
b2dpY2FsSGVpZ2h0KCkgKyBtYXJnaW5JbmZvLm1hcmdpbigpICsgY2hpbGQtPm1hcmdpblRvcCgp
KTsKKyAgICAgICAgICAgIHlwb3MgPSBsb2dpY2FsSGVpZ2h0KCk7CiAgICAgICAgIH0KICAgICAg
ICAgZWxzZSBpZiAoIW1hcmdpbkluZm8uYXRCZWZvcmVTaWRlT2ZCbG9jaygpIHx8CiAgICAgICAg
ICAgICAoIW1hcmdpbkluZm8uY2FuQ29sbGFwc2VNYXJnaW5CZWZvcmVXaXRoQ2hpbGRyZW4oKQog
ICAgICAgICAgICAgICYmICghZG9jdW1lbnQoKS0+aW5RdWlya3NNb2RlKCkgfHwgIW1hcmdpbklu
Zm8ucXVpcmtDb250YWluZXIoKSB8fCAhbWFyZ2luSW5mby5tYXJnaW5CZWZvcmVRdWlyaygpKSkp
IHsKICAgICAgICAgICAgIC8vIFdlJ3JlIGNvbGxhcHNpbmcgd2l0aCBhIHByZXZpb3VzIHNpYmxp
bmcncyBtYXJnaW5zIGFuZCBub3QKICAgICAgICAgICAgIC8vIHdpdGggdGhlIHRvcCBvZiB0aGUg
YmxvY2suCi0gICAgICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0KGhlaWdodCgpICsgbWF4KG1hcmdp
bkluZm8ucG9zTWFyZ2luKCksIHBvc1RvcCkgLSBtYXgobWFyZ2luSW5mby5uZWdNYXJnaW4oKSwg
bmVnVG9wKSk7Ci0gICAgICAgICAgICB5cG9zID0gaGVpZ2h0KCk7CisgICAgICAgICAgICBzZXRM
b2dpY2FsSGVpZ2h0KGxvZ2ljYWxIZWlnaHQoKSArIG1heChtYXJnaW5JbmZvLnBvc01hcmdpbigp
LCBwb3NUb3ApIC0gbWF4KG1hcmdpbkluZm8ubmVnTWFyZ2luKCksIG5lZ1RvcCkpOworICAgICAg
ICAgICAgeXBvcyA9IGxvZ2ljYWxIZWlnaHQoKTsKICAgICAgICAgfQogCiAgICAgICAgIG1hcmdp
bkluZm8uc2V0UG9zTWFyZ2luKGNoaWxkLT5tYXhNYXJnaW5BZnRlcihQb3NpdGl2ZU1hcmdpbikp
OwpAQCAtMTU1OCw3ICsxNTU4LDcgQEAgaW50IFJlbmRlckJsb2NrOjpjb2xsYXBzZU1hcmdpbnMo
UmVuZGVyQgogICAgIGlmIChwYWdpbmF0ZWQgJiYgeXBvcyA+IGJlZm9yZUNvbGxhcHNlWSkgewog
ICAgICAgICBpbnQgb2xkWSA9IHlwb3M7CiAgICAgICAgIHlwb3MgPSBtaW4oeXBvcywgbmV4dFBh
Z2VUb3AoYmVmb3JlQ29sbGFwc2VZKSk7Ci0gICAgICAgIHNldExvZ2ljYWxIZWlnaHQoaGVpZ2h0
KCkgKyAoeXBvcyAtIG9sZFkpKTsKKyAgICAgICAgc2V0TG9naWNhbEhlaWdodChsb2dpY2FsSGVp
Z2h0KCkgKyAoeXBvcyAtIG9sZFkpKTsKICAgICB9CiAgICAgcmV0dXJuIHlwb3M7CiB9CkBAIC0x
Njk5LDE0ICsxNjk5LDE0IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmhhbmRsZUFmdGVyU2lkZU9mQmxv
Y2sKICAgICAvLyBJZiB3ZSBjYW4ndCBjb2xsYXBzZSB3aXRoIGNoaWxkcmVuIHRoZW4gZ28gYWhl
YWQgYW5kIGFkZCBpbiB0aGUgYm90dG9tIG1hcmdpbi4KICAgICBpZiAoIW1hcmdpbkluZm8uY2Fu
Q29sbGFwc2VXaXRoTWFyZ2luQWZ0ZXIoKSAmJiAhbWFyZ2luSW5mby5jYW5Db2xsYXBzZVdpdGhN
YXJnaW5CZWZvcmUoKQogICAgICAgICAmJiAoIWRvY3VtZW50KCktPmluUXVpcmtzTW9kZSgpIHx8
ICFtYXJnaW5JbmZvLnF1aXJrQ29udGFpbmVyKCkgfHwgIW1hcmdpbkluZm8ubWFyZ2luQWZ0ZXJR
dWlyaygpKSkKLSAgICAgICAgc2V0TG9naWNhbEhlaWdodChoZWlnaHQoKSArIG1hcmdpbkluZm8u
bWFyZ2luKCkpOworICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0KGxvZ2ljYWxIZWlnaHQoKSArIG1h
cmdpbkluZm8ubWFyZ2luKCkpOwogICAgICAgICAKICAgICAvLyBOb3cgYWRkIGluIG91ciBib3R0
b20gYm9yZGVyL3BhZGRpbmcuCi0gICAgc2V0TG9naWNhbEhlaWdodChoZWlnaHQoKSArIGJvdHRv
bSk7CisgICAgc2V0TG9naWNhbEhlaWdodChsb2dpY2FsSGVpZ2h0KCkgKyBib3R0b20pOwogCiAg
ICAgLy8gTmVnYXRpdmUgbWFyZ2lucyBjYW4gY2F1c2Ugb3VyIGhlaWdodCB0byBzaHJpbmsgYmVs
b3cgb3VyIG1pbmltYWwgaGVpZ2h0IChib3JkZXIvcGFkZGluZykuCiAgICAgLy8gSWYgdGhpcyBo
YXBwZW5zLCBlbnN1cmUgdGhhdCB0aGUgY29tcHV0ZWQgaGVpZ2h0IGlzIGluY3JlYXNlZCB0byB0
aGUgbWluaW1hbCBoZWlnaHQuCi0gICAgc2V0TG9naWNhbEhlaWdodChtYXgoaGVpZ2h0KCksIHRv
cCArIGJvdHRvbSkpOworICAgIHNldExvZ2ljYWxIZWlnaHQobWF4KGxvZ2ljYWxIZWlnaHQoKSwg
dG9wICsgYm90dG9tKSk7CiAKICAgICAvLyBVcGRhdGUgb3VyIGJvdHRvbSBjb2xsYXBzZWQgbWFy
Z2luIGluZm8uCiAgICAgc2V0Q29sbGFwc2VkQm90dG9tTWFyZ2luKG1hcmdpbkluZm8pOwpJbmRl
eDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmxvY2tmbG93L3Jvb3QtbHItYmFzaWMt
ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0
L2Jsb2NrZmxvdy9yb290LWxyLWJhc2ljLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNjg4MTYpCisr
KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ibG9ja2Zsb3cvcm9vdC1sci1iYXNpYy1l
eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTIsNCArMiw0IEBAIGxheWVyIGF0ICgwLDAp
IHNpemUgODAweDYwMAogICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAogbGF5ZXIg
YXQgKDAsMCkgc2l6ZSAxMDR4NjAwCiAgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXpl
IDEwNHg2MDAgW2JvcmRlcjogKDJweCBzb2xpZCAjMDAwMDAwKV0KLSAgICBSZW5kZXJCb2R5IHtC
T0RZfSBhdCAoMTAsMCkgc2l6ZSAweDU4MAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICgxMCwx
MCkgc2l6ZSAweDU4MAo=
</data>
<flag name="review"
          id="59056"
          type_id="1"
          status="+"
          setter="bdakin"
    />
          </attachment>
      

    </bug>

</bugzilla>