46931 2010-09-30 13:21:44 -0700 ContextShadow should not call ceil() on m_blurRadius (an integer) 2010-09-30 14:20:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED P2 Major --- 0 jarred webkit-unassigned commit-queue oldest_to_newest 287767 0 jarred 2010-09-30 13:21:44 -0700 ContextShadow.cpp, lines 157 and 170, call ceil(m_blurRadius) which is passed into IntRect::inflate(int). This is not only unnecessary (because m_blurRadius is an integer) but it causes a build error with MSVC9+ (haven't tested <MSVC9) about ambiguous call to ceil() which cannot take an integer parameter. 287787 1 69376 jarred 2010-09-30 13:51:58 -0700 Created attachment 69376 Proposed patch 287817 2 69376 commit-queue 2010-09-30 14:20:49 -0700 Comment on attachment 69376 Proposed patch Clearing flags on attachment: 69376 Committed r68824: <http://trac.webkit.org/changeset/68824> 287818 3 commit-queue 2010-09-30 14:20:53 -0700 All reviewed patches have been landed. Closing bug. 69376 2010-09-30 13:51:58 -0700 2010-09-30 14:20:49 -0700 Proposed patch b46931.patch text/plain 1764 jarred SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODgxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDktMzAgIEphcnJlZCBOaWNob2xscyAgPGphcnJlZEBzZW5j aGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZWQgdW5uZWNlc3NhcnkgY2FsbHMgdG8gY2VpbCgpIG9uIGFuIGludAorICAgICAgICBS ZW1vdmluZyB0aGUgY2FsbCBmaXhlcyBNU1ZDIGJ1aWxkIGVycm9ycworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY5MzEKKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL0NvbnRleHRTaGFkb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4 dFNoYWRvdzo6Y2FsY3VsYXRlTGF5ZXJCb3VuZGluZ1JlY3QpOgorCiAyMDEwLTA5LTMwICBDcmlz IE5lY2thciAgPGNkbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbnRleHRTaGFkb3cuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29udGV4dFNoYWRvdy5j cHAJKHJldmlzaW9uIDY4ODE4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0 U2hhZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDcgKzE1NCw3IEBAIHZvaWQgQ29udGV4 dFNoYWRvdzo6Y2FsY3VsYXRlTGF5ZXJCb3VuZGkKICAgICBtX2xheWVyUmVjdCA9IGVuY2xvc2lu Z0ludFJlY3QoZGVzdGluYXRpb25SZWN0KTsKIAogICAgIC8vIFdlIGV4cGFuZCB0aGUgYXJlYSBi eSB0aGUgYmx1ciByYWRpdXMgKiAyIHRvIGdpdmUgZXh0cmEgc3BhY2UgZm9yIHRoZSBibHVyIHRy YW5zaXRpb24uCi0gICAgbV9sYXllclJlY3QuaW5mbGF0ZSgobV90eXBlID09IEJsdXJTaGFkb3cp ID8gY2VpbChtX2JsdXJSYWRpdXMgKiAyKSA6IDApOworICAgIG1fbGF5ZXJSZWN0LmluZmxhdGUo KG1fdHlwZSA9PSBCbHVyU2hhZG93KSA/IG1fYmx1clJhZGl1cyAqIDIgOiAwKTsKIAogICAgIGlm ICghY2xpcFJlY3QuY29udGFpbnMobV9sYXllclJlY3QpKSB7CiAgICAgICAgIC8vIE5vIG5lZWQg dG8gaGF2ZSB0aGUgYnVmZmVyIGxhcmdlciB0aGFuIHRoZSBjbGlwLgpAQCAtMTY3LDcgKzE2Nyw3 IEBAIHZvaWQgQ29udGV4dFNoYWRvdzo6Y2FsY3VsYXRlTGF5ZXJCb3VuZGkKICAgICAgICAgLy8g V2UgYWRqdXN0IGFnYWluIGJlY2F1c2UgdGhlIHBpeGVscyBhdCB0aGUgYm9yZGVycyBhcmUgc3Rp bGwKICAgICAgICAgLy8gcG90ZW50aWFsbHkgYWZmZWN0ZWQgYnkgdGhlIHBpeGVscyBvdXRzaWRl IHRoZSBidWZmZXIuCiAgICAgICAgIGlmIChtX3R5cGUgPT0gQmx1clNoYWRvdykKLSAgICAgICAg ICAgIG1fbGF5ZXJSZWN0LmluZmxhdGUoKG1fdHlwZSA9PSBCbHVyU2hhZG93KSA/IGNlaWwobV9i bHVyUmFkaXVzICogMikgOiAwKTsKKyAgICAgICAgICAgIG1fbGF5ZXJSZWN0LmluZmxhdGUoKG1f dHlwZSA9PSBCbHVyU2hhZG93KSA/IG1fYmx1clJhZGl1cyAqIDIgOiAwKTsKICAgICB9CiB9