46912 2010-09-30 09:38:25 -0700 compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey 2010-10-06 18:18:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser abarth commit-queue eric jamesr mikelawther simon.fraser oldest_to_newest 287594 0 simon.fraser 2010-09-30 09:38:25 -0700 compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey on the bots, e.g. http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68788%20(18524)/results.html 290646 1 70003 abarth 2010-10-06 16:14:53 -0700 Created attachment 70003 Patch 290651 2 jamesr 2010-10-06 16:21:35 -0700 The theory here is that the tiling flag (m_usingTiledLayer) is only being set from calls to GraphicsLayerCA::syncCompositingState(), which is called whenever FrameView::paintContents() is called or when the layerSyncRunLoopObserverCallBack in WebView.mm is called. We suspect that since this test doesn't specifically request a paint, that sometimes the test runs without syncCompositingState() being called and forcing the tiled flag to be set. I don't know if that really makes sense or not. The layer size seems correct. WDYT Simon? 290652 3 70003 simon.fraser 2010-10-06 16:24:40 -0700 Comment on attachment 70003 Patch That's exactly the change I would have made. Sorry I didn't get to this. 290739 4 70003 commit-queue 2010-10-06 18:18:40 -0700 Comment on attachment 70003 Patch Clearing flags on attachment: 70003 Committed r69265: <http://trac.webkit.org/changeset/69265> 290740 5 commit-queue 2010-10-06 18:18:45 -0700 All reviewed patches have been landed. Closing bug. 70003 2010-10-06 16:14:53 -0700 2010-10-06 18:18:40 -0700 Patch bug-46912-20101006161451.patch text/plain 1674 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY5MjQ5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTAtMDYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBjb21wb3NpdGluZy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMtdHJhbnNmb3Jt ZWQtb3ZlcmZsb3cuaHRtbCBpcyBmbGFrZXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ2OTEyCisKKyAgICAgICAgVGhpcyB0ZXN0IGlzIHRoZSBmbGFr aWVzdCB0ZXN0IG9mIGFsbCBiZWNhdXNlIHNvbWV0aW1lcyBpdCBkb2Vzbid0IHNob3cKKyAgICAg ICAgdGhhdCBpdCdzIHVzaW5nIHRpbGVkIGxheWVyaW5nLiAgSXQgc2VlbXMgbGlrZWx5IHRoYXQg dGhlIGNvbXBvc2l0b3IKKyAgICAgICAgc3RhdGUganVzdCBoYXNuJ3Qgc3luY2VkIGFsbCB0aGUg dGltZS4gIFRoaXMgcGF0Y2ggYWRkcyBhbiBleHBsaWNpdAorICAgICAgICBkaXNwbGF5KCkgY2Fs bCB0byBmb3JjZSB0aGUgY29tcG9zaXRvciBzdGF0ZSB0byBzeW5jLiAgSG9wZWZ1bGx5IGl0Cisg ICAgICAgIHdpbGwgbWFrZSB0aGUgdGVzdCBub24tZmxha3kuCisKKyAgICAgICAgKiBjb21wb3Np dGluZy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMtdHJhbnNmb3JtZWQtb3ZlcmZsb3cuaHRt bDoKKwogMjAxMC0xMC0wNiAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBMYXlvdXRUZXN0cy9jb21w b3NpdGluZy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMtdHJhbnNmb3JtZWQtb3ZlcmZsb3cu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy9nZW9tZXRyeS9saW1p dC1sYXllci1ib3VuZHMtdHJhbnNmb3JtZWQtb3ZlcmZsb3cuaHRtbAkocmV2aXNpb24gNjkyNDAp CisrKyBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMt dHJhbnNmb3JtZWQtb3ZlcmZsb3cuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsOCBA QAogICAgIGZ1bmN0aW9uIGRvVGVzdCgpCiAgICAgewogICAgICAgaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikgeworICAgICAgICAvLyBXZSBuZWVkIHRvIGNhbGwgZGlzcGxheSgpIGhl cmUgdG8gc3luYyB0aGUgY29tcG9zaXRvciBzdGF0ZSBhbmQgYXZvaWQgYSByYWNlIGNvbmRpdGlv bi4KKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZGlzcGxheSgpOwogICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnbGF5ZXJzJykuaW5uZXJUZXh0ID0gbGF5b3V0VGVzdENvbnRy b2xsZXIubGF5ZXJUcmVlQXNUZXh0KCk7CiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5v dGlmeURvbmUoKTsKICAgICAgIH0K