46886 2010-09-30 04:43:59 -0700 [GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED 2010-09-30 18:24:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mario webkit-unassigned alex commit-queue dbates mrobinson oldest_to_newest 287485 0 mario 2010-09-30 04:43:59 -0700 It looks that the following crash has been happening in the Debug build of the GTK port since the patch for bug 45381 was applied (see http://trac.webkit.org/changeset/68415): Program terminated with signal 11, Segmentation fault. #0 0x55fb8d13 in listMarkerSuffix (type=WebCore::Disc, value=1) at ../../WebCore/rendering/RenderListMarker.cpp:507 507 ASSERT_NOT_REACHED(); This is caused due to the new function WebCore::RenderListMarker::suffix() added along with that patch, which uses the internal function listMarkerSuffix() to retrieve the marker's suffix and return its value. Adding Daniel Bates to CC as its name is in commit revision 53452 (bug 33089), where the original code was introduced. 287492 1 69325 mario 2010-09-30 04:57:08 -0700 Created attachment 69325 Patch proposal Attaching a patch proposal that just gets rid of the ASSERT_NOT_REACHED() statement, as it's my understanding that's no longer correct. As explained in the ChangeLog entry: So far, this assertion made sense because it was not possible that a call to listMarkerSuffix() happened when the style of the list item was one of the following: Asterisks, Circle, Discm Footnotes, NoneListStyle or Square (it's easy to figure this out by checking the functions where listMarkerSuffix() was called). However, since revision 68415 (about bug 45381), there's a new place where listMarkerSuffix() is being called (the suffix() public method), regardless of the style of the item being or not one of those pointed out, so the aforementioned assertion in listMarkerSuffix() would no longer be correct, as now it's ok to reach those cases in the switch statement. Daniel, would you mind taking a look to this. I guess you're probably one of the best persons to say whether this approach is correct or not. Thanks in advance 287922 2 69325 dbates 2010-09-30 16:35:50 -0700 Comment on attachment 69325 Patch proposal This seems reasonable to me. 287926 3 69325 mrobinson 2010-09-30 16:37:46 -0700 Comment on attachment 69325 Patch proposal Setting the cq bit, since Mario is still waiting on his committer access. 287985 4 69325 commit-queue 2010-09-30 18:24:52 -0700 Comment on attachment 69325 Patch proposal Clearing flags on attachment: 69325 Committed r68858: <http://trac.webkit.org/changeset/68858> 287986 5 commit-queue 2010-09-30 18:24:57 -0700 All reviewed patches have been landed. Closing bug. 69325 2010-09-30 04:57:08 -0700 2010-09-30 18:24:52 -0700 Patch proposal 0001-2010-09-30-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3438 mario RnJvbSBjMThjZTg0MTBhODJjOThmNGE0ZGMyNGMxM2NmMWJkODU0NWRlZTczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDMwIFNlcCAyMDEwIDEzOjUzOjAwICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wOS0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBDcmFz aCBvbiB0ZXN0YXRrLmMgdW5pdHRlc3QgYmVjYXVzZSBvZiBhIGNhbGwgdG8gQVNTRVJUX05PVF9S RUFDSEVECiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2 ODg2CgogICAgICAgIFJlbW92ZWQgY2FsbCB0byBBU1NFUlRfTk9UX1JFQUNIRUQoKSBmcm9tIGxp c3RNYXJrZXJTdWZmaXgoKS4KCiAgICAgICAgU28gZmFyLCB0aGlzIGFzc2VydGlvbiBtYWRlIHNl bnNlIGJlY2F1c2UgaXQgd2FzIG5vdCBwb3NzaWJsZSB0aGF0CiAgICAgICAgYSBjYWxsIHRvIGxp c3RNYXJrZXJTdWZmaXgoKSBoYXBwZW5lZCB3aGVuIHRoZSBzdHlsZSBvZiB0aGUgbGlzdAogICAg ICAgIGl0ZW0gd2FzIG9uZSBvZiB0aGUgZm9sbG93aW5nOiBBc3Rlcmlza3MsIENpcmNsZSwgRGlz Y20gRm9vdG5vdGVzLAogICAgICAgIE5vbmVMaXN0U3R5bGUgb3IgU3F1YXJlIChpdCdzIGVhc3kg dG8gZmlndXJlIHRoaXMgb3V0IGJ5IGNoZWNraW5nCiAgICAgICAgdGhlIGZ1bmN0aW9ucyB3aGVy ZSBsaXN0TWFya2VyU3VmZml4KCkgd2FzIGNhbGxlZCkuCgogICAgICAgIEhvd2V2ZXIsIHNpbmNl IHJldmlzaW9uIDY4NDE1IChhYm91dCBidWcgNDUzODEpLCB0aGVyZSdzIGEgbmV3CiAgICAgICAg cGxhY2Ugd2hlcmUgbGlzdE1hcmtlclN1ZmZpeCgpIGlzIGJlaW5nIGNhbGxlZCAodGhlIHN1ZmZp eCgpCiAgICAgICAgcHVibGljIG1ldGhvZCksIHJlZ2FyZGxlc3Mgb2YgdGhlIHN0eWxlIG9mIHRo ZSBpdGVtIGJlaW5nIG9yIG5vdAogICAgICAgIG9uZSBvZiB0aG9zZSBwb2ludGVkIG91dCwgc28g dGhlIGFmb3JlbWVudGlvbmVkIGFzc2VydGlvbiBpbgogICAgICAgIGxpc3RNYXJrZXJTdWZmaXgo KSB3b3VsZCBubyBsb25nZXIgYmUgY29ycmVjdCwgYXMgbm93IGl0J3Mgb2sgdG8KICAgICAgICBy ZWFjaCB0aG9zZSBjYXNlcyBpbiB0aGUgc3dpdGNoIHN0YXRlbWVudC4KCiAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHA6CiAgICAgICAgKFdlYkNvcmU6Omxpc3RNYXJrZXJT dWZmaXgpOiBSZW1vdmVkIGNhbGwgdG8gQVNTRVJUX05PVF9SRUFDSEVEKCkuCi0tLQogV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgfCAgIDI1ICsrKysrKysrKysrKysrKysr KysrKysrKysKIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RNYXJrZXIuY3BwIHwgICAgMSAt CiAyIGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMzMx ODMyLi4wZmIyY2E1IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEwLTA5LTMwICBNYXJpbyBTYW5jaGV6IFBy YWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR1RLXSBDcmFzaCBvbiB0ZXN0YXRrLmMgdW5pdHRlc3QgYmVj YXVzZSBvZiBhIGNhbGwgdG8gQVNTRVJUX05PVF9SRUFDSEVECisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njg4NgorCisgICAgICAgIFJlbW92ZWQgY2Fs bCB0byBBU1NFUlRfTk9UX1JFQUNIRUQoKSBmcm9tIGxpc3RNYXJrZXJTdWZmaXgoKS4KKworICAg ICAgICBTbyBmYXIsIHRoaXMgYXNzZXJ0aW9uIG1hZGUgc2Vuc2UgYmVjYXVzZSBpdCB3YXMgbm90 IHBvc3NpYmxlIHRoYXQKKyAgICAgICAgYSBjYWxsIHRvIGxpc3RNYXJrZXJTdWZmaXgoKSBoYXBw ZW5lZCB3aGVuIHRoZSBzdHlsZSBvZiB0aGUgbGlzdAorICAgICAgICBpdGVtIHdhcyBvbmUgb2Yg dGhlIGZvbGxvd2luZzogQXN0ZXJpc2tzLCBDaXJjbGUsIERpc2NtIEZvb3Rub3RlcywKKyAgICAg ICAgTm9uZUxpc3RTdHlsZSBvciBTcXVhcmUgKGl0J3MgZWFzeSB0byBmaWd1cmUgdGhpcyBvdXQg YnkgY2hlY2tpbmcKKyAgICAgICAgdGhlIGZ1bmN0aW9ucyB3aGVyZSBsaXN0TWFya2VyU3VmZml4 KCkgd2FzIGNhbGxlZCkuCisKKyAgICAgICAgSG93ZXZlciwgc2luY2UgcmV2aXNpb24gNjg0MTUg KGFib3V0IGJ1ZyA0NTM4MSksIHRoZXJlJ3MgYSBuZXcKKyAgICAgICAgcGxhY2Ugd2hlcmUgbGlz dE1hcmtlclN1ZmZpeCgpIGlzIGJlaW5nIGNhbGxlZCAodGhlIHN1ZmZpeCgpCisgICAgICAgIHB1 YmxpYyBtZXRob2QpLCByZWdhcmRsZXNzIG9mIHRoZSBzdHlsZSBvZiB0aGUgaXRlbSBiZWluZyBv ciBub3QKKyAgICAgICAgb25lIG9mIHRob3NlIHBvaW50ZWQgb3V0LCBzbyB0aGUgYWZvcmVtZW50 aW9uZWQgYXNzZXJ0aW9uIGluCisgICAgICAgIGxpc3RNYXJrZXJTdWZmaXgoKSB3b3VsZCBubyBs b25nZXIgYmUgY29ycmVjdCwgYXMgbm93IGl0J3Mgb2sgdG8KKyAgICAgICAgcmVhY2ggdGhvc2Ug Y2FzZXMgaW4gdGhlIHN3aXRjaCBzdGF0ZW1lbnQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGlzdE1hcmtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsaXN0TWFya2VyU3VmZml4KTog UmVtb3ZlZCBjYWxsIHRvIEFTU0VSVF9OT1RfUkVBQ0hFRCgpLgorCiAyMDEwLTA5LTMwICBKb2No ZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RN YXJrZXIuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHAKaW5kZXgg MTg4MTFkZi4uZWI5MTRkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlz dE1hcmtlci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHAK QEAgLTUwNCw3ICs1MDQsNiBAQCBzdGF0aWMgVUNoYXIgbGlzdE1hcmtlclN1ZmZpeChFTGlzdFN0 eWxlVHlwZSB0eXBlLCBpbnQgdmFsdWUpCiAgICAgY2FzZSBGb290bm90ZXM6CiAgICAgY2FzZSBO b25lTGlzdFN0eWxlOgogICAgIGNhc2UgU3F1YXJlOgotICAgICAgICBBU1NFUlRfTk9UX1JFQUNI RUQoKTsKICAgICAgICAgcmV0dXJuICcgJzsKICAgICBjYXNlIEFmYXI6CiAgICAgY2FzZSBBbWhh cmljOgotLSAKMS43LjAuNAoK