46884 2010-09-30 02:24:03 -0700 [chromium] add an identifier method to WebFrame 2010-10-01 01:06:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jochen jochen commit-queue fishd oldest_to_newest 287447 0 jochen 2010-09-30 02:24:03 -0700 [chromium] add an identifier method to WebFrame 287448 1 69320 jochen 2010-09-30 02:24:27 -0700 Created attachment 69320 Patch 287681 2 69320 fishd 2010-09-30 11:19:27 -0700 Comment on attachment 69320 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69320&action=review > WebKit/chromium/ChangeLog:5 > + [chromium] add an identifier method to WebFrame please add some explanation here about why this is important. please document what kind of constraints you have on this identifier. that way people in the future will understand what they can and can't change about this identifier field. > WebKit/chromium/src/WebFrameImpl.cpp:267 > + // identifiers that overlap with those from past/future browser sessions. making these IDs unique across browser sessions is not a requirement is it? 288095 3 69429 jochen 2010-10-01 00:41:46 -0700 Created attachment 69429 Patch 288110 4 69429 commit-queue 2010-10-01 01:06:26 -0700 Comment on attachment 69429 Patch Clearing flags on attachment: 69429 Committed r68871: <http://trac.webkit.org/changeset/68871> 288111 5 commit-queue 2010-10-01 01:06:30 -0700 All reviewed patches have been landed. Closing bug. 69320 2010-09-30 02:24:27 -0700 2010-10-01 00:41:41 -0700 Patch bug-46884-20100930112425.patch text/plain 3596 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDE0MjMwMWNiOWQxOTUwM2I0NWFiMzQwY2I3YTlhM2UzZWI4NDI3MGIu LjNkNmViNThjNTkzZjA3NGNhZjIzM2ZmYzVmNTI5OWUxOWM3YmIyMGMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEwLTA5LTMwICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtjaHJvbWl1bV0gYWRkIGFuIGlkZW50aWZpZXIgbWV0aG9kIHRvIFdlYkZyYW1lCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njg4NAorCisgICAg ICAgICogcHVibGljL1dlYkZyYW1lLmg6CisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OmdlbmVyYXRlRnJhbWVJZGVudGlmaWVyKToKKyAgICAgICAgKFdl YktpdDo6V2ViRnJhbWVJbXBsOjppZGVudGlmaWVyKToKKyAgICAgICAgKFdlYktpdDo6V2ViRnJh bWVJbXBsOjpXZWJGcmFtZUltcGwpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKwog MjAxMC0wOS0zMCAgQWxleGV5IE1hcmluaWNoZXYgIDxhbWFyaW5pY2hldkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGcmFtZS5oCmluZGV4IDVkNDFkMTA4YjJkNmU4ZjNhYjI3MDlmNzZhZGQwODM4MWE4MmM2NWQu LjVmODUzOWM2YmJkMzViN2Y4NDA0MDgzYjdkNDc5ZDk3MGFmMDMwYTcgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkZyYW1lLmgKQEAgLTEwOSw2ICsxMDksOSBAQCBwdWJsaWM6CiAgICAgLy8gZnJhbWUg bmFtZSB1bmlxdWUgd2l0aGluIHRoZSBoaWVyYXJjaHkuCiAgICAgdmlydHVhbCB2b2lkIHNldE5h bWUoY29uc3QgV2ViU3RyaW5nJikgPSAwOwogCisgICAgLy8gQSBnbG9iYWxseSB1bmlxdWUgaWRl bnRpZmllciBmb3IgdGhpcyBmcmFtZS4KKyAgICB2aXJ0dWFsIGxvbmcgbG9uZyBpZGVudGlmaWVy KCkgY29uc3QgPSAwOworCiAgICAgLy8gVGhlIHVybCBvZiB0aGUgZG9jdW1lbnQgbG9hZGVkIGlu IHRoaXMgZnJhbWUuICBUaGlzIGlzIGVxdWl2YWxlbnQgdG8KICAgICAvLyBkYXRhU291cmNlKCkt PnJlcXVlc3QoKS51cmwoKS4KICAgICB2aXJ0dWFsIFdlYlVSTCB1cmwoKSBjb25zdCA9IDA7CmRp ZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggMWI2NGU1YTA2NzgwYjdiMjczM2Iz MTU5YjhmNjQwZDkzOTBhNzRiMi4uMDRlOThmMzViODA4NjVjYjkwYTlkMzI3MmU4NWY5Nzc5NWJl YTc5ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisr KyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMjYxLDYgKzI2MSwx NCBAQCBzdGF0aWMgdm9pZCBmcmFtZUNvbnRlbnRBc1BsYWluVGV4dChzaXplX3QgbWF4Q2hhcnMs IEZyYW1lKiBmcmFtZSwKICAgICB9CiB9CiAKK3N0YXRpYyBsb25nIGxvbmcgZ2VuZXJhdGVGcmFt ZUlkZW50aWZpZXIoKQoreworICAgIC8vIEluaXRpYWxpemUgdG8gdGhlIGN1cnJlbnQgdGltZSB0 byByZWR1Y2UgdGhlIGxpa2VsaWhvb2Qgb2YgZ2VuZXJhdGluZworICAgIC8vIGlkZW50aWZpZXJz IHRoYXQgb3ZlcmxhcCB3aXRoIHRob3NlIGZyb20gcGFzdC9mdXR1cmUgYnJvd3NlciBzZXNzaW9u cy4KKyAgICBzdGF0aWMgbG9uZyBsb25nIG5leHQgPSBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KGN1 cnJlbnRUaW1lKCkgKiAxMDAwMDAwLjApOworICAgIHJldHVybiArK25leHQ7Cit9CisKIFdlYlBs dWdpbkNvbnRhaW5lckltcGwqIFdlYkZyYW1lSW1wbDo6cGx1Z2luQ29udGFpbmVyRnJvbUZyYW1l KEZyYW1lKiBmcmFtZSkKIHsKICAgICBpZiAoIWZyYW1lKQpAQCAtNDg4LDYgKzQ5NiwxMSBAQCB2 b2lkIFdlYkZyYW1lSW1wbDo6c2V0TmFtZShjb25zdCBXZWJTdHJpbmcmIG5hbWUpCiAgICAgbV9m cmFtZS0+dHJlZSgpLT5zZXROYW1lKG5hbWUpOwogfQogCitsb25nIGxvbmcgV2ViRnJhbWVJbXBs OjppZGVudGlmaWVyKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9pZGVudGlmaWVyOworfQorCiBX ZWJVUkwgV2ViRnJhbWVJbXBsOjp1cmwoKSBjb25zdAogewogICAgIGNvbnN0IFdlYkRhdGFTb3Vy Y2UqIGRzID0gZGF0YVNvdXJjZSgpOwpAQCAtMTc3OSw2ICsxNzkyLDcgQEAgV2ViRnJhbWVJbXBs OjpXZWJGcmFtZUltcGwoV2ViRnJhbWVDbGllbnQqIGNsaWVudCkKICAgICAsIG1fc2NvcGluZ0Nv bXBsZXRlKGZhbHNlKQogICAgICwgbV9uZXh0SW52YWxpZGF0ZUFmdGVyKDApCiAgICAgLCBtX2Fu aW1hdGlvbkNvbnRyb2xsZXIodGhpcykKKyAgICAsIG1faWRlbnRpZmllcihnZW5lcmF0ZUZyYW1l SWRlbnRpZmllcigpKQogewogICAgIENocm9taXVtQnJpZGdlOjppbmNyZW1lbnRTdGF0c0NvdW50 ZXIod2ViRnJhbWVBY3RpdmVDb3VudCk7CiAgICAgZnJhbWVDb3VudCsrOwpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRnJhbWVJbXBsLmgKaW5kZXggZDkzMjU0YjYwYjY2Mjc4MzU3ZjQ1NGU0MWNjNzBjNWE0OTA4 MGVlOS4uNGU4YjFlYWU3ZjMzMGVhODNiMTZmMmRkMDdlZGY4MTAyYjQ0NjMwOCAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBAIC02Nyw2ICs2Nyw3IEBAIHB1YmxpYzoKICAgICAvLyBX ZWJGcmFtZSBtZXRob2RzOgogICAgIHZpcnR1YWwgV2ViU3RyaW5nIG5hbWUoKSBjb25zdDsKICAg ICB2aXJ0dWFsIHZvaWQgc2V0TmFtZShjb25zdCBXZWJTdHJpbmcmKTsKKyAgICB2aXJ0dWFsIGxv bmcgbG9uZyBpZGVudGlmaWVyKCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJVUkwgdXJsKCkgY29u c3Q7CiAgICAgdmlydHVhbCBXZWJVUkwgZmF2SWNvblVSTCgpIGNvbnN0OwogICAgIHZpcnR1YWwg V2ViVVJMIG9wZW5TZWFyY2hEZXNjcmlwdGlvblVSTCgpIGNvbnN0OwpAQCAtMzg2LDYgKzM4Nyw5 IEBAIHByaXZhdGU6CiAKICAgICAvLyBLZWVwcyBhIHJlZmVyZW5jZSB0byB0aGUgZnJhbWUncyBX ZWJBbmltYXRpb25Db250cm9sbGVyLgogICAgIFdlYkFuaW1hdGlvbkNvbnRyb2xsZXJJbXBsIG1f YW5pbWF0aW9uQ29udHJvbGxlcjsKKworICAgIC8vIFRoZSBpZGVudGlmaWVyIG9mIHRoaXMgZnJh bWUuCisgICAgbG9uZyBsb25nIG1faWRlbnRpZmllcjsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdl YktpdAo= 69429 2010-10-01 00:41:46 -0700 2010-10-01 01:06:25 -0700 Patch bug-46884-20101001094144.patch text/plain 3625 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDE0MjMwMWNiOWQxOTUwM2I0NWFiMzQwY2I3YTlhM2UzZWI4NDI3MGIu Ljk0ZDk2NWI2MGE2NTA0NTE4MTkzMWJiOWI2NTdmYmQyN2Q1MTc0ZjMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE5IEBACisyMDEwLTA5LTMwICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtjaHJvbWl1bV0gYWRkIGFuIGlkZW50aWZpZXIgbWV0aG9kIHRvIFdlYkZyYW1lLiBUaGUg aWRlbnRpZmllciBjYW4gYmUgdXNlZCB0byBpZGVudGlmeQorICAgICAgICBhIGdpdmVuIGZyYW1l IG9mIGEgdmlldyBvdmVyIHRpbWUuIFVzaW5nIGEgcG9pbnRlciB0byB0aGUgV2ViRnJhbWUgb2Jq ZWN0IGlzIGZyYWdpbGUsCisgICAgICAgIHNpbmNlIGEgbmV3IGZyYW1lIG1pZ2h0IGhhdmUgYmVl biBhbGxvY2F0ZWQgYXQgdGhlIHNhbWUgYWRkcmVzcyBhcyBhbiBvbGQsIGRlbGV0ZWQgZnJhbWUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njg4NAor CisgICAgICAgICogcHVibGljL1dlYkZyYW1lLmg6CisgICAgICAgICogc3JjL1dlYkZyYW1lSW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmdlbmVyYXRlRnJhbWVJZGVudGlmaWVyKToKKyAgICAg ICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjppZGVudGlmaWVyKToKKyAgICAgICAgKFdlYktpdDo6 V2ViRnJhbWVJbXBsOjpXZWJGcmFtZUltcGwpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwu aDoKKwogMjAxMC0wOS0zMCAgQWxleGV5IE1hcmluaWNoZXYgIDxhbWFyaW5pY2hldkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJGcmFtZS5oCmluZGV4IDVkNDFkMTA4YjJkNmU4ZjNhYjI3MDlmNzZhZGQwODM4MWE4 MmM2NWQuLjVmODUzOWM2YmJkMzViN2Y4NDA0MDgzYjdkNDc5ZDk3MGFmMDMwYTcgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAorKysgYi9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkZyYW1lLmgKQEAgLTEwOSw2ICsxMDksOSBAQCBwdWJsaWM6CiAgICAgLy8g ZnJhbWUgbmFtZSB1bmlxdWUgd2l0aGluIHRoZSBoaWVyYXJjaHkuCiAgICAgdmlydHVhbCB2b2lk IHNldE5hbWUoY29uc3QgV2ViU3RyaW5nJikgPSAwOwogCisgICAgLy8gQSBnbG9iYWxseSB1bmlx dWUgaWRlbnRpZmllciBmb3IgdGhpcyBmcmFtZS4KKyAgICB2aXJ0dWFsIGxvbmcgbG9uZyBpZGVu dGlmaWVyKCkgY29uc3QgPSAwOworCiAgICAgLy8gVGhlIHVybCBvZiB0aGUgZG9jdW1lbnQgbG9h ZGVkIGluIHRoaXMgZnJhbWUuICBUaGlzIGlzIGVxdWl2YWxlbnQgdG8KICAgICAvLyBkYXRhU291 cmNlKCktPnJlcXVlc3QoKS51cmwoKS4KICAgICB2aXJ0dWFsIFdlYlVSTCB1cmwoKSBjb25zdCA9 IDA7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggMWI2NGU1YTA2NzgwYjdi MjczM2IzMTU5YjhmNjQwZDkzOTBhNzRiMi4uYjkzYTc5MjAyMzU4MGI4MWYyNDY1ZWFlZGUyMDJm MGY1NmIxMmFmZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwu Y3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMjYxLDYg KzI2MSwxMiBAQCBzdGF0aWMgdm9pZCBmcmFtZUNvbnRlbnRBc1BsYWluVGV4dChzaXplX3QgbWF4 Q2hhcnMsIEZyYW1lKiBmcmFtZSwKICAgICB9CiB9CiAKK3N0YXRpYyBsb25nIGxvbmcgZ2VuZXJh dGVGcmFtZUlkZW50aWZpZXIoKQoreworICAgIHN0YXRpYyBsb25nIGxvbmcgbmV4dCA9IDA7Cisg ICAgcmV0dXJuICsrbmV4dDsKK30KKwogV2ViUGx1Z2luQ29udGFpbmVySW1wbCogV2ViRnJhbWVJ bXBsOjpwbHVnaW5Db250YWluZXJGcm9tRnJhbWUoRnJhbWUqIGZyYW1lKQogewogICAgIGlmICgh ZnJhbWUpCkBAIC00ODgsNiArNDk0LDExIEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpzZXROYW1lKGNv bnN0IFdlYlN0cmluZyYgbmFtZSkKICAgICBtX2ZyYW1lLT50cmVlKCktPnNldE5hbWUobmFtZSk7 CiB9CiAKK2xvbmcgbG9uZyBXZWJGcmFtZUltcGw6OmlkZW50aWZpZXIoKSBjb25zdAoreworICAg IHJldHVybiBtX2lkZW50aWZpZXI7Cit9CisKIFdlYlVSTCBXZWJGcmFtZUltcGw6OnVybCgpIGNv bnN0CiB7CiAgICAgY29uc3QgV2ViRGF0YVNvdXJjZSogZHMgPSBkYXRhU291cmNlKCk7CkBAIC0x Nzc5LDYgKzE3OTAsNyBAQCBXZWJGcmFtZUltcGw6OldlYkZyYW1lSW1wbChXZWJGcmFtZUNsaWVu dCogY2xpZW50KQogICAgICwgbV9zY29waW5nQ29tcGxldGUoZmFsc2UpCiAgICAgLCBtX25leHRJ bnZhbGlkYXRlQWZ0ZXIoMCkKICAgICAsIG1fYW5pbWF0aW9uQ29udHJvbGxlcih0aGlzKQorICAg ICwgbV9pZGVudGlmaWVyKGdlbmVyYXRlRnJhbWVJZGVudGlmaWVyKCkpCiB7CiAgICAgQ2hyb21p dW1CcmlkZ2U6OmluY3JlbWVudFN0YXRzQ291bnRlcih3ZWJGcmFtZUFjdGl2ZUNvdW50KTsKICAg ICBmcmFtZUNvdW50Kys7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5oIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAppbmRleCBkOTMyNTRi NjBiNjYyNzgzNTdmNDU0ZTQxY2M3MGM1YTQ5MDgwZWU5Li40ZThiMWVhZTdmMzMwZWE4M2IxNmYy ZGQwN2VkZjgxMDJiNDQ2MzA4IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKQEAgLTY3 LDYgKzY3LDcgQEAgcHVibGljOgogICAgIC8vIFdlYkZyYW1lIG1ldGhvZHM6CiAgICAgdmlydHVh bCBXZWJTdHJpbmcgbmFtZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCBzZXROYW1lKGNvbnN0 IFdlYlN0cmluZyYpOworICAgIHZpcnR1YWwgbG9uZyBsb25nIGlkZW50aWZpZXIoKSBjb25zdDsK ICAgICB2aXJ0dWFsIFdlYlVSTCB1cmwoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlVSTCBmYXZJ Y29uVVJMKCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJVUkwgb3BlblNlYXJjaERlc2NyaXB0aW9u VVJMKCkgY29uc3Q7CkBAIC0zODYsNiArMzg3LDkgQEAgcHJpdmF0ZToKIAogICAgIC8vIEtlZXBz IGEgcmVmZXJlbmNlIHRvIHRoZSBmcmFtZSdzIFdlYkFuaW1hdGlvbkNvbnRyb2xsZXIuCiAgICAg V2ViQW5pbWF0aW9uQ29udHJvbGxlckltcGwgbV9hbmltYXRpb25Db250cm9sbGVyOworCisgICAg Ly8gVGhlIGlkZW50aWZpZXIgb2YgdGhpcyBmcmFtZS4KKyAgICBsb25nIGxvbmcgbV9pZGVudGlm aWVyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==