46870 2010-09-29 20:36:49 -0700 fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard 2010-09-30 16:36:49 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 45769 1 eric zmo alokp cmarrin commit-queue enne kbr zmo oldest_to_newest 287358 0 eric 2010-09-29 20:36:49 -0700 fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68740%20(18485)/fast/canvas/webgl/draw-elements-out-of-bounds-stderr.txt Assertion failed: (0 && "InitThread(): Process hasn't been initalised."), function InitThread, file /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release/build/ANGLE/src/compiler/InitializeDll.cpp, line 71. The crashing started after I turned off some canvas tests as part of this rollout: http://trac.webkit.org/changeset/68737 Since skipping tests should not cause crashes, there was likely a crash here before, masked by other factors. Going to skip this canvas test until zmo/kbr can take a look. 287359 1 69307 commit-queue 2010-09-29 20:40:44 -0700 Created attachment 69307 Skip the test 287360 2 commit-queue 2010-09-29 20:42:22 -0700 Committed r68745: <http://trac.webkit.org/changeset/68745> 287370 3 zmo 2010-09-29 21:08:09 -0700 I'll take a look. Looks like Angle issue, but it could be misleading. 287498 4 aroben 2010-09-30 05:25:15 -0700 <rdar://problem/8496585> 287776 5 69374 zmo 2010-09-30 13:35:18 -0700 Created attachment 69374 patch After discussing with Alok and Dimitri, this is an educated attempt. The cause (from the assertion failure) could be the previous test cleanup is delayed and the current test called ShInitialize() before the ShFinalize() from the previous test. 287779 6 eric 2010-09-30 13:37:57 -0700 Do we finalize in some other way? or after this change would we never finalize? And what are the consequences of such? 287825 7 69374 kbr 2010-09-30 14:27:17 -0700 Comment on attachment 69374 patch We've discussed this earlier via email and this is the correct fix at the present time. 287858 8 zmo 2010-09-30 14:48:38 -0700 Committed r68833: <http://trac.webkit.org/changeset/68833> 287920 9 eric 2010-09-30 16:31:19 -0700 My questions were never answered, but I guess I'm not on the right mailing list. :) Does this need a FIXME for the future? 287921 10 kbr 2010-09-30 16:32:55 -0700 (In reply to comment #9) > My questions were never answered, but I guess I'm not on the right mailing list. :) > > Does this need a FIXME for the future? Not really. At best we would need an at-exit hook, but OS process separation will take care of the cleanup of the needed static and thread-local resources. 287924 11 zmo 2010-09-30 16:36:49 -0700 (In reply to comment #9) > My questions were never answered, but I guess I'm not on the right mailing list. :) > > Does this need a FIXME for the future? alokp is working on getting rid of ShInitialize and ShFinalize. We'll just live with this until that happens. 69307 2010-09-29 20:40:44 -0700 2010-09-30 13:35:18 -0700 Skip the test bug-46870-20100929204043.patch text/plain 1388 commit-queue ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNWQ0MWRkZWJmZWViYjRiOTZiOGYwNzRmZDE5MWE1NWEwMmZiYTk4Li4wMGIyMDZh OTFlNmRmYjc3OWY2NDA3YzY2YjY3MTM1YmZhZjBmMWI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDktMjkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFVu cmV2aWV3ZWQuICBTa2lwcGluZyBjcmFzaGluZyB0ZXN0IHRvIGdyZWVuIHRoZSB0cmVlLgorICAg ICAgICBUaGlzIGNyYXNoIHN0YXJ0ZWQgd2hlbiBJIHNraXBwZWQgc29tZSBjYW52YXMgdGVzdHMK KyAgICAgICAgYXMgcGFydCBvZiByb2xsaW5nIG91dCByNjg1NjguCisKKyAgICAgICAgZmFzdC9j YW52YXMvd2ViZ2wvZHJhdy1lbGVtZW50cy1vdXQtb2YtYm91bmRzLmh0bWwgaXMgY3Jhc2hpbmcg b24gU25vdyBMZW9wYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00Njg3MAorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL1NraXBw ZWQ6CisKIDIwMTAtMDktMjkgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tpcHBlZAppbmRleCBmZDg5YzE3MDcxZWNjYzVlNzhhMTdl Zjk5YzAzM2ZjODQwZDE1ZGQ1Li42MzI3NjBhNDZlM2I2OWQzMzRiODdmYWZmYWYyZTM4YTE5NjFi NGM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tp cHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tpcHBlZApA QCAtMTM3LDMgKzEzNyw3IEBAIHN0b3JhZ2UvaW5kZXhlZGRiCiAjIFBoaWxpcCdzIGNhbnZhcyB0 ZXN0cyB0aGF0IGZhaWwgb24gU25vd0xlb3BhcmQgb25seQogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5ncmFkaWVudC5pbnRlcnBvbGF0ZS5vdmVybGFwLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMv MmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUub3ZlcmxhcDIuaHRtbAorCisjIENyYXNoaW5nIGR1ZSB0 byBpbnRlcmFjdGlvbiB3aXRoIGVhcmxpZXIgdGVzdHMKKyMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ2ODcwCitmYXN0L2NhbnZhcy93ZWJnbC9kcmF3LWVsZW1lbnRz LW91dC1vZi1ib3VuZHMuaHRtbAo= 69374 2010-09-30 13:35:18 -0700 2010-09-30 14:27:17 -0700 patch angle.patch text/plain 2407 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODgxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMzAgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmYXN0L2Nh bnZhcy93ZWJnbC9kcmF3LWVsZW1lbnRzLW91dC1vZi1ib3VuZHMuaHRtbCBpcyBjcmFzaGluZyBv biBTbm93IExlb3BhcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ2ODcwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9BTkdMRVdlYktpdEJy aWRnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBTkdMRVdlYktpdEJyaWRnZTo6fkFOR0xFV2Vi S2l0QnJpZGdlKTogUmVtb3ZlIFNoRmluYWxpemUoKS4KKwogMjAxMC0wOS0zMCAgRGF2aWQgSHlh dHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQU5HTEVXZWJLaXRCcmlkZ2UuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQU5HTEVXZWJLaXRCcmlkZ2Uu Y3BwCShyZXZpc2lvbiA2ODgwNSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQU5HTEVX ZWJLaXRCcmlkZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw4ICs0NCw2IEBAIEFOR0xFV2Vi S2l0QnJpZGdlOjp+QU5HTEVXZWJLaXRCcmlkZ2UoKQogICAgICAgICBTaERlc3RydWN0KG1fZnJh Z21lbnRDb21waWxlcik7CiAgICAgICAgIFNoRGVzdHJ1Y3QobV92ZXJ0ZXhDb21waWxlcik7CiAg ICAgfQotICAgIAotICAgIFNoRmluYWxpemUoKTsKIH0KIAogYm9vbCBBTkdMRVdlYktpdEJyaWRn ZTo6dmFsaWRhdGVTaGFkZXJTb3VyY2UoY29uc3QgY2hhciogc2hhZGVyU291cmNlLCBBTkdMRVNo YWRlclR5cGUgc2hhZGVyVHlwZSwgU3RyaW5nJiB0cmFuc2xhdGVkU2hhZGVyU291cmNlLCBTdHJp bmcmIHNoYWRlclZhbGlkYXRpb25Mb2cpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2ODgxOCkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEw LTA5LTMwICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9jYW52YXMvd2ViZ2wvZHJhdy1lbGVt ZW50cy1vdXQtb2YtYm91bmRzLmh0bWwgaXMgY3Jhc2hpbmcgb24gU25vdyBMZW9wYXJkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njg3MAorCisgICAg ICAgICogcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL1NraXBwZWQ6IFJlLWVuYWJsZSB0aGUgdGVz dC4KKwogMjAxMC0wOS0zMCAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIEJ1aWxkIGZpeC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy1zbm93bGVvcGFyZC9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3Jt L21hYy1zbm93bGVvcGFyZC9Ta2lwcGVkCShyZXZpc2lvbiA2ODgwNSkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy1zbm93bGVvcGFyZC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xMzcs NyArMTM3LDMgQEAgc3RvcmFnZS9pbmRleGVkZGIKICMgUGhpbGlwJ3MgY2FudmFzIHRlc3RzIHRo YXQgZmFpbCBvbiBTbm93TGVvcGFyZCBvbmx5CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRp ZW50LmludGVycG9sYXRlLm92ZXJsYXAuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFk aWVudC5pbnRlcnBvbGF0ZS5vdmVybGFwMi5odG1sCi0KLSMgQ3Jhc2hpbmcgZHVlIHRvIGludGVy YWN0aW9uIHdpdGggZWFybGllciB0ZXN0cwotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDY4NzAKLWZhc3QvY2FudmFzL3dlYmdsL2RyYXctZWxlbWVudHMtb3V0LW9m LWJvdW5kcy5odG1sCg==