46865 2010-09-29 18:46:37 -0700 WebCore::ESpeak causes missing symbol with no ENABLE_SVG 2010-09-29 20:42:51 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 morrita webkit-unassigned abarth cfleizach darin eric webkit.review.bot oldest_to_newest 287305 0 morrita 2010-09-29 18:46:37 -0700 From error output: out/Release/obj.target/third_party/WebKit/WebCore/WebCore.gyp/libwebcore_remaining.a(CSSStyleSelector.o): In function `WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*)': /b/slave/chromium-rel-linux-valgrind-builder/build/src/third_party/WebKit/WebCore/css/CSSStyleSelector.cpp:5489: undefined reference to `WebCore::CSSPrimitiveValue::operator WebCore::ESpeak<WebCore::ESpeak>() const' out/Release/obj.target/third_party/WebKit/WebCore/WebCore.gyp/libwebcore_remaining.a(CSSComputedStyleDeclaration.o): In function `WTF::PassRefPtr<WebCore::CSSPrimitiveValue> WebCore::CSSPrimitiveValue::create<WebCore::ESpeak>(WebCore::ESpeak)': /b/slave/chromium-rel-linux-valgrind-builder/build/src/third_party/WebKit/WebCore/css/CSSPrimitiveValue.h:107: undefined reference to `WebCore::CSSPrimitiveValue::CSSPrimitiveValue<WebCore::ESpeak>(WebCore::ESpeak)' Seems introduced at http://trac.webkit.org/changeset/68680. A patch will come shortly. 287321 1 69296 morrita 2010-09-29 19:24:51 -0700 Created attachment 69296 Patch 287325 2 morrita 2010-09-29 19:34:19 -0700 Committed r68738: <http://trac.webkit.org/changeset/68738> 287327 3 69296 cfleizach 2010-09-29 19:36:10 -0700 Comment on attachment 69296 Patch R=me Thanks 287361 4 webkit.review.bot 2010-09-29 20:42:51 -0700 http://trac.webkit.org/changeset/68738 might have broken Leopard Intel Debug (Tests) 69296 2010-09-29 19:24:51 -0700 2010-09-29 20:32:40 -0700 Patch bug-46865-20100930112449.patch text/plain 3886 morrita ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjIwMzk4YTMwYzAzYjBjMzhmOTAwNWM1NGMyNWZiYmM0MmYzMDQ5YS4uNzYzNDM3ZjlmZDZkYzJk YjFlYTExMTE0YzdjZGQzZDYzZGIyYmI1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOS0yOSAgTU9S SVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpFU3Bl YWsgY2F1c2VzIG1pc3Npbmcgc3ltYm9sIHdpdGggbm8gRU5BQkxFX1NWRworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY4NjUKKworICAgICAgICBNb3Zl cyBFU3BlYWsgcmVsYXRlZCBmdW5jdGlvbiBkZWZpbml0aW9ucyBvdXRzaWRlIEVOQUJMRV9TVkcg YmxvY2suCisgICAgICAgIAorICAgICAgICBObyB0ZXN0LCBqdXN0IGEgYnVpbGQgZml4LgorCisg ICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZSk6CisgICAgICAgIChXZWJD b3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6b3BlcmF0b3IgRVNwZWFrKToKKyAgICAgICAgKFdlYkNv cmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRvciBFVmVjdG9yRWZmZWN0KToKKwogMjAxMC0w OS0yOSAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU1ByaW1p dGl2ZVZhbHVlTWFwcGluZ3MuaCBiL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGlu Z3MuaAppbmRleCA4MzY5MTU1MDNmYjY2ZGYwYzM4MTc2MzAzOTY1MDMwZDVhMDQ4M2E5Li4wNzBh NWY2ZGViNDFmNGUxMjhjMjVjYTk5ZDI3ZTZkNzFkZWMxNmY4IDEwMDY0NAotLS0gYS9XZWJDb3Jl L2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKKysrIGIvV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWVNYXBwaW5ncy5oCkBAIC0yMjQzLDYgKzIyNDMsNTMgQEAgdGVtcGxhdGU8PiBp bmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9yIEh5cGhlbnMoKSBjb25zdAogICAgIH0K IH0KIAordGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZh bHVlKEVTcGVhayBlKQorICAgIDogbV90eXBlKENTU19JREVOVCkKKyAgICAsIG1faGFzQ2FjaGVk Q1NTVGV4dChmYWxzZSkKK3sKKyAgICBzd2l0Y2ggKGUpIHsKKyAgICBjYXNlIFNwZWFrTm9uZToK KyAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlTm9uZTsKKyAgICAgICAgYnJlYWs7Cisg ICAgY2FzZSBTcGVha05vcm1hbDoKKyAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlTm9y bWFsOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFNwZWFrU3BlbGxPdXQ6CisgICAgICAgIG1f dmFsdWUuaWRlbnQgPSBDU1NWYWx1ZVNwZWxsT3V0OworICAgICAgICBicmVhazsKKyAgICBjYXNl IFNwZWFrRGlnaXRzOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVEaWdpdHM7Cisg ICAgICAgIGJyZWFrOworICAgIGNhc2UgU3BlYWtMaXRlcmFsUHVuY3R1YXRpb246CisgICAgICAg IG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZUxpdGVyYWxQdW5jdHVhdGlvbjsKKyAgICAgICAgYnJl YWs7CisgICAgY2FzZSBTcGVha05vUHVuY3R1YXRpb246CisgICAgICAgIG1fdmFsdWUuaWRlbnQg PSBDU1NWYWx1ZU5vUHVuY3R1YXRpb247CisgICAgICAgIGJyZWFrOworICAgIH0KK30KKyAgICAK K3RlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRvciBFU3BlYWsoKSBj b25zdAoreworICAgIHN3aXRjaCAobV92YWx1ZS5pZGVudCkgeworICAgIGNhc2UgQ1NTVmFsdWVO b25lOgorICAgICAgICByZXR1cm4gU3BlYWtOb25lOworICAgIGNhc2UgQ1NTVmFsdWVOb3JtYWw6 CisgICAgICAgIHJldHVybiBTcGVha05vcm1hbDsKKyAgICBjYXNlIENTU1ZhbHVlU3BlbGxPdXQ6 CisgICAgICAgIHJldHVybiBTcGVha1NwZWxsT3V0OworICAgIGNhc2UgQ1NTVmFsdWVEaWdpdHM6 CisgICAgICAgIHJldHVybiBTcGVha0RpZ2l0czsKKyAgICBjYXNlIENTU1ZhbHVlTGl0ZXJhbFB1 bmN0dWF0aW9uOgorICAgICAgICByZXR1cm4gU3BlYWtMaXRlcmFsUHVuY3R1YXRpb247CisgICAg Y2FzZSBDU1NWYWx1ZU5vUHVuY3R1YXRpb246CisgICAgICAgIHJldHVybiBTcGVha05vUHVuY3R1 YXRpb247CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAg ICAgIHJldHVybiBTcGVha05vcm1hbDsKKyAgICB9Cit9CisKICNpZiBFTkFCTEUoU1ZHKQogCiB0 ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUoTGlu ZUNhcCBlKQpAQCAtMjcyOSw1MyArMjc3Niw2IEBAIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1p dGl2ZVZhbHVlOjpvcGVyYXRvciBFVmVjdG9yRWZmZWN0KCkgY29uc3QKICAgICAgICAgcmV0dXJu IFZFX05PTkU7CiAgICAgfQogfQotCi10ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1 ZTo6Q1NTUHJpbWl0aXZlVmFsdWUoRVNwZWFrIGUpCi0gICAgOiBtX3R5cGUoQ1NTX0lERU5UKQot ICAgICwgbV9oYXNDYWNoZWRDU1NUZXh0KGZhbHNlKQotewotICAgIHN3aXRjaCAoZSkgewotICAg IGNhc2UgU3BlYWtOb25lOgotICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVOb25lOwot ICAgICAgICBicmVhazsKLSAgICBjYXNlIFNwZWFrTm9ybWFsOgotICAgICAgICBtX3ZhbHVlLmlk ZW50ID0gQ1NTVmFsdWVOb3JtYWw7Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2UgU3BlYWtTcGVs bE91dDoKLSAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlU3BlbGxPdXQ7Ci0gICAgICAg IGJyZWFrOwotICAgIGNhc2UgU3BlYWtEaWdpdHM6Ci0gICAgICAgIG1fdmFsdWUuaWRlbnQgPSBD U1NWYWx1ZURpZ2l0czsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBTcGVha0xpdGVyYWxQdW5j dHVhdGlvbjoKLSAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlTGl0ZXJhbFB1bmN0dWF0 aW9uOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIFNwZWFrTm9QdW5jdHVhdGlvbjoKLSAgICAg ICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlTm9QdW5jdHVhdGlvbjsKLSAgICAgICAgYnJlYWs7 Ci0gICAgfQotfQotICAgIAotdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9w ZXJhdG9yIEVTcGVhaygpIGNvbnN0Ci17Ci0gICAgc3dpdGNoIChtX3ZhbHVlLmlkZW50KSB7Ci0g ICAgY2FzZSBDU1NWYWx1ZU5vbmU6Ci0gICAgICAgIHJldHVybiBTcGVha05vbmU7Ci0gICAgY2Fz ZSBDU1NWYWx1ZU5vcm1hbDoKLSAgICAgICAgcmV0dXJuIFNwZWFrTm9ybWFsOwotICAgIGNhc2Ug Q1NTVmFsdWVTcGVsbE91dDoKLSAgICAgICAgcmV0dXJuIFNwZWFrU3BlbGxPdXQ7Ci0gICAgY2Fz ZSBDU1NWYWx1ZURpZ2l0czoKLSAgICAgICAgcmV0dXJuIFNwZWFrRGlnaXRzOwotICAgIGNhc2Ug Q1NTVmFsdWVMaXRlcmFsUHVuY3R1YXRpb246Ci0gICAgICAgIHJldHVybiBTcGVha0xpdGVyYWxQ dW5jdHVhdGlvbjsKLSAgICBjYXNlIENTU1ZhbHVlTm9QdW5jdHVhdGlvbjoKLSAgICAgICAgcmV0 dXJuIFNwZWFrTm9QdW5jdHVhdGlvbjsKLSAgICBkZWZhdWx0OgotICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKLSAgICAgICAgcmV0dXJuIFNwZWFrTm9ybWFsOwotICAgIH0KLX0KICAgICAK ICNlbmRpZgogCg==