46856 2010-09-29 16:49:24 -0700 [Chromium] Tabbing into page doesn't always select the first element 2010-10-02 21:02:44 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 avi webkit-unassigned commit-queue ctguil oldest_to_newest 287216 0 avi 2010-09-29 16:49:24 -0700 Upstream of http://code.google.com/p/chromium/issues/detail?id=57344 : What steps will reproduce the problem? 1. Load http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/focus/typical_page.html 2. Click in the omnibox 3. Press [tab] once Result: search field has focus (correct). 4. Click in the omnibox 5. Press [tab] once Result: the search button has focus (incorrect). Every time you tab into a web view, the first element in that view should gain focus (or the last element, if you reverse-tab in). The bug: in WebViewImpl::setInitialFocus (WebKit/WebKit/chromium/src/WebViewImpl.cpp), just a tab keystroke is fired off. That works the first time when the page is initially loaded since no page object has the focus, but in subsequent calls it just advances the focus (incorrectly). Compare to WebKit/WebKit/win/WebView.cpp's version which explicitly calls setFocusedNode(0) to reset the focus before advancing using the focus controller. Broken on all platforms but the Mac (in which this initial focus code is even _more_ broken; see http://code.google.com/p/chromium/issues/detail?id=49738). 287221 1 69278 avi 2010-09-29 16:57:06 -0700 Created attachment 69278 Patch to fix; modeled after win/WebView.cpp and mac/WebHTMLView.mm 287227 2 69278 kbr 2010-09-29 17:05:35 -0700 Comment on attachment 69278 Patch to fix; modeled after win/WebView.cpp and mac/WebHTMLView.mm This looks OK to me based on comparison to mac/WebView/WebHTMLView.mm and win/WebView.cpp. 287430 3 69278 commit-queue 2010-09-30 01:51:10 -0700 Comment on attachment 69278 Patch to fix; modeled after win/WebView.cpp and mac/WebHTMLView.mm Clearing flags on attachment: 69278 Committed r68765: <http://trac.webkit.org/changeset/68765> 287431 4 commit-queue 2010-09-30 01:51:15 -0700 All reviewed patches have been landed. Closing bug. 69278 2010-09-29 16:57:06 -0700 2010-09-30 01:51:10 -0700 Patch to fix; modeled after win/WebView.cpp and mac/WebHTMLView.mm tab text/plain 1375 avi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjg3MTUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMjkgIEF2aSBE cmlzc21hbiAgPGF2aUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gVGFiYmluZyBpbnRvIHBhZ2UgZG9lc24ndCBh bHdheXMgc2VsZWN0IHRoZSBmaXJzdCBlbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njg1NgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBs LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldEluaXRpYWxGb2N1cyk6CisK IDIwMTAtMDktMjkgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwCShyZXZpc2lvbiA2ODA4MCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgxLDYgKzE0ODEsMTAgQEAgdm9pZCBXZWJWaWV3 SW1wbDo6c2V0SW5pdGlhbEZvY3VzKGJvb2wgcgogICAgIGtleWJvYXJkRXZlbnQud2luZG93c0tl eUNvZGUgPSAweDA5OwogICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudEJ1aWxkZXIgcGxhdGZvcm1F dmVudChrZXlib2FyZEV2ZW50KTsKICAgICBSZWZQdHI8S2V5Ym9hcmRFdmVudD4gd2Via2l0RXZl bnQgPSBLZXlib2FyZEV2ZW50OjpjcmVhdGUocGxhdGZvcm1FdmVudCwgMCk7CisKKyAgICBGcmFt ZSogZnJhbWUgPSBwYWdlKCktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUo KTsKKyAgICBpZiAoRG9jdW1lbnQqIGRvY3VtZW50ID0gZnJhbWUtPmRvY3VtZW50KCkpCisgICAg ICAgIGRvY3VtZW50LT5zZXRGb2N1c2VkTm9kZSgwKTsKICAgICBwYWdlKCktPmZvY3VzQ29udHJv bGxlcigpLT5zZXRJbml0aWFsRm9jdXMoCiAgICAgICAgIHJldmVyc2UgPyBGb2N1c0RpcmVjdGlv bkJhY2t3YXJkIDogRm9jdXNEaXJlY3Rpb25Gb3J3YXJkLAogICAgICAgICB3ZWJraXRFdmVudC5n ZXQoKSk7Cg==