46852 2010-09-29 16:28:34 -0700 Build fix: Add ENABLE(INSPECTOR) guard 2010-09-30 01:22:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned commit-queue oldest_to_newest 287205 0 skyul 2010-09-29 16:28:34 -0700 Page does not have inspectorController() when ENABLE(INSPECTOR) is 0. 287206 1 69274 skyul 2010-09-29 16:29:46 -0700 Created attachment 69274 Patch 287208 2 69274 darin 2010-09-29 16:37:08 -0700 Comment on attachment 69274 Patch Seems this would be better if you wrapped even more of the function in the #if. It’s strange to look up a page to just return 0. 287425 3 69274 commit-queue 2010-09-30 01:22:29 -0700 Comment on attachment 69274 Patch Clearing flags on attachment: 69274 Committed r68763: <http://trac.webkit.org/changeset/68763> 287426 4 commit-queue 2010-09-30 01:22:33 -0700 All reviewed patches have been landed. Closing bug. 69274 2010-09-29 16:29:46 -0700 2010-09-30 01:22:28 -0700 Patch buildfix.patch text/plain 1346 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODcxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMjkgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWlsZCBmaXg6IEFkZCBFTkFCTEUoSU5TUEVDVE9SKSBndWFyZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY4NTIKKworICAgICAgICBQYWdlIGRv ZXMgbm90IGhhdmUgaW5zcGVjdG9yQ29udHJvbGxlcigpIHdoZW4gRU5BQkxFKElOU1BFQ1RPUikg aXMgMC4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmg6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjppbnNwZWN0b3JDb250cm9sbGVyRm9y RG9jdW1lbnQpOgorCiAyMDEwLTA5LTI5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCShyZXZpc2lvbiA2ODcwOSkKKysrIFdlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTA2 LDEyICs1MDYsMTYgQEAgaW5saW5lIEluc3BlY3RvckNvbnRyb2xsZXIqIEluc3BlY3RvckNvbgog ICAgIFBhZ2UqIHBhZ2UgPSBkb2N1bWVudC0+cGFnZSgpOwogICAgIGlmICghcGFnZSkKICAgICAg ICAgcmV0dXJuIDA7CisjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICBJbnNwZWN0b3JDb250cm9s bGVyKiBpbnNwZWN0b3JDb250cm9sbGVyID0gcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpOwog ICAgIGlmICghaW5zcGVjdG9yQ29udHJvbGxlcikKICAgICAgICAgcmV0dXJuIDA7CiAgICAgaWYg KCFpbnNwZWN0b3JDb250cm9sbGVyLT5oYXNGcm9udGVuZCgpKQogICAgICAgICByZXR1cm4gMDsK ICAgICByZXR1cm4gaW5zcGVjdG9yQ29udHJvbGxlcjsKKyNlbHNlCisgICAgcmV0dXJuIDA7Cisj ZW5kaWYKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=