46842 2010-09-29 14:59:52 -0700 Add removeRecursively to WebKit WebFileSystem API 2010-09-30 13:39:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 42903 1 kinuko webkit-unassigned dumi ericu fishd oldest_to_newest 287141 0 kinuko 2010-09-29 14:59:52 -0700 For the recent addition of FileSystem API. An additional flag for existing remove() or a new method is needed. http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-directoryentry-interface http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-DirectoryEntry-removeRecursively interface DirectoryEntry : Entry { void removeRecursively (VoidCallback successCallback, optional ErrorCallback errorCallback); }; 287145 1 69255 kinuko 2010-09-29 15:01:45 -0700 Created attachment 69255 Patch 287239 2 69255 dumi 2010-09-29 17:22:01 -0700 Comment on attachment 69255 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69255&action=review r=me. > WebKit/chromium/public/WebFileSystem.h:69 > + virtual void removeRecursively(const WebString& path, WebFileSystemCallbacks*) { WEBKIT_ASSERT_NOT_REACHED(); } const WebString& path: might have to remove the name of the argument for now, or some compilers might complain that it's not used. 287342 3 kinuko 2010-09-29 20:02:07 -0700 Committed r68741: <http://trac.webkit.org/changeset/68741> 69255 2010-09-29 15:01:45 -0700 2010-09-29 17:22:01 -0700 Patch bug-46842-20100929150144.patch text/plain 2168 kinuko ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDJlMWM2NzM0ODMzMzZmOGY0NDgyOWI4NGQzZmI2OTE2ODVkNDJlYmIu LjFkNGNlOGM3YmIxOWFiZDM3YThlOGU0YTRiZTIwYzBkNTRmMzZjNmYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTI5ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgcmVtb3ZlUmVjdXJzaXZlbHkgdG8gV2ViS2l0IFdlYkZpbGVTeXN0ZW0gQVBJCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njg0MgorCisgICAg ICAgICogcHVibGljL1dlYkZpbGVTeXN0ZW0uaDoKKyAgICAgICAgKFdlYktpdDo6V2ViRmlsZVN5 c3RlbTo6cmVtb3ZlUmVjdXJzaXZlbHkpOiBBZGRlZC4KKwogMjAxMC0wOS0yOSAgTWloYWkgUGFy cGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHJlbW92 YWwgb2YgdW51c2VkICNkZWZpbmUgZnJvbSBXZWJIaXN0b3J5LmguCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkZpbGVTeXN0ZW0uaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViRmlsZVN5c3RlbS5oCmluZGV4IGIyMTIzNWRjYTNiZTVmY2NlYzdlNzc3NjllNTYxNjNj YTIzN2M4ZDkuLjcxOThmMzEzODNlNzE3ZThlMGI5NzY1ZDE1MDQ5MDQ0OThmN2EwM2UgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRmlsZVN5c3RlbS5oCisrKyBiL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRmlsZVN5c3RlbS5oCkBAIC01OCwxMCArNTgsMTYgQEAgcHVi bGljOgogICAgIHZpcnR1YWwgdm9pZCBjb3B5KGNvbnN0IFdlYlN0cmluZyYgc3JjUGF0aCwgY29u c3QgV2ViU3RyaW5nJiBkZXN0UGF0aCwgV2ViRmlsZVN5c3RlbUNhbGxiYWNrcyopIHsgV0VCS0lU X0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAKICAgICAvLyBEZWxldGVzIGEgZmlsZSBvciBkaXJl Y3RvcnkgYXQgYSBnaXZlbiB8cGF0aHwuCisgICAgLy8gSXQgaXMgYW4gZXJyb3IgdG8gdHJ5IHRv IHJlbW92ZSBhIGRpcmVjdG9yeSB0aGF0IGlzIG5vdCBlbXB0eS4KICAgICAvLyBXZWJGaWxlU3lz dGVtQ2FsbGJhY2tzOjpkaWRTdWNjZWVkKCkgbXVzdCBiZSBjYWxsZWQgd2hlbiB0aGUgb3BlcmF0 aW9uIGlzIGNvbXBsZXRlZCBzdWNjZXNzZnVsbHkuCiAgICAgLy8gV2ViRmlsZVN5c3RlbUNhbGxi YWNrczo6ZGlkRmFpbCgpIG11c3QgYmUgY2FsbGVkIG90aGVyd2lzZS4KICAgICB2aXJ0dWFsIHZv aWQgcmVtb3ZlKGNvbnN0IFdlYlN0cmluZyYgcGF0aCwgV2ViRmlsZVN5c3RlbUNhbGxiYWNrcyop IHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAKKyAgICAvLyBEZWxldGVzIGEgZmls ZSBvciBkaXJlY3RvcnkgcmVjdXJzaXZlbHkgYXQgYSBnaXZlbiB8cGF0aHwuCisgICAgLy8gV2Vi RmlsZVN5c3RlbUNhbGxiYWNrczo6ZGlkU3VjY2VlZCgpIG11c3QgYmUgY2FsbGVkIHdoZW4gdGhl IG9wZXJhdGlvbiBpcyBjb21wbGV0ZWQgc3VjY2Vzc2Z1bGx5LgorICAgIC8vIFdlYkZpbGVTeXN0 ZW1DYWxsYmFja3M6OmRpZEZhaWwoKSBtdXN0IGJlIGNhbGxlZCBvdGhlcndpc2UuCisgICAgdmly dHVhbCB2b2lkIHJlbW92ZVJlY3Vyc2l2ZWx5KGNvbnN0IFdlYlN0cmluZyYgcGF0aCwgV2ViRmls ZVN5c3RlbUNhbGxiYWNrcyopIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CisKICAg ICAvLyBSZXRyaWV2ZXMgdGhlIG1ldGFkYXRhIGluZm9ybWF0aW9uIG9mIHRoZSBmaWxlIG9yIGRp cmVjdG9yeSBhdCB0aGUgZ2l2ZW4gfHBhdGh8LgogICAgIC8vIFdlYkZpbGVTeXN0ZW1DYWxsYmFj a3M6OmRpZFJlYWRNZXRhZGF0YSgpIG11c3QgYmUgY2FsbGVkIHdpdGggYSB2YWxpZCBtZXRhZGF0 YSB3aGVuIHRoZSByZXRyaWV2YWwgaXMgY29tcGxldGVkIHN1Y2Nlc3NmdWxseS4KICAgICAvLyBX ZWJGaWxlU3lzdGVtQ2FsbGJhY2tzOjpkaWRGYWlsKCkgbXVzdCBiZSBjYWxsZWQgb3RoZXJ3aXNl Lgo=