46839 2010-09-29 14:16:34 -0700 Autocorrection shouldn't prompt the same correction after user has edited previous correction. 2010-10-01 11:11:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 0 jiapu.mail webkit-unassigned commit-queue jiapu.mail oldest_to_newest 287115 0 jiapu.mail 2010-09-29 14:16:34 -0700 <rdar://problem/8476963> 287165 1 69260 jiapu.mail 2010-09-29 15:26:00 -0700 Created attachment 69260 Proposed patch (v1) Prior to bug 45709. We use "Replacement" marker to indicate the word that has been autocorrected and need to be marked with underline. Whenever user edits an autocorrected word, in order to remove the underline, we remove the "Replacement" marker. However, doing this also prevents us from keeping track of on which word we have already applied autocorrection. So if the user corrects an autocorrection, we would keep prompting the same autocorrection suggestion. In bug 45709, we introduced a new marker "CorrectionIndicator" to indicate whether we should draw underline. So now we can remove underline by removing "CorrectionIndicator" marker. This allows us to keep "Replacement" marker around, so that we won't suggest autocorrection on word that already bears "Replacement" marker. 287192 2 69260 darin 2010-09-29 16:06:40 -0700 Comment on attachment 69260 Proposed patch (v1) Change looks fine. We should come up with a way to do regression tests. It’s not safe to have this code in here but not tested in the WebKit regression test suite. 287194 3 jiapu.mail 2010-09-29 16:12:10 -0700 (In reply to comment #2) > (From update of attachment 69260 [details]) > Change looks fine. We should come up with a way to do regression tests. It’s not safe to have this code in here but not tested in the WebKit regression test suite. Agree. I will look into writing test for autocorrection. One of the trick parts is that autocorrection result depends on user's past usage. In other word, we adapt to user feedback. So unless we always run the tests on a freshly installed system, there's no guarantee to get the expected correction result back. 287432 4 69260 commit-queue 2010-09-30 01:53:41 -0700 Comment on attachment 69260 Proposed patch (v1) Rejecting patch 69260 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: tests successful. Files=14, Tests=304, 1 wallclock secs ( 0.63 cusr + 0.13 csys = 0.76 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/abarth/git/webkit-queue/LayoutTests Testing 21408 test cases. websocket/tests/simple.html -> failed Exiting early after 1 failures. 21390 tests run. 498.10s total testing time 21389 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 33 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4229026 288331 5 69260 darin 2010-10-01 10:28:43 -0700 Comment on attachment 69260 Proposed patch (v1) Trying again because the last failure seemed to be due to a flaky websocket test. 288353 6 69260 commit-queue 2010-10-01 11:11:34 -0700 Comment on attachment 69260 Proposed patch (v1) Clearing flags on attachment: 69260 Committed r68902: <http://trac.webkit.org/changeset/68902> 288354 7 commit-queue 2010-10-01 11:11:40 -0700 All reviewed patches have been landed. Closing bug. 69260 2010-09-29 15:26:00 -0700 2010-10-01 11:11:34 -0700 Proposed patch (v1) webkit-bug46839.patch text/plain 1862 jiapu.mail SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODY4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMjkgIEppYSBQdSAgPGpwdUBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0b2NvcnJlY3Rp b24gc2hvdWxkbid0IHByb21wdCB0aGUgc2FtZSBjb3JyZWN0aW9uIGFmdGVyIHVzZXIgaGFzIGVk aXRlZCBwcmV2aW91cyBjb3JyZWN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDY4MzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0NzY5NjM+ CisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0 b3I6OnJlc3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24pOiBSZW1vdmUgIkNvcnJlY3Rpb25JbmRpY2F0 b3IiIG1hcmtlciBpbnN0ZWFkIG9mCisgICAgICAgICAgIlJlcGxhY2VtZW50IiBtYXJrZXIuIFNp bmNlIHRoZSBmb3JtZXIgY29udHJvbHMgd2hldGhlciB3ZSBkcmF3IGF1dG9jb3JyZWN0aW9uIHVu ZGVybGluZSwKKyAgICAgICAgICBhbmQgdGhlIGxhdHRlciBpcyB1c2VkIHRvIHByZXZlbnQgYXV0 b2NvcnJlY3Rpb24gZnJvbSBiZWluZyBhcHBsaWVkIGFnYWluIG9uIGFscmVhZHkgYXV0by0KKyAg ICAgICAgICBjb3JyZWN0ZWQgd29yZC4gU28gdGhlICJSZXBsYWNlbWVudCIgc2hvdWxkbid0IGJl IHJlbW92ZWQuCisKIDIwMTAtMDktMjkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViQ29yZS9lZGl0aW5n L0VkaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHJl dmlzaW9uIDY4Njg2KQorKysgV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM2MDAsNyArMzYwMCw3IEBAIHZvaWQgRWRpdG9yOjpyZXNwb25kVG9DaGFuZ2VkU2Vs ZWN0aW9uKGMKICAgICAgICAgLy8gUGVyaGFwcyBwZWN1bGlhciwgYnV0IGl0IG1hdGNoZXMgQXBw S2l0LgogICAgICAgICBpZiAoUmVmUHRyPFJhbmdlPiB3b3JkUmFuZ2UgPSBuZXdBZGphY2VudFdv cmRzLnRvTm9ybWFsaXplZFJhbmdlKCkpIHsKICAgICAgICAgICAgIG1fZnJhbWUtPmRvY3VtZW50 KCktPm1hcmtlcnMoKS0+cmVtb3ZlTWFya2Vycyh3b3JkUmFuZ2UuZ2V0KCksIERvY3VtZW50TWFy a2VyOjpTcGVsbGluZyk7Ci0gICAgICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5tYXJrZXJz KCktPnJlbW92ZU1hcmtlcnMod29yZFJhbmdlLmdldCgpLCBEb2N1bWVudE1hcmtlcjo6UmVwbGFj ZW1lbnQpOworICAgICAgICAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+bWFya2VycygpLT5yZW1v dmVNYXJrZXJzKHdvcmRSYW5nZS5nZXQoKSwgRG9jdW1lbnRNYXJrZXI6OkNvcnJlY3Rpb25JbmRp Y2F0b3IpOwogICAgICAgICB9CiAgICAgICAgIGlmIChSZWZQdHI8UmFuZ2U+IHNlbnRlbmNlUmFu Z2UgPSBuZXdTZWxlY3RlZFNlbnRlbmNlLnRvTm9ybWFsaXplZFJhbmdlKCkpCiAgICAgICAgICAg ICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5tYXJrZXJzKCktPnJlbW92ZU1hcmtlcnMoc2VudGVuY2VS YW5nZS5nZXQoKSwgRG9jdW1lbnRNYXJrZXI6OkdyYW1tYXIpOwo=