46829 2010-09-29 11:37:34 -0700 [chromium] enable -Werror for DRT and webkit_unit_tests on Linux 2010-09-29 15:53:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony jamesr oldest_to_newest 287026 0 tony 2010-09-29 11:37:34 -0700 [chromium] enable -Werror for DRT and webkit_unit_tests on Linux 287027 1 69236 tony 2010-09-29 11:38:28 -0700 Created attachment 69236 Patch 287028 2 tony 2010-09-29 11:38:52 -0700 Only tested on Lucid (-O0 and -02). 287103 3 69236 jamesr 2010-09-29 13:52:39 -0700 Comment on attachment 69236 Patch Code changes look good, but please compile test on a hardy box before landing. I had to revert the WebCore flip because of a bunch of hardy gcc errors that make no sense. 287180 4 tony 2010-09-29 15:53:41 -0700 Committed r68700: <http://trac.webkit.org/changeset/68700> 69236 2010-09-29 11:38:28 -0700 2010-09-29 13:52:48 -0700 Patch bug-46829-20100929113835.patch text/plain 7083 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGEyODUxN2FmYjA1MWNhNWY4MGQ3OTk3MWRhMzcyMzVhZjY1NjI3YjEu LjY4MTQwYTUxOGJhMTg3N2VjOTBiOGY4YmQ4MzdhNTJjOTc3MTc4ZTYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTI5ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBlbmFibGUgLVdlcnJvciBmb3IgRFJUIGFuZCB3ZWJraXRfdW5pdF90ZXN0cyBvbiBM aW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY4 MjkKKworICAgICAgICAqIFdlYktpdC5neXA6CisgICAgICAgICogdGVzdHMvQXJlbmFUZXN0SGVs cGVycy5oOgorICAgICAgICAoV2ViQ29yZTo6QXJlbmFUZXN0SGVscGVyczo6VHJhY2tlZEFsbG9j YXRvcjo6ZnJlZSk6CisgICAgICAgICogdGVzdHMvSURCS2V5UGF0aFRlc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Y2hlY2tLZXlQYXRoKToKKwogMjAxMC0wOS0yOCAgVmFuZ2VsaXMgS29ra2V2 aXMgIDx2YW5nZWxpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0 aCBSdXNzZWxsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9XZWJL aXQvY2hyb21pdW0vV2ViS2l0Lmd5cAppbmRleCA1Yjk1M2UzZWIyNTE1OTNiODNhMDdhNjAwMThj YzlkYjAzZDgxZGYwLi5hYTVjNzJiOWNmY2UwYjRkMDg1MjgxMzMwZmM3ZGMzNGYyYWI0ODNhIDEw MDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9XZWJLaXQvY2hyb21p dW0vV2ViS2l0Lmd5cApAQCAtNzc1LDYgKzc3NSwxMCBAQAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICdwdWJsaWMvZ3RrJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBdLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICd2YXJpYWJsZXMnOiB7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAjIEZJWE1FOiBFbmFibGUgd2FybmluZ3Mgb24gb3RoZXIgcGxhdGZvcm1zLgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtX2NvZGUnOiAxLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgICAgICB9XSwKICAgICAg ICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAgICAgICB9XSwKQEAgLTkyNCw2ICs5MjgsMTAg QEAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPChJTlRFUk1FRElBVEVfRElSKS9yZXBh Y2svRHVtcFJlbmRlclRyZWUucGFrJywKICAgICAgICAgICAgICAgICAgICAgICAgIF0KICAgICAg ICAgICAgICAgICAgICAgfV0sCisgICAgICAgICAgICAgICAgICAgICd2YXJpYWJsZXMnOiB7Cisg ICAgICAgICAgICAgICAgICAgICAgIyBGSVhNRTogRW5hYmxlIHdhcm5pbmdzIG9uIG90aGVyIHBs YXRmb3Jtcy4KKyAgICAgICAgICAgICAgICAgICAgICAnY2hyb21pdW1fY29kZSc6IDEsCisgICAg ICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgfSx7ICMgT1MhPSJsaW51eCIgYW5k IE9TIT0iZnJlZWJzZCIgYW5kIE9TIT0ib3BlbmJzZCIgYW5kIE9TIT0ic29sYXJpcyIKICAgICAg ICAgICAgICAgICAgICAgJ3NvdXJjZXMvJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgWydl eGNsdWRlJywgJyhHdGt8TGludXgpXFwuY3BwJCddCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvQXJlbmFUZXN0SGVscGVycy5oIGIvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0FyZW5h VGVzdEhlbHBlcnMuaAppbmRleCA4N2Y4MjdkZGVkNWFkMWEzYjg0MDcwMjI4YjBjNjM0YjhiODc4 OTQxLi43MDkzNmU1YjYzNWY1ZjdhY2VkZjc3MWJkMjYzZmQzNmNlNzYzYTRhIDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQXJlbmFUZXN0SGVscGVycy5oCisrKyBiL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9BcmVuYVRlc3RIZWxwZXJzLmgKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2lu Y2x1ZGUgIlBPREFyZW5hLmgiCiAjaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KKyNpbmNsdWRlIDx3 dGYvTm90Rm91bmQuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKQEAgLTUyLDcgKzUzLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBmcmVlKHZv aWQqIHB0cikKICAgICB7CiAgICAgICAgIHNpemVfdCBzbG90ID0gbV9hbGxvY2F0ZWRSZWdpb25z LmZpbmQocHRyKTsKLSAgICAgICAgQVNTRVJUX0dFKHNsb3QsIDApOworICAgICAgICBBU1NFUlRf TkUoc2xvdCwgbm90Rm91bmQpOwogICAgICAgICBtX2FsbG9jYXRlZFJlZ2lvbnMucmVtb3ZlKHNs b3QpOwogICAgICAgICBQT0RBcmVuYTo6RmFzdE1hbGxvY0FsbG9jYXRvcjo6ZnJlZShwdHIpOwog ICAgIH0KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJLZXlQYXRoVGVzdC5j cHAgYi9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCS2V5UGF0aFRlc3QuY3BwCmluZGV4IGFjMTBm NGY5NzIwY2M4OTIwMmUxNGQ0NjRjZDU0ZTIyYzdiNzMxMGUuLjZjMzc4ZDY5NzFjYTg5YWFhYWM2 YmY1ZWJiYjQwOTBjMmFjMWRkZGEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9J REJLZXlQYXRoVGVzdC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQktleVBhdGhU ZXN0LmNwcApAQCAtNTgsNyArNTgsNyBAQCB2b2lkIGNoZWNrS2V5UGF0aChjb25zdCBTdHJpbmcm IGtleVBhdGgsIGNvbnN0IFZlY3RvcjxJREJLZXlQYXRoRWxlbWVudD4mIGV4cGVjdAogICAgIGlm IChlcnJvciAhPSBJREJLZXlQYXRoUGFyc2VFcnJvck5vbmUpCiAgICAgICAgIHJldHVybjsKICAg ICBBU1NFUlRfRVEoZXhwZWN0ZWQuc2l6ZSgpLCBpZGJLZXlQYXRoRWxlbWVudHMuc2l6ZSgpKTsK LSAgICBmb3IgKGludCBpID0gMDsgaSA8IGV4cGVjdGVkLnNpemUoKTsgKytpKSB7CisgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBleHBlY3RlZC5zaXplKCk7ICsraSkgewogICAgICAgICBBU1NF UlRfVFJVRShleHBlY3RlZFtpXS50eXBlID09IGlkYktleVBhdGhFbGVtZW50c1tpXS50eXBlKSA8 PCBpOwogICAgICAgICBpZiAoZXhwZWN0ZWRbaV0udHlwZSA9PSBJREJLZXlQYXRoRWxlbWVudDo6 SXNJbmRleGVkKQogICAgICAgICAgICAgQVNTRVJUX0VRKGV4cGVjdGVkW2ldLmluZGV4LCBpZGJL ZXlQYXRoRWxlbWVudHNbaV0uaW5kZXgpIDw8IGk7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9D aGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggYjJhMzc5MTY5MGFlOWQ0NGEw NmExNjBiZjA3ZmYzOGI3NTc5YjA5Ni4uYjc5Y2RmODM5NTI3OTk2NzU4NzUxNmJjMGZiYTMxZWUz YmFkNjM2NyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA5LTI5ICBUb255IENoYW5nICA8 dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW2Nocm9taXVtXSBlbmFibGUgLVdlcnJvciBmb3IgRFJUIGFuZCB3ZWJraXRf dW5pdF90ZXN0cyBvbiBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDY4MjkKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0RS VERldlRvb2xzQ2xpZW50LmNwcDoKKyAgICAgICAgKERSVERldlRvb2xzQ2xpZW50OjpEUlREZXZU b29sc0NsaWVudCk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxs LmNwcDoKKyAgICAgICAgKFRlc3RTaGVsbDo6VGVzdFNoZWxsKToKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6 cG9zdEFjY2Vzc2liaWxpdHlOb3RpZmljYXRpb24pOgorICAgICAgICAoV2ViVmlld0hvc3Q6Oldl YlZpZXdIb3N0KToKKwogMjAxMC0wOS0yOCAgSm9obm55IERpbmcgIDxqbmRAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EUlREZXZUb29sc0NsaWVudC5jcHAgYi9XZWJL aXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EUlREZXZUb29sc0NsaWVudC5jcHAKaW5k ZXggYTUzZjBkYjRlODE0NzI1YWVjZTlmNGU4MDIyMGYzY2M0ZTEyYTA3MS4uMTlkNjc0M2Q3NjVm NmRlMzA1YjQ4OGQ1MzViODFkY2Y2YWMyZGQ4OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vRFJURGV2VG9vbHNDbGllbnQuY3BwCisrKyBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0RSVERldlRvb2xzQ2xpZW50LmNwcApAQCAtNDUs OCArNDUsOCBAQAogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAogRFJURGV2VG9vbHNDbGllbnQ6 OkRSVERldlRvb2xzQ2xpZW50KERSVERldlRvb2xzQWdlbnQqIGFnZW50LCBXZWJWaWV3KiB3ZWJW aWV3KQotICAgIDogbV9kcnREZXZUb29sc0FnZW50KGFnZW50KQotICAgICwgbV93ZWJWaWV3KHdl YlZpZXcpCisgICAgOiBtX3dlYlZpZXcod2ViVmlldykKKyAgICAsIG1fZHJ0RGV2VG9vbHNBZ2Vu dChhZ2VudCkKIHsKICAgICBtX3dlYkRldlRvb2xzRnJvbnRlbmQuc2V0KFdlYkRldlRvb2xzRnJv bnRlbmQ6OmNyZWF0ZShtX3dlYlZpZXcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdGhpcywKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAgYi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCmluZGV4IDFhOTliN2QyMmFiN2RmYThi ZDQ4ZGQ3Mjk5ZGUwZDE4ZmMwZGYwNWEuLjhjN2Y5ZGZhNDU2ZTIxODkzZDljMGQzOGE5ODlkMmQw YTY0OGIzODggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1Rlc3RTaGVsbC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v VGVzdFNoZWxsLmNwcApAQCAtODIsOSArODIsOSBAQCBUZXN0U2hlbGw6OlRlc3RTaGVsbChib29s IHRlc3RTaGVsbE1vZGUpCiAgICAgLCBtX3Rlc3RJc1ByZXBhcmluZyhmYWxzZSkKICAgICAsIG1f Zm9jdXNlZFdpZGdldCgwKQogICAgICwgbV90ZXN0U2hlbGxNb2RlKHRlc3RTaGVsbE1vZGUpCisg ICAgLCBtX2RldlRvb2xzKDApCiAgICAgLCBtX2FsbG93RXh0ZXJuYWxQYWdlcyhmYWxzZSkKICAg ICAsIG1fYWNjZWxlcmF0ZWQyZENhbnZhc0VuYWJsZWQoZmFsc2UpCi0gICAgLCBtX2RldlRvb2xz KDApCiB7CiAgICAgV2ViUnVudGltZUZlYXR1cmVzOjplbmFibGVHZW9sb2NhdGlvbih0cnVlKTsK ICAgICBXZWJSdW50aW1lRmVhdHVyZXM6OmVuYWJsZUluZGV4ZWREYXRhYmFzZSh0cnVlKTsKZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNw cAppbmRleCA5YTA4NmU0MTM4NzkxODkyNjc2N2FlNjE1ZTk0NDYyNDJjNjM1NGVjLi5iN2ZkYWI5 ODQ3ZDdmNzU3ZDJkODFkOTBlY2FiYzliOWZkNjliYjQwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCkBAIC01NDEsNiArNTQx LDggQEAgdm9pZCBXZWJWaWV3SG9zdDo6cG9zdEFjY2Vzc2liaWxpdHlOb3RpZmljYXRpb24oY29u c3QgV2ViQWNjZXNzaWJpbGl0eU9iamVjdCYgb2IKICAgICAgICAgY2FzZSBXZWJBY2Nlc3NpYmls aXR5Tm90aWZpY2F0aW9uUm93RXhwYW5kZWQ6CiAgICAgICAgICAgICBwcmludGYoIlJvd0V4cGFu ZGVkIik7CiAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAg IGJyZWFrOwogICAgICAgICB9CiAKICAgICAgICAgV2ViS2l0OjpXZWJOb2RlIG5vZGUgPSBvYmou bm9kZSgpOwpAQCAtMTA0MSwxMCArMTA0MywxMSBAQCBXZWJWaWV3SG9zdDo6V2ViVmlld0hvc3Qo VGVzdFNoZWxsKiBzaGVsbCkKICAgICAsIG1fcG9saWN5RGVsZWdhdGVJc1Blcm1pc3NpdmUoZmFs c2UpCiAgICAgLCBtX3BvbGljeURlbGVnYXRlU2hvdWxkTm90aWZ5RG9uZShmYWxzZSkKICAgICAs IG1fc2hlbGwoc2hlbGwpCisgICAgLCBtX3dlYldpZGdldCgwKQogICAgICwgbV90b3BMb2FkaW5n RnJhbWUoMCkKLSAgICAsIG1faGFzV2luZG93KGZhbHNlKQogICAgICwgbV9wYWdlSWQoLTEpCiAg ICAgLCBtX2xhc3RQYWdlSWRVcGRhdGVkKC0xKQorICAgICwgbV9oYXNXaW5kb3coZmFsc2UpCiAg ICAgLCBtX3NtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZCh0cnVlKQogI2lmIE9TKFdJTkRPV1MpCiAg ICAgLCBtX3NlbGVjdFRyYWlsaW5nV2hpdGVzcGFjZUVuYWJsZWQodHJ1ZSkKQEAgLTEwNTQsNyAr MTA1Nyw2IEBAIFdlYlZpZXdIb3N0OjpXZWJWaWV3SG9zdChUZXN0U2hlbGwqIHNoZWxsKQogICAg ICwgbV9ibG9ja3NSZWRpcmVjdHMoZmFsc2UpCiAgICAgLCBtX3JlcXVlc3RSZXR1cm5OdWxsKGZh bHNlKQogICAgICwgbV9pc1BhaW50aW5nKGZhbHNlKQotICAgICwgbV93ZWJXaWRnZXQoMCkKIHsK ICAgICBtX25hdmlnYXRpb25Db250cm9sbGVyLnNldChuZXcgVGVzdE5hdmlnYXRpb25Db250cm9s bGVyKHRoaXMpKTsKIH0K