46821 2010-09-29 10:39:13 -0700 [chromium] enable -Werror on chromium linux webkit 2010-09-29 15:06:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony jamesr webkit.review.bot oldest_to_newest 286965 0 tony 2010-09-29 10:39:13 -0700 [chromium] enable -Werror on chromium linux webkit 286966 1 69213 tony 2010-09-29 10:39:52 -0700 Created attachment 69213 Patch 286969 2 tony 2010-09-29 10:41:10 -0700 This is going to fail the style checker, but we have to use NULL instead of 0 otherwise gcc complains about "missing sentinel in function call". Tested on hardy -O0, -O1, -O2 and lucid -O0, -O2. 286970 3 webkit.review.bot 2010-09-29 10:41:31 -0700 Attachment 69213 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/gtk/WebInputEventFactory.cpp:55: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 287105 4 69213 jamesr 2010-09-29 13:53:32 -0700 Comment on attachment 69213 Patch Code changes look good. Please compile test on hardy before landing. 287106 5 jamesr 2010-09-29 13:55:22 -0700 Ah, I see you did. Bombs away! 287151 6 tony 2010-09-29 15:06:32 -0700 Committed r68691: <http://trac.webkit.org/changeset/68691> 69213 2010-09-29 10:39:52 -0700 2010-09-29 13:53:31 -0700 Patch bug-46821-20100929103958.patch text/plain 2557 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGEyODUxN2FmYjA1MWNhNWY4MGQ3OTk3MWRhMzcyMzVhZjY1NjI3YjEu LjhkMWQ2ZGY1ZTYwOTQ4NGY1YjBlN2Y4NzcyNGNmZWYyN2NhNWIxZTkgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTI5ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBlbmFibGUgLVdlcnJvciBvbiBjaHJvbWl1bSBsaW51eCB3ZWJraXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2ODIxCisKKyAgICAgICAg KiBXZWJLaXQuZ3lwOgorICAgICAgICAqIHNyYy9ndGsvV2ViSW5wdXRFdmVudEZhY3RvcnkuY3Bw OgorCiAyMDEwLTA5LTI4ICBWYW5nZWxpcyBLb2trZXZpcyAgPHZhbmdlbGlzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCmRpZmYgLS1naXQgYS9X ZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cCBiL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCmlu ZGV4IDViOTUzZTNlYjI1MTU5M2I4M2EwN2E2MDAxOGNjOWRiMDNkODFkZjAuLmNlNGIwOTRjYjgz YmJhODc3MjA2NzJmMjNmMTk4N2FkZTNlM2UzZjkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9XZWJLaXQuZ3lwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBAIC02MDIsMTEg KzYwMiw2IEBACiAgICAgICAgICAgICAgICAgICAgICdzb3VyY2VzLyc6IFsKICAgICAgICAgICAg ICAgICAgICAgICAgIFsnZXhjbHVkZScsICdTa2lhXFwuY3BwJCddLAogICAgICAgICAgICAgICAg ICAgICBdLAotICAgICAgICAgICAgICAgICAgICAndmFyaWFibGVzJzogewotICAgICAgICAgICAg ICAgICAgICAgICAgIyBGSVhNRTogVHVybiBvbiB3YXJuaW5ncyBvbiBvdGhlciBwbGF0Zm9ybXMg YW5kIGZvcgotICAgICAgICAgICAgICAgICAgICAgICAgIyBvdGhlciB0YXJnZXRzLgotICAgICAg ICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtX2NvZGUnOiAxLAotICAgICAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICAgICAgfSwgeyAjIGVsc2U6IE9TIT0ibWFjIgogICAgICAgICAgICAg ICAgICAgICAnc291cmNlcy8nOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICBbJ2V4Y2x1ZGUn LCAnL21hYy8nXSwKQEAgLTYxOSw2ICs2MTQsMTAgQEAKICAgICAgICAgICAgICAgICAgICAgXSwK ICAgICAgICAgICAgICAgICB9LCB7ICMgZWxzZTogT1MhPSJ3aW4iCiAgICAgICAgICAgICAgICAg ICAgICdzb3VyY2VzLyc6IFtbJ2V4Y2x1ZGUnLCAnL3dpbi8nXV0sCisgICAgICAgICAgICAgICAg ICAgICd2YXJpYWJsZXMnOiB7CisgICAgICAgICAgICAgICAgICAgICAgICAjIEZJWE1FOiBUdXJu IG9uIHdhcm5pbmdzIG9uIFdpbmRvd3MuCisgICAgICAgICAgICAgICAgICAgICAgICAnY2hyb21p dW1fY29kZSc6IDEsCisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9XSwK ICAgICAgICAgICAgICAgICBbJyJFTkFCTEVfM0RfQ0FOVkFTPTEiIGluIGZlYXR1cmVfZGVmaW5l cycsIHsKICAgICAgICAgICAgICAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCmRpZmYgLS1naXQgYS9X ZWJLaXQvY2hyb21pdW0vc3JjL2d0ay9XZWJJbnB1dEV2ZW50RmFjdG9yeS5jcHAgYi9XZWJLaXQv Y2hyb21pdW0vc3JjL2d0ay9XZWJJbnB1dEV2ZW50RmFjdG9yeS5jcHAKaW5kZXggMGQ1NWM0MzU0 OWEwZDlmMGYxNDNkNDAyYmM2OGVmYTcxYjY5NzAzOS4uNzFkMWIzOTgzOTNhYmU0ODg4ZWRjNTQz YjI4N2JiMzE2NjAxZTE2ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9ndGsvV2Vi SW5wdXRFdmVudEZhY3RvcnkuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvZ3RrL1dlYklu cHV0RXZlbnRGYWN0b3J5LmNwcApAQCAtNTIsNyArNTIsNyBAQCBib29sIGNvdW50c0FzRG91Ymxl Q2xpY2soZ2ludCB0aW1lRGlmZiwgZ2ludCB4RGlmZiwgZ2ludCB5RGlmZikKICAgICBnaW50IGRv dWJsZUNsaWNrRGlzdGFuY2UgPSA1OwogICAgIGdfb2JqZWN0X2dldChHX09CSkVDVChzZXR0aW5n cyksCiAgICAgICAgICAgICAgICAgICJndGstZG91YmxlLWNsaWNrLXRpbWUiLCAmZG91YmxlQ2xp Y2tUaW1lLAotICAgICAgICAgICAgICAgICAiZ3RrLWRvdWJsZS1jbGljay1kaXN0YW5jZSIsICZk b3VibGVDbGlja0Rpc3RhbmNlLCAwKTsKKyAgICAgICAgICAgICAgICAgImd0ay1kb3VibGUtY2xp Y2stZGlzdGFuY2UiLCAmZG91YmxlQ2xpY2tEaXN0YW5jZSwgTlVMTCk7CiAgICAgcmV0dXJuIHRp bWVEaWZmIDw9IGRvdWJsZUNsaWNrVGltZSAmJiBhYnMoeERpZmYpIDw9IGRvdWJsZUNsaWNrRGlz dGFuY2UgJiYgYWJzKHlEaWZmKSA8PSBkb3VibGVDbGlja0Rpc3RhbmNlOwogfQogCg==