46814 2010-09-29 09:23:34 -0700 [Qt] Fix tst_QWebPage::geolocationRequestJS() 2011-01-11 02:08:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 46810 1 benjamin webkit-unassigned abarth benjamin commit-queue eric kling laszlo.gombos maheshk webkit.review.bot oldest_to_newest 286908 0 benjamin 2010-09-29 09:23:34 -0700 The test tst_QWebPage::geolocationRequestJS() always fail with a default build because ENABLE(GEOLOCATION) is false. When the API is fixed, the test should be fixed accordingly to succeed for standard build. 286934 1 69206 benjamin 2010-09-29 09:57:58 -0700 Created attachment 69206 Disable the test 286942 2 69206 kling 2010-09-29 10:09:01 -0700 Comment on attachment 69206 Disable the test View in context: https://bugs.webkit.org/attachment.cgi?id=69206&action=review > WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:256 > +#if 0 Please don't disable this code. We want whoever alters the permissions API to update the test as well. 286971 3 maheshk 2010-09-29 10:41:37 -0700 one way to know if geolocation is enabled is by checking return value of frame->evaluateJavascript("navigator.geolocation == undefined"). Based on this we can ignore all assert checks. 286973 4 maheshk 2010-09-29 10:43:45 -0700 (In reply to comment #0) > > When the API is fixed, the test should be fixed accordingly to succeed for standard build. @Benjamin I did not get what you mean here? What has to be fixed in API? 286982 5 69219 benjamin 2010-09-29 10:51:03 -0700 Created attachment 69219 Patch 286985 6 69220 benjamin 2010-09-29 10:52:10 -0700 Created attachment 69220 Ooops 286986 7 benjamin 2010-09-29 10:53:35 -0700 (In reply to comment #4) > > When the API is fixed, the test should be fixed accordingly to succeed for standard build. > > @Benjamin I did not get what you mean here? What has to be fixed in API? The API did not go through any API review, see: https://bugs.webkit.org/show_bug.cgi?id=46810 The API does not seem future proof at the moment. When the API will be better, this test should be re-enabled. 287037 8 69220 commit-queue 2010-09-29 11:57:03 -0700 Comment on attachment 69220 Ooops Rejecting patch 69220 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: s successful. Files=14, Tests=304, 1 wallclock secs ( 0.72 cusr + 0.16 csys = 0.88 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21476 test cases. plugins/plugin-initiate-popup-window.html -> failed Exiting early after 1 failures. 17959 tests run. 321.64s total testing time 17958 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 31 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4153011 287042 9 69220 benjamin 2010-09-29 12:01:41 -0700 Comment on attachment 69220 Ooops Trying cq+ again. This is just a QSKIP, it has not influence on other tests. 287401 10 69220 commit-queue 2010-09-30 00:10:15 -0700 Comment on attachment 69220 Ooops Clearing flags on attachment: 69220 Committed r68760: <http://trac.webkit.org/changeset/68760> 287402 11 commit-queue 2010-09-30 00:10:21 -0700 All reviewed patches have been landed. Closing bug. 287414 12 benjamin 2010-09-30 00:45:41 -0700 Reopening since this bug is really about fixing the test. The patch disabling is temporary. 323034 13 76732 laszlo.gombos 2010-12-15 20:14:48 -0800 Created attachment 76732 re-enable the test API review is finished; GEOLOCATION is enabled in the master bot. Test will fail if GEOLOCATION is not enabled - I think this is the correct expected behavior from the test. 323051 14 76732 commit-queue 2010-12-15 22:14:34 -0800 Comment on attachment 76732 re-enable the test Clearing flags on attachment: 76732 Committed r74173: <http://trac.webkit.org/changeset/74173> 323052 15 commit-queue 2010-12-15 22:14:41 -0800 All reviewed patches have been landed. Closing bug. 323464 16 webkit.review.bot 2010-12-16 15:38:04 -0800 http://trac.webkit.org/changeset/74173 might have broken Leopard Intel Debug (Tests) 331968 17 benjamin 2011-01-10 14:56:31 -0800 This test is failing. Did you take into account my comments? "This test is disabled because it can only succeed if ENABLE(GEOLOCATION) is true." 331997 18 laszlo.gombos 2011-01-10 15:36:21 -0800 (In reply to comment #17) > This test is failing. Did you take into account my comments? Failing where ? Seems to be passing on the bot - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/26268/steps/API%20tests/logs/stdio 332004 19 benjamin 2011-01-10 15:42:12 -0800 (In reply to comment #18) > (In reply to comment #17) > > This test is failing. Did you take into account my comments? > > Failing where ? Seems to be passing on the bot - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/26268/steps/API%20tests/logs/stdio On my computer at least. :) But my guess is it fails on any build done without mobility. 332027 20 78466 benjamin 2011-01-10 16:05:47 -0800 Created attachment 78466 Patch 332029 21 78467 benjamin 2011-01-10 16:10:21 -0800 Created attachment 78467 Patch 332196 22 78467 commit-queue 2011-01-11 02:08:23 -0800 Comment on attachment 78467 Patch Clearing flags on attachment: 78467 Committed r75479: <http://trac.webkit.org/changeset/75479> 332197 23 commit-queue 2011-01-11 02:08:31 -0800 All reviewed patches have been landed. Closing bug. 69206 2010-09-29 09:57:58 -0700 2011-01-10 16:05:28 -0800 Disable the test 46814.diff text/plain 1887 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDFiZDc1ZTIuLmE4NWU0NWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTI5ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdHN0X1FXZWJQYWdl OjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NjgxNAorCisgICAgICAgIERpc2FibGUgdGhlIHRlc3QuIFRoaXMg dGVzdCBjYW5ub3QgcGFzcyB3aXRoIGEKKyAgICAgICAgc3RhbmRhcmQgYnVpbGQgb2YgV2ViS2l0 LCBpdCBpcyBkaXNhYmxlZCB1bnRpbCB0aGUgQVBJIGlzIGZpbmlsaXplZC4KKworICAgICAgICAq IHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6 Omdlb2xvY2F0aW9uUmVxdWVzdEpTKToKKwogMjAxMC0wOS0yOCAgQW5kcmVhcyBLbGluZyAgPGFu ZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9o ZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNw cAppbmRleCAzNmZhMDUwLi5jYzA1M2Y0IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdl YnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcApAQCAtMjQ3LDYgKzI0NywxMyBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6aW5m aW5pdGVMb29wSlMoKQogCiB2b2lkIHRzdF9RV2ViUGFnZTo6Z2VvbG9jYXRpb25SZXF1ZXN0SlMo KQogeworICAgIFFTS0lQKCJUZXN0IGRpc2FibGVkIGFzIGxvbmcgYXMgZ2VvbG9jYXRpb24gaXMg ZGlzYWJsZWQgZnJvbSB0aGUgYnVpbGQuIiwgU2tpcFNpbmdsZSk7CisKKyAgICAvKgorICAgICAg VGhpcyB0ZXN0IGlzIGRpc2FibGVkIGJlY2F1c2UgaXQgY2FuIG9ubHkgc3VjY2VlZCBpZiBFTkFC TEUoR0VPTE9DQVRJT04pIGlzIHRydWUuCisgICAgICBUaGUgY29kZSBuZWVkcyB0byBiZSB1cGRh dGVkIHdoZW4gdGhlIEFQSSBvZiByZXF1ZXN0UGVybWlzc2lvbkZyb21Vc2VyIGlzIHVwZGF0ZWQu CisgICAgKi8KKyNpZiAwCiAgICAgSlNUZXN0UGFnZSogbmV3UGFnZSA9IG5ldyBKU1Rlc3RQYWdl KG1fdmlldyk7CiAgICAgY29ubmVjdChuZXdQYWdlLCBTSUdOQUwocmVxdWVzdFBlcm1pc3Npb25G cm9tVXNlcihRV2ViRnJhbWUqLCBRV2ViUGFnZTo6UGVybWlzc2lvbkRvbWFpbikpLCAKICAgICAg ICAgICAgIG5ld1BhZ2UsIFNMT1QocmVxdWVzdFBlcm1pc3Npb24oUVdlYkZyYW1lKiwgUVdlYlBh Z2U6OlBlcm1pc3Npb25Eb21haW4pKSk7CkBAIC0yNjgsOCArMjc1LDEwIEBAIHZvaWQgdHN0X1FX ZWJQYWdlOjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCiAgICAgLy9Qb3NpdGlvbkVycm9yOiBjb25z dCB1bnNpZ25lZCBzaG9ydCBQRVJNSVNTSU9OX0RFTklFRCA9IDE7CiAgICAgUVZFUklGWShlbXB0 eS50eXBlKCkgPT0gUVZhcmlhbnQ6OkRvdWJsZSAmJiBlbXB0eS50b0ludCgpICE9IDEpOwogICAg IGRlbGV0ZSBuZXdQYWdlOworI2VuZGlmCiB9CiAKKwogdm9pZCB0c3RfUVdlYlBhZ2U6OmxvYWRG aW5pc2hlZCgpCiB7CiAgICAgcVJlZ2lzdGVyTWV0YVR5cGU8UVdlYkZyYW1lKj4oIlFXZWJGcmFt ZSoiKTsK 69219 2010-09-29 10:51:03 -0700 2010-09-29 10:52:10 -0700 Patch 46814.patch text/plain 347 benjamin IyBPbiBicmFuY2ggbWFzdGVyCiMgQ2hhbmdlZCBidXQgbm90IHVwZGF0ZWQ6CiMgICAodXNlICJn aXQgYWRkIDxmaWxlPi4uLiIgdG8gdXBkYXRlIHdoYXQgd2lsbCBiZSBjb21taXR0ZWQpCiMgICAo dXNlICJnaXQgY2hlY2tvdXQgLS0gPGZpbGU+Li4uIiB0byBkaXNjYXJkIGNoYW5nZXMgaW4gd29y a2luZyBkaXJlY3RvcnkpCiMKIwltb2RpZmllZDogICBXZWJLaXQvcXQvQ2hhbmdlTG9nCiMJbW9k aWZpZWQ6ICAgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKIwpubyBj aGFuZ2VzIGFkZGVkIHRvIGNvbW1pdCAodXNlICJnaXQgYWRkIiBhbmQvb3IgImdpdCBjb21taXQg LWEiKQo= 69220 2010-09-29 10:52:10 -0700 2011-01-10 16:05:35 -0800 Ooops 46814.patch text/plain 1557 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDFiZDc1ZTIuLmE4NWU0NWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA5LTI5ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdHN0X1FXZWJQYWdl OjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NjgxNAorCisgICAgICAgIERpc2FibGUgdGhlIHRlc3QuIFRoaXMg dGVzdCBjYW5ub3QgcGFzcyB3aXRoIGEKKyAgICAgICAgc3RhbmRhcmQgYnVpbGQgb2YgV2ViS2l0 LCBpdCBpcyBkaXNhYmxlZCB1bnRpbCB0aGUgQVBJIGlzIGZpbmlsaXplZC4KKworICAgICAgICAq IHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6 Omdlb2xvY2F0aW9uUmVxdWVzdEpTKToKKwogMjAxMC0wOS0yOCAgQW5kcmVhcyBLbGluZyAgPGFu ZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9o ZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNw cAppbmRleCAzNmZhMDUwLi4zZGRiZjRlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdl YnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcApAQCAtMjQ3LDYgKzI0NywxMiBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6aW5m aW5pdGVMb29wSlMoKQogCiB2b2lkIHRzdF9RV2ViUGFnZTo6Z2VvbG9jYXRpb25SZXF1ZXN0SlMo KQogeworICAgIC8qCisgICAgICBUaGlzIHRlc3QgaXMgZGlzYWJsZWQgYmVjYXVzZSBpdCBjYW4g b25seSBzdWNjZWVkIGlmIEVOQUJMRShHRU9MT0NBVElPTikgaXMgdHJ1ZS4KKyAgICAgIFRoZSBj b2RlIG5lZWRzIHRvIGJlIHVwZGF0ZWQgd2hlbiB0aGUgQVBJIG9mIHJlcXVlc3RQZXJtaXNzaW9u RnJvbVVzZXIgaXMgdXBkYXRlZC4KKyAgICAqLworICAgIFFTS0lQKCJUZXN0IGRpc2FibGVkIGFz IGxvbmcgYXMgZ2VvbG9jYXRpb24gaXMgZGlzYWJsZWQgZnJvbSB0aGUgYnVpbGQuIiwgU2tpcFNp bmdsZSk7CisKICAgICBKU1Rlc3RQYWdlKiBuZXdQYWdlID0gbmV3IEpTVGVzdFBhZ2UobV92aWV3 KTsKICAgICBjb25uZWN0KG5ld1BhZ2UsIFNJR05BTChyZXF1ZXN0UGVybWlzc2lvbkZyb21Vc2Vy KFFXZWJGcmFtZSosIFFXZWJQYWdlOjpQZXJtaXNzaW9uRG9tYWluKSksIAogICAgICAgICAgICAg bmV3UGFnZSwgU0xPVChyZXF1ZXN0UGVybWlzc2lvbihRV2ViRnJhbWUqLCBRV2ViUGFnZTo6UGVy bWlzc2lvbkRvbWFpbikpKTsK 76732 2010-12-15 20:14:48 -0800 2011-01-10 16:05:41 -0800 re-enable the test 46814.patch text/plain 1653 laszlo.gombos ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDQxOTU0MzQuLjUwOGQ3M2IgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTEyLTE1ICBMYXN6 bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCB0c3RfUVdlYlBhZ2U6Omdl b2xvY2F0aW9uUmVxdWVzdEpTKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ2ODE0CisKKyAgICAgICAgQ2hhbmdlIHRoZSB0ZXN0IGNhc2UgYWNjb3Jk aW5nIHRvIHRoZSBjaGFuZ2VzIGludHJvZHVjZWQgYnkKKyAgICAgICAgcjcyNjAzIGFuZCBlbmFi bGUgdGhlIHRlc3QgY2FzZS4KKworICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFn ZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6Omdlb2xvY2F0aW9uUmVxdWVzdEpTKToKKwog MjAxMC0xMi0xNCAgVmlhdGNoZXNsYXYgT3N0YXBlbmtvICA8b3N0YXBlbmtvLnZpYXRjaGVzbGF2 QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAgYi9XZWJLaXQv cXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAppbmRleCAyN2QyOGYwLi4zMDFhMDUw IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAor KysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcApAQCAtMjUwLDE0 ICsyNTAsOCBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6aW5maW5pdGVMb29wSlMoKQogCiB2b2lkIHRz dF9RV2ViUGFnZTo6Z2VvbG9jYXRpb25SZXF1ZXN0SlMoKQogewotICAgIC8qCi0gICAgICBUaGlz IHRlc3QgaXMgZGlzYWJsZWQgYmVjYXVzZSBpdCBjYW4gb25seSBzdWNjZWVkIGlmIEVOQUJMRShH RU9MT0NBVElPTikgaXMgdHJ1ZS4KLSAgICAgIFRoZSBjb2RlIG5lZWRzIHRvIGJlIHVwZGF0ZWQg d2hlbiB0aGUgQVBJIG9mIHJlcXVlc3RQZXJtaXNzaW9uRnJvbVVzZXIgaXMgdXBkYXRlZC4KLSAg ICAqLwotICAgIFFTS0lQKCJUZXN0IGRpc2FibGVkIGFzIGxvbmcgYXMgZ2VvbG9jYXRpb24gaXMg ZGlzYWJsZWQgZnJvbSB0aGUgYnVpbGQuIiwgU2tpcFNpbmdsZSk7Ci0KICAgICBKU1Rlc3RQYWdl KiBuZXdQYWdlID0gbmV3IEpTVGVzdFBhZ2UobV92aWV3KTsKLSAgICBjb25uZWN0KG5ld1BhZ2Us IFNJR05BTChyZXF1ZXN0UGVybWlzc2lvbkZyb21Vc2VyKFFXZWJGcmFtZSosIFFXZWJQYWdlOjpG ZWF0dXJlKSksIAorICAgIGNvbm5lY3QobmV3UGFnZSwgU0lHTkFMKGZlYXR1cmVQZXJtaXNzaW9u UmVxdWVzdGVkKFFXZWJGcmFtZSosIFFXZWJQYWdlOjpGZWF0dXJlKSksCiAgICAgICAgICAgICBu ZXdQYWdlLCBTTE9UKHJlcXVlc3RQZXJtaXNzaW9uKFFXZWJGcmFtZSosIFFXZWJQYWdlOjpGZWF0 dXJlKSkpOwogCiAgICAgbmV3UGFnZS0+c2V0R2VvbG9jYXRpb25QZXJtaXNzaW9uKGZhbHNlKTsK 78466 2011-01-10 16:05:47 -0800 2011-01-10 16:10:14 -0800 Patch bug-46814-20110111011054.patch text/plain 1579 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGNlNzE2ZDQyZDc3NzU2ZDQ3NWVkMzk3MzNlNTVmMGNhMDc2MzI4ODIuLmE5OTVlMjRjMjc0 YjVjZDhlMDBiYjBkMjFkN2I0YzBlYzgwNmFhNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDExLTAx LTEwICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdHN0 X1FXZWJQYWdlOjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjgxNAorCisgICAgICAgIFNraXAgdGhlIHRlc3Qg d2hlbiBXZWJLaXQgaXMgY29tcGlsZWQgd2l0aG91dCBnZW9sb2NhdGlvbi4KKworICAgICAgICAq IHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6 Omdlb2xvY2F0aW9uUmVxdWVzdEpTKToKKworMjAxMS0wMS0xMCAgQmVuamFtaW4gUG91bGFpbiAg PGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgogCiAgICAgICAgIFtRdF0gTmF2aWdhdG9yLmNvb2tpZXNF bmFibGVkIHJldHVybiB0cnVlIGZvciBRdCBldmVuIGlmIHRoZXJlIGlzIG5vIGNvb2tpZSBqYXIK ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIv V2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggZDRlZWQyMWE3 NzBhZjQyMzM1MDg0ODcwODhhZWNjOGNlZTc1MTA2Zi4uMGRjNGZiZDlkYzI0ZDY5YTllYTQxYjk1 NjI4ZDJkYmFiM2M3YTNkMyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFn ZS5jcHAKQEAgLTI1OSw2ICsyNTksMTAgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmluZmluaXRlTG9v cEpTKCkKIHZvaWQgdHN0X1FXZWJQYWdlOjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCiB7CiAgICAg SlNUZXN0UGFnZSogbmV3UGFnZSA9IG5ldyBKU1Rlc3RQYWdlKG1fdmlldyk7CisKKyAgICBpZiAo bmV3UGFnZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdChRTGF0aW4xU3RyaW5nKCIh bmF2aWdhdG9yLmdlb2xvY2F0aW9uIikpLnRvQm9vbCgpKQorICAgICAgICBRU0tJUCgiR2VvbG9j YXRpb24gaXMgbm90IHN1cHBvcnRlZC4iLCBTa2lwU2luZ2xlKTsKKwogICAgIGNvbm5lY3QobmV3 UGFnZSwgU0lHTkFMKGZlYXR1cmVQZXJtaXNzaW9uUmVxdWVzdGVkKFFXZWJGcmFtZSosIFFXZWJQ YWdlOjpGZWF0dXJlKSksCiAgICAgICAgICAgICBuZXdQYWdlLCBTTE9UKHJlcXVlc3RQZXJtaXNz aW9uKFFXZWJGcmFtZSosIFFXZWJQYWdlOjpGZWF0dXJlKSkpOwogCg== 78467 2011-01-10 16:10:21 -0800 2011-01-11 02:08:23 -0800 Patch bug-46814-20110111011528.patch text/plain 1613 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGNlNzE2ZDQyZDc3NzU2ZDQ3NWVkMzk3MzNlNTVmMGNhMDc2MzI4ODIuLmE5OTVlMjRjMjc0 YjVjZDhlMDBiYjBkMjFkN2I0YzBlYzgwNmFhNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDExLTAx LTEwICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdHN0 X1FXZWJQYWdlOjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjgxNAorCisgICAgICAgIFNraXAgdGhlIHRlc3Qg d2hlbiBXZWJLaXQgaXMgY29tcGlsZWQgd2l0aG91dCBnZW9sb2NhdGlvbi4KKworICAgICAgICAq IHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6 Omdlb2xvY2F0aW9uUmVxdWVzdEpTKToKKworMjAxMS0wMS0xMCAgQmVuamFtaW4gUG91bGFpbiAg PGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgogCiAgICAgICAgIFtRdF0gTmF2aWdhdG9yLmNvb2tpZXNF bmFibGVkIHJldHVybiB0cnVlIGZvciBRdCBldmVuIGlmIHRoZXJlIGlzIG5vIGNvb2tpZSBqYXIK ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIv V2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggZDRlZWQyMWE3 NzBhZjQyMzM1MDg0ODcwODhhZWNjOGNlZTc1MTA2Zi4uODAwNzI2MTA3YzhkNzllYTRmMmNhZjcz MWM1M2ZkN2ZiYmNiOGFmNCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFn ZS5jcHAKQEAgLTI1OSw2ICsyNTksMTIgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmluZmluaXRlTG9v cEpTKCkKIHZvaWQgdHN0X1FXZWJQYWdlOjpnZW9sb2NhdGlvblJlcXVlc3RKUygpCiB7CiAgICAg SlNUZXN0UGFnZSogbmV3UGFnZSA9IG5ldyBKU1Rlc3RQYWdlKG1fdmlldyk7CisKKyAgICBpZiAo bmV3UGFnZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdChRTGF0aW4xU3RyaW5nKCIh bmF2aWdhdG9yLmdlb2xvY2F0aW9uIikpLnRvQm9vbCgpKSB7CisgICAgICAgIGRlbGV0ZSBuZXdQ YWdlOworICAgICAgICBRU0tJUCgiR2VvbG9jYXRpb24gaXMgbm90IHN1cHBvcnRlZC4iLCBTa2lw U2luZ2xlKTsKKyAgICB9CisKICAgICBjb25uZWN0KG5ld1BhZ2UsIFNJR05BTChmZWF0dXJlUGVy bWlzc2lvblJlcXVlc3RlZChRV2ViRnJhbWUqLCBRV2ViUGFnZTo6RmVhdHVyZSkpLAogICAgICAg ICAgICAgbmV3UGFnZSwgU0xPVChyZXF1ZXN0UGVybWlzc2lvbihRV2ViRnJhbWUqLCBRV2ViUGFn ZTo6RmVhdHVyZSkpKTsKIAo=