46803 2010-09-29 06:12:54 -0700 [v8] Use generic mechanism to report exceptions in V8CustomVoidCallback 2010-09-29 06:47:06 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys abarth commit-queue ericu loislo pfeldman oldest_to_newest 286816 0 yurys 2010-09-29 06:12:54 -0700 At the moment it uses custom call to ScriptExecutionContext::reportException while the exceptions should be reported in a regular way using V8 message listener set in V8DOMWindowShell::initContextIfNeeded. 286819 1 69185 yurys 2010-09-29 06:16:44 -0700 Created attachment 69185 Patch 286822 2 69185 antonm 2010-09-29 06:20:15 -0700 Comment on attachment 69185 Patch LGTM, much nicer 286832 3 69185 commit-queue 2010-09-29 06:47:01 -0700 Comment on attachment 69185 Patch Clearing flags on attachment: 69185 Committed r68641: <http://trac.webkit.org/changeset/68641> 286833 4 commit-queue 2010-09-29 06:47:06 -0700 All reviewed patches have been landed. Closing bug. 69185 2010-09-29 06:16:44 -0700 2010-09-29 06:47:01 -0700 Patch bug-46803-20100929171642.patch text/plain 2093 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGJjZGEwYWMyNGJiZjY0NGE3N2VhMmE4N2Y3MWVlZGFmNTdiZGM5YS4uMjZiYjBlMzRhNTA3MjEx ZTZkNDFlNTEwYWE4ZDY3MWM2YTkwZDczNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0yOSAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFVzZSBnZW5lcmljIG1lY2hhbmlzbSB0 byByZXBvcnQgZXhjZXB0aW9ucyBpbiBWOEN1c3RvbVZvaWRDYWxsYmFjaworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY4MDMKKworICAgICAgICBObyBu ZXcgdGVzdHMuIEl0J3MgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cyB1bmRlciBMYXlvdXRUZXN0 cy9zdG9yYWdlCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21Wb2lkQ2Fs bGJhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6aW52b2tlQ2FsbGJhY2spOgorCiAyMDEwLTA5 LTI3ICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVZvaWRDYWxsYmFjay5jcHAgYi9XZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOEN1c3RvbVZvaWRDYWxsYmFjay5jcHAKaW5kZXggMjVlN2UwZDgzYzk4NTNk MDRkYTNjZTFiZGQyNGE1OGE3NTgxMDJlMS4uMTFmMzA5YjY5OTRhMTA4OTAwMmExMTJiNWZmMDU5 NDg3N2FkZTk3OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0 b21Wb2lkQ2FsbGJhY2suY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3Vz dG9tVm9pZENhbGxiYWNrLmNwcApAQCAtNjYsNiArNjYsNyBAQCB2b2lkIFY4Q3VzdG9tVm9pZENh bGxiYWNrOjpoYW5kbGVFdmVudCgpCiBib29sIGludm9rZUNhbGxiYWNrKHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+IGNhbGxiYWNrLCBpbnQgYXJnYywgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFy Z3ZbXSwgYm9vbCYgY2FsbGJhY2tSZXR1cm5WYWx1ZSwgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCog c2NyaXB0RXhlY3V0aW9uQ29udGV4dCkKIHsKICAgICB2ODo6VHJ5Q2F0Y2ggZXhjZXB0aW9uQ2F0 Y2hlcjsKKyAgICBleGNlcHRpb25DYXRjaGVyLlNldFZlcmJvc2UodHJ1ZSk7CiAKICAgICB2ODo6 TG9jYWw8djg6OkZ1bmN0aW9uPiBjYWxsYmFja0Z1bmN0aW9uOwogICAgIGlmIChjYWxsYmFjay0+ SXNGdW5jdGlvbigpKSB7CkBAIC04NCwxNCArODUsNyBAQCBib29sIGludm9rZUNhbGxiYWNrKHY4 OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IGNhbGxiYWNrLCBpbnQgYXJnYywgdjg6OkhhbmRsZTx2 OAogCiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHJlc3VsdCA9IGNhbGxiYWNrRnVuY3Rpb24t PkNhbGwodGhpc09iamVjdCwgYXJnYywgYXJndik7CiAgICAgY2FsbGJhY2tSZXR1cm5WYWx1ZSA9 ICFyZXN1bHQuSXNFbXB0eSgpICYmIHJlc3VsdC0+Qm9vbGVhblZhbHVlKCk7Ci0KLSAgICBpZiAo ZXhjZXB0aW9uQ2F0Y2hlci5IYXNDYXVnaHQoKSkgewotICAgICAgICB2ODo6TG9jYWw8djg6Ok1l c3NhZ2U+IG1lc3NhZ2UgPSBleGNlcHRpb25DYXRjaGVyLk1lc3NhZ2UoKTsKLSAgICAgICAgc2Ny aXB0RXhlY3V0aW9uQ29udGV4dC0+cmVwb3J0RXhjZXB0aW9uKHRvV2ViQ29yZVN0cmluZyhtZXNz YWdlLT5HZXQoKSksIG1lc3NhZ2UtPkdldExpbmVOdW1iZXIoKSwgdG9XZWJDb3JlU3RyaW5nKG1l c3NhZ2UtPkdldFNjcmlwdFJlc291cmNlTmFtZSgpKSk7Ci0gICAgICAgIHJldHVybiB0cnVlOwot ICAgIH0KLQotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gZXhjZXB0aW9uQ2F0Y2hlci5I YXNDYXVnaHQoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=