46795 2010-09-29 03:58:04 -0700 build still broken since r68521 2010-09-30 08:46:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abecsi alex darin gustavo mrobinson ossy oldest_to_newest 286787 0 pnormand 2010-09-29 03:58:04 -0700 Martin did an attempt to fix it with r68550 but it still fails. 286788 1 69175 pnormand 2010-09-29 04:00:38 -0700 Created attachment 69175 proposed build fix 286884 2 pnormand 2010-09-29 08:13:28 -0700 Commited http://trac.webkit.org/changeset/68645 after discussion on IRC with kov, Ossy and bbandix. Leaving opened for now. 286961 3 69211 ossy 2010-09-29 10:34:52 -0700 Created attachment 69211 proposed proper fix I think the landed patch is incorrect: foo1.c: foo2.c: dependency1.c dependency2.c receipe_to_make_foo1_and_foo2 --> Here "foo1.c:" is an empty rule and we don't want this. 286967 4 darin 2010-09-29 10:40:12 -0700 (In reply to comment #3) > I think the landed patch is incorrect: > > foo1.c: > foo2.c: dependency1.c dependency2.c > receipe_to_make_foo1_and_foo2 > > --> Here "foo1.c:" is an empty rule and we don't want this. Yes, I agree. 287437 5 abecsi 2010-09-30 02:04:42 -0700 (In reply to comment #3) > Created an attachment (id=69211) [details] > proposed proper fix LGTM. With the empty rule we have the same effect as without Martin's patch. Thanks for fixing this. 287560 6 69211 mrobinson 2010-09-30 08:38:11 -0700 Comment on attachment 69211 proposed proper fix Thank you! 287567 7 69211 ossy 2010-09-30 08:45:52 -0700 Comment on attachment 69211 proposed proper fix Clearing flags on attachment: 69211 Committed r68787: <http://trac.webkit.org/changeset/68787> 287568 8 ossy 2010-09-30 08:46:02 -0700 All reviewed patches have been landed. Closing bug. 69175 2010-09-29 04:00:38 -0700 2010-09-29 10:34:52 -0700 proposed build fix proposed-build-fix.patch text/plain 1888 pnormand RnJvbSBkN2ZjYjhjNGJhMmQ1NWVmYWU1ZmVkNDE2NGQ0ZmZmNzk1NTAwMzUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDI5IFNlcCAyMDEwIDEzOjAxOjIwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgYnVpbGQgZml4CgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgfCAgIDEzICsr KysrKysrKysrKysKIFdlYkNvcmUvR05VbWFrZWZpbGUuYW0gfCAgICAzICsrLQogMiBmaWxlcyBj aGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdlNjU4MS4uNWNmYzBi MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOS0yOSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5k QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgYnVpbGQgc3RpbGwgYnJva2VuIHNpbmNlIHI2ODUyMQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY3OTUKKworICAgICAgICBDYWxsIG1ha2Ut dmFsdWVzLnBsIG9uY2Ugb25seS4gSXQgc2VlbXMgY2FsbGluZyBpdCBtdWx0aXBsZSB0aW1lcwor ICAgICAgICBpbiB0aGUgc2FtZSBidWlsZCBwcm9kdWNlcyBhIHdyb25nIENTU1ZhbHVlS2V5d29y ZHNIYXNoLmggd2hpY2gKKyAgICAgICAgaGFzIGEgZHVwbGljYXRlIGRlY2xhcmF0aW9uIG9mIGl0 cyB2YWx1ZUxpc3QgdmFyaWFibGUuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwogMjAx MC0wOS0yOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL0dOVW1h a2VmaWxlLmFtIGIvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQppbmRleCA5ODViNWNlLi41NjEwNGMz IDEwMDY0NAotLS0gYS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCisrKyBiL1dlYkNvcmUvR05VbWFr ZWZpbGUuYW0KQEAgLTQ0MDIsNyArNDQwMiw4IEBAIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NT UHJvcGVydHlOYW1lcy5oIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTUHJvcGVydHlOYW1lCiAJ bXYgQ1NTUHJvcGVydHlOYW1lcy4qICQoR0VOU09VUkNFU19XRUJDT1JFKQogCiAjIExvd2VyIGNh c2UgYWxsIHRoZSB2YWx1ZXMsIGFzIENTUyB2YWx1ZXMgYXJlIGNhc2UtaW5zZW5zaXRpdmUKLURl cml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTVmFsdWVLZXl3b3Jkcy5oIERlcml2ZWRTb3VyY2VzL1dl YkNvcmUvQ1NTVmFsdWVLZXl3b3Jkcy5jcHA6ICQoV0VCQ09SRV9DU1NfVkFMVUVfS0VZV09SRFMp ICQoV2ViQ29yZSkvY3NzL21ha2V2YWx1ZXMucGwKK0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NT VmFsdWVLZXl3b3Jkcy5jcHA6CitEZXJpdmVkU291cmNlcy9XZWJDb3JlL0NTU1ZhbHVlS2V5d29y ZHMuaDogJChXRUJDT1JFX0NTU19WQUxVRV9LRVlXT1JEUykgJChXZWJDb3JlKS9jc3MvbWFrZXZh bHVlcy5wbAogCSQoUEVSTCkgLW5lICdwcmludCBsYycgJChXRUJDT1JFX0NTU19WQUxVRV9LRVlX T1JEUykgPiBDU1NWYWx1ZUtleXdvcmRzLmluCiAJaWYgc29ydCBDU1NWYWx1ZUtleXdvcmRzLmlu IHwgdW5pcSAtZCB8IGdyZXAgLUUgJ15bXiNdJzsgdGhlbiBlY2hvICdEdXBsaWNhdGUgdmFsdWUh JzsgZXhpdCAxOyBmaQogCSQoUEVSTCkgIiQoV2ViQ29yZSkvY3NzL21ha2V2YWx1ZXMucGwiCi0t IAoxLjcuMQ== 69211 2010-09-29 10:34:52 -0700 2010-09-30 08:45:52 -0700 proposed proper fix 1.patch text/plain 2749 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODY1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMjkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbR3RrXSBidWlsZCBzdGlsbCBicm9rZW4gc2luY2UgcjY4NTIxCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njc5NQorCisgICAgICAgIG1ha2V2YWx1 ZXMucGwgYW5kIG1ha2Vwcm9wLnBsIGdlbmVyYXRlIDMgZmlsZXMgaW4gb25lIHJ1bi4KKyAgICAg ICAgRG91YmxlIG9yIHRyaXBsZSB0YXJnZXQgaXMgaW5jb3JyZWN0LCBiZWNhdXNlIG9uIGEgbXVs dGljb3JlCisgICAgICAgIG1hY2hpbmUgbWFrZSBwcm9jZXNzZXMgdGFyZ2V0cyBpbiBwYXJhbGxl bC4KKworICAgICAgICBTZXR0aW5nIGEtPmItPmMgZGVwZW5kZW5jaWVzIGZvciAzIGdlbmVyYXRl ZCBmaWxlcyBndWFyYW50ZWVzCisgICAgICAgIHRoYXQgbWFrZSBkb2Vzbid0IGV4ZWN1dGUgdGhl IHJlY2lwZSBvZiB0aGUgcnVsZSBtb3JlIHRoYW4gb25lLgorCisgICAgICAgICogR05VbWFrZWZp bGUuYW06IERlcGVuZGVuY2llcyBhbmQgbWlzc2luZyBoZWFkZXJzIGFkZGVkLgorCiAyMDEwLTA5 LTI5ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBTYW0gV2VpbmlnLgpJbmRleDogV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiA2ODY1NCkKKysrIFdlYkNvcmUvR05V bWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTg4LDggKzg4LDEwIEBACiAJRGVyaXZlZFNv dXJjZXMvV2ViQ29yZS9DU1NHcmFtbWFyLmggXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NT UHJvcGVydHlOYW1lcy5oIFwKIAlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0NTU1Byb3BlcnR5TmFt ZXMuY3BwIFwKKwlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0NTU1Byb3BlcnR5TmFtZXNIYXNoLmgg XAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTVmFsdWVLZXl3b3Jkcy5oIFwKIAlEZXJpdmVk U291cmNlcy9XZWJDb3JlL0NTU1ZhbHVlS2V5d29yZHMuY3BwIFwKKwlEZXJpdmVkU291cmNlcy9X ZWJDb3JlL0NTU1ZhbHVlS2V5d29yZHNIYXNoLmggXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUv Q29sb3JEYXRhLmNwcCBcCiAJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9Eb2NUeXBlU3RyaW5ncy5j cHAgXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSGFzaFRvb2xzLmggXApAQCAtNDM5NSw3ICs0 Mzk3LDggQEAKIHdlYmNvcmVfY3BwZmxhZ3MgKz0gLURFTkFCTEVfQkxPQj0xCiBlbmRpZiAgIyBF TkQgRU5BQkxFX0JMT0IKIAotRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NQcm9wZXJ0eU5hbWVz LmNwcDoKK0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTUHJvcGVydHlOYW1lc0hhc2guaDogRGVy aXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NQcm9wZXJ0eU5hbWVzLmNwcAorRGVyaXZlZFNvdXJjZXMv V2ViQ29yZS9DU1NQcm9wZXJ0eU5hbWVzLmNwcDogRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NQ cm9wZXJ0eU5hbWVzLmgKIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTUHJvcGVydHlOYW1lcy5o OiAkKFdFQkNPUkVfQ1NTX1BST1BFUlRZX05BTUVTKSAkKFdlYkNvcmUpL2Nzcy9tYWtlcHJvcC5w bAogCWlmIHNvcnQgJChXRUJDT1JFX0NTU19QUk9QRVJUWV9OQU1FUykgfCB1bmlxIC1kIHwgZ3Jl cCAtRSAnXlteI10nOyB0aGVuIGVjaG8gJ0R1cGxpY2F0ZSB2YWx1ZSEnOyBleGl0IDE7IGZpCiAJ Y2F0ICQoV0VCQ09SRV9DU1NfUFJPUEVSVFlfTkFNRVMpID4gQ1NTUHJvcGVydHlOYW1lcy5pbgpA QCAtNDQwMyw3ICs0NDA2LDggQEAKIAltdiBDU1NQcm9wZXJ0eU5hbWVzLiogJChHRU5TT1VSQ0VT X1dFQkNPUkUpCiAKICMgTG93ZXIgY2FzZSBhbGwgdGhlIHZhbHVlcywgYXMgQ1NTIHZhbHVlcyBh cmUgY2FzZS1pbnNlbnNpdGl2ZQotRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NWYWx1ZUtleXdv cmRzLmNwcDoKK0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTVmFsdWVLZXl3b3Jkc0hhc2guaDog RGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NWYWx1ZUtleXdvcmRzLmNwcAorRGVyaXZlZFNvdXJj ZXMvV2ViQ29yZS9DU1NWYWx1ZUtleXdvcmRzLmNwcDogRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9D U1NWYWx1ZUtleXdvcmRzLmgKIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTVmFsdWVLZXl3b3Jk cy5oOiAkKFdFQkNPUkVfQ1NTX1ZBTFVFX0tFWVdPUkRTKSAkKFdlYkNvcmUpL2Nzcy9tYWtldmFs dWVzLnBsCiAJJChQRVJMKSAtbmUgJ3ByaW50IGxjJyAkKFdFQkNPUkVfQ1NTX1ZBTFVFX0tFWVdP UkRTKSA+IENTU1ZhbHVlS2V5d29yZHMuaW4KIAlpZiBzb3J0IENTU1ZhbHVlS2V5d29yZHMuaW4g fCB1bmlxIC1kIHwgZ3JlcCAtRSAnXlteI10nOyB0aGVuIGVjaG8gJ0R1cGxpY2F0ZSB2YWx1ZSEn OyBleGl0IDE7IGZpCg==