46790 2010-09-29 01:23:07 -0700 GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay 2010-10-19 05:17:23 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand pnormand eric oldest_to_newest 286771 0 pnormand 2010-09-29 01:23:07 -0700 On Mac OSX, the osxvideosink sends a message on the GStreamer bus which includes a pointer to its internal NSView. Application-side needs to retrieve and use it before calling the XOverlay set_window_handle function. So I propose to add a simple "prepare(GstMessage*)" method in PlatformVideoWindow for this purpose. On Gtk and EFL this would be an empty implementation. 286789 1 69176 pnormand 2010-09-29 04:07:42 -0700 Created attachment 69176 proposed patch 288703 2 69176 mrobinson 2010-10-02 11:23:20 -0700 Comment on attachment 69176 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=69176&action=review I'm not sure what an appropriate name for this method should be (perhaps prepareForOverlay?), but I think that prepare is not descriptive enough. > WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:198 > + m_videoWindow->prepare(message); The name prepare(...) seems a little ambiguous. I would prefer something a bit more descriptive. > WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:40 > + notImplemented(); An empty implementation is different than notImplemented(). This should just be empty. > WebCore/platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:69 > + notImplemented(); Same here. 293617 3 eric 2010-10-13 12:27:39 -0700 Attachment 69176 was posted by a committer and has review+, assigning to Philippe Normand for commit. 296121 4 pnormand 2010-10-19 05:17:23 -0700 Committed r70048: <http://trac.webkit.org/changeset/70048> 69176 2010-09-29 04:07:42 -0700 2010-10-02 11:23:20 -0700 proposed patch proposed-patch.patch text/plain 4600 pnormand RnJvbSAxOWJiNWYzOWNlMWZhM2E1YTU2YjcxNGI3MzdiZTFiOWUxYzJjYjZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDE5IEF1ZyAyMDEwIDE4OjA5OjEwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDIwICsrKysrKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAgICAgICAgICB8ICAgIDQgKysrLQogLi4uL2dy YXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93LmggICAgICAgfCAgICA0ICsrKysK IC4uLi9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvd0VmbC5jcHAgIHwgICAg NSArKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93R3RrLmNw cCAgfCAgICA4ICsrKysrKysrCiA1IGZpbGVzIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MTYyYzUxLi4zNmMwZDhjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEwLTA5LTI5 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHU3RyZWFtZXIgUGxhdGZvcm1WaWRl b1dpbmRvdyBuZWVkcyBhbiBBUEkgdG8gcHJlcGFyZSB0aGUgd2lkZ2V0IGJlZm9yZSBhcHBseWlu ZyB0aGUgb3ZlcmxheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDY3OTAKKworICAgICAgICBTaW1wbGUgQVBJIGFkZGl0aW9uIHRvIFBsYXRmb3JtVmlk ZW9XaW5kb3cgdG8gYWxsb3cKKyAgICAgICAgaW1wbGVtZW50YXRpb25zIHRvIG9wdGlvbmFsbHkg cHJlcGFyZSB0aGVpciBvd24gUGxhdGZvcm1XaWRnZXQKKyAgICAgICAgYmVmb3JlIGFwcGx5aW5n IHRoZSBHU3RyZWFtZXIgWE92ZXJsYXkgdG8gaXQuIFRoaXMgd2lsbCBsaWtlbHkgYmUKKyAgICAg ICAgbmVlZGVkIG9uIE1hYyBPU1ggb25seS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9HU3RyZWFtZXJHV29ybGQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R1N0cmVh bWVyR1dvcmxkOjpzZXRXaW5kb3dPdmVybGF5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93R3RrLmNwcDoKKyAgICAgICAgKFBs YXRmb3JtVmlkZW9XaW5kb3c6OnByZXBhcmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcDoKKyAgICAgICAgKFBsYXRmb3Jt VmlkZW9XaW5kb3c6OnByZXBhcmUpOgorCiAyMDEwLTA5LTI4ICBJbHlhIFRpa2hvbm92c2t5ICA8 bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0 c2t5LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0 cmVhbWVyR1dvcmxkLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dT dHJlYW1lckdXb3JsZC5jcHAKaW5kZXggNTM5ZDkyYS4uOTQ4NGQ5NyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJHV29ybGQuY3Bw CkBAIC0xOTQsMTIgKzE5NCwxNCBAQCB2b2lkIEdTdHJlYW1lckdXb3JsZDo6c2V0V2luZG93T3Zl cmxheShHc3RNZXNzYWdlKiBtZXNzYWdlKQogICAgIGlmIChnX29iamVjdF9jbGFzc19maW5kX3By b3BlcnR5KEdfT0JKRUNUX0dFVF9DTEFTUyhzaW5rKSwgImZvcmNlLWFzcGVjdC1yYXRpbyIpKQog ICAgICAgICBnX29iamVjdF9zZXQoc2luaywgImZvcmNlLWFzcGVjdC1yYXRpbyIsIFRSVUUsIE5V TEwpOwogCi0gICAgaWYgKG1fdmlkZW9XaW5kb3cpCisgICAgaWYgKG1fdmlkZW9XaW5kb3cpIHsK KyAgICAgICAgbV92aWRlb1dpbmRvdy0+cHJlcGFyZShtZXNzYWdlKTsKICNpZiBHU1RfQ0hFQ0tf VkVSU0lPTigwLCAxMCwgMzEpIHx8IEdTVF9WRVJTSU9OX05BTk8KICAgICAgICAgZ3N0X3hfb3Zl cmxheV9zZXRfd2luZG93X2hhbmRsZShHU1RfWF9PVkVSTEFZKHNpbmspLCBtX3ZpZGVvV2luZG93 LT52aWRlb1dpbmRvd0lkKCkpOwogI2Vsc2UKICAgICAgICAgZ3N0X3hfb3ZlcmxheV9zZXRfeHdp bmRvd19pZChHU1RfWF9PVkVSTEFZKHNpbmspLCBtX3ZpZGVvV2luZG93LT52aWRlb1dpbmRvd0lk KCkpOwogI2VuZGlmCisgICAgfQogfQogCiB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93LmggYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93LmgKaW5kZXggZjNkZjIw Ny4uMWY1MjFmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvUGxhdGZvcm1WaWRlb1dpbmRvdy5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL1BsYXRmb3JtVmlkZW9XaW5kb3cuaApAQCAtMjUsNiArMjUsOCBAQAogI2luY2x1 ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KIAordHlw ZWRlZiBzdHJ1Y3QgX0dzdE1lc3NhZ2UgR3N0TWVzc2FnZTsKKwogbmFtZXNwYWNlIFdlYkNvcmUg ewogCiBjbGFzcyBQbGF0Zm9ybVZpZGVvV2luZG93IDogcHVibGljIFJlZkNvdW50ZWQ8UGxhdGZv cm1WaWRlb1dpbmRvdz4gewpAQCAtMzQsNiArMzYsOCBAQCBjbGFzcyBQbGF0Zm9ybVZpZGVvV2lu ZG93IDogcHVibGljIFJlZkNvdW50ZWQ8UGxhdGZvcm1WaWRlb1dpbmRvdz4gewogICAgICAgICBQ bGF0Zm9ybVZpZGVvV2luZG93KCk7CiAgICAgICAgIH5QbGF0Zm9ybVZpZGVvV2luZG93KCk7CiAK KworICAgICAgICB2b2lkIHByZXBhcmUoR3N0TWVzc2FnZSopOwogICAgICAgICBQbGF0Zm9ybVdp ZGdldCB3aW5kb3coKSBjb25zdCB7IHJldHVybiBtX3dpbmRvdzsgfQogICAgICAgICB1bnNpZ25l ZCBsb25nIHZpZGVvV2luZG93SWQoKSBjb25zdCB7IHJldHVybiBtX3ZpZGVvV2luZG93SWQ7IH0K IApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZv cm1WaWRlb1dpbmRvd0VmbC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9QbGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcAppbmRleCBjNTViOWNjLi44MjZjYzY1IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVv V2luZG93RWZsLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9Q bGF0Zm9ybVZpZGVvV2luZG93RWZsLmNwcApAQCAtMzUsNCArMzUsOSBAQCBQbGF0Zm9ybVZpZGVv V2luZG93Ojp+UGxhdGZvcm1WaWRlb1dpbmRvdygpCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0K IAordm9pZCBQbGF0Zm9ybVZpZGVvV2luZG93OjpwcmVwYXJlKEdzdE1lc3NhZ2UqKQoreworICAg IG5vdEltcGxlbWVudGVkKCk7Cit9CisKICNlbmRpZiAvLyBVU0UoR1NUUkVBTUVSKQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvUGxhdGZvcm1WaWRlb1dp bmRvd0d0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9y bVZpZGVvV2luZG93R3RrLmNwcAppbmRleCA3NzM0M2FlLi5kY2UxMzhkIDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZpZGVvV2luZG93R3Rr LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9QbGF0Zm9ybVZp ZGVvV2luZG93R3RrLmNwcApAQCAtMjEsNiArMjEsOCBAQAogI2luY2x1ZGUgIlBsYXRmb3JtVmlk ZW9XaW5kb3cuaCIKICNpZiBVU0UoR1NUUkVBTUVSKQogCisjaW5jbHVkZSAiTm90SW1wbGVtZW50 ZWQuaCIKKwogI2luY2x1ZGUgPGd0ay9ndGsuaD4KIAogI2lmZGVmIEdES19XSU5ET1dJTkdfWDEx CkBAIC02MSw0ICs2MywxMCBAQCBQbGF0Zm9ybVZpZGVvV2luZG93Ojp+UGxhdGZvcm1WaWRlb1dp bmRvdygpCiAKICAgICBtX3ZpZGVvV2luZG93SWQgPSAwOwogfQorCit2b2lkIFBsYXRmb3JtVmlk ZW9XaW5kb3c6OnByZXBhcmUoR3N0TWVzc2FnZSopCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsK K30KICNlbmRpZiAvLyBVU0UoR1NUUkVBTUVSKQorCi0tIAoxLjcuMQ==