46789 2010-09-29 00:51:49 -0700 Web Inspector: assign the resourceLoad finish time which was obtained from the network stack as the end time for the corresponding event in Timeline. 2010-09-30 05:49:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 286763 0 loislo 2010-09-29 00:51:49 -0700 See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664 286767 1 69168 loislo 2010-09-29 00:56:18 -0700 Created attachment 69168 [patch] First iteration. 286769 2 69168 yurys 2010-09-29 01:03:27 -0700 Comment on attachment 69168 [patch] First iteration. View in context: https://bugs.webkit.org/attachment.cgi?id=69168&action=review > WebCore/inspector/InspectorTimelineAgent.cpp:248 > + RefPtr<InspectorObject> record = TimelineRecordFactory::createGenericRecord(finishTime ? finishTime : WTF::currentTimeMS()); I don't quite understand why we not use finishTime in all cases? 287504 3 loislo 2010-09-30 05:48:45 -0700 Committed r68779 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorTimelineAgent.cpp M WebCore/inspector/InspectorTimelineAgent.h r68779 = 28059cde085c595f4c6f4c8c40d411ba472717db (refs/remotes/trunk) 69168 2010-09-29 00:56:18 -0700 2010-09-30 05:49:37 -0700 [patch] First iteration. patch text/plain 3808 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTUyY2M5Yi4uMzhmMTQ4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOS0yOSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYXNzaWduIHRoZSByZXNvdXJjZSBs b2FkaW5nIGZpbmlzaCB0aW1lIHdoaWNoIHdhcyBvYnRhaW5lZCBmcm9tIHRoZSBuZXR3b3JrIHN0 YWNrCisgICAgICAgIGFzIHRoZSBlbmQgdGltZSBmb3IgdGhlIGNvcnJlc3BvbmRpbmcgZXZlbnQg aW4gVGltZWxpbmUuCisgICAgICAgIFNlZSByZWxhdGVkIGNoYW5nZSBmb3IgUmVzb3VyY2VzIHBh bmVsIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTY2NAorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njc4OQorCisgICAg ICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkRmluaXNoTG9hZGluZyk6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpkaWRGYWlsTG9hZGluZyk6CisgICAgICAgICogaW5z cGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5z cGVjdG9yVGltZWxpbmVBZ2VudDo6ZGlkRmluaXNoTG9hZGluZ1Jlc291cmNlKToKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5oOgorCiAyMDEwLTA5LTI4ICBEYXZp ZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWog U3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5k ZXggZDEwNmQ1Ni4uODcyNDYxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJv bGxlci5jcHAKQEAgLTEwOTAsNyArMTA5MCw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6 ZGlkRmluaXNoTG9hZGluZyh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGRvdWJsZSBmaW5pCiAg ICAgICAgIHJldHVybjsKIAogICAgIGlmIChtX3RpbWVsaW5lQWdlbnQpCi0gICAgICAgIG1fdGlt ZWxpbmVBZ2VudC0+ZGlkRmluaXNoTG9hZGluZ1Jlc291cmNlKGlkZW50aWZpZXIsIGZhbHNlKTsK KyAgICAgICAgbV90aW1lbGluZUFnZW50LT5kaWRGaW5pc2hMb2FkaW5nUmVzb3VyY2UoaWRlbnRp ZmllciwgZmFsc2UsIGZpbmlzaFRpbWUgKiAxMDAwKTsKIAogICAgIFJlZlB0cjxJbnNwZWN0b3JS ZXNvdXJjZT4gcmVzb3VyY2UgPSBnZXRUcmFja2VkUmVzb3VyY2UoaWRlbnRpZmllcik7CiAgICAg aWYgKCFyZXNvdXJjZSkKQEAgLTExMDksNyArMTEwOSw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJv bGxlcjo6ZGlkRmFpbExvYWRpbmcodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBjb25zdCBSZXNv dXJjCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChtX3RpbWVsaW5lQWdlbnQpCi0gICAgICAg IG1fdGltZWxpbmVBZ2VudC0+ZGlkRmluaXNoTG9hZGluZ1Jlc291cmNlKGlkZW50aWZpZXIsIHRy dWUpOworICAgICAgICBtX3RpbWVsaW5lQWdlbnQtPmRpZEZpbmlzaExvYWRpbmdSZXNvdXJjZShp ZGVudGlmaWVyLCB0cnVlLCAwKTsKIAogICAgIFN0cmluZyBtZXNzYWdlID0gIkZhaWxlZCB0byBs b2FkIHJlc291cmNlIjsKICAgICBpZiAoIWVycm9yLmxvY2FsaXplZERlc2NyaXB0aW9uKCkuaXNF bXB0eSgpKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVB Z2VudC5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmNwcApp bmRleCBmYmIxN2M0Li4xMmQyODUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JUaW1lbGluZUFnZW50LmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JU aW1lbGluZUFnZW50LmNwcApAQCAtMjQyLDEwICsyNDIsMTAgQEAgdm9pZCBJbnNwZWN0b3JUaW1l bGluZUFnZW50OjpkaWRSZWNlaXZlUmVzb3VyY2VSZXNwb25zZSgpCiAgICAgZGlkQ29tcGxldGVD dXJyZW50UmVjb3JkKFJlc291cmNlUmVjZWl2ZVJlc3BvbnNlVGltZWxpbmVSZWNvcmRUeXBlKTsK IH0KIAotdm9pZCBJbnNwZWN0b3JUaW1lbGluZUFnZW50OjpkaWRGaW5pc2hMb2FkaW5nUmVzb3Vy Y2UodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBib29sIGRpZEZhaWwpCit2b2lkIEluc3BlY3Rv clRpbWVsaW5lQWdlbnQ6OmRpZEZpbmlzaExvYWRpbmdSZXNvdXJjZSh1bnNpZ25lZCBsb25nIGlk ZW50aWZpZXIsIGJvb2wgZGlkRmFpbCwgZG91YmxlIGZpbmlzaFRpbWUpCiB7CiAgICAgcHVzaEdD RXZlbnRSZWNvcmRzKCk7Ci0gICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gcmVjb3JkID0gVGlt ZWxpbmVSZWNvcmRGYWN0b3J5OjpjcmVhdGVHZW5lcmljUmVjb3JkKFdURjo6Y3VycmVudFRpbWVN UygpKTsKKyAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiByZWNvcmQgPSBUaW1lbGluZVJlY29y ZEZhY3Rvcnk6OmNyZWF0ZUdlbmVyaWNSZWNvcmQoZmluaXNoVGltZSA/IGZpbmlzaFRpbWUgOiBX VEY6OmN1cnJlbnRUaW1lTVMoKSk7CiAgICAgcmVjb3JkLT5zZXRPYmplY3QoImRhdGEiLCBUaW1l bGluZVJlY29yZEZhY3Rvcnk6OmNyZWF0ZVJlc291cmNlRmluaXNoRGF0YShpZGVudGlmaWVyLCBk aWRGYWlsKSk7CiAgICAgcmVjb3JkLT5zZXROdW1iZXIoInR5cGUiLCBSZXNvdXJjZUZpbmlzaFRp bWVsaW5lUmVjb3JkVHlwZSk7CiAgICAgc2V0SGVhcFNpemVTdGF0aXN0aWMocmVjb3JkLmdldCgp KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQu aCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuaAppbmRleCA2YjMz MjRiLi4yNjFhZTNhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1l bGluZUFnZW50LmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2Vu dC5oCkBAIC0xMjIsNyArMTIyLDcgQEAgcHVibGljOgogICAgIHZvaWQgd2lsbFNlbmRSZXNvdXJj ZVJlcXVlc3QodW5zaWduZWQgbG9uZywgYm9vbCBpc01haW5SZXNvdXJjZSwgY29uc3QgUmVzb3Vy Y2VSZXF1ZXN0Jik7CiAgICAgdm9pZCB3aWxsUmVjZWl2ZVJlc291cmNlUmVzcG9uc2UodW5zaWdu ZWQgbG9uZywgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwogICAgIHZvaWQgZGlkUmVjZWl2ZVJl c291cmNlUmVzcG9uc2UoKTsKLSAgICB2b2lkIGRpZEZpbmlzaExvYWRpbmdSZXNvdXJjZSh1bnNp Z25lZCBsb25nLCBib29sIGRpZEZhaWwpOworICAgIHZvaWQgZGlkRmluaXNoTG9hZGluZ1Jlc291 cmNlKHVuc2lnbmVkIGxvbmcsIGJvb2wgZGlkRmFpbCwgZG91YmxlIGZpbmlzaFRpbWUpOwogICAg IHZvaWQgd2lsbFJlY2VpdmVSZXNvdXJjZURhdGEodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyKTsK ICAgICB2b2lkIGRpZFJlY2VpdmVSZXNvdXJjZURhdGEoKTsKICAgICAgICAgCg==