46788 2010-09-29 00:50:15 -0700 check for ENABLE(GLIB_SUPPORT) in WebView 2010-10-05 08:32:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned commit-queue oldest_to_newest 286762 0 pnormand 2010-09-29 00:50:15 -0700 WebView.mm contains a small runloop observer used to trigger the main glib context iterations. That code is guarded with ENABLE(VIDEO) && USE(GSTREAMER). It would make more sense to guard it with ENABLE(GLIB_SUPPORT) instead because it's not specific to video or gstreamer support in the end. 286766 1 69167 pnormand 2010-09-29 00:54:09 -0700 Created attachment 69167 proposed patch 286808 2 69181 pnormand 2010-09-29 05:37:04 -0700 Created attachment 69181 proposed patch 288704 3 69181 mrobinson 2010-10-02 11:24:06 -0700 Comment on attachment 69181 proposed patch Looks reasonable! 289625 4 69181 commit-queue 2010-10-05 08:32:39 -0700 Comment on attachment 69181 proposed patch Clearing flags on attachment: 69181 Committed r69109: <http://trac.webkit.org/changeset/69109> 289626 5 commit-queue 2010-10-05 08:32:44 -0700 All reviewed patches have been landed. Closing bug. 69167 2010-09-29 00:54:09 -0700 2010-09-29 05:37:04 -0700 proposed patch proposed-patch.patch text/plain 2701 pnormand RnJvbSBmMzA3MDRmNzhiZTBkNTYwYjY5MzU3Zjc2NzJjODJhYjZiOGE0NDdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI4IFNlcCAyMDEwIDE3OjQwOjQ5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0L21hYy9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDEz ICsrKysrKysrKysrKysKIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIHwgICAxMiArKysr KystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1dlYktpdC9tYWMvQ2hhbmdl TG9nCmluZGV4IGQ3MDc3MjAuLjY5ZjQzZDcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDkt MjkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrIGZvciBFTkFCTEUoR0xJ Ql9TVVBQT1JUKSBpbiBXZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00Njc4OAorCisgICAgICAgIFVzZSBFTkFCTEUoR0xJQl9TVVBQT1JUKSBp biBXZWJWaWV3IHRvIGd1YXJkIHRoZSBnbGliIHJ1bmxvb3Agb2JzZXJ2ZXIuCisKKyAgICAgICAg KiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgX2NvbW1vbkluaXRpYWxp emF0aW9uV2l0aEZyYW1lTmFtZTpncm91cE5hbWU6dXNlc0RvY3VtZW50Vmlld3M6XSk6CisgICAg ICAgICgtW1dlYlZpZXcgX2Nsb3NlXSk6CisKIDIwMTAtMDktMjggIEpvaG5ueSBEaW5nICA8am5k QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0t Z2l0IGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0gYi9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViVmlldy5tbQppbmRleCAxZmNhOGQxLi4xMjdkNzIyIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQpA QCAtMTkwLDcgKzE5MCw3IEBACiAjaW1wb3J0IDxXZWJDb3JlL0dlb2xvY2F0aW9uRXJyb3IuaD4K ICNlbmRpZgogCi0jaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQorI2lmIEVOQUJM RShHTElCX1NVUFBPUlQpCiAjaW1wb3J0IDxnbGliLmg+CiAjZW5kaWYKIApAQCAtMzg1LDcgKzM4 NSw3IEBAIHN0YXRpYyBjb25zdCBjaGFyIHdlYlZpZXdJc09wZW5bXSA9ICJBdCBsZWFzdCBvbmUg V2ViVmlldyBpcyBzdGlsbCBvcGVuLiI7CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5H KQogLSAodm9pZClfY2xlYXJMYXllclN5bmNMb29wT2JzZXJ2ZXI7CiAjZW5kaWYKLSNpZiBFTkFC TEUoVklERU8pICYmIFVTRShHU1RSRUFNRVIpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKIC0g KHZvaWQpX2NsZWFyR2xpYkxvb3BPYnNlcnZlcjsKICNlbmRpZgogQGVuZApAQCAtNzUwLDcgKzc1 MCw3IEBAIHN0YXRpYyBib29sIHNob3VsZEVuYWJsZUxvYWREZWZlcnJpbmcoKQogICAgIGlmICgh V2ViS2l0TGlua2VkT25PckFmdGVyKFdFQktJVF9GSVJTVF9WRVJTSU9OX1dJVEhPVVRfQ09OVEVO VF9TTklGRklOR19GT1JfRklMRV9VUkxTKSkKICAgICAgICAgUmVzb3VyY2VIYW5kbGU6OmZvcmNl Q29udGVudFNuaWZmaW5nKCk7CiAKLSNpZiBFTkFCTEUoVklERU8pICYmIFVTRShHU1RSRUFNRVIp CisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICAgICBbc2VsZiBfc2NoZWR1bGVHbGliQ29udGV4 dEl0ZXJhdGlvbnNdOwogI2VuZGlmCiAKQEAgLTExNTEsNyArMTE1MSw3IEBAIHN0YXRpYyBib29s IGZhc3REb2N1bWVudFRlYXJkb3duRW5hYmxlZCgpCiAgICAgW3NlbGYgX2NsZWFyTGF5ZXJTeW5j TG9vcE9ic2VydmVyXTsKICNlbmRpZgogICAgIAotI2lmIEVOQUJMRShWSURFTykgJiYgVVNFKEdT VFJFQU1FUikKKyNpZiBFTkFCTEUoR0xJQl9TVVBQT1JUKQogICAgIFtzZWxmIF9jbGVhckdsaWJM b29wT2JzZXJ2ZXJdOwogI2VuZGlmCiAKQEAgLTU2MzIsNyArNTYzMiw3IEBAIHN0YXRpYyBXZWJG cmFtZVZpZXcgKmNvbnRhaW5pbmdGcmFtZVZpZXcoTlNWaWV3ICp2aWV3KQogfQogI2VuZGlmCiAK LSNpZiBFTkFCTEUoVklERU8pICYmIFVTRShHU1RSRUFNRVIpCisjaWYgRU5BQkxFKEdMSUJfU1VQ UE9SVCkKIC0gKHZvaWQpX2NsZWFyR2xpYkxvb3BPYnNlcnZlcgogewogICAgIGlmICghX3ByaXZh dGUtPmdsaWJSdW5Mb29wT2JzZXJ2ZXIpCkBAIC01OTU1LDcgKzU5NTUsNyBAQCBzdGF0aWMgdm9p ZCBsYXllclN5bmNSdW5Mb29wT2JzZXJ2ZXJDYWxsQmFjayhDRlJ1bkxvb3BPYnNlcnZlclJlZiwg Q0ZSdW5Mb29wQWN0aQogCiAjZW5kaWYKIAotI2lmIEVOQUJMRShWSURFTykgJiYgVVNFKEdTVFJF QU1FUikKKyNpZiBFTkFCTEUoR0xJQl9TVVBQT1JUKQogCiBzdGF0aWMgdm9pZCBnbGliQ29udGV4 dEl0ZXJhdGlvbkNhbGxiYWNrKENGUnVuTG9vcE9ic2VydmVyUmVmLCBDRlJ1bkxvb3BBY3Rpdml0 eSwgdm9pZCopCiB7Ci0tIAoxLjcuMQ== 69181 2010-09-29 05:37:04 -0700 2010-10-05 08:32:39 -0700 proposed patch proposed-patch.patch text/plain 3778 pnormand RnJvbSA3ZTE5ZmVmMTYwMjNlZjNlMDRmMzAxM2M0ZWQyZGM1MzdjNmM5OWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI4IFNlcCAyMDEwIDE3OjQwOjQ5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0L21hYy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tICAg ICAgICB8ICAgMTIgKysrKysrLS0tLS0tCiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEu aCAgICAgfCAgICAyICstCiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0ludGVybmFsLmggfCAg ICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9XZWJLaXQvbWFjL0NoYW5nZUxv ZwppbmRleCBkNzA3NzIwLi5kZGY0YzRmIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL0NoYW5nZUxv ZworKysgYi9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA5LTI5 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjayBmb3IgRU5BQkxFKEdMSUJf U1VQUE9SVCkgaW4gV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDY3ODgKKworICAgICAgICBVc2UgRU5BQkxFKEdMSUJfU1VQUE9SVCkgaW4g V2ViVmlldyB0byBndWFyZCB0aGUgZ2xpYiBydW5sb29wIG9ic2VydmVyLgorCisgICAgICAgICog V2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9jb21tb25Jbml0aWFsaXph dGlvbldpdGhGcmFtZU5hbWU6Z3JvdXBOYW1lOnVzZXNEb2N1bWVudFZpZXdzOl0pOgorICAgICAg ICAoLVtXZWJWaWV3IF9jbG9zZV0pOgorICAgICAgICAqIFdlYlZpZXcvV2ViVmlld0RhdGEuaDoK KyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXdJbnRlcm5hbC5oOgorCiAyMDEwLTA5LTI4ICBKb2hu bnkgRGluZyAgPGpuZEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KaW5kZXggMWZjYThkMS4uMTI3ZDcyMiAxMDA2NDQKLS0t IGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KKysrIGIvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYlZpZXcubW0KQEAgLTE5MCw3ICsxOTAsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9HZW9sb2Nh dGlvbkVycm9yLmg+CiAjZW5kaWYKIAotI2lmIEVOQUJMRShWSURFTykgJiYgVVNFKEdTVFJFQU1F UikKKyNpZiBFTkFCTEUoR0xJQl9TVVBQT1JUKQogI2ltcG9ydCA8Z2xpYi5oPgogI2VuZGlmCiAK QEAgLTM4NSw3ICszODUsNyBAQCBzdGF0aWMgY29uc3QgY2hhciB3ZWJWaWV3SXNPcGVuW10gPSAi QXQgbGVhc3Qgb25lIFdlYlZpZXcgaXMgc3RpbGwgb3Blbi4iOwogI2lmIFVTRShBQ0NFTEVSQVRF RF9DT01QT1NJVElORykKIC0gKHZvaWQpX2NsZWFyTGF5ZXJTeW5jTG9vcE9ic2VydmVyOwogI2Vu ZGlmCi0jaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQorI2lmIEVOQUJMRShHTElC X1NVUFBPUlQpCiAtICh2b2lkKV9jbGVhckdsaWJMb29wT2JzZXJ2ZXI7CiAjZW5kaWYKIEBlbmQK QEAgLTc1MCw3ICs3NTAsNyBAQCBzdGF0aWMgYm9vbCBzaG91bGRFbmFibGVMb2FkRGVmZXJyaW5n KCkKICAgICBpZiAoIVdlYktpdExpbmtlZE9uT3JBZnRlcihXRUJLSVRfRklSU1RfVkVSU0lPTl9X SVRIT1VUX0NPTlRFTlRfU05JRkZJTkdfRk9SX0ZJTEVfVVJMUykpCiAgICAgICAgIFJlc291cmNl SGFuZGxlOjpmb3JjZUNvbnRlbnRTbmlmZmluZygpOwogCi0jaWYgRU5BQkxFKFZJREVPKSAmJiBV U0UoR1NUUkVBTUVSKQorI2lmIEVOQUJMRShHTElCX1NVUFBPUlQpCiAgICAgW3NlbGYgX3NjaGVk dWxlR2xpYkNvbnRleHRJdGVyYXRpb25zXTsKICNlbmRpZgogCkBAIC0xMTUxLDcgKzExNTEsNyBA QCBzdGF0aWMgYm9vbCBmYXN0RG9jdW1lbnRUZWFyZG93bkVuYWJsZWQoKQogICAgIFtzZWxmIF9j bGVhckxheWVyU3luY0xvb3BPYnNlcnZlcl07CiAjZW5kaWYKICAgICAKLSNpZiBFTkFCTEUoVklE RU8pICYmIFVTRShHU1RSRUFNRVIpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKICAgICBbc2Vs ZiBfY2xlYXJHbGliTG9vcE9ic2VydmVyXTsKICNlbmRpZgogCkBAIC01NjMyLDcgKzU2MzIsNyBA QCBzdGF0aWMgV2ViRnJhbWVWaWV3ICpjb250YWluaW5nRnJhbWVWaWV3KE5TVmlldyAqdmlldykK IH0KICNlbmRpZgogCi0jaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQorI2lmIEVO QUJMRShHTElCX1NVUFBPUlQpCiAtICh2b2lkKV9jbGVhckdsaWJMb29wT2JzZXJ2ZXIKIHsKICAg ICBpZiAoIV9wcml2YXRlLT5nbGliUnVuTG9vcE9ic2VydmVyKQpAQCAtNTk1NSw3ICs1OTU1LDcg QEAgc3RhdGljIHZvaWQgbGF5ZXJTeW5jUnVuTG9vcE9ic2VydmVyQ2FsbEJhY2soQ0ZSdW5Mb29w T2JzZXJ2ZXJSZWYsIENGUnVuTG9vcEFjdGkKIAogI2VuZGlmCiAKLSNpZiBFTkFCTEUoVklERU8p ICYmIFVTRShHU1RSRUFNRVIpCisjaWYgRU5BQkxFKEdMSUJfU1VQUE9SVCkKIAogc3RhdGljIHZv aWQgZ2xpYkNvbnRleHRJdGVyYXRpb25DYWxsYmFjayhDRlJ1bkxvb3BPYnNlcnZlclJlZiwgQ0ZS dW5Mb29wQWN0aXZpdHksIHZvaWQqKQogewpkaWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYlZpZXdEYXRhLmggYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEuaAppbmRleCA5 YWE5MWRjLi42MzljM2UwIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0Rh dGEuaAorKysgYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEuaApAQCAtMTcyLDcgKzE3 Miw3IEBAIGV4dGVybiBpbnQgcGx1Z2luRGF0YWJhc2VDbGllbnRDb3VudDsKICAgICBXZWJWaWRl b0Z1bGxzY3JlZW5Db250cm9sbGVyICpmdWxsc2NyZWVuQ29udHJvbGxlcjsKICNlbmRpZgogCi0j aWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQorI2lmIEVOQUJMRShHTElCX1NVUFBP UlQpCiAgICAgQ0ZSdW5Mb29wT2JzZXJ2ZXJSZWYgZ2xpYlJ1bkxvb3BPYnNlcnZlcjsKICNlbmRp ZgogICAgIGlkPFdlYkdlb2xvY2F0aW9uUHJvdmlkZXI+IF9nZW9sb2NhdGlvblByb3ZpZGVyOwpk aWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdJbnRlcm5hbC5oIGIvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXdJbnRlcm5hbC5oCmluZGV4IDcxYTI2NjAuLjBhNmY0NjIgMTAw NjQ0Ci0tLSBhL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3SW50ZXJuYWwuaAorKysgYi9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViVmlld0ludGVybmFsLmgKQEAgLTg4LDcgKzg4LDcgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogLSAodm9pZClfc2NoZWR1bGVDb21wb3NpdGluZ0xheWVyU3luYzsKICNl bmRpZgogCi0jaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQorI2lmIEVOQUJMRShH TElCX1NVUFBPUlQpCiAtICh2b2lkKV9zY2hlZHVsZUdsaWJDb250ZXh0SXRlcmF0aW9uczsKICNl bmRpZgogCi0tIAoxLjcuMQ==