46774 2010-09-28 18:58:05 -0700 Add WKStringIsEqual to the WK2 API 2010-09-30 15:42:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson webkit-unassigned oldest_to_newest 286698 0 beidson 2010-09-28 18:58:05 -0700 Add WKStringIsEqual to the WK2 API 286699 1 69151 beidson 2010-09-28 18:59:28 -0700 Created attachment 69151 Patch 287738 2 69151 cfleizach 2010-09-30 12:36:12 -0700 Comment on attachment 69151 Patch should you check if one or the other string is nil i would expect WKStringIsEqual("blah", nil) to return false and not crash 287885 3 69390 beidson 2010-09-30 15:29:09 -0700 Created attachment 69390 Better, noncrashy fix 287892 4 beidson 2010-09-30 15:42:20 -0700 http://trac.webkit.org/changeset/68844 69151 2010-09-28 18:59:28 -0700 2010-09-30 15:29:09 -0700 Patch 1patch.txt text/plain 1470 beidson SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODYxOSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMjggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njc3NCAtIEFkZCBXS1N0cmlu Z0lzRXF1YWwgQVBJCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tTdHJpbmcuY3BwOgorICAg ICAgICAoV0tTdHJpbmdJc0VxdWFsKToKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tTdHJpbmcu aDoKKwogMjAxMC0wOS0yOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJLaXQyL1NoYXJlZC9B UEkvYy9XS1N0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tT dHJpbmcuY3BwCShyZXZpc2lvbiA2ODYxNykKKysrIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLU3Ry aW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgsMyArMzgsOCBAQCBib29sIFdLU3RyaW5nSXNF bXB0eShXS1N0cmluZ1JlZiBzdHJpbmdSCiB7CiAgICAgcmV0dXJuIHRvV0soc3RyaW5nUmVmKS0+ aXNFbXB0eSgpOwogfQorCitib29sIFdLU3RyaW5nSXNFcXVhbChXS1N0cmluZ1JlZiBmaXJzdFN0 cmluZywgV0tTdHJpbmdSZWYgc2Vjb25kU3RyaW5nKQoreworICAgIHJldHVybiB0b1dLKGZpcnN0 U3RyaW5nKS0+c3RyaW5nKCkgPT0gdG9XSyhzZWNvbmRTdHJpbmcpLT5zdHJpbmcoKTsKK30KSW5k ZXg6IFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLU3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 Mi9TaGFyZWQvQVBJL2MvV0tTdHJpbmcuaAkocmV2aXNpb24gNjg2MTcpCisrKyBXZWJLaXQyL1No YXJlZC9BUEkvYy9XS1N0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw3IEBAIGV4 dGVybiAiQyIgewogV0tfRVhQT1JUIFdLVHlwZUlEIFdLU3RyaW5nR2V0VHlwZUlEKCk7CiAKIFdL X0VYUE9SVCBib29sIFdLU3RyaW5nSXNFbXB0eShXS1N0cmluZ1JlZiBzdHJpbmcpOworV0tfRVhQ T1JUIGJvb2wgV0tTdHJpbmdJc0VxdWFsKFdLU3RyaW5nUmVmIGZpcnN0U3RyaW5nLCBXS1N0cmlu Z1JlZiBzZWNvbmRTdHJpbmcpOwogCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0K 69390 2010-09-30 15:29:09 -0700 2010-09-30 15:30:39 -0700 Better, noncrashy fix patch.txt text/plain 1605 beidson SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODY4NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njc3NCAtIEFkZCBXS1N0cmlu Z0lzRXF1YWwgQVBJCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tTdHJpbmcuY3BwOgorICAg ICAgICAoV0tTdHJpbmdJc0VxdWFsKToKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvV0tTdHJpbmcu aDoKKwogMjAxMC0wOS0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFVwZGF0ZSBleHBlY3RlZCByZXN1bHRzLgpJbmRleDogV2ViS2l0Mi9TaGFyZWQv QVBJL2MvV0tTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dL U3RyaW5nLmNwcAkocmV2aXNpb24gNjg3ODUpCisrKyBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1N0 cmluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4LDMgKzM4LDEzIEBAIGJvb2wgV0tTdHJpbmdJ c0VtcHR5KFdLU3RyaW5nUmVmIHN0cmluZ1IKIHsKICAgICByZXR1cm4gdG9XSyhzdHJpbmdSZWYp LT5pc0VtcHR5KCk7CiB9CisKK2Jvb2wgV0tTdHJpbmdJc0VxdWFsKFdLU3RyaW5nUmVmIGZpcnN0 U3RyaW5nLCBXS1N0cmluZ1JlZiBzZWNvbmRTdHJpbmcpCit7CisgICAgaWYgKGZpcnN0U3RyaW5n ID09IHNlY29uZFN0cmluZykKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgaWYgKCFmaXJzdFN0 cmluZyB8fCAhc2Vjb25kU3RyaW5nKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIAor ICAgIHJldHVybiB0b1dLKGZpcnN0U3RyaW5nKS0+c3RyaW5nKCkgPT0gdG9XSyhzZWNvbmRTdHJp bmcpLT5zdHJpbmcoKTsKK30KSW5kZXg6IFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLU3RyaW5nLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTdHJpbmcuaAkocmV2aXNpb24g Njg3ODUpCisrKyBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1N0cmluZy5oCSh3b3JraW5nIGNvcHkp CkBAIC0zOSw2ICszOSw3IEBAIGV4dGVybiAiQyIgewogV0tfRVhQT1JUIFdLVHlwZUlEIFdLU3Ry aW5nR2V0VHlwZUlEKCk7CiAKIFdLX0VYUE9SVCBib29sIFdLU3RyaW5nSXNFbXB0eShXS1N0cmlu Z1JlZiBzdHJpbmcpOworV0tfRVhQT1JUIGJvb2wgV0tTdHJpbmdJc0VxdWFsKFdLU3RyaW5nUmVm IGZpcnN0U3RyaW5nLCBXS1N0cmluZ1JlZiBzZWNvbmRTdHJpbmcpOwogCiAjaWZkZWYgX19jcGx1 c3BsdXMKIH0K