46771 2010-09-28 18:00:55 -0700 Rename chromium's GraphicsContext3D.cpp to match others. 2010-09-30 00:08:51 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 amarinichev webkit-unassigned cmarrin commit-queue kbr zmo oldest_to_newest 286677 0 amarinichev 2010-09-28 18:00:55 -0700 There are two of those in the webkit tree: WebCore/platform/graphics/GraphicsContext3D.cpp, which implements functions shared by all implementations, and WebKit/chromium/src/GraphicsContext3D.cpp, which implements chromium's version. It would be more consistent and easier to follow, if the first one was renamed to, say, GraphicsContext3DCommon.cpp, and the second to GraphicsContext3DChromium.cpp. 286682 1 69148 amarinichev 2010-09-28 18:23:22 -0700 Created attachment 69148 Patch 286686 2 69148 kbr 2010-09-28 18:35:41 -0700 Comment on attachment 69148 Patch You need to take into consideration that platform/graphics/GraphicsContext3D.cpp is currently compiled in to all platforms. You will minimally need to also modify WebCore/WebCore.xcodeproj/project.pbxproj . I don't know whether you need to strictly make this modification in Xcode or whether you can do it in a text editor. You should also do a recursive grep on all flat files in the WebKit workspace to see where else this file name is referenced. Since the bots apparently can't build on Mac unless you're a WebKit committer I strongly suggest testing your build modifications on Mac OS X -- or your reviewer will need to do so for safety. 286710 3 69148 cmarrin 2010-09-28 19:42:39 -0700 Comment on attachment 69148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69148&action=review > WebCore/ChangeLog:10 > + * platform/graphics/GraphicsContext3DCommon.cpp: Renamed from WebCore/platform/graphics/GraphicsContext3D.cpp. I'm very much against this renaming. We have many places where we use the current naming convention: GraphicsLayer, GraphicsContext, FloatRect, and virtually every other "common" file in platoform/graphics, as well as other platform specific code throughout the tree. Yes, the Chromium specific version should be renamed, but please do not change the name of the above file 287012 4 amarinichev 2010-09-29 11:25:15 -0700 Ouch. Won't touch WebCore. 287013 5 69229 amarinichev 2010-09-29 11:25:37 -0700 Created attachment 69229 Patch 287090 6 69229 kbr 2010-09-29 13:25:53 -0700 Comment on attachment 69229 Patch Looks fine. Assuming you've built this locally to test. 287399 7 69229 commit-queue 2010-09-30 00:08:46 -0700 Comment on attachment 69229 Patch Clearing flags on attachment: 69229 Committed r68759: <http://trac.webkit.org/changeset/68759> 287400 8 commit-queue 2010-09-30 00:08:51 -0700 All reviewed patches have been landed. Closing bug. 69148 2010-09-28 18:23:22 -0700 2010-09-29 11:25:33 -0700 Patch bug-46771-20100928182321.patch text/plain 3684 amarinichev ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTZmYThkM2JmYWE1MGNkZDk5Zjk3YTE1YmY4MmEwNjY2NjYzNTk5OS4uMzQ5NTI5MDBmYzI4MTk1 NzgyYjk5YzQyYjk5ODZkYjA3Y2Q2MDg5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOS0yOCAgQWxl eGV5IE1hcmluaWNoZXYgIDxhbWFyaW5pY2hldkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0M0QuY3Bw IGZpbGVzIGFyZSBjb25mdXNpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ2NzcxCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAgICAgICog V2ViQ29yZS5wcm86CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0 M0RDb21tb24uY3BwOiBSZW5hbWVkIGZyb20gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFw aGljc0NvbnRleHQzRC5jcHAuCisKIDIwMTAtMDktMjcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJl dmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2 ODM4OS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5neXBpIGIvV2ViQ29yZS9XZWJDb3Jl Lmd5cGkKaW5kZXggY2E2NTVkNTRmODExODYzNDlmNDZjNTI3Mzg2MjQ5ZTJmOTBkMWExNC4uYTYx YTAyZjAxZDEyMjdjZjkzOTViN2M1NDI4Zjc3MTFlYjExNDA4YyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9XZWJDb3JlLmd5cGkKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkKQEAgLTI2NTMsNyArMjY1 Myw3IEBACiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaCcsCiAgICAg ICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcCcsCiAgICAgICAg ICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgnLAotICAgICAgICAgICAg J3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcCcsCisgICAgICAgICAgICAn cGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RDb21tb24uY3BwJywKICAgICAgICAg ICAgICdwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oJywKICAgICAgICAgICAg ICdwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHRQcml2YXRlLmgnLAogICAgICAgICAg ICAgJ3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3BwJywKZGlmZiAtLWdpdCBhL1dl YkNvcmUvV2ViQ29yZS5wcm8gYi9XZWJDb3JlL1dlYkNvcmUucHJvCmluZGV4IDkzMDc2ZDY4ZWRi NmUwMjNkNDU4YzMxMjI2YWY2NWU0M2Q2NjA4NjUuLjEyNjE5YjJhYWRhNTM2ODdkOGUxZmU4NTAw ZjM5YzQ1OGM3ZjdmOTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5wcm8KKysrIGIvV2Vi Q29yZS9XZWJDb3JlLnBybwpAQCAtMzU4NCw3ICszNTg0LDcgQEAgU09VUkNFUyArPSBcCiAgICAg ICAgIGh0bWwvY2FudmFzL1VpbnQ4QXJyYXkuY3BwIFwKICAgICAgICAgaHRtbC9jYW52YXMvVWlu dDMyQXJyYXkuY3BwIFwKICAgICAgICAgaHRtbC9jYW52YXMvVWludDE2QXJyYXkuY3BwIFwKLSAg ICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwIFwKKyAgICAgICAg cGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RDb21tb24uY3BwIFwKICAgICAgICAg cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKIAogfQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNEQ29tbW9uLmNwcApzaW1p bGFyaXR5IGluZGV4IDEwMCUKcmVuYW1lIGZyb20gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQzRC5jcHAKcmVuYW1lIHRvIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0M0RDb21tb24uY3BwCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAyNDg5ZGRlNjI0Njk2 MzE4M2JiOGE3ZjMyNzZlMDc4OWU3MmI4ZGNhLi4xYzQzMjMxOTU0Nzk4OTRhMzI1MmZjMjRiNmUx MTM4MDBhMjM1OGExIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBi L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOS0yOCAg QWxleGV5IE1hcmluaWNoZXYgIDxhbWFyaW5pY2hldkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0M0Qu Y3BwIGZpbGVzIGFyZSBjb25mdXNpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ2NzcxCisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorICAgICAgICAq IHNyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcDogUmVuYW1lZCBmcm9tIFdlYktpdC9j aHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwLgorCiAyMDEwLTA5LTI3ICBLaW51a28g WWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9XZWJLaXQv Y2hyb21pdW0vV2ViS2l0Lmd5cAppbmRleCA1NGE2NDNiMmFmOWU1MDMwNWM0MDczYjNlNmM3YTlk N2Q2MmY0OWJkLi45ODIwNmMxZDljMzhlMDFiMDE1NmYwZThjNTdhMTQ5ODc1MTdjOWM4IDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9XZWJLaXQvY2hyb21pdW0v V2ViS2l0Lmd5cApAQCAtMzIyLDcgKzMyMiw3IEBACiAgICAgICAgICAgICAgICAgJ3NyYy9GcmFt ZUxvYWRlckNsaWVudEltcGwuY3BwJywKICAgICAgICAgICAgICAgICAnc3JjL0ZyYW1lTG9hZGVy Q2xpZW50SW1wbC5oJywKICAgICAgICAgICAgICAgICAnc3JjL0ZyYW1lTmV0d29ya2luZ0NvbnRl eHRJbXBsLmgnLAotICAgICAgICAgICAgICAgICdzcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwJywK KyAgICAgICAgICAgICAgICAnc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwJywKICAg ICAgICAgICAgICAgICAnc3JjL0dyYXBoaWNzQ29udGV4dDNESW50ZXJuYWwuaCcsCiAgICAgICAg ICAgICAgICAgJ3NyYy9ndGsvV2ViRm9udEluZm8uY3BwJywKICAgICAgICAgICAgICAgICAnc3Jj L2d0ay9XZWJGb250SW5mby5oJywKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvR3Jh cGhpY3NDb250ZXh0M0QuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQz RENocm9taXVtLmNwcApzaW1pbGFyaXR5IGluZGV4IDEwMCUKcmVuYW1lIGZyb20gV2ViS2l0L2No cm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRC5jcHAKcmVuYW1lIHRvIFdlYktpdC9jaHJvbWl1 bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAK 69229 2010-09-29 11:25:37 -0700 2010-09-30 00:08:45 -0700 Patch bug-46771-20100929112536.patch text/plain 1562 amarinichev ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDI0ODlkZGU2MjQ2OTYzMTgzYmI4YTdmMzI3NmUwNzg5ZTcyYjhkY2Eu LjhiYTI4YzBlNmM1NjJkMjE0Mjc1MzE1N2E2ZDljZGNkMjUxODFlMGQgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTA5LTI4ICBBbGV4ZXkgTWFyaW5pY2hldiAgPGFtYXJpbmlj aGV2QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW5hbWUgY2hyb21pdW0ncyBHcmFwaGljc0NvbnRleHQzRC5jcHAgdG8gbWF0 Y2ggb3RoZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDY3NzEKKworICAgICAgICAqIFdlYktpdC5neXA6CisgICAgICAgICogc3JjL0dyYXBoaWNz Q29udGV4dDNEQ2hyb21pdW0uY3BwOiBSZW5hbWVkIGZyb20gV2ViS2l0L2Nocm9taXVtL3NyYy9H cmFwaGljc0NvbnRleHQzRC5jcHAuCisKIDIwMTAtMDktMjcgIEtpbnVrbyBZYXN1ZGEgIDxraW51 a29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYg LS1naXQgYS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cCBiL1dlYktpdC9jaHJvbWl1bS9XZWJL aXQuZ3lwCmluZGV4IDU0YTY0M2IyYWY5ZTUwMzA1YzQwNzNiM2U2YzdhOWQ3ZDYyZjQ5YmQuLjk4 MjA2YzFkOWMzOGUwMWIwMTU2ZjBlOGM1N2ExNDk4NzUxN2M5YzggMTAwNjQ0Ci0tLSBhL1dlYktp dC9jaHJvbWl1bS9XZWJLaXQuZ3lwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBA IC0zMjIsNyArMzIyLDcgQEAKICAgICAgICAgICAgICAgICAnc3JjL0ZyYW1lTG9hZGVyQ2xpZW50 SW1wbC5jcHAnLAogICAgICAgICAgICAgICAgICdzcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmgn LAogICAgICAgICAgICAgICAgICdzcmMvRnJhbWVOZXR3b3JraW5nQ29udGV4dEltcGwuaCcsCi0g ICAgICAgICAgICAgICAgJ3NyYy9HcmFwaGljc0NvbnRleHQzRC5jcHAnLAorICAgICAgICAgICAg ICAgICdzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAnLAogICAgICAgICAgICAgICAg ICdzcmMvR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbC5oJywKICAgICAgICAgICAgICAgICAnc3Jj L2d0ay9XZWJGb250SW5mby5jcHAnLAogICAgICAgICAgICAgICAgICdzcmMvZ3RrL1dlYkZvbnRJ bmZvLmgnLApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQz RC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3Bw CnNpbWlsYXJpdHkgaW5kZXggMTAwJQpyZW5hbWUgZnJvbSBXZWJLaXQvY2hyb21pdW0vc3JjL0dy YXBoaWNzQ29udGV4dDNELmNwcApyZW5hbWUgdG8gV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGlj c0NvbnRleHQzRENocm9taXVtLmNwcAo=