46769 2010-09-28 17:06:28 -0700 Bundle should expose a reportException method 2010-10-07 07:59:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jberlin jberlin jberlin sam oldest_to_newest 286643 0 jberlin 2010-09-28 17:06:28 -0700 There should be a WKBundleReportException analogous to WebView::reportException. 290619 1 jberlin 2010-10-06 15:32:04 -0700 <rdar://problem/8521276> 290748 2 70023 jberlin 2010-10-06 18:32:20 -0700 Created attachment 70023 Add InjectedBundle::reportException 290788 3 70023 sullivan 2010-10-06 21:11:30 -0700 Comment on attachment 70023 Add InjectedBundle::reportException View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review > WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232 > + // Make sure the context has a DOMWindow global object, otherwise this context didn't originate from a View. I'm not sure if View with a capital V refers to a class or a named concept. Maybe this comment could be improved. 290955 4 jberlin 2010-10-07 06:04:36 -0700 (In reply to comment #3) > (From update of attachment 70023 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70023&action=review > > > WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:232 > > + // Make sure the context has a DOMWindow global object, otherwise this context didn't originate from a View. > > I'm not sure if View with a capital V refers to a class or a named concept. Maybe this comment could be improved. You are right, when we are talking in WebKit2 terms that should be a Page. In WebKit1 terms that is a WebView. I will correct the comment. Thanks for the review! Jessie 291013 5 70023 jberlin 2010-10-07 07:59:13 -0700 Comment on attachment 70023 Add InjectedBundle::reportException Comitted in r69309 http://trac.webkit.org/changeset/69309 70023 2010-10-06 18:32:20 -0700 2010-10-07 07:59:13 -0700 Add InjectedBundle::reportException addBundleReportException.patch text/plain 3900 jberlin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTI2NSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMDYgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dW5kbGUgc2hvdWxkIGV4cG9zZSBhIHJlcG9ydEV4Y2VwdGlvbiBtZXRob2QuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njc2OQorCisgICAgICAgICog V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZS5jcHA6CisgICAgICAgIChX S0J1bmRsZVJlcG9ydEV4Y2VwdGlvbik6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvYy9XS0J1bmRsZS5oOgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxl OjpyZXBvcnRFeGNlcHRpb24pOgorICAgICAgICBNaW1pYyB0aGUgYmVoYXZpb3Igb2YgV2ViVmll dzo6cmVwb3J0RXhjZXB0aW9uLgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv SW5qZWN0ZWRCdW5kbGUuaDoKKwogMjAxMC0xMC0wNiAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpz QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4uCkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRC dW5kbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9JbmplY3RlZEJ1bmRsZS5jcHAJKHJldmlzaW9uIDY5MjMwKQorKysgV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzcsNiArMzcsNyBAQAogI2luY2x1ZGUgIldlYlBhZ2UuaCIKICNpbmNsdWRlICJXZWJQcmVmZXJl bmNlc1N0b3JlLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgorI2luY2x1ZGUgPEphdmFTY3Jp cHRDb3JlL0FQSUNhc3QuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0xvY2suaD4KICNp bmNsdWRlIDxXZWJDb3JlL0dDQ29udHJvbGxlci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvSlNET01X aW5kb3cuaD4KQEAgLTIyMCw0ICsyMjEsMTkgQEAgdm9pZCBJbmplY3RlZEJ1bmRsZTo6ZGlkUmVj ZWl2ZU1lc3NhZ2UoQwogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCit2b2lkIEluamVj dGVkQnVuZGxlOjpyZXBvcnRFeGNlcHRpb24oSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTVmFsdWVS ZWYgZXhjZXB0aW9uKQoreworICAgIGlmICghY29udGV4dCB8fCAhZXhjZXB0aW9uKQorICAgICAg ICByZXR1cm47CisKKyAgICBKU0xvY2sgbG9jayhKU0M6OlNpbGVuY2VBc3NlcnRpb25zT25seSk7 CisgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWNTdGF0ZSA9IHRvSlMoY29udGV4dCk7CisKKyAgICAv LyBNYWtlIHN1cmUgdGhlIGNvbnRleHQgaGFzIGEgRE9NV2luZG93IGdsb2JhbCBvYmplY3QsIG90 aGVyd2lzZSB0aGlzIGNvbnRleHQgZGlkbid0IG9yaWdpbmF0ZSBmcm9tIGEgVmlldy4KKyAgICBp ZiAoIXRvSlNET01XaW5kb3coZXhlY1N0YXRlLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCkpKQorICAg ICAgICByZXR1cm47CisKKyAgICBXZWJDb3JlOjpyZXBvcnRFeGNlcHRpb24oZXhlY1N0YXRlLCB0 b0pTKGV4ZWNTdGF0ZSwgZXhjZXB0aW9uKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJ bmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVk QnVuZGxlLmgJKHJldmlzaW9uIDY5MjMwKQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVk QnVuZGxlL0luamVjdGVkQnVuZGxlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNSw2ICsxMDUsOCBA QCBwdWJsaWM6CiAKICAgICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rp b24qLCBDb3JlSVBDOjpNZXNzYWdlSUQsIENvcmVJUEM6OkFyZ3VtZW50RGVjb2RlciopOwogCisg ICAgc3RhdGljIHZvaWQgcmVwb3J0RXhjZXB0aW9uKEpTQ29udGV4dFJlZiwgSlNWYWx1ZVJlZiBl eGNlcHRpb24pOworCiBwcml2YXRlOgogICAgIEluamVjdGVkQnVuZGxlKGNvbnN0IFN0cmluZyYp OwogCkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvYy9XS0J1bmRsZS5jcHAJKHJldmlzaW9uIDY5MjMwKQorKysgV2ViS2l0Mi9XZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI2 LDMgKzEyNiw4IEBAIHZvaWQgV0tCdW5kbGVPdmVycmlkZVhTU0F1ZGl0b3JFbmFibGVkRm8KIHsK ICAgICB0b0ltcGwoYnVuZGxlUmVmKS0+b3ZlcnJpZGVYU1NBdWRpdG9yRW5hYmxlZEZvclRlc3RS dW5uZXIoZW5hYmxlZCk7CiB9CisKK3ZvaWQgV0tCdW5kbGVSZXBvcnRFeGNlcHRpb24oSlNDb250 ZXh0UmVmIGNvbnRleHQsIEpTVmFsdWVSZWYgZXhjZXB0aW9uKQoreworICAgIEluamVjdGVkQnVu ZGxlOjpyZXBvcnRFeGNlcHRpb24oY29udGV4dCwgZXhjZXB0aW9uKTsKK30KSW5kZXg6IFdlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZS5oCShy ZXZpc2lvbiA2OTIzMCkKKysrIFdlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkv Yy9XS0J1bmRsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIFdL QnVuZGxlX2gKICNkZWZpbmUgV0tCdW5kbGVfaAogCisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUv SmF2YVNjcmlwdC5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tCYXNlLmg+CiAKICNpZmRlZiBfX2Nw bHVzcGx1cwpAQCAtNTMsNiArNTQsOCBAQCBXS19FWFBPUlQgdm9pZCBXS0J1bmRsZVNldENsaWVu dChXS0J1bmRsCiBXS19FWFBPUlQgdm9pZCBXS0J1bmRsZVBvc3RNZXNzYWdlKFdLQnVuZGxlUmVm IGJ1bmRsZSwgV0tTdHJpbmdSZWYgbWVzc2FnZU5hbWUsIFdLVHlwZVJlZiBtZXNzYWdlQm9keSk7 CiBXS19FWFBPUlQgdm9pZCBXS0J1bmRsZVBvc3RTeW5jaHJvbm91c01lc3NhZ2UoV0tCdW5kbGVS ZWYgYnVuZGxlLCBXS1N0cmluZ1JlZiBtZXNzYWdlTmFtZSwgV0tUeXBlUmVmIG1lc3NhZ2VCb2R5 LCBXS1R5cGVSZWYqIHJldHVybkRhdGEpOwogCitXS19FWFBPUlQgdm9pZCBXS0J1bmRsZVJlcG9y dEV4Y2VwdGlvbihKU0NvbnRleHRSZWYsIEpTVmFsdWVSZWYgZXhjZXB0aW9uKTsKKwogI2lmZGVm IF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK