46762 2010-09-28 15:59:55 -0700 WebKit.gyp always builds as static_library, breaking shared chromium builds 2010-10-04 21:22:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mattm webkit-unassigned commit-queue dglazkov fishd yaar oldest_to_newest 286601 0 mattm 2010-09-28 15:59:55 -0700 WebKit gets unconditionally built statically, regardless what the library setting of Chromium build is. Since libwebkit is linked in multiple libraries in chrome, this causes issues with initializers and finalizers getting called multiple times. Building webkit as a shared library fixes this issue. I saw http://trac.webkit.org/changeset/50985 which changed it to be built statically under chromium and shared otherwise, and http://trac.webkit.org/changeset/53001 which caused it to always be built statically. The reasoning isn't entirely clear to me, but it seems that, at least when building under chromium, we should just use the <(library) setting to build webkit. Chromium bugs caused by this: http://code.google.com/p/chromium/issues/detail?id=47575 http://code.google.com/p/chromium/issues/detail?id=47979 286607 1 69124 mattm 2010-09-28 16:05:48 -0700 Created attachment 69124 use 'webkit_target_type': '<(library)' when inside_chromium_build 287065 2 69124 commit-queue 2010-09-29 12:33:57 -0700 Comment on attachment 69124 use 'webkit_target_type': '<(library)' when inside_chromium_build Rejecting patch 69124 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69124]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69124&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=46762&ctype=xml Processing 1 patch from 1 bug. Processing patch 69124 from bug 46762. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4225010 287164 3 69259 mattm 2010-09-29 15:25:14 -0700 Created attachment 69259 Patch 287167 4 mattm 2010-09-29 15:28:29 -0700 I think that failed because the patch didn't have full paths, since I just generated it from a regular chromium checkout. Generated a new patch using a full webkit checkout, hopefully this one will work correctly. 289119 5 mattm 2010-10-04 13:51:43 -0700 ping, mind taking another quick look? 289394 6 69259 commit-queue 2010-10-04 21:21:54 -0700 Comment on attachment 69259 Patch Clearing flags on attachment: 69259 Committed r69067: <http://trac.webkit.org/changeset/69067> 289395 7 commit-queue 2010-10-04 21:22:01 -0700 All reviewed patches have been landed. Closing bug. 69124 2010-09-28 16:05:48 -0700 2010-09-29 15:25:10 -0700 use 'webkit_target_type': '<(library)' when inside_chromium_build webkit-46762.diff text/plain 1850 mattm SW5kZXg6IFdlYktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Lmd5cAkocmV2aXNpb24gNjg1 MDQpCisrKyBXZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw2IEBACiAgICAg ICAgICdmZWF0dXJlcy5neXBpJywKICAgICBdLAogICAgICd2YXJpYWJsZXMnOiB7Ci0gICAgICAg ICd3ZWJraXRfdGFyZ2V0X3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAogICAgICAgICAnY29uZGl0 aW9ucyc6IFsKICAgICAgICAgICAgICMgTG9jYXRpb24gb2YgdGhlIGNocm9taXVtIHNyYyBkaXJl Y3RvcnkgYW5kIHRhcmdldCB0eXBlIGlzIGRpZmZlcmVudAogICAgICAgICAgICAgIyBpZiB3ZWJr aXQgaXMgYnVpbHQgaW5zaWRlIGNocm9taXVtIG9yIGFzIHN0YW5kYWxvbmUgcHJvamVjdC4KQEAg LTQ0LDYgKzQzLDcgQEAKICAgICAgICAgICAgICAgICAjIFdlYmtpdCBpcyBiZWluZyBidWlsdCBv dXRzaWRlIG9mIHRoZSBmdWxsIGNocm9taXVtIHByb2plY3QuCiAgICAgICAgICAgICAgICAgIyBl LmcuIHZpYSBidWlsZC13ZWJraXQgLS1jaHJvbWl1bQogICAgICAgICAgICAgICAgICdjaHJvbWl1 bV9zcmNfZGlyJzogJy4uLy4uL1dlYktpdC9jaHJvbWl1bScsCisgICAgICAgICAgICAgICAgJ3dl YmtpdF90YXJnZXRfdHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCiAKICAgICAgICAgICAgICAgICAj IExpc3Qgb2YgRGV2VG9vbHMgc291cmNlIGZpbGVzLCBvcmRlcmVkIGJ5IGRlcGVuZGVuY2llcy4g SXQgaXMgdXNlZCBib3RoCiAgICAgICAgICAgICAgICAgIyBmb3IgY29weWluZyB0aGVtIHRvIHJl c291cmNlIGRpciwgYW5kIGZvciBnZW5lcmF0aW5nICdkZXZ0b29scy5odG1sJyBmaWxlLgpAQCAt NTQsNiArNTQsNyBAQAogICAgICAgICAgICAgfSx7CiAgICAgICAgICAgICAgICAgIyBXZWJLaXQg aXMgY2hlY2tlZCBvdXQgaW4gc3JjL2Nocm9taXVtL3RoaXJkX3BhcnR5L1dlYktpdAogICAgICAg ICAgICAgICAgICdjaHJvbWl1bV9zcmNfZGlyJzogJy4uLy4uLy4uLy4uJywKKyAgICAgICAgICAg ICAgICAnd2Via2l0X3RhcmdldF90eXBlJzogJzwobGlicmFyeSknLAogCiAgICAgICAgICAgICAg ICAgJ2RldnRvb2xzX2ZpbGVzJzogWwogICAgICAgICAgICAgICAgICAgICAnPEAoZGV2dG9vbHNf Y3NzX2ZpbGVzKScsCkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShy ZXZpc2lvbiA2ODU5MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEwLTA5LTI4ICBNYXR0IE11ZWxsZXIgIDxtYXR0bUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBidWlsZGlu ZyB1bmRlciBjaHJvbWl1bSwgYnVpbGQgbGlid2Via2l0IGFzIHRoZSBzYW1lIHR5cGUgKHNoYXJl ZAorICAgICAgICBvciBzdGF0aWMpIGFzIGNocm9taXVtLiAgRml4ZXMgcHJvYmxlbXMgd2l0aCBt dWx0aXBsZSBjYWxscyB0byBnbG9iYWwKKyAgICAgICAgaW5pdGlhbGl6ZXJzL2ZpbmFsaXplcnMg aW4gc2hhcmVkIGNocm9taXVtIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDY3NjIKKworICAgICAgICAqIFdlYktpdC5neXA6CisKIDIwMTAt MDktMjggIEplbm4gQnJhaXRod2FpdGUgIDxqZW5uYkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92Lgo= 69259 2010-09-29 15:25:14 -0700 2010-10-04 21:21:54 -0700 Patch bug-46762-20100929152513.patch text/plain 2010 mattm ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGY3ZjE2ZDM0NDZiOTllNmYwNzMxYTI4Mjk1OWNjMGMyMzcwNWI2MzMu LjVjMWIxZWFmYjU1NmUxODgxMjZkOTA2NTY4MmM2OWRjMWJmNjZiODEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDEwLTA5LTI4ICBNYXR0IE11ZWxsZXIgIDxtYXR0bUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiBidWlsZGluZyB1bmRlciBjaHJvbWl1bSwgYnVpbGQgbGlid2Via2l0IGFzIHRoZSBzYW1l IHR5cGUgKHNoYXJlZAorICAgICAgICBvciBzdGF0aWMpIGFzIGNocm9taXVtLiAgRml4ZXMgcHJv YmxlbXMgd2l0aCBtdWx0aXBsZSBjYWxscyB0byBnbG9iYWwKKyAgICAgICAgaW5pdGlhbGl6ZXJz L2ZpbmFsaXplcnMgaW4gc2hhcmVkIGNocm9taXVtIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY3NjIKKworICAgICAgICAqIFdlYktpdC5n eXA6CisKIDIwMTAtMDktMjkgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS9XZWJLaXQuZ3lwIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXggYWY1OWMz MjI4NDRmZmJjZjgyNDk0Yzc4OWVkNjI3MmViZjIwNDNkYy4uZWUxNDVjMjI1N2JkZDU5ODM5ODQz NjU0YzU3MWZiZWUyMDNkZjRmNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5n eXAKKysrIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKQEAgLTM2LDcgKzM2LDYgQEAKICAg ICAgICAgJ2ZlYXR1cmVzLmd5cGknLAogICAgIF0sCiAgICAgJ3ZhcmlhYmxlcyc6IHsKLSAgICAg ICAgJ3dlYmtpdF90YXJnZXRfdHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCiAgICAgICAgICdjb25k aXRpb25zJzogWwogICAgICAgICAgICAgIyBMb2NhdGlvbiBvZiB0aGUgY2hyb21pdW0gc3JjIGRp cmVjdG9yeSBhbmQgdGFyZ2V0IHR5cGUgaXMgZGlmZmVyZW50CiAgICAgICAgICAgICAjIGlmIHdl YmtpdCBpcyBidWlsdCBpbnNpZGUgY2hyb21pdW0gb3IgYXMgc3RhbmRhbG9uZSBwcm9qZWN0LgpA QCAtNDQsNiArNDMsNyBAQAogICAgICAgICAgICAgICAgICMgV2Via2l0IGlzIGJlaW5nIGJ1aWx0 IG91dHNpZGUgb2YgdGhlIGZ1bGwgY2hyb21pdW0gcHJvamVjdC4KICAgICAgICAgICAgICAgICAj IGUuZy4gdmlhIGJ1aWxkLXdlYmtpdCAtLWNocm9taXVtCiAgICAgICAgICAgICAgICAgJ2Nocm9t aXVtX3NyY19kaXInOiAnLi4vLi4vV2ViS2l0L2Nocm9taXVtJywKKyAgICAgICAgICAgICAgICAn d2Via2l0X3RhcmdldF90eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKIAogICAgICAgICAgICAgICAg ICMgTGlzdCBvZiBEZXZUb29scyBzb3VyY2UgZmlsZXMsIG9yZGVyZWQgYnkgZGVwZW5kZW5jaWVz LiBJdCBpcyB1c2VkIGJvdGgKICAgICAgICAgICAgICAgICAjIGZvciBjb3B5aW5nIHRoZW0gdG8g cmVzb3VyY2UgZGlyLCBhbmQgZm9yIGdlbmVyYXRpbmcgJ2RldnRvb2xzLmh0bWwnIGZpbGUuCkBA IC01NCw2ICs1NCw3IEBACiAgICAgICAgICAgICB9LHsKICAgICAgICAgICAgICAgICAjIFdlYktp dCBpcyBjaGVja2VkIG91dCBpbiBzcmMvY2hyb21pdW0vdGhpcmRfcGFydHkvV2ViS2l0CiAgICAg ICAgICAgICAgICAgJ2Nocm9taXVtX3NyY19kaXInOiAnLi4vLi4vLi4vLi4nLAorICAgICAgICAg ICAgICAgICd3ZWJraXRfdGFyZ2V0X3R5cGUnOiAnPChsaWJyYXJ5KScsCiAKICAgICAgICAgICAg ICAgICAnZGV2dG9vbHNfZmlsZXMnOiBbCiAgICAgICAgICAgICAgICAgICAgICc8QChkZXZ0b29s c19jc3NfZmlsZXMpJywK