46759 2010-09-28 15:50:36 -0700 Implement showModalDialog for Layout tests for chromium port 2010-10-11 18:39:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 prasadt webkit-unassigned commit-queue oldest_to_newest 286591 0 prasadt 2010-09-28 15:50:36 -0700 This is related to the bug - https://bugs.webkit.org/show_bug.cgi?id=35350 291954 1 70315 prasadt 2010-10-08 16:38:37 -0700 Created attachment 70315 Implement showModalDialog in DRT for chromium port. 292572 2 70315 dimich 2010-10-11 11:21:13 -0700 Comment on attachment 70315 Implement showModalDialog in DRT for chromium port. r=me 292818 3 70315 commit-queue 2010-10-11 18:39:32 -0700 Comment on attachment 70315 Implement showModalDialog in DRT for chromium port. Clearing flags on attachment: 70315 Committed r69550: <http://trac.webkit.org/changeset/69550> 292819 4 commit-queue 2010-10-11 18:39:37 -0700 All reviewed patches have been landed. Closing bug. 70315 2010-10-08 16:38:37 -0700 2010-10-11 18:39:32 -0700 Implement showModalDialog in DRT for chromium port. smd_upload.txt text/plain 4058 prasadt ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZmFlMjk0Li42ZTBiODNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAt MDggIFByYXNhZCBUYW1tYW5hICA8cHJhc2FkdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgc3VwcG9ydCBmb3Igc2hv d01vZGFsRGlhbG9nIG9uIGNocm9taXVtIHBvcnQuCisKKyAgICAgICAgSW1wbGVtZW50IHNob3dN b2RhbERpYWxvZyBmb3IgTGF5b3V0IHRlc3RzIGZvciBjaHJvbWl1bSBwb3J0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Njc1OQorCisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQ6ICBSZW1vdmVkIHNob3ctbW9k YWwtZGlhbG9nIHRlc3RzLgorCiAyMDEwLTEwLTA4ICBBbGJlcnQgSi4gV29uZyAgPGFqd29uZ0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1VucmV2aWV3ZWRdIENocm9taXVtIGJ1aWxkIGZpeC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2RydF9leHBlY3RhdGlv bnMudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50 eHQKaW5kZXggMGI3MzRlMC4uNzljOTkyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vZHJ0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTYzLDEwICs2Myw2IEBAIEJVR19E UlQgTElOVVggOiBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC8wMDMuaHRtbCA9IElNQUdFCiAvLyBD SksgY2hhcmFjdGVycyBhcmUgbm90IHJvdGF0ZWQuCiBCVUdfRFJUIExJTlVYIDogc3ZnL2JhdGlr L3RleHQvdmVydGljYWxUZXh0LnN2ZyA9IElNQUdFK1RFWFQKIAotLy8gTmVlZCBtb2RhbCBkaWFs b2cgc3VwcG9ydC4KLUJVR19EUlQgV0lOIDogZmFzdC9ldmVudHMvc2hvdy1tb2RhbC1kaWFsb2ct b25ibHVyLW9uZm9jdXMuaHRtbCA9IFRFWFQKLUJVR19EUlQgV0lOIDogZmFzdC9oYXJuZXNzL3No b3ctbW9kYWwtZGlhbG9nLmh0bWwgPSBURVhUCi0KIC8vIFRoaXMgaXMgYW4gZXJyb3Igd2hpY2gg dGVzdF9zaGVsbCBjYW4ndCBmaW5kLgogQlVHV0s0Mzk2MCBXSU4gTUFDIExJTlVYIDogc2Nyb2xs YmFycy9jdXN0b20tc2Nyb2xsYmFyLXdpdGgtaW5jb21wbGV0ZS1zdHlsZS5odG1sID0gSU1BR0UK IApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCmluZGV4IDk1MmUwNjEuLjc2YzA4ZDAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0x MC0wOCAgUHJhc2FkIFRhbW1hbmEgIDxwcmFzYWR0QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBzdXBwb3J0IGZvciBz aG93TW9kYWxEaWFsb2cgb24gY2hyb21pdW0gcG9ydC4KKworICAgICAgICBJbXBsZW1lbnQgc2hv d01vZGFsRGlhbG9nIGZvciBMYXlvdXQgdGVzdHMgZm9yIGNocm9taXVtIHBvcnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NzU5CisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHA6CisgICAgICAgIChXZWJW aWV3SG9zdDo6Y2xvc2VXaWRnZXRTb29uKTogUXVpdCBjdXJyZW50IG1lc3NhZ2UgbG9vcCBpZiBp biBhIG1vZGFsIGxvb3AuCisgICAgICAgIChXZWJWaWV3SG9zdDo6cnVuTW9kYWwpOiAgU3RhcnQg YSBuZXN0ZWQgbWVzc2FnZSBsb29wIGFuZCByZW1lbWJlciB0aGF0LgorICAgICAgICAoV2ViVmll d0hvc3Q6OldlYlZpZXdIb3N0KTogIEluaXRpYWxpemUgbV9pbk1vZGFsTG9vcC4KKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oOiAgQWRkIG1faW5Nb2RhbExv b3AuCisKIDIwMTAtMTAtMDggIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCmluZGV4IGNiMTQzOTMuLjAzMTY3ZWYg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdI b3N0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3 SG9zdC5jcHAKQEAgLTYzNSw2ICs2MzUsMTAgQEAgdm9pZCBXZWJWaWV3SG9zdDo6Y2xvc2VXaWRn ZXRTb29uKCkKIHsKICAgICBtX2hhc1dpbmRvdyA9IGZhbHNlOwogICAgIG1fc2hlbGwtPmNsb3Nl V2luZG93KHRoaXMpOworICAgIGlmIChtX2luTW9kYWxMb29wKSB7CisgICAgICBtX2luTW9kYWxM b29wID0gZmFsc2U7CisgICAgICB3ZWJraXRfc3VwcG9ydDo6UXVpdE1lc3NhZ2VMb29wKCk7Cisg ICAgfQogfQogCiB2b2lkIFdlYlZpZXdIb3N0OjpkaWRDaGFuZ2VDdXJzb3IoY29uc3QgV2ViQ3Vy c29ySW5mbyYgY3Vyc29ySW5mbykKQEAgLTY3Nyw3ICs2ODEsMTEgQEAgV2ViUmVjdCBXZWJWaWV3 SG9zdDo6d2luZG93UmVzaXplclJlY3QoKQogCiB2b2lkIFdlYlZpZXdIb3N0OjpydW5Nb2RhbCgp CiB7Ci0gICAgLy8gRklYTUU6IFNob3VsZCB3ZSBpbXBsZW1lbnQgdGhpcyBpbiBEUlQ/CisgICAg Ym9vbCBvbGRTdGF0ZSA9IHdlYmtpdF9zdXBwb3J0OjpNZXNzYWdlTG9vcE5lc3RhYmxlVGFza3NB bGxvd2VkKCk7CisgICAgd2Via2l0X3N1cHBvcnQ6Ok1lc3NhZ2VMb29wU2V0TmVzdGFibGVUYXNr c0FsbG93ZWQodHJ1ZSk7CisgICAgbV9pbk1vZGFsTG9vcCA9IHRydWU7CisgICAgd2Via2l0X3N1 cHBvcnQ6OlJ1bk1lc3NhZ2VMb29wKCk7CisgICAgd2Via2l0X3N1cHBvcnQ6Ok1lc3NhZ2VMb29w U2V0TmVzdGFibGVUYXNrc0FsbG93ZWQob2xkU3RhdGUpOwogfQogCiAvLyBXZWJGcmFtZUNsaWVu dCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KQEAgLTEwNTMsNiArMTA2MSw3IEBAIFdlYlZpZXdIb3N0OjpXZWJWaWV3SG9zdChUZXN0 U2hlbGwqIHNoZWxsKQogICAgICwgbV9wYWdlSWQoLTEpCiAgICAgLCBtX2xhc3RQYWdlSWRVcGRh dGVkKC0xKQogICAgICwgbV9oYXNXaW5kb3coZmFsc2UpCisgICAgLCBtX2luTW9kYWxMb29wKGZh bHNlKQogICAgICwgbV9zbWFydEluc2VydERlbGV0ZUVuYWJsZWQodHJ1ZSkKICNpZiBPUyhXSU5E T1dTKQogICAgICwgbV9zZWxlY3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkKHRydWUpCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5o IGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAppbmRl eCBlMmU1Njg0Li5kNjBlYTc2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1dlYlZpZXdIb3N0LmgKQEAgLTI1Nyw2ICsyNTcsNyBAQCBwcml2YXRlOgogICAg IFdlYktpdDo6V2ViQ3Vyc29ySW5mbyBtX2N1cnJlbnRDdXJzb3I7CiAKICAgICBib29sIG1faGFz V2luZG93OworICAgIGJvb2wgbV9pbk1vZGFsTG9vcDsKICAgICBXZWJLaXQ6OldlYlJlY3QgbV93 aW5kb3dSZWN0OwogCiAgICAgLy8gdHJ1ZSBpZiB3ZSB3YW50IHRvIGVuYWJsZSBzbWFydCBpbnNl cnQvZGVsZXRlLgo=