46749 2010-09-28 13:16:36 -0700 Web Inspector: a number of breakpoints for one line 2010-10-04 10:27:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo podivilov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 286488 0 loislo 2010-09-28 13:16:36 -0700 1) start chromium 2) open inspector 3) press pause 4) move mouse over inspected page 5) debugger will stop on mouseover listener 6) make a breakpoint 7) close inspector 8) open inspector expected: single breakpoint actual: multiple breakpoints for one line. 288863 1 69612 podivilov 2010-10-04 03:40:47 -0700 Created attachment 69612 Proposed patch. 288974 2 69612 joepeck 2010-10-04 09:40:34 -0700 Comment on attachment 69612 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=69612&action=review > WebCore/bindings/v8/DebuggerScript.js:103 > + if (!locations.length) > + return undefined; > + var actualLineNumber = locations[0].line; Looks like incorrect whitespace on the 2nd line. Would be great if this was fixed. 288982 3 podivilov 2010-10-04 10:01:35 -0700 Committed r69019: <http://trac.webkit.org/changeset/69019> 288984 4 podivilov 2010-10-04 10:03:11 -0700 (In reply to comment #2) > (From update of attachment 69612 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69612&action=review > > > WebCore/bindings/v8/DebuggerScript.js:103 > > + if (!locations.length) > > + return undefined; > > + var actualLineNumber = locations[0].line; > > Looks like incorrect whitespace on the 2nd line. Would be great if this was fixed. Sure, thanks for correction, Joe! 289000 5 joepeck 2010-10-04 10:27:45 -0700 (In reply to comment #4) > Sure, thanks for correction, Joe! Thanks for making the fix and landing manually! 69612 2010-10-04 03:40:47 -0700 2010-10-04 09:57:53 -0700 Proposed patch. patch text/plain 1222 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDk2MDJkYS4uNTY4MzMxMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0wNCAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkbyBub3Qgc2hvdyBicmVha3Bv aW50IGluIGZyb250LWVuZCBpZiBpdCB3YXMgbm90IHNldCBpbiB2OAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY3NDkKKworICAgICAgICAqIGJpbmRp bmdzL3Y4L0RlYnVnZ2VyU2NyaXB0LmpzOgorICAgICAgICAoKToKKwogMjAxMC0xMC0wMyAgS2Vu dCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVp bGQgZml4IGZvciByNjg5OTYuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RlYnVn Z2VyU2NyaXB0LmpzIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9EZWJ1Z2dlclNjcmlwdC5qcwppbmRl eCAwMjIyMjk2Li42N2M2ZmUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RlYnVn Z2VyU2NyaXB0LmpzCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvRGVidWdnZXJTY3JpcHQuanMK QEAgLTk4LDcgKzk4LDkgQEAgRGVidWdnZXJTY3JpcHQuc2V0QnJlYWtwb2ludCA9IGZ1bmN0aW9u KGV4ZWNTdGF0ZSwgYXJncykKICAgICAgICAgRGVidWcuZGlzYWJsZVNjcmlwdEJyZWFrUG9pbnQo YnJlYWtJZCk7CiAKICAgICB2YXIgbG9jYXRpb25zID0gRGVidWcuZmluZEJyZWFrUG9pbnRBY3R1 YWxMb2NhdGlvbnMoYnJlYWtJZCk7Ci0gICAgdmFyIGFjdHVhbExpbmVOdW1iZXIgPSBsb2NhdGlv bnMubGVuZ3RoID8gbG9jYXRpb25zWzBdLmxpbmUgOiBhcmdzLmxpbmVOdW1iZXI7CisgICAgaWYg KCFsb2NhdGlvbnMubGVuZ3RoKQorICAgICAgcmV0dXJuIHVuZGVmaW5lZDsKKyAgICB2YXIgYWN0 dWFsTGluZU51bWJlciA9IGxvY2F0aW9uc1swXS5saW5lOwogCiAgICAgdmFyIGtleSA9IGFyZ3Mu c2NyaXB0SWQgKyAiOiIgKyBhY3R1YWxMaW5lTnVtYmVyOwogICAgIGlmIChrZXkgaW4gRGVidWdn ZXJTY3JpcHQuX2JyZWFrcG9pbnRzKSB7Cg==