46745 2010-09-28 12:09:09 -0700 Fix perf/class-list-remove test 2010-09-28 15:52:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 arv arv commit-queue ojan oldest_to_newest 286433 0 arv 2010-09-28 12:09:09 -0700 Fix perf/class-list-remove test 286434 1 69083 arv 2010-09-28 12:09:59 -0700 Created attachment 69083 Patch 286440 2 69083 darin 2010-09-28 12:16:51 -0700 Comment on attachment 69083 Patch For next time, it would be good to explain what was wrong in the change log and why your fix should work. This is especially helpful if the fix is ineffective and someone else is trying to figure out what you meant to do. 286508 3 69083 ojan 2010-09-28 13:54:27 -0700 Comment on attachment 69083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69083&action=review > LayoutTests/perf/class-list-remove.html:22 > function test1(magnitude) > { > + var s = 'b'; > + element.className = Array(magnitude).join('a ') + s; > element.classList.remove(s); I worry that this is testing Array.join's perf more than classList.remove. Shouldn't the Array.join be in the setup function? Same with test2. 286554 4 69083 ojan 2010-09-28 14:55:35 -0700 Comment on attachment 69083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69083&action=review >> LayoutTests/perf/class-list-remove.html:22 >> element.classList.remove(s); > > I worry that this is testing Array.join's perf more than classList.remove. Shouldn't the Array.join be in the setup function? Same with test2. What I mean is that you should do something like the following. In the setup function: classToUse = Array(magnitude).join('a ') + 'b'; Then in the test function: element.className = classToUse; 286556 5 69112 arv 2010-09-28 14:56:03 -0700 Created attachment 69112 Patch 286559 6 69112 ojan 2010-09-28 15:00:00 -0700 Comment on attachment 69112 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69112&action=review > LayoutTests/perf/class-list-remove.html:4 > +var element, className, s; Nit: would be nice to have a more descriptive name than s. classToRemove perhaps? 286561 7 69112 arv 2010-09-28 15:00:48 -0700 Comment on attachment 69112 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69112&action=review >> LayoutTests/perf/class-list-remove.html:4 >> +var element, className, s; > > Nit: would be nice to have a more descriptive name than s. classToRemove perhaps? Done. 286562 8 69115 arv 2010-09-28 15:02:45 -0700 Created attachment 69115 Patch for landing 286593 9 69115 commit-queue 2010-09-28 15:52:35 -0700 Comment on attachment 69115 Patch for landing Clearing flags on attachment: 69115 Committed r68596: <http://trac.webkit.org/changeset/68596> 286594 10 commit-queue 2010-09-28 15:52:40 -0700 All reviewed patches have been landed. Closing bug. 69083 2010-09-28 12:09:59 -0700 2010-09-28 14:56:00 -0700 Patch bug-46745-20100928120958.patch text/plain 1988 arv ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiN2U0NjJhYjQ1ZDIxYjdhZjgzMjJiYzlmM2E5YWI4NDZjNGM3NzI1Li4zZGUyYWE1 NjNiMjA2NzU0OThhMTc5Y2NlMDk2NmM3MGM1NDk0ZGZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDktMjggIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcGVyZi9jbGFzcy1s aXN0LXJlbW92ZSB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00Njc0NQorCisgICAgICAgICogcGVyZi9jbGFzcy1saXN0LXJlbW92ZS5odG1sOgor CiAyMDEwLTA5LTI4ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQ7IGV4cGVjdGF0aW9ucyBmaXguCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wZXJmL2NsYXNzLWxpc3QtcmVtb3ZlLmh0bWwgYi9MYXlvdXRUZXN0cy9wZXJmL2Ns YXNzLWxpc3QtcmVtb3ZlLmh0bWwKaW5kZXggZjAzZTliYWMxODAyYTM4NjM5OTI5M2U5YzJmYWYy NmMzNzk0NTNkNi4uOGI3ZTY5NzliOGUyNzA0ZjQ0ODRjMTVmZTgwZmZjNWI1OTAzODVkZSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGVyZi9jbGFzcy1saXN0LXJlbW92ZS5odG1sCisrKyBiL0xh eW91dFRlc3RzL3BlcmYvY2xhc3MtbGlzdC1yZW1vdmUuaHRtbApAQCAtMSwyOCArMSwyOSBAQAog PHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9tYWduaXR1ZGUtcGVyZi5qcyI+PC9zY3JpcHQ+CiA8 c2NyaXB0PgogCi12YXIgZWxlbWVudCwgczsKK3ZhciBlbGVtZW50OworCitmdW5jdGlvbiBzZXR1 cEZ1bmN0aW9uKG1hZ25pdHVkZSkKK3sKKyAgICBlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxl bWVudCgnZGl2Jyk7Cit9CiAKIC8vIFRlc3QgMSB0ZXN0cyB0aGF0IHJlbW92ZSBpcyBsaW5lYXIg d2hlbiB0aGVyZSBhcmUgTiBjbGFzcyBuYW1lcy4KIAogZnVuY3Rpb24gc2V0dXBGdW5jdGlvbjEo bWFnbml0dWRlKQogewotICAgIHMgPSAnYic7Ci0gICAgZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoJ2RpdicpOwotICAgIGVsZW1lbnQuY2xhc3NOYW1lID0gQXJyYXkobWFnbml0dWRl KS5qb2luKCdhICcpICsgczsKKwogfQogCiBmdW5jdGlvbiB0ZXN0MShtYWduaXR1ZGUpCiB7Cisg ICAgdmFyIHMgPSAnYic7CisgICAgZWxlbWVudC5jbGFzc05hbWUgPSBBcnJheShtYWduaXR1ZGUp LmpvaW4oJ2EgJykgKyBzOwogICAgIGVsZW1lbnQuY2xhc3NMaXN0LnJlbW92ZShzKTsKIH0KIAog Ly8gVGVzdCAyIHRlc3RzIHRoYXQgcmVtb3ZlIGlzIGxpbmVhciB3aGVuIHRoZSBsZW5ndGggb2Yg dGhlIGNsYXNzIG5hbWUgaXMgTi4KIAotZnVuY3Rpb24gc2V0dXBGdW5jdGlvbjIobWFnbml0dWRl KQotewotICAgIGVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKLX0KIAog ZnVuY3Rpb24gdGVzdDIobWFnbml0dWRlKQogewpAQCAtMzIsOCArMzMsOCBAQCBmdW5jdGlvbiB0 ZXN0MihtYWduaXR1ZGUpCiB9CiAKIE1hZ25pdHVkZS5kZXNjcmlwdGlvbignVGVzdHMgdGhhdCBj bGFzc0xpc3QgcmVtb3ZlIGlzIGxpbmVhci4nKTsKLU1hZ25pdHVkZS5ydW4oc2V0dXBGdW5jdGlv bjEsIHRlc3QxLCBNYWduaXR1ZGUuTElORUFSKTsKLU1hZ25pdHVkZS5ydW4oc2V0dXBGdW5jdGlv bjIsIHRlc3QyLCBNYWduaXR1ZGUuTElORUFSKTsKK01hZ25pdHVkZS5ydW4oc2V0dXBGdW5jdGlv biwgdGVzdDEsIE1hZ25pdHVkZS5MSU5FQVIpOworTWFnbml0dWRlLnJ1bihzZXR1cEZ1bmN0aW9u LCB0ZXN0MiwgTWFnbml0dWRlLkxJTkVBUik7CiAKIDwvc2NyaXB0PgogPC9ib2R5Pgo= 69112 2010-09-28 14:56:03 -0700 2010-09-28 15:02:41 -0700 Patch bug-46745-20100928145602.patch text/plain 2264 arv ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiN2U0NjJhYjQ1ZDIxYjdhZjgzMjJiYzlmM2E5YWI4NDZjNGM3NzI1Li5mZDkzNGMz YTA5NjBhNWFkOTI2ZDY1OWJmMWJkZDcwM2Y2NWRkOTIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjggIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcGVyZi9jbGFzcy1s aXN0LXJlbW92ZSB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00Njc0NQorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSBwcmVjb21wdXRlIHRoZSBjbGFz c05hbWUgaW4gdGhlIHNldHVwIGZ1bmN0aW9ucyBhbmQgdGhhdAorICAgICAgICB3ZSByZXNldCBp dCBiZWZvcmUgY2FsbGluZyBjbGFzc0xpc3QucmVtb3ZlLgorCisgICAgICAgICogcGVyZi9jbGFz cy1saXN0LXJlbW92ZS5odG1sOgorCiAyMDEwLTA5LTI4ICBTdGVwaGVuIFdoaXRlICA8c2Vub3Ji bGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQ7IGV4cGVjdGF0aW9ucyBm aXguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wZXJmL2NsYXNzLWxpc3QtcmVtb3ZlLmh0bWwg Yi9MYXlvdXRUZXN0cy9wZXJmL2NsYXNzLWxpc3QtcmVtb3ZlLmh0bWwKaW5kZXggZjAzZTliYWMx ODAyYTM4NjM5OTI5M2U5YzJmYWYyNmMzNzk0NTNkNi4uYzhiYzkxNmRmMjA4OGUyY2Y2NzQ1MTE5 M2Q1NjhhNmQ1NzdmNmQ4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGVyZi9jbGFzcy1saXN0 LXJlbW92ZS5odG1sCisrKyBiL0xheW91dFRlc3RzL3BlcmYvY2xhc3MtbGlzdC1yZW1vdmUuaHRt bApAQCAtMSwyMCArMSwxNSBAQAogPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9tYWduaXR1ZGUt cGVyZi5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgogCi12YXIgZWxlbWVudCwgczsKK3ZhciBlbGVt ZW50LCBjbGFzc05hbWUsIHM7CiAKIC8vIFRlc3QgMSB0ZXN0cyB0aGF0IHJlbW92ZSBpcyBsaW5l YXIgd2hlbiB0aGVyZSBhcmUgTiBjbGFzcyBuYW1lcy4KIAogZnVuY3Rpb24gc2V0dXBGdW5jdGlv bjEobWFnbml0dWRlKQogewotICAgIHMgPSAnYic7CiAgICAgZWxlbWVudCA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2RpdicpOwotICAgIGVsZW1lbnQuY2xhc3NOYW1lID0gQXJyYXkobWFnbml0 dWRlKS5qb2luKCdhICcpICsgczsKLX0KLQotZnVuY3Rpb24gdGVzdDEobWFnbml0dWRlKQotewot ICAgIGVsZW1lbnQuY2xhc3NMaXN0LnJlbW92ZShzKTsKKyAgICBzID0gJ2InOworICAgIGNsYXNz TmFtZSA9IEFycmF5KG1hZ25pdHVkZSkuam9pbignYSAnKSArIHM7CiB9CiAKIC8vIFRlc3QgMiB0 ZXN0cyB0aGF0IHJlbW92ZSBpcyBsaW5lYXIgd2hlbiB0aGUgbGVuZ3RoIG9mIHRoZSBjbGFzcyBu YW1lIGlzIE4uCkBAIC0yMiwxOCArMTcsMTkgQEAgZnVuY3Rpb24gdGVzdDEobWFnbml0dWRlKQog ZnVuY3Rpb24gc2V0dXBGdW5jdGlvbjIobWFnbml0dWRlKQogewogICAgIGVsZW1lbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKKyAgICBzID0gQXJyYXkobWFnbml0dWRlICsgMSku am9pbignYScpOworICAgIGNsYXNzTmFtZSA9IHM7CiB9CiAKLWZ1bmN0aW9uIHRlc3QyKG1hZ25p dHVkZSkKK2Z1bmN0aW9uIHRlc3QobWFnbml0dWRlKQogewotICAgIHZhciBzID0gQXJyYXkobWFn bml0dWRlICsgMSkuam9pbignYScpOwotICAgIGVsZW1lbnQuY2xhc3NOYW1lID0gczsKKyAgICBl bGVtZW50LmNsYXNzTmFtZSA9IGNsYXNzTmFtZTsKICAgICBlbGVtZW50LmNsYXNzTGlzdC5yZW1v dmUocyk7CiB9CiAKIE1hZ25pdHVkZS5kZXNjcmlwdGlvbignVGVzdHMgdGhhdCBjbGFzc0xpc3Qg cmVtb3ZlIGlzIGxpbmVhci4nKTsKLU1hZ25pdHVkZS5ydW4oc2V0dXBGdW5jdGlvbjEsIHRlc3Qx LCBNYWduaXR1ZGUuTElORUFSKTsKLU1hZ25pdHVkZS5ydW4oc2V0dXBGdW5jdGlvbjIsIHRlc3Qy LCBNYWduaXR1ZGUuTElORUFSKTsKK01hZ25pdHVkZS5ydW4oc2V0dXBGdW5jdGlvbjEsIHRlc3Qs IE1hZ25pdHVkZS5MSU5FQVIpOworTWFnbml0dWRlLnJ1bihzZXR1cEZ1bmN0aW9uMiwgdGVzdCwg TWFnbml0dWRlLkxJTkVBUik7CiAKIDwvc2NyaXB0PgogPC9ib2R5Pgo= 69115 2010-09-28 15:02:45 -0700 2010-09-28 15:52:35 -0700 Patch for landing bug-46745-20100928150244.patch text/plain 2320 arv ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiN2U0NjJhYjQ1ZDIxYjdhZjgzMjJiYzlmM2E5YWI4NDZjNGM3NzI1Li42MWY4ZjIy MTU0NDZhMGZjMWVkMDNjNzIzNGNmOTUxOTZjYWUxNWRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjggIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgorCisgICAgICAgIEZpeCBwZXJmL2NsYXNzLWxpc3Qt cmVtb3ZlIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ2NzQ1CisKKyAgICAgICAgTWFrZSBzdXJlIHdlIHByZWNvbXB1dGUgdGhlIGNsYXNzTmFt ZSBpbiB0aGUgc2V0dXAgZnVuY3Rpb25zIGFuZCB0aGF0CisgICAgICAgIHdlIHJlc2V0IGl0IGJl Zm9yZSBjYWxsaW5nIGNsYXNzTGlzdC5yZW1vdmUuCisKKyAgICAgICAgKiBwZXJmL2NsYXNzLWxp c3QtcmVtb3ZlLmh0bWw6CisKIDIwMTAtMDktMjggIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5j b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZDsgZXhwZWN0YXRpb25zIGZpeC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BlcmYvY2xhc3MtbGlzdC1yZW1vdmUuaHRtbCBiL0xh eW91dFRlc3RzL3BlcmYvY2xhc3MtbGlzdC1yZW1vdmUuaHRtbAppbmRleCBmMDNlOWJhYzE4MDJh Mzg2Mzk5MjkzZTljMmZhZjI2YzM3OTQ1M2Q2Li4wZTMxZDkzMDlkODBlYjU3YmIzNzFjMzMzZGU3 OGJlN2UwNTNkMDQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wZXJmL2NsYXNzLWxpc3QtcmVt b3ZlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGVyZi9jbGFzcy1saXN0LXJlbW92ZS5odG1sCkBA IC0xLDIwICsxLDE1IEBACiA8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL21hZ25pdHVkZS1wZXJm LmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CiAKLXZhciBlbGVtZW50LCBzOwordmFyIGVsZW1lbnQs IGNsYXNzTmFtZSwgY2xhc3NUb1JlbW92ZTsKIAogLy8gVGVzdCAxIHRlc3RzIHRoYXQgcmVtb3Zl IGlzIGxpbmVhciB3aGVuIHRoZXJlIGFyZSBOIGNsYXNzIG5hbWVzLgogCiBmdW5jdGlvbiBzZXR1 cEZ1bmN0aW9uMShtYWduaXR1ZGUpCiB7Ci0gICAgcyA9ICdiJzsKICAgICBlbGVtZW50ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Ci0gICAgZWxlbWVudC5jbGFzc05hbWUgPSBBcnJh eShtYWduaXR1ZGUpLmpvaW4oJ2EgJykgKyBzOwotfQotCi1mdW5jdGlvbiB0ZXN0MShtYWduaXR1 ZGUpCi17Ci0gICAgZWxlbWVudC5jbGFzc0xpc3QucmVtb3ZlKHMpOworICAgIGNsYXNzVG9SZW1v dmUgPSAnYic7CisgICAgY2xhc3NOYW1lID0gQXJyYXkobWFnbml0dWRlKS5qb2luKCdhICcpICsg Y2xhc3NUb1JlbW92ZTsKIH0KIAogLy8gVGVzdCAyIHRlc3RzIHRoYXQgcmVtb3ZlIGlzIGxpbmVh ciB3aGVuIHRoZSBsZW5ndGggb2YgdGhlIGNsYXNzIG5hbWUgaXMgTi4KQEAgLTIyLDE4ICsxNywx OSBAQCBmdW5jdGlvbiB0ZXN0MShtYWduaXR1ZGUpCiBmdW5jdGlvbiBzZXR1cEZ1bmN0aW9uMiht YWduaXR1ZGUpCiB7CiAgICAgZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2Rpdicp OworICAgIGNsYXNzVG9SZW1vdmUgPSBBcnJheShtYWduaXR1ZGUgKyAxKS5qb2luKCdhJyk7Cisg ICAgY2xhc3NOYW1lID0gY2xhc3NUb1JlbW92ZTsKIH0KIAotZnVuY3Rpb24gdGVzdDIobWFnbml0 dWRlKQorZnVuY3Rpb24gdGVzdChtYWduaXR1ZGUpCiB7Ci0gICAgdmFyIHMgPSBBcnJheShtYWdu aXR1ZGUgKyAxKS5qb2luKCdhJyk7Ci0gICAgZWxlbWVudC5jbGFzc05hbWUgPSBzOworICAgIGVs ZW1lbnQuY2xhc3NOYW1lID0gY2xhc3NOYW1lOwogICAgIGVsZW1lbnQuY2xhc3NMaXN0LnJlbW92 ZShzKTsKIH0KIAogTWFnbml0dWRlLmRlc2NyaXB0aW9uKCdUZXN0cyB0aGF0IGNsYXNzTGlzdCBy ZW1vdmUgaXMgbGluZWFyLicpOwotTWFnbml0dWRlLnJ1bihzZXR1cEZ1bmN0aW9uMSwgdGVzdDEs IE1hZ25pdHVkZS5MSU5FQVIpOwotTWFnbml0dWRlLnJ1bihzZXR1cEZ1bmN0aW9uMiwgdGVzdDIs IE1hZ25pdHVkZS5MSU5FQVIpOworTWFnbml0dWRlLnJ1bihzZXR1cEZ1bmN0aW9uMSwgdGVzdCwg TWFnbml0dWRlLkxJTkVBUik7CitNYWduaXR1ZGUucnVuKHNldHVwRnVuY3Rpb24yLCB0ZXN0LCBN YWduaXR1ZGUuTElORUFSKTsKIAogPC9zY3JpcHQ+CiA8L2JvZHk+Cg==