46731 2010-09-28 09:30:36 -0700 Implement PluginControllerProxy::initialize and have it create a plug-in 2010-12-14 01:55:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric webkit.review.bot oldest_to_newest 286297 0 andersca 2010-09-28 09:30:36 -0700 Implement PluginControllerProxy::initialize and have it create a plug-in 286300 1 69061 andersca 2010-09-28 09:33:16 -0700 Created attachment 69061 Patch 286304 2 69061 aroben 2010-09-28 09:38:52 -0700 Comment on attachment 69061 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69061&action=review > WebKit2/PluginProcess/WebProcessConnection.cpp:66 > + // Delete the plug-in controller. > + delete pluginController; The coment doesn't seem very helpful. 286329 3 webkit.review.bot 2010-09-28 10:11:39 -0700 http://trac.webkit.org/changeset/68531 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68523 http://trac.webkit.org/changeset/68524 http://trac.webkit.org/changeset/68525 http://trac.webkit.org/changeset/68526 http://trac.webkit.org/changeset/68527 http://trac.webkit.org/changeset/68528 http://trac.webkit.org/changeset/68529 http://trac.webkit.org/changeset/68530 http://trac.webkit.org/changeset/68531 69061 2010-09-28 09:33:16 -0700 2010-09-28 09:38:52 -0700 Patch bug-46731-20100928093315.patch text/plain 6767 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg OGJiNzNmNzRiYzRiYTEyNThjZTQ1ZWI0NzBjODAxYzZiYmQ3OTYyNy4uOTVmZGY3NGU2MmVjMjAw OGNiMmIzZDgwODk0NTU4ZjA0M2UzMWE4MyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyOSBAQAogMjAxMC0wOS0yOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBQbHVnaW5Db250cm9sbGVyUHJv eHk6OmluaXRpYWxpemUgYW5kIGhhdmUgaXQgY3JlYXRlIGEgcGx1Zy1pbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY3MzEKKworICAgICAgICAqIFBs dWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UGx1Z2luQ29udHJvbGxlclByb3h5Ojppbml0aWFsaXplKToKKyAgICAgICAgQ3JlYXRlIHRoZSBw bHVnLWluIGFuZCB0cnkgdG8gaW5pdGlhbGl6ZSBpdC4KKworICAgICAgICAoV2ViS2l0OjpQbHVn aW5Db250cm9sbGVyUHJveHk6OmRlc3Ryb3kpOgorICAgICAgICBEZXN0cm95IHRoZSBwbHVnLWlu LgorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NDb25uZWN0aW9uOjphZGRQbHVnaW5Db250cm9sbGVy UHJveHkpOgorICAgICAgICBBZGQgdGhlIGdpdmVuIHBsdWctaW4gY29udHJvbGxlciBwcm94eSB0 byB0aGUgbWFwIGFuZCBhc3N1bWUgb3duZXJzaGlwIG9mIGl0LgorCisgICAgICAgIChXZWJLaXQ6 OldlYlByb2Nlc3NDb25uZWN0aW9uOjpyZW1vdmVQbHVnaW5Db250cm9sbGVyUHJveHkpOgorICAg ICAgICBSZW1vdmUgdGhlIGdpdmVuIHBsdWctaW4gY29udHJvbGxlciBwcm94eSBmcm9tIHRoZSBt YXAgYW5kIGRlbGV0ZSBpdC4KKworICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzQ29ubmVjdGlv bjo6Y3JlYXRlUGx1Z2luKToKKyAgICAgICAgQ3JlYXRlIGEgcGx1Zy1pbiBjb250cm9sbGVyIHBy b3h5IGFuZCB0cnkgdG8gaW5pdGlhbGl6ZSBpdC4KKworMjAxMC0wOS0yOCAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9i ZW4uCiAKICAgICAgICAgQWRkIFBsdWdpbkNvbnRyb2xsZXJQcm94eSBjbGFzcwpkaWZmIC0tZ2l0 IGEvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5jcHAgYi9XZWJL aXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmNwcAppbmRleCA3M2ZlNGU2 YTdlNGQ4ZDczNTQwYjc5ODlkNjc2MTc5MzJkNGQ2YThkLi42YzkxY2MwNmYyNDY5NDdhNTA2MDdk MjBlZDA5NGYyNDBkNDdjOTA1IDEwMDY0NAotLS0gYS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1 Z2luQ29udHJvbGxlclByb3h5LmNwcAorKysgYi9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2lu Q29udHJvbGxlclByb3h5LmNwcApAQCAtMjcsNyArMjcsOSBAQAogCiAjaW5jbHVkZSAiUGx1Z2lu Q29udHJvbGxlclByb3h5LmgiCiAKKyNpbmNsdWRlICJOZXRzY2FwZVBsdWdpbi5oIgogI2luY2x1 ZGUgIk5vdEltcGxlbWVudGVkLmgiCisjaW5jbHVkZSAiUGx1Z2luUHJvY2Vzcy5oIgogI2luY2x1 ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKQEAg LTUwLDYgKzUyLDI3IEBAIFBsdWdpbkNvbnRyb2xsZXJQcm94eTo6flBsdWdpbkNvbnRyb2xsZXJQ cm94eSgpCiAgICAgQVNTRVJUKCFtX3BsdWdpbik7CiB9CiAKK2Jvb2wgUGx1Z2luQ29udHJvbGxl clByb3h5Ojppbml0aWFsaXplKGNvbnN0IFBsdWdpbjo6UGFyYW1ldGVycyYgcGFyYW1ldGVycykK K3sKKyAgICBBU1NFUlQoIW1fcGx1Z2luKTsKKworICAgIG1fcGx1Z2luID0gTmV0c2NhcGVQbHVn aW46OmNyZWF0ZShQbHVnaW5Qcm9jZXNzOjpzaGFyZWQoKS5uZXRzY2FwZVBsdWdpbk1vZHVsZSgp KTsKKyAgICBpZiAoIW1fcGx1Z2luLT5pbml0aWFsaXplKHRoaXMsIHBhcmFtZXRlcnMpKSB7Cisg ICAgICAgIG1fcGx1Z2luID0gMDsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAg IHJldHVybiB0cnVlOworfQorCit2b2lkIFBsdWdpbkNvbnRyb2xsZXJQcm94eTo6ZGVzdHJveSgp Cit7CisgICAgQVNTRVJUKG1fcGx1Z2luKTsKKworICAgIG1fcGx1Z2luLT5kZXN0cm95KCk7Cisg ICAgbV9wbHVnaW4gPSAwOworfQorCiB2b2lkIFBsdWdpbkNvbnRyb2xsZXJQcm94eTo6aW52YWxp ZGF0ZShjb25zdCBJbnRSZWN0JikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwpkaWZmIC0tZ2l0 IGEvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5oIGIvV2ViS2l0 Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5oCmluZGV4IGExYTI4YjZhZWU2 MmYyZjA4ZDI0MzgzOGY5ZjRmNDE1MTZhYmMxNzYuLjcwNjYyMDJhNjJmMThhNjNhYjdhYzlkNWEy ODlhNGU1ZDIxMzVjM2IgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5D b250cm9sbGVyUHJveHkuaAorKysgYi9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJv bGxlclByb3h5LmgKQEAgLTQ2LDYgKzQ2LDkgQEAgcHVibGljOgogCiAgICAgdWludDY0X3QgcGx1 Z2luSW5zdGFuY2VJRCgpIGNvbnN0IHsgcmV0dXJuIG1fcGx1Z2luSW5zdGFuY2VJRDsgfQogCisg ICAgYm9vbCBpbml0aWFsaXplKGNvbnN0IFBsdWdpbjo6UGFyYW1ldGVycyYpOworICAgIHZvaWQg ZGVzdHJveSgpOworCiBwcml2YXRlOgogICAgIFBsdWdpbkNvbnRyb2xsZXJQcm94eShXZWJQcm9j ZXNzQ29ubmVjdGlvbiogY29ubmVjdGlvbiwgdWludDY0X3QgcGx1Z2luSW5zdGFuY2VJRCk7CiAK ZGlmZiAtLWdpdCBhL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5j cHAgYi9XZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwCmluZGV4 IGE1YWNmYTRiOTU2NzkxN2FmNWM0ZGRiOGIwMWI2YzMxNzg3OWM2ZGYuLjc0MGI1YThmNGFlYzVl YzkwNDM0NDU1ZWY2NDdiYjg2MDFiMGVjMWQgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGx1Z2luUHJv Y2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5jcHAKKysrIGIvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNz L1dlYlByb2Nlc3NDb25uZWN0aW9uLmNwcApAQCAtNDksMTAgKzQ5LDEyIEBAIFdlYlByb2Nlc3ND b25uZWN0aW9uOjpXZWJQcm9jZXNzQ29ubmVjdGlvbihDb3JlSVBDOjpDb25uZWN0aW9uOjpJZGVu dGlmaWVyIGNvbm5lCiAgICAgbV9jb25uZWN0aW9uLT5vcGVuKCk7CiB9CiAKLXZvaWQgV2ViUHJv Y2Vzc0Nvbm5lY3Rpb246OmFkZFBsdWdpbkNvbnRyb2xsZXJQcm94eShQbHVnaW5Db250cm9sbGVy UHJveHkqIHBsdWdpbkNvbnRyb2xsZXIpCit2b2lkIFdlYlByb2Nlc3NDb25uZWN0aW9uOjphZGRQ bHVnaW5Db250cm9sbGVyUHJveHkoUGFzc093blB0cjxQbHVnaW5Db250cm9sbGVyUHJveHk+IHBs dWdpbkNvbnRyb2xsZXIpCiB7Ci0gICAgQVNTRVJUKCFtX3BsdWdpbkNvbnRyb2xsZXJzLmNvbnRh aW5zKHBsdWdpbkNvbnRyb2xsZXItPnBsdWdpbkluc3RhbmNlSUQoKSkpOwotICAgIG1fcGx1Z2lu Q29udHJvbGxlcnMuc2V0KHBsdWdpbkNvbnRyb2xsZXItPnBsdWdpbkluc3RhbmNlSUQoKSwgcGx1 Z2luQ29udHJvbGxlcik7CisgICAgdWludDY0X3QgcGx1Z2luSW5zdGFuY2VJRCA9IHBsdWdpbkNv bnRyb2xsZXItPnBsdWdpbkluc3RhbmNlSUQoKTsKKworICAgIEFTU0VSVCghbV9wbHVnaW5Db250 cm9sbGVycy5jb250YWlucyhwbHVnaW5JbnN0YW5jZUlEKSk7CisgICAgbV9wbHVnaW5Db250cm9s bGVycy5zZXQocGx1Z2luSW5zdGFuY2VJRCwgcGx1Z2luQ29udHJvbGxlci5sZWFrUHRyKCkpOwog fQogCiB2b2lkIFdlYlByb2Nlc3NDb25uZWN0aW9uOjpyZW1vdmVQbHVnaW5Db250cm9sbGVyUHJv eHkoUGx1Z2luQ29udHJvbGxlclByb3h5KiBwbHVnaW5Db250cm9sbGVyKQpAQCAtNjAsNiArNjIs OSBAQCB2b2lkIFdlYlByb2Nlc3NDb25uZWN0aW9uOjpyZW1vdmVQbHVnaW5Db250cm9sbGVyUHJv eHkoUGx1Z2luQ29udHJvbGxlclByb3h5KiBwbAogICAgIEFTU0VSVChtX3BsdWdpbkNvbnRyb2xs ZXJzLmNvbnRhaW5zKHBsdWdpbkNvbnRyb2xsZXItPnBsdWdpbkluc3RhbmNlSUQoKSkpOwogICAg IG1fcGx1Z2luQ29udHJvbGxlcnMucmVtb3ZlKHBsdWdpbkNvbnRyb2xsZXItPnBsdWdpbkluc3Rh bmNlSUQoKSk7CiAKKyAgICAvLyBEZWxldGUgdGhlIHBsdWctaW4gY29udHJvbGxlci4KKyAgICBk ZWxldGUgcGx1Z2luQ29udHJvbGxlcjsKKwogICAgIGlmICghbV9wbHVnaW5Db250cm9sbGVycy5p c0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtOTEsOCArOTYsMjMgQEAgdm9pZCBXZWJQ cm9jZXNzQ29ubmVjdGlvbjo6ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlKENvcmVJUEM6OkNvbm5l Y3Rpb24qLCBDb3JlSVAKICAgICAvLyBGSVhNRTogSW1wbGVtZW50LgogfQogCi12b2lkIFdlYlBy b2Nlc3NDb25uZWN0aW9uOjpjcmVhdGVQbHVnaW4odWludDY0X3QgcGx1Z2luSW5zdGFuY2VJRCwg Y29uc3QgUGx1Z2luOjpQYXJhbWV0ZXJzJiwgYm9vbCYgcmVzdWx0KQordm9pZCBXZWJQcm9jZXNz Q29ubmVjdGlvbjo6Y3JlYXRlUGx1Z2luKHVpbnQ2NF90IHBsdWdpbkluc3RhbmNlSUQsIGNvbnN0 IFBsdWdpbjo6UGFyYW1ldGVycyYgcGFyYW1ldGVycywgYm9vbCYgcmVzdWx0KQogeworICAgIE93 blB0cjxQbHVnaW5Db250cm9sbGVyUHJveHk+IHBsdWdpbkNvbnRyb2xsZXJQcm94eSA9IFBsdWdp bkNvbnRyb2xsZXJQcm94eTo6Y3JlYXRlKHRoaXMsIHBsdWdpbkluc3RhbmNlSUQpOworCisgICAg UGx1Z2luQ29udHJvbGxlclByb3h5KiBwbHVnaW5Db250cm9sbGVyUHJveHlQdHIgPSBwbHVnaW5D b250cm9sbGVyUHJveHkuZ2V0KCk7CisKKyAgICAvLyBNYWtlIHN1cmUgdG8gYWRkIHRoZSBwcm94 eSB0byB0aGUgbWFwIGJlZm9yZSBpbml0aWFsaXppbmcgaXQsIHNpbmNlIHRoZSBwbHVnLWluIG1p Z2h0IGNhbGwgb3V0IHRvIHRoZSB3ZWIgcHJvY2VzcyBmcm9tIAorICAgIC8vIGl0cyBOUFBfTmV3 IGZ1bmN0aW9uLiBUaGlzIHdpbGwgaGFuZCBvdmVyIG93bmVyc2hpcCBvZiB0aGUgcHJveHkgdG8g dGhlIHdlYiBwcm9jZXNzIGNvbm5lY3Rpb24uCisgICAgYWRkUGx1Z2luQ29udHJvbGxlclByb3h5 KHBsdWdpbkNvbnRyb2xsZXJQcm94eS5yZWxlYXNlKCkpOworCisgICAgLy8gTm93IHRyeSB0byBp bml0aWFsaXplIHRoZSBwbHVnLWluLgorICAgIHJlc3VsdCA9IHBsdWdpbkNvbnRyb2xsZXJQcm94 eVB0ci0+aW5pdGlhbGl6ZShwYXJhbWV0ZXJzKTsKKworICAgIGlmICghcmVzdWx0KSB7CisgICAg ICAgIC8vIFdlIGZhaWxlZCB0byBpbml0aWFsaXplLCByZW1vdmUgdGhlIHBsdWctaW4gY29udHJv bGxlci4gVGhpcyBjb3VsZCBjYXVzZSB1cyB0byBiZSBkZWxldGVkLgorICAgICAgICByZW1vdmVQ bHVnaW5Db250cm9sbGVyUHJveHkocGx1Z2luQ29udHJvbGxlclByb3h5UHRyKTsKKyAgICB9CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9QbHVnaW5Qcm9j ZXNzL1dlYlByb2Nlc3NDb25uZWN0aW9uLmggYi9XZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJv Y2Vzc0Nvbm5lY3Rpb24uaAppbmRleCAwOGI2ZTkxN2NlNTE3NzQzN2RiZDVjNGUyM2RlMmU3NzI3 OWFiMGE2Li5hODYwMGMxYjU4NGIzNWE0MWQ3OGQ4ZGQ2M2FmNjYyOWM3MDNiYjUwIDEwMDY0NAot LS0gYS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rpb24uaAorKysgYi9X ZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rpb24uaApAQCAtNDUsMTIgKzQ1 LDEyIEBAIHB1YmxpYzoKIAogICAgIENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24oKSBj b25zdCB7IHJldHVybiBtX2Nvbm5lY3Rpb24uZ2V0KCk7IH0KIAotICAgIHZvaWQgYWRkUGx1Z2lu Q29udHJvbGxlclByb3h5KFBsdWdpbkNvbnRyb2xsZXJQcm94eSopOwotICAgIHZvaWQgcmVtb3Zl UGx1Z2luQ29udHJvbGxlclByb3h5KFBsdWdpbkNvbnRyb2xsZXJQcm94eSopOwotCiBwcml2YXRl OgogICAgIFdlYlByb2Nlc3NDb25uZWN0aW9uKENvcmVJUEM6OkNvbm5lY3Rpb246OklkZW50aWZp ZXIpOwogCisgICAgdm9pZCBhZGRQbHVnaW5Db250cm9sbGVyUHJveHkoUGFzc093blB0cjxQbHVn aW5Db250cm9sbGVyUHJveHk+KTsKKyAgICB2b2lkIHJlbW92ZVBsdWdpbkNvbnRyb2xsZXJQcm94 eShQbHVnaW5Db250cm9sbGVyUHJveHkqKTsKKwogICAgIC8vIENvcmVJUEM6OkNvbm5lY3Rpb246 OkNsaWVudAogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZShDb3JlSVBDOjpDb25u ZWN0aW9uKiwgQ29yZUlQQzo6TWVzc2FnZUlELCBDb3JlSVBDOjpBcmd1bWVudERlY29kZXIqKTsK ICAgICB2aXJ0dWFsIENvcmVJUEM6OlN5bmNSZXBseU1vZGUgZGlkUmVjZWl2ZVN5bmNNZXNzYWdl KENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3JlSVBDOjpNZXNzYWdlSUQsIENvcmVJUEM6OkFyZ3Vt ZW50RGVjb2RlciosIENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciopOwo=