46730 2010-09-28 09:17:22 -0700 [Qt] Clean up QWebPage::ViewportConfiguration API 2010-09-28 10:11:09 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling abarth ademar eric webkit.review.bot oldest_to_newest 286291 0 kling 2010-09-28 09:17:22 -0700 - Pass QSize parameter as const-reference - Style fixes 286292 1 69060 kling 2010-09-28 09:18:03 -0700 Created attachment 69060 Patch (r=kenneth) 286293 2 69060 kling 2010-09-28 09:21:05 -0700 Comment on attachment 69060 Patch (r=kenneth) Clearing flags on attachment: 69060 Committed r68525: <http://trac.webkit.org/changeset/68525> 286294 3 kling 2010-09-28 09:21:15 -0700 All reviewed patches have been landed. Closing bug. 286318 4 ademar 2010-09-28 10:03:20 -0700 Revision r68525 cherry-picked into qtwebkit-2.1 with commit 9615fdd <http://gitorious.org/webkit/qtwebkit/commit/9615fdd> 286327 5 webkit.review.bot 2010-09-28 10:11:09 -0700 http://trac.webkit.org/changeset/68525 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/68523 http://trac.webkit.org/changeset/68524 http://trac.webkit.org/changeset/68525 http://trac.webkit.org/changeset/68526 http://trac.webkit.org/changeset/68527 http://trac.webkit.org/changeset/68528 http://trac.webkit.org/changeset/68529 http://trac.webkit.org/changeset/68530 http://trac.webkit.org/changeset/68531 69060 2010-09-28 09:18:03 -0700 2010-09-28 09:21:05 -0700 Patch (r=kenneth) bug-46730.diff text/plain 3017 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggNTFlM2RjMy4uOTMyMTAzZCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTIz NjMsNyArMjM2Myw3IEBAIHN0YXRpYyBRU2l6ZSBxdWVyeURldmljZVNpemVGb3JTY3JlZW5Db250 YWluaW5nV2lkZ2V0KGNvbnN0IFFXaWRnZXQqIHdpZGdldCkKICAgICBib3RoIG5lZWRzIHRvIGJl IHNldC4KICovCiAKLVFXZWJQYWdlOjpWaWV3cG9ydENvbmZpZ3VyYXRpb24gUVdlYlBhZ2U6OnZp ZXdwb3J0Q29uZmlndXJhdGlvbkZvclNpemUoUVNpemUgYXZhaWxhYmxlU2l6ZSkgY29uc3QKK1FX ZWJQYWdlOjpWaWV3cG9ydENvbmZpZ3VyYXRpb24gUVdlYlBhZ2U6OnZpZXdwb3J0Q29uZmlndXJh dGlvbkZvclNpemUoY29uc3QgUVNpemUmIGF2YWlsYWJsZVNpemUpIGNvbnN0CiB7CiAgICAgc3Rh dGljIGludCBkZXNrdG9wV2lkdGggPSA5ODA7CiAgICAgc3RhdGljIGludCBkZXZpY2VEUEkgPSAx NjA7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmggYi9XZWJLaXQvcXQvQXBp L3F3ZWJwYWdlLmgKaW5kZXggYTIwMDc0Zi4uZTcxZTNkYSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuaApAQCAtMjE3LDEz ICsyMTcsMTMgQEAgcHVibGljOgogCiAgICAgICAgIFFXZWJQYWdlOjpWaWV3cG9ydENvbmZpZ3Vy YXRpb24mIG9wZXJhdG9yPShjb25zdCBRV2ViUGFnZTo6Vmlld3BvcnRDb25maWd1cmF0aW9uJiBv dGhlcik7CiAKLSAgICAgICAgaW5saW5lIHFyZWFsIGluaXRpYWxTY2FsZUZhY3RvcigpIGNvbnN0 IHsgcmV0dXJuIG1faW5pdGlhbFNjYWxlRmFjdG9yOyB9OwotICAgICAgICBpbmxpbmUgcXJlYWwg bWluaW11bVNjYWxlRmFjdG9yKCkgY29uc3QgeyByZXR1cm4gbV9taW5pbXVtU2NhbGVGYWN0b3I7 IH07Ci0gICAgICAgIGlubGluZSBxcmVhbCBtYXhpbXVtU2NhbGVGYWN0b3IoKSBjb25zdCB7IHJl dHVybiBtX21heGltdW1TY2FsZUZhY3RvcjsgfTsKLSAgICAgICAgaW5saW5lIHFyZWFsIGRldmlj ZVBpeGVsUmF0aW8oKSBjb25zdCB7IHJldHVybiBtX2RldmljZVBpeGVsUmF0aW87IH07Ci0gICAg ICAgIGlubGluZSBib29sIGlzVXNlclNjYWxhYmxlKCkgY29uc3QgeyByZXR1cm4gbV9pc1VzZXJT Y2FsYWJsZTsgfTsKLSAgICAgICAgaW5saW5lIGJvb2wgaXNWYWxpZCgpIGNvbnN0IHsgcmV0dXJu IG1faXNWYWxpZDsgfTsKLSAgICAgICAgaW5saW5lIFFTaXplIHNpemUoKSBjb25zdCB7IHJldHVy biBtX3NpemU7IH07CisgICAgICAgIGlubGluZSBxcmVhbCBpbml0aWFsU2NhbGVGYWN0b3IoKSBj b25zdCB7IHJldHVybiBtX2luaXRpYWxTY2FsZUZhY3RvcjsgfQorICAgICAgICBpbmxpbmUgcXJl YWwgbWluaW11bVNjYWxlRmFjdG9yKCkgY29uc3QgeyByZXR1cm4gbV9taW5pbXVtU2NhbGVGYWN0 b3I7IH0KKyAgICAgICAgaW5saW5lIHFyZWFsIG1heGltdW1TY2FsZUZhY3RvcigpIGNvbnN0IHsg cmV0dXJuIG1fbWF4aW11bVNjYWxlRmFjdG9yOyB9CisgICAgICAgIGlubGluZSBxcmVhbCBkZXZp Y2VQaXhlbFJhdGlvKCkgY29uc3QgeyByZXR1cm4gbV9kZXZpY2VQaXhlbFJhdGlvOyB9CisgICAg ICAgIGlubGluZSBib29sIGlzVXNlclNjYWxhYmxlKCkgY29uc3QgeyByZXR1cm4gbV9pc1VzZXJT Y2FsYWJsZTsgfQorICAgICAgICBpbmxpbmUgYm9vbCBpc1ZhbGlkKCkgY29uc3QgeyByZXR1cm4g bV9pc1ZhbGlkOyB9CisgICAgICAgIGlubGluZSBRU2l6ZSBzaXplKCkgY29uc3QgeyByZXR1cm4g bV9zaXplOyB9CiAKICAgICBwcml2YXRlOgogICAgICAgICBRU2hhcmVkRGF0YVBvaW50ZXI8UXRW aWV3cG9ydENvbmZpZ3VyYXRpb25Qcml2YXRlPiBkOwpAQCAtMjc2LDcgKzI3Niw3IEBAIHB1Ymxp YzoKIAogICAgIFFTaXplIHZpZXdwb3J0U2l6ZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0Vmlld3Bv cnRTaXplKGNvbnN0IFFTaXplICZzaXplKSBjb25zdDsKLSAgICBWaWV3cG9ydENvbmZpZ3VyYXRp b24gdmlld3BvcnRDb25maWd1cmF0aW9uRm9yU2l6ZShRU2l6ZSBhdmFpbGFibGVTaXplKSBjb25z dDsKKyAgICBWaWV3cG9ydENvbmZpZ3VyYXRpb24gdmlld3BvcnRDb25maWd1cmF0aW9uRm9yU2l6 ZShjb25zdCBRU2l6ZSYgYXZhaWxhYmxlU2l6ZSkgY29uc3Q7CiAKICAgICBRU2l6ZSBwcmVmZXJy ZWRDb250ZW50c1NpemUoKSBjb25zdDsKICAgICB2b2lkIHNldFByZWZlcnJlZENvbnRlbnRzU2l6 ZShjb25zdCBRU2l6ZSAmc2l6ZSkgY29uc3Q7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAwMzI2M2Y0Li4xYmQ3NWUyIDEwMDY0NAot LS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMC0wOS0yOCAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2Vu LgorCisgICAgICAgIFtRdF0gQ2xlYW4gdXAgUVdlYlBhZ2U6OlZpZXdwb3J0Q29uZmlndXJhdGlv biBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2 NzMwCisKKyAgICAgICAgLSBQYXNzIFFTaXplIHBhcmFtZXRlciBhcyBjb25zdC1yZWZlcmVuY2UK KyAgICAgICAgLSBTdHlsZSBmaXhlcworCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAg ICAgICAgKFFXZWJQYWdlOjp2aWV3cG9ydENvbmZpZ3VyYXRpb25Gb3JTaXplKToKKyAgICAgICAg KiBBcGkvcXdlYnBhZ2UuaDoKKwogMjAxMC0wOS0yOCAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgo=