46723 2010-09-28 07:48:53 -0700 webkit_web_navigation_action_get_button() wrong 2010-10-19 00:58:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED http://webkitgtk.org/reference/webkitgtk-WebKitWebNavigationAction.html#webkit-web-navigation-action-get-button P2 Minor --- 0 prof.maad webkit-unassigned commit-queue prof.maad webkit.review.bot xan.lopez oldest_to_newest 286224 0 prof.maad 2010-09-28 07:48:53 -0700 The documentation in WebKitGTK webkit_web_navigation_action_get_button() states that it returns the following buttons: 0 - left mouse button 1 - middle mouse button 2 - right mouse button This is plain wrong, it returns: 1 - left mouse button 2 - middle mouse button 3 - right mouse button This was probably introduced in this bug report: https://bugs.webkit.org/show_bug.cgi?id=25555 294682 1 xan.lopez 2010-10-15 04:25:41 -0700 You are right, we add + 1 to use the GTK+ button values. Care to make a patch correcting the doc? 294685 2 70849 prof.maad 2010-10-15 04:31:47 -0700 Created attachment 70849 Patch to correct documentation for webkit_web_navigation_action_get_button() This patch corrects the documentation for webkit_web_navigation_action_get_button() to specify the right button codes. 294686 3 prof.maad 2010-10-15 04:32:29 -0700 Please be gentle, this is the very first patch I submitted to a Gtk project, so I had basically no idea what I was doing. 294688 4 70849 xan.lopez 2010-10-15 04:38:19 -0700 Comment on attachment 70849 Patch to correct documentation for webkit_web_navigation_action_get_button() Some comments: - The text appears twice in the file, you need to fix it in both places. - Your fix basically is telling a lie, since those are not the DOM values, but the GTK+ ones. I think we should either tell the whole story, or just say that the identifier for the clicked button is returned, leaving it implicit that it's GTK+'s. I'd vote to do the former. - You need to generate a ChangeLog and set the patch as r? when submitting it. Go over this document (http://webkit.org/coding/contributing.html) quickly, but at the very least I need the ChangeLog to commit your patch :) Thanks! 294712 5 70859 prof.maad 2010-10-15 06:00:41 -0700 Created attachment 70859 Patch to correct documentation for webkit_web_navigation_action_get_button() Adapted the patch to the WebKit guidelines and added a Changelog entry. 294714 6 webkit.review.bot 2010-10-15 06:03:08 -0700 Attachment 70859 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 294716 7 70861 prof.maad 2010-10-15 06:05:55 -0700 Created attachment 70861 Patch to correct documentation for webkit_web_navigation_action_get_button() (with style correction) Corrected style error (tab in ChangeLog). 296033 8 70861 xan.lopez 2010-10-19 00:45:31 -0700 Comment on attachment 70861 Patch to correct documentation for webkit_web_navigation_action_get_button() (with style correction) Looks great, thank you. 296039 9 70861 commit-queue 2010-10-19 00:58:48 -0700 Comment on attachment 70861 Patch to correct documentation for webkit_web_navigation_action_get_button() (with style correction) Clearing flags on attachment: 70861 Committed r70035: <http://trac.webkit.org/changeset/70035> 296040 10 commit-queue 2010-10-19 00:58:54 -0700 All reviewed patches have been landed. Closing bug. 70849 2010-10-15 04:31:47 -0700 2010-10-15 06:00:41 -0700 Patch to correct documentation for webkit_web_navigation_action_get_button() webkit_web_navigation_action_get_button_documentation.patch text/plain 556 prof.maad LS0tIHdlYmtpdHdlYm5hdmlnYXRpb25hY3Rpb24uY3BwCTIwMTAtMTAtMTUgMTM6Mjk6NDIuNzkz MDgxMDQyICswMjAwCisrKyB3ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9uX3BhdGNoZWQuY3BwCTIw MTAtMTAtMTUgMTM6Mjk6MTguNzUyNzcwNzU1ICswMjAwCkBAIC0zMTEsNyArMzExLDcgQEAKICAq IEBuYXZpZ2F0aW9uQWN0aW9uOiBhICNXZWJLaXRXZWJOYXZpZ2F0aW9uQWN0aW9uCiAgKgogICog UmV0dXJucyB0aGUgRE9NIGlkZW50aWZpZXIgZm9yIHRoZSBtb3VzZSBidXR0b24gdXNlZCB0byBj bGljay4KLSAqIERPTSBidXR0b24gdmFsdWVzIGFyZSAwLCAxIGFuZCAyIGZvciBsZWZ0LCBtaWRk bGUgYW5kIHJpZ2h0IGJ1dHRvbnMuCisgKiBET00gYnV0dG9uIHZhbHVlcyBhcmUgMSwgMiBhbmQg MyBmb3IgbGVmdCwgbWlkZGxlIGFuZCByaWdodCBidXR0b25zLgogICogSWYgdGhlIGFjdGlvbiB3 YXMgbm90IGluaXRpYXRlZCBieSBhIG1vdXNlIGNsaWNrLCByZXR1cm5zIC0xLgogICoKICAqIFJl dHVybiB2YWx1ZTogdGhlIG1vdXNlIGJ1dHRvbiB1c2VkIHRvIGNsaWNrCg== 70859 2010-10-15 06:00:41 -0700 2010-10-15 06:05:55 -0700 Patch to correct documentation for webkit_web_navigation_action_get_button() webkit_web_navigation_action_get_button_documentation.patch text/plain 2064 prof.maad SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY5ODUw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAt MTUgIFByb2YuIE1BQUQgIDxoaW1zZWxmQHByb2YtbWFhZC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ29ycmVjdCBlcnJvbmVvdXMg ZG9jdW1lbnRhdGlvbiBmb3Igd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9nZXRfYnV0dG9u KCkKKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDY3MjMKKworICAg ICAgICAqIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYm5hdmlnYXRpb25hY3Rpb24uY3BwOgor CiAyMDEwLTEwLTE0ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCkluZGV4OiBXZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9uLmNwcAkocmV2aXNpb24gNjM3NzMpCisr KyBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9uLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTc3LDggKzE3Nyw4IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfbmF2aWdh dGlvbl9hY3Rpb24KICAgICAvKioKICAgICAgKiBXZWJLaXRXZWJOYXZpZ2F0aW9uQWN0aW9uOmJ1 dHRvbjoKICAgICAgKgotICAgICAqIFRoZSBET00gaWRlbnRpZmllciBmb3IgdGhlIG1vdXNlIGJ1 dHRvbiB1c2VkIHRvIGNsaWNrLiBET00gYnV0dG9uIHZhbHVlcwotICAgICAqIGFyZSAwLCAxIGFu ZCAyIGZvciBsZWZ0LCBtaWRkbGUgYW5kIHJpZ2h0IGJ1dHRvbnMuIElmIHRoZSBhY3Rpb24gd2Fz IG5vdAorICAgICAqIFRoZSBHVEsrIGlkZW50aWZpZXIgZm9yIHRoZSBtb3VzZSBidXR0b24gdXNl ZCB0byBjbGljay4gTm90aWNlIHRoYXQgR1RLKyBidXR0b24gdmFsdWVzCisgICAgICogYXJlIDEs IDIgYW5kIDMgZm9yIGxlZnQsIG1pZGRsZSBhbmQgcmlnaHQgYnV0dG9ucywgc28gdGhleSBhcmUg RE9NIGJ1dHRvbiB2YWx1ZXMgKzEuIElmIHRoZSBhY3Rpb24gd2FzIG5vdAogICAgICAqIGluaXRp YXRlZCBieSBhIG1vdXNlIGNsaWNrIHRoZSB2YWx1ZSB3aWxsIGJlIC0xLgogICAgICAqCiAgICAg ICogU2luY2U6IDEuMC4zCkBAIC0zMTAsOSArMzEwLDkgQEAgdm9pZCB3ZWJraXRfd2ViX25hdmln YXRpb25fYWN0aW9uX3NldF9vcgogICogd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9nZXRf YnV0dG9uOgogICogQG5hdmlnYXRpb25BY3Rpb246IGEgI1dlYktpdFdlYk5hdmlnYXRpb25BY3Rp b24KICAqCi0gKiBSZXR1cm5zIHRoZSBET00gaWRlbnRpZmllciBmb3IgdGhlIG1vdXNlIGJ1dHRv biB1c2VkIHRvIGNsaWNrLgotICogRE9NIGJ1dHRvbiB2YWx1ZXMgYXJlIDAsIDEgYW5kIDIgZm9y IGxlZnQsIG1pZGRsZSBhbmQgcmlnaHQgYnV0dG9ucy4KLSAqIElmIHRoZSBhY3Rpb24gd2FzIG5v dCBpbml0aWF0ZWQgYnkgYSBtb3VzZSBjbGljaywgcmV0dXJucyAtMS4KKyAqIFRoZSBHVEsrIGlk ZW50aWZpZXIgZm9yIHRoZSBtb3VzZSBidXR0b24gdXNlZCB0byBjbGljay4gTm90aWNlIHRoYXQg R1RLKyBidXR0b24gdmFsdWVzCisgKiBhcmUgMSwgMiBhbmQgMyBmb3IgbGVmdCwgbWlkZGxlIGFu ZCByaWdodCBidXR0b25zLCBzbyB0aGV5IGFyZSBET00gYnV0dG9uIHZhbHVlcyArMS4gSWYgdGhl IGFjdGlvbiB3YXMgbm90CisgKiBpbml0aWF0ZWQgYnkgYSBtb3VzZSBjbGljayB0aGUgdmFsdWUg d2lsbCBiZSAtMS4KICAqCiAgKiBSZXR1cm4gdmFsdWU6IHRoZSBtb3VzZSBidXR0b24gdXNlZCB0 byBjbGljawogICoK 70861 2010-10-15 06:05:55 -0700 2010-10-19 00:58:48 -0700 Patch to correct documentation for webkit_web_navigation_action_get_button() (with style correction) webkit_web_navigation_action_get_button_documentation.patch text/plain 2071 prof.maad SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY5ODUw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAt MTUgIFByb2YuIE1BQUQgIDxoaW1zZWxmQHByb2YtbWFhZC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ29ycmVjdCBlcnJvbmVvdXMg ZG9jdW1lbnRhdGlvbiBmb3Igd2Via2l0X3dlYl9uYXZpZ2F0aW9uX2FjdGlvbl9nZXRfYnV0dG9u KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NzIz CisKKyAgICAgICAgKiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJuYXZpZ2F0aW9uYWN0aW9u LmNwcDoKKwogMjAxMC0xMC0xNCAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpJbmRleDogV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2VibmF2aWdhdGlvbmFjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2VibmF2aWdhdGlvbmFjdGlvbi5jcHAJKHJldmlzaW9uIDYz NzczKQorKysgV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VibmF2aWdhdGlvbmFjdGlvbi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE3Nyw4ICsxNzcsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X25hdmlnYXRpb25fYWN0aW9uCiAgICAgLyoqCiAgICAgICogV2ViS2l0V2ViTmF2aWdhdGlvbkFj dGlvbjpidXR0b246CiAgICAgICoKLSAgICAgKiBUaGUgRE9NIGlkZW50aWZpZXIgZm9yIHRoZSBt b3VzZSBidXR0b24gdXNlZCB0byBjbGljay4gRE9NIGJ1dHRvbiB2YWx1ZXMKLSAgICAgKiBhcmUg MCwgMSBhbmQgMiBmb3IgbGVmdCwgbWlkZGxlIGFuZCByaWdodCBidXR0b25zLiBJZiB0aGUgYWN0 aW9uIHdhcyBub3QKKyAgICAgKiBUaGUgR1RLKyBpZGVudGlmaWVyIGZvciB0aGUgbW91c2UgYnV0 dG9uIHVzZWQgdG8gY2xpY2suIE5vdGljZSB0aGF0IEdUSysgYnV0dG9uIHZhbHVlcworICAgICAq IGFyZSAxLCAyIGFuZCAzIGZvciBsZWZ0LCBtaWRkbGUgYW5kIHJpZ2h0IGJ1dHRvbnMsIHNvIHRo ZXkgYXJlIERPTSBidXR0b24gdmFsdWVzICsxLiBJZiB0aGUgYWN0aW9uIHdhcyBub3QKICAgICAg KiBpbml0aWF0ZWQgYnkgYSBtb3VzZSBjbGljayB0aGUgdmFsdWUgd2lsbCBiZSAtMS4KICAgICAg KgogICAgICAqIFNpbmNlOiAxLjAuMwpAQCAtMzEwLDkgKzMxMCw5IEBAIHZvaWQgd2Via2l0X3dl Yl9uYXZpZ2F0aW9uX2FjdGlvbl9zZXRfb3IKICAqIHdlYmtpdF93ZWJfbmF2aWdhdGlvbl9hY3Rp b25fZ2V0X2J1dHRvbjoKICAqIEBuYXZpZ2F0aW9uQWN0aW9uOiBhICNXZWJLaXRXZWJOYXZpZ2F0 aW9uQWN0aW9uCiAgKgotICogUmV0dXJucyB0aGUgRE9NIGlkZW50aWZpZXIgZm9yIHRoZSBtb3Vz ZSBidXR0b24gdXNlZCB0byBjbGljay4KLSAqIERPTSBidXR0b24gdmFsdWVzIGFyZSAwLCAxIGFu ZCAyIGZvciBsZWZ0LCBtaWRkbGUgYW5kIHJpZ2h0IGJ1dHRvbnMuCi0gKiBJZiB0aGUgYWN0aW9u IHdhcyBub3QgaW5pdGlhdGVkIGJ5IGEgbW91c2UgY2xpY2ssIHJldHVybnMgLTEuCisgKiBUaGUg R1RLKyBpZGVudGlmaWVyIGZvciB0aGUgbW91c2UgYnV0dG9uIHVzZWQgdG8gY2xpY2suIE5vdGlj ZSB0aGF0IEdUSysgYnV0dG9uIHZhbHVlcworICogYXJlIDEsIDIgYW5kIDMgZm9yIGxlZnQsIG1p ZGRsZSBhbmQgcmlnaHQgYnV0dG9ucywgc28gdGhleSBhcmUgRE9NIGJ1dHRvbiB2YWx1ZXMgKzEu IElmIHRoZSBhY3Rpb24gd2FzIG5vdAorICogaW5pdGlhdGVkIGJ5IGEgbW91c2UgY2xpY2sgdGhl IHZhbHVlIHdpbGwgYmUgLTEuCiAgKgogICogUmV0dXJuIHZhbHVlOiB0aGUgbW91c2UgYnV0dG9u IHVzZWQgdG8gY2xpY2sKICAqCg==