46715 2010-09-28 04:16:19 -0700 plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown 2010-09-29 16:52:50 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED InRadar, LayoutTestFailure P2 Normal --- 1 aroben webkit-unassigned andersca jhoneycutt oldest_to_newest 286169 0 aroben 2010-09-28 04:16:19 -0700 plugins/npruntime/invoke-failure.html fails in WebKit2 due to a slightly different exception being thrown. Here's the diff: --- /tmp/layout-test-results/plugins/npruntime/invoke-failure-expected.txt 2010-09-27 19:41:55.453000000 -0400 +++ /tmp/layout-test-results/plugins/npruntime/invoke-failure-actual.txt 2010-09-27 19:41:55.453000000 -0400 @@ -1,2 +1,2 @@ -SUCCESS: Exception caught: Error: Error calling method on NPObject! +SUCCESS: Exception caught: Error: Error calling method on NPObject. 286176 1 aroben 2010-09-28 04:30:39 -0700 <rdar://problem/8485909> 287195 2 69270 andersca 2010-09-29 16:14:49 -0700 Created attachment 69270 Patch 287200 3 69270 darin 2010-09-29 16:17:53 -0700 Comment on attachment 69270 Patch Those exclamation points are horrible! 287212 4 andersca 2010-09-29 16:47:49 -0700 I talked to Darin and we agreed to get rid of the exclamation points everywhere instead. 287213 5 69270 andersca 2010-09-29 16:48:01 -0700 Comment on attachment 69270 Patch Clearing review flag. 287219 6 andersca 2010-09-29 16:52:50 -0700 Committed r68716: <http://trac.webkit.org/changeset/68716> 69270 2010-09-29 16:14:49 -0700 2010-09-29 16:48:01 -0700 Patch bug-46715-20100929161447.patch text/plain 2498 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZjBhM2MwNjhlZTg2NjUxYTY2ZjRjMWU2ZTkwOTE0MWY3ODA5YTI0Zi4uYTUzNzgyYjA0MmZmOWFh Y2Q4NjE3MThhMzUwOTg1MDkxZGE1MTMxYiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wOS0yOSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHBsdWdpbnMvbnBydW50aW1lL2ludm9rZS1mYWls dXJlLmh0bWwgZmFpbHMgaW4gV2ViS2l0MiBkdWUgdG8gc2xpZ2h0bHkgZGlmZmVyZW50IGV4Y2Vw dGlvbiBiZWluZyB0aHJvd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ2NzE1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDg1OTA5PgorCisgICAg ICAgIEFkZCBleGNsYW1hdGlvbiBwb2ludHMhCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdp bnMvSlNOUE9iamVjdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkpTTlBPYmplY3Q6OmNhbGxNZXRo b2QpOgorICAgICAgICAoV2ViS2l0OjpKU05QT2JqZWN0OjpjYWxsT2JqZWN0KToKKyAgICAgICAg KFdlYktpdDo6SlNOUE9iamVjdDo6Y2FsbENvbnN0cnVjdG9yKToKKworMjAxMC0wOS0yOSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCiAKICAgICAgICAgSW1wbGVtZW50IG1vcmUgb2YgUGx1Z2luUHJveHkgYW5k IFBMdWdpbkNvbnRyb2xsZXJQcm94eS4KZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL0pTTlBPYmplY3QuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvSlNOUE9i amVjdC5jcHAKaW5kZXggOTQ2NTUyNmEzNzcxODUwNTk0MTQ0ZDUyN2Q5NmY0YjNhMTE0NDA1My4u ODZlOTFjNzIwYzFkMmNlOTNkZWRiZWEwZGE3ZDg4NTcxNGE1YzczNSAxMDA2NDQKLS0tIGEvV2Vi S2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvSlNOUE9iamVjdC5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvSlNOUE9iamVjdC5jcHAKQEAgLTEwOCw3ICsxMDgsNyBAQCBKU1ZhbHVl IEpTTlBPYmplY3Q6OmNhbGxNZXRob2QoRXhlY1N0YXRlKiBleGVjLCBOUElkZW50aWZpZXIgbWV0 aG9kTmFtZSkKICAgICAgICAgcmVsZWFzZU5QVmFyaWFudFZhbHVlKCZhcmd1bWVudHNbaV0pOwog CiAgICAgaWYgKCFyZXR1cm5WYWx1ZSkKLSAgICAgICAgdGhyb3dFcnJvcihleGVjLCBjcmVhdGVF cnJvcihleGVjLCAiRXJyb3IgY2FsbGluZyBtZXRob2Qgb24gTlBPYmplY3QuIikpOworICAgICAg ICB0aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZUVycm9yKGV4ZWMsICJFcnJvciBjYWxsaW5nIG1ldGhv ZCBvbiBOUE9iamVjdCEiKSk7CiAKICAgICBKU1ZhbHVlIHByb3BlcnR5VmFsdWUgPSBtX29iamVj dE1hcC0+Y29udmVydE5QVmFyaWFudFRvSlNWYWx1ZShleGVjLCBnbG9iYWxPYmplY3QoKSwgcmVz dWx0KTsKICAgICByZWxlYXNlTlBWYXJpYW50VmFsdWUoJnJlc3VsdCk7CkBAIC0xNDcsNyArMTQ3 LDcgQEAgSlNDOjpKU1ZhbHVlIEpTTlBPYmplY3Q6OmNhbGxPYmplY3QoSlNDOjpFeGVjU3RhdGUq IGV4ZWMpCiAgICAgICAgIHJlbGVhc2VOUFZhcmlhbnRWYWx1ZSgmYXJndW1lbnRzW2ldKTsKIAog ICAgIGlmICghcmV0dXJuVmFsdWUpCi0gICAgICAgIHRocm93RXJyb3IoZXhlYywgY3JlYXRlRXJy b3IoZXhlYywgIkVycm9yIGNhbGxpbmcgbWV0aG9kIG9uIE5QT2JqZWN0LiIpKTsKKyAgICAgICAg dGhyb3dFcnJvcihleGVjLCBjcmVhdGVFcnJvcihleGVjLCAiRXJyb3IgY2FsbGluZyBtZXRob2Qg b24gTlBPYmplY3QhIikpOwogCiAgICAgSlNWYWx1ZSBwcm9wZXJ0eVZhbHVlID0gbV9vYmplY3RN YXAtPmNvbnZlcnROUFZhcmlhbnRUb0pTVmFsdWUoZXhlYywgZ2xvYmFsT2JqZWN0KCksIHJlc3Vs dCk7CiAgICAgcmVsZWFzZU5QVmFyaWFudFZhbHVlKCZyZXN1bHQpOwpAQCAtMTgyLDcgKzE4Miw3 IEBAIEpTVmFsdWUgSlNOUE9iamVjdDo6Y2FsbENvbnN0cnVjdG9yKEV4ZWNTdGF0ZSogZXhlYykK ICAgICB9CiAKICAgICBpZiAoIXJldHVyblZhbHVlKQotICAgICAgICB0aHJvd0Vycm9yKGV4ZWMs IGNyZWF0ZUVycm9yKGV4ZWMsICJFcnJvciBjYWxsaW5nIG1ldGhvZCBvbiBOUE9iamVjdC4iKSk7 CisgICAgICAgIHRocm93RXJyb3IoZXhlYywgY3JlYXRlRXJyb3IoZXhlYywgIkVycm9yIGNhbGxp bmcgbWV0aG9kIG9uIE5QT2JqZWN0ISIpKTsKICAgICAKICAgICBKU1ZhbHVlIHZhbHVlID0gbV9v YmplY3RNYXAtPmNvbnZlcnROUFZhcmlhbnRUb0pTVmFsdWUoZXhlYywgZ2xvYmFsT2JqZWN0KCks IHJlc3VsdCk7CiAgICAgcmVsZWFzZU5QVmFyaWFudFZhbHVlKCZyZXN1bHQpOwo=