46714 2010-09-28 04:03:38 -0700 WebKitTestRunner needs layoutTestController.setCallCloseOnWebViews 2012-05-28 11:22:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW InRadar, LayoutTestFailure P2 Normal --- 1 aroben kbalazs abecsi andersca eric hugo.lima kbalazs ossy sam webkit.review.bot oldest_to_newest 286165 0 aroben 2010-09-28 04:03:38 -0700 WebKitTestRunner needs layoutTestController.setCallCloseOnWebViews 286175 1 aroben 2010-09-28 04:30:15 -0700 <rdar://problem/8485908> 427893 2 kbalazs 2011-06-27 06:35:45 -0700 Currently it is on the win-wk2 list and also on the mac-snowleopard list with other reason. It should be skipped via the mac-wk2 list to make it skipped on every wk2 platform. 427895 3 98714 kbalazs 2011-06-27 06:37:49 -0700 Created attachment 98714 Patch 427898 4 98714 ossy 2011-06-27 06:44:36 -0700 Comment on attachment 98714 Patch r=me. Please reopen the bug after CQ closed it. :) 427899 5 98714 webkit.review.bot 2011-06-27 06:47:54 -0700 Comment on attachment 98714 Patch Rejecting attachment 98714 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 385, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 441, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/8944341 427900 6 abecsi 2011-06-27 06:52:05 -0700 (In reply to comment #5) > (From update of attachment 98714 [details]) > Rejecting attachment 98714 [details] from commit-queue. > > Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 > > Last 500 characters of output: > cripts/webkitpy/common/system/executive.py", line 385, in run_command > close_fds=self._should_close_fds()) > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 441, in popen > return subprocess.Popen(*args, **kwargs) > File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ > errread, errwrite) > File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child > raise child_exception > TypeError: execv() arg 2 must contain only strings > > Full output: http://queues.webkit.org/results/8944341 Seems, that CQ does not like UTF-8 characters in reviewers names, like in bug https://bugs.webkit.org/show_bug.cgi?id=61890 427914 7 98719 kbalazs 2011-06-27 07:22:26 -0700 Created attachment 98719 Patch One more test is affected by this and need to be skipped. 428040 8 eric 2011-06-27 10:13:29 -0700 (In reply to comment #6) > Seems, that CQ does not like UTF-8 characters in reviewers names, like in bug > https://bugs.webkit.org/show_bug.cgi?id=61890 I suspect it's a config issue on these new CQ bots, due to setting LANG=ascii, etc. 428641 9 98719 ossy 2011-06-27 22:48:19 -0700 Comment on attachment 98719 Patch rs=me, but it seems your patch needs update to be appliable. 428681 10 kbalazs 2011-06-28 00:35:28 -0700 Committed r89900: <http://trac.webkit.org/changeset/89900> 461127 11 abecsi 2011-09-02 03:31:25 -0700 (In reply to comment #10) > Committed r89900: <http://trac.webkit.org/changeset/89900> Can this bug be closed now? 461128 12 abecsi 2011-09-02 03:33:26 -0700 (In reply to comment #11) > (In reply to comment #10) > > Committed r89900: <http://trac.webkit.org/changeset/89900> > > Can this bug be closed now? Please disregard me, this was just skipping the affected tests. Please make it more obvious next time, that the patch only skips tests. 633043 13 hugo.lima 2012-05-24 12:21:50 -0700 Is this function really needed? Only two layouttests uses it: ./plugins/open-and-close-window-with-plugin.html ./plugins/geturlnotify-during-document-teardown.html The chromium implementation does nothing: void LayoutTestController::setCallCloseOnWebViews(const CppArgumentList& arguments, CppVariant* result) { result->setNull(); } The Qt implementation also does nothing. DumpRenderTree/LayoutTestController.{h|cpp} just sets the variable m_callCloseOnWebViews that isn't used anywhere. The other ports didn't have any reference to it. So it's fine to remove it and modify the only two layout tests using it? Regards 633279 14 kbalazs 2012-05-24 15:03:06 -0700 > So it's fine to remove it and modify the only two layout tests using it? I think's it's definitely an improvement to remove such a non-sense feature. 635331 15 hugo.lima 2012-05-28 11:22:49 -0700 (In reply to comment #14) > > So it's fine to remove it and modify the only two layout tests using it? > > I think's it's definitely an improvement to remove such a non-sense feature. I was wrong, some ports including Qt-WK1 really do something on this function, so it's still valid. Sorry for the noise. 98714 2011-06-27 06:37:49 -0700 2011-06-27 07:22:20 -0700 Patch bug-46714-20110627133747.patch text/plain 2748 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODk3NDgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZGI5ZDU4Nzk3Y2QxZWVkYjFkZDFj NDYxMTAxMTRiNmIxOWVlMWQxLi42ZDk5NTE3MzFmMWUyNTg2NDE1NWU5MDYyMmI2ODM5OTY5NGFm Mzc2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjcgIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgbGF5b3V0VGVzdENvbnRyb2xsZXIu c2V0Q2FsbENsb3NlT25XZWJWaWV3cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDY3MTQKKworICAgICAgICBTa2lwIHRoZSB0ZXN0IHZpYSB0aGUgbWFj IGxpc3QgdG8gbWFrZSBpdCBza2lwcGVkIG9uIGV2ZXJ5IHdrMiBwbGF0Zm9ybS4KKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0vd2luLXdrMi9T a2lwcGVkOgorCiAyMDExLTA2LTIzICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvU2tpcHBlZAppbmRleCA0ZjZiZTZmZjA1OTc2NWNkZjI3NzBjNzllZjI1OGZlYTgy NWQ5OTI4Li5hNmQ0YTQxZDlmZjgyYmQyMjdkNjc5MTRkYmY0MDZjNWY4M2M5NjgzIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkCkBAIC0xNTU5LDYgKzE1NTksMTAgQEAgaHR0cC90 ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvcmVwb3J0LXVyaS1mcm9tLWNoaWxk LWZyYW1lLmh0bWwKIHBsdWdpbnMvcHJpdmF0ZS1icm93c2luZy1tb2RlLmh0bWwKIHBsdWdpbnMv cHJpdmF0ZS1icm93c2luZy1tb2RlLTIuaHRtbAogCisjIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMg bGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0Q2FsbENsb3NlT25XZWJWaWV3cworIyBodHRwOi8vd2Vi a2l0Lm9yZy9iLzQ2NzE0CitwbHVnaW5zL2dldHVybG5vdGlmeS1kdXJpbmctZG9jdW1lbnQtdGVh cmRvd24uaHRtbAorCiAjIFNvbWV0aW1lcyBmYWlscwogIyBodHRwOi8vd2Via2l0Lm9yZy9iLzU4 OTkwCiBlZGl0aW5nL3VuZG8vdW5kby1pZnJhbWUtbG9jYXRpb24tY2hhbmdlLmh0bWwKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQtd2syL1NraXBwZWQKaW5kZXggMzUzYjExZmNhODdjMTZlNTg2ZTNmNjI2MzE5 M2Y3YWUzYzRhMTZkYi4uMzU1NmYyYWIyZDhkNDY2NDk2MGQ4ZDVhYTIyNmUxOTQ1YmI0MDZiMCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtd2syL1NraXBwZWQKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQtd2syL1NraXBwZWQKQEAgLTE0OTIsNyArMTQ5Miw2IEBAIGh0 dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLXByb3RvY29sLmh0bWwKICMgVW5l eHBsYWluZWQgcGx1Z2luIGZhaWx1cmVzCiBwbHVnaW5zL2RvY3VtZW50LW9wZW4uaHRtbAogcGx1 Z2lucy9lbWJlZC1wcmVmZXJzLXBsdWdpbnMtZm9yLWltYWdlcy5odG1sCi1wbHVnaW5zL2dldHVy bG5vdGlmeS1kdXJpbmctZG9jdW1lbnQtdGVhcmRvd24uaHRtbAogcGx1Z2lucy9wbHVnaW4taW5p dGlhdGUtcG9wdXAtd2luZG93Lmh0bWwKIHBsdWdpbnMvbmV0c2NhcGUtZG9tLWFjY2Vzcy5odG1s CiBwbHVnaW5zL25wcC1zZXQtd2luZG93LWNhbGxlZC1kdXJpbmctZGVzdHJ1Y3Rpb24uaHRtbApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luLXdrMi9Ta2lwcGVkIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2luLXdrMi9Ta2lwcGVkCmluZGV4IDQ3ZWM2ODRkYmZmNDZhMDk1ZjUw YjViMWUyNGI5Y2U3MDRkYzA3ZGIuLjA4NDU0ZmVkZjI1NjkxMzk2OWM3OTdmZTM5MjFkMmRhNTNl YzgzNjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi13azIvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4td2syL1NraXBwZWQKQEAgLTExMywxMCArMTEz LDYgQEAgcGx1Z2lucy9lbWJlZC1hdHRyaWJ1dGVzLXN0eWxlLmh0bWwKICMgaHR0cDovL3dlYmtp dC5vcmcvYi80NjcxNQogcGx1Z2lucy9ucHJ1bnRpbWUvaW52b2tlLWZhaWx1cmUuaHRtbAogCi0j IFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0Q2FsbENsb3Nl T25XZWJWaWV3cwotIyBodHRwOi8vd2Via2l0Lm9yZy9iLzQ2NzE0Ci1wbHVnaW5zL2dldHVybG5v dGlmeS1kdXJpbmctZG9jdW1lbnQtdGVhcmRvd24uaHRtbAotCiAjIFdlYktpdFRlc3RSdW5uZXIg bmVlZHMgYW4gaW1wbGVtZW50YXRpb24gb2YgZXZlbnRTZW5kZXIKICMgPGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjE5ND4KIHBsdWdpbnMvbW91c2UtZXZlbnRzLWZp eGVkcG9zLmh0bWwK 98719 2011-06-27 07:22:26 -0700 2011-06-28 00:35:47 -0700 Patch bug-46714-20110627142224.patch text/plain 2962 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODk3NDgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZGI5ZDU4Nzk3Y2QxZWVkYjFkZDFj NDYxMTAxMTRiNmIxOWVlMWQxLi4wZjg1MDMxNGU4MjEyN2VkMDc2Yjc2YWE2MjZhMzY5YmM1NDJk ZWViIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjcgIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgbGF5b3V0VGVzdENvbnRyb2xsZXIu c2V0Q2FsbENsb3NlT25XZWJWaWV3cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDY3MTQKKworICAgICAgICBTa2lwIHRoZXNlIHRlc3RzIHZpYSB0aGUg bWFjIGxpc3QgdG8gbWFrZSB0aGVtIHNraXBwZWQgb24gZXZlcnkgd2syIHBsYXRmb3JtLgorICAg ICAgICAqIHBsYXRmb3JtL21hYy13azIvU2tpcHBlZDoKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4t d2syL1NraXBwZWQ6CisKIDIwMTEtMDYtMjMgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLXdrMi9Ta2lwcGVkCmluZGV4IDRmNmJlNmZmMDU5NzY1Y2RmMjc3MGM3OWVmMjU4 ZmVhODI1ZDk5MjguLjQwNDcyMzFlYzAxYjRiYjRmNTM4MGYxODQ1ZGRkMjFhYmM3NTcxOGQgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKQEAgLTE1NTksNiArMTU1OSwxMSBAQCBo dHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9yZXBvcnQtdXJpLWZyb20t Y2hpbGQtZnJhbWUuaHRtbAogcGx1Z2lucy9wcml2YXRlLWJyb3dzaW5nLW1vZGUuaHRtbAogcGx1 Z2lucy9wcml2YXRlLWJyb3dzaW5nLW1vZGUtMi5odG1sCiAKKyMgV2ViS2l0VGVzdFJ1bm5lciBu ZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRDYWxsQ2xvc2VPbldlYlZpZXdzCisjIGh0dHA6 Ly93ZWJraXQub3JnL2IvNDY3MTQKK3BsdWdpbnMvZ2V0dXJsbm90aWZ5LWR1cmluZy1kb2N1bWVu dC10ZWFyZG93bi5odG1sCitwbHVnaW5zL29wZW4tYW5kLWNsb3NlLXdpbmRvdy13aXRoLXBsdWdp bi5odG1sCisKICMgU29tZXRpbWVzIGZhaWxzCiAjIGh0dHA6Ly93ZWJraXQub3JnL2IvNTg5OTAK IGVkaXRpbmcvdW5kby91bmRvLWlmcmFtZS1sb2NhdGlvbi1jaGFuZ2UuaHRtbApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtd2syL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC13azIvU2tpcHBlZAppbmRleCAzNTNiMTFmY2E4N2MxNmU1ODZlM2Y2MjYzMTkzZjdh ZTNjNGExNmRiLi42ZjYwMWQ2MDU0MjE3ZjkwNzk0NjYwZjM3OTZkMWQxNDVhNmRkMWEyIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC13azIvU2tpcHBlZApAQCAtMTQ5MiwxMSArMTQ5Miw5IEBAIGh0dHAv dGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLXByb3RvY29sLmh0bWwKICMgVW5leHBs YWluZWQgcGx1Z2luIGZhaWx1cmVzCiBwbHVnaW5zL2RvY3VtZW50LW9wZW4uaHRtbAogcGx1Z2lu cy9lbWJlZC1wcmVmZXJzLXBsdWdpbnMtZm9yLWltYWdlcy5odG1sCi1wbHVnaW5zL2dldHVybG5v dGlmeS1kdXJpbmctZG9jdW1lbnQtdGVhcmRvd24uaHRtbAogcGx1Z2lucy9wbHVnaW4taW5pdGlh dGUtcG9wdXAtd2luZG93Lmh0bWwKIHBsdWdpbnMvbmV0c2NhcGUtZG9tLWFjY2Vzcy5odG1sCiBw bHVnaW5zL25wcC1zZXQtd2luZG93LWNhbGxlZC1kdXJpbmctZGVzdHJ1Y3Rpb24uaHRtbAotcGx1 Z2lucy9vcGVuLWFuZC1jbG9zZS13aW5kb3ctd2l0aC1wbHVnaW4uaHRtbAogcGx1Z2lucy9wbHVn aW4tamF2YXNjcmlwdC1hY2Nlc3MuaHRtbAogcGx1Z2lucy9yZWxvYWRwbHVnaW5zLWFuZC1wYWdl cy5odG1sCiBwbHVnaW5zL2Rlc3Ryb3ktc3RyZWFtLXR3aWNlLmh0bWwKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3dpbi13azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi13azIvU2tpcHBlZAppbmRleCA0N2VjNjg0ZGJmZjQ2YTA5NWY1MGI1YjFlMjRiOWNlNzA0 ZGMwN2RiLi4wODQ1NGZlZGYyNTY5MTM5NjljNzk3ZmUzOTIxZDJkYTUzZWM4MzYzIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4td2syL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vd2luLXdrMi9Ta2lwcGVkCkBAIC0xMTMsMTAgKzExMyw2IEBAIHBsdWdpbnMv ZW1iZWQtYXR0cmlidXRlcy1zdHlsZS5odG1sCiAjIGh0dHA6Ly93ZWJraXQub3JnL2IvNDY3MTUK IHBsdWdpbnMvbnBydW50aW1lL2ludm9rZS1mYWlsdXJlLmh0bWwKIAotIyBXZWJLaXRUZXN0UnVu bmVyIG5lZWRzIGxheW91dFRlc3RDb250cm9sbGVyLnNldENhbGxDbG9zZU9uV2ViVmlld3MKLSMg aHR0cDovL3dlYmtpdC5vcmcvYi80NjcxNAotcGx1Z2lucy9nZXR1cmxub3RpZnktZHVyaW5nLWRv Y3VtZW50LXRlYXJkb3duLmh0bWwKLQogIyBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIGFuIGltcGxl bWVudGF0aW9uIG9mIGV2ZW50U2VuZGVyCiAjIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDIxOTQ+CiBwbHVnaW5zL21vdXNlLWV2ZW50cy1maXhlZHBvcy5odG1sCg==