46713 2010-09-28 03:56:10 -0700 JSC compile fails on 32bit platform when Regexp Tracing is enabled 2010-09-29 05:46:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pvarga webkit-unassigned barraclough commit-queue msaboff ossy oldest_to_newest 286163 0 pvarga 2010-09-28 03:56:10 -0700 In case of REGEXP_TRACING define is enabled I got the following error during the compile on 32bit platform since -Werror flag is added: cc1plus: warnings being treated as errors ../../../JavaScriptCore/runtime/RegExp.cpp: In member function 'void JSC::RegExp::printTraceData()': ../../../JavaScriptCore/runtime/RegExp.cpp:257: error: format '%014lx' expects type 'long unsigned int', but argument 3 has type 'uintptr_t' 286164 1 69036 pvarga 2010-09-28 03:58:36 -0700 Created attachment 69036 proposed patch 286375 2 msaboff 2010-09-28 10:55:39 -0700 Thanks for looking into this. I have some concerns with %p is that it doesn't include leading zeros and pretty much ignores precision. Did you consider changing the cast to (unsigned long)? 286803 3 69036 ossy 2010-09-29 05:07:10 -0700 Comment on attachment 69036 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=69036&action=review %lx expects "unsigned long int", but uintptr_t is "unsigned long int" on 64 bit and "unsigned int" on 32 bit sizeof(uintptr_t) == sizeof(unsigned long int) always, but unfortunately unsigned int != unsigned long int. :( I propose to cast unsigned long int with reinterpret_cast and use %014lx. I prefer reinterpret_cast instead of obsolete C style cast On 64 bit machine: ------------------- sizeof(int) = 4 sizeof(long int) = 8 sizeof(long long int) = 8 sizeof(uintptr_t) = 8 sizeof(uintptr_t) == sizeof(unsigned long int) == 8 typedef unsigned long int uintptr_t; On 32 bit machine: ------------------- sizeof(int) = 4 sizeof(long int) = 4 sizeof(long long int) = 8 sizeof(uintptr_t) = 4 sizeof(uintptr_t) == sizeof(unsigned long int) == 4 typedef unsigned int uintptr_t; > JavaScriptCore/runtime/RegExp.cpp:257 > - sprintf(jitAddr, "0x%014lx", (uintptr_t)codeBlock.getAddr()); > + sprintf(jitAddr, "%16p", codeBlock.getAddr()); sprintf(jitAddr, "0x%014lx", reinterpret_cast<unsigned long int>(codeBlock.getAddr())); 286806 4 69180 pvarga 2010-09-29 05:23:06 -0700 Created attachment 69180 proposed patch v2 286811 5 69180 commit-queue 2010-09-29 05:46:03 -0700 Comment on attachment 69180 proposed patch v2 Clearing flags on attachment: 69180 Committed r68639: <http://trac.webkit.org/changeset/68639> 286812 6 commit-queue 2010-09-29 05:46:09 -0700 All reviewed patches have been landed. Closing bug. 69036 2010-09-28 03:58:36 -0700 2010-09-29 05:23:06 -0700 proposed patch 0001-trace-fix.patch text/plain 1563 pvarga RnJvbSAyYjA4MTkyOWVkMjJmZDlmNzFlZjIxY2VjNGMzNTViMTQxZDFmOGE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogVHVlLCAyOCBTZXAgMjAxMCAxMjo1NzozNyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHRy YWNlIGZpeAoKLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDEyICsr KysrKysrKysrKwogSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwIHwgICAgMiArLQog MiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwppbmRleCAwNzk0YzM1Li4yZjVjNjBkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTAtMDktMjggIFBldGVyIFZhcmdhICA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0MgY29tcGlsZSBmYWls cyBvbiAzMmJpdCBwbGF0Zm9ybSB3aGVuIFJlZ2V4cCBUcmFjaW5nIGlzIGVuYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NzEzCisKKyAgICAg ICAgQ2hhbmdlIHRoZSBzcHJpbnRmIGZvcm1hdCBpbiByZWdleHAgdHJhY2luZyBmb3IgZml4IHRo ZSBjb21waWxlIHdhcm5pbmcuCisKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cC5jcHA6CisgICAg ICAgIChKU0M6OlJlZ0V4cDo6bWF0Y2gpOgorCiAyMDEwLTA5LTI3ICBNaWNoYWVsIFNhYm9mZiAg PG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVu LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwIGIvSmF2YVNj cmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwCmluZGV4IDQ4NTQwMWEuLmVlYzNkMjMgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwLmNwcAorKysgYi9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1JlZ0V4cC5jcHAKQEAgLTI1NCw3ICsyNTQsNyBAQCBpbnQgUmVnRXhwOjpt YXRjaChjb25zdCBVU3RyaW5nJiBzLCBpbnQgc3RhcnRPZmZzZXQsIFZlY3RvcjxpbnQsIDMyPiog b3ZlY3RvcikKICAgICAgICAgaWYgKGNvZGVCbG9jay5nZXRGYWxsYmFjaygpKQogICAgICAgICAg ICAgc3ByaW50ZihqaXRBZGRyLCAiZmFsbGJhY2siKTsKICAgICAgICAgZWxzZQotICAgICAgICAg ICAgc3ByaW50ZihqaXRBZGRyLCAiMHglMDE0bHgiLCAodWludHB0cl90KWNvZGVCbG9jay5nZXRB ZGRyKCkpOworICAgICAgICAgICAgc3ByaW50ZihqaXRBZGRyLCAiJTE2cCIsIGNvZGVCbG9jay5n ZXRBZGRyKCkpOwogI2Vsc2UKICAgICAgICAgY29uc3QgY2hhciogaml0QWRkciA9ICJKSVQgT2Zm IjsKICNlbmRpZgotLSAKMS43LjIuMgoK 69180 2010-09-29 05:23:06 -0700 2010-09-29 05:46:03 -0700 proposed patch v2 0001-trace-fix-v2.patch text/plain 1596 pvarga RnJvbSBiMjhiYmMzNmQ2ZTNiNjM0N2VlMTg3Mzc5NTIzODY1NmE0NDllMzMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogV2VkLCAyOSBTZXAgMjAxMCAwNToyMDozOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHRy YWNlIGZpeCB2MgoKLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwIHwgICAgMiAr LQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwppbmRleCBmNjRkYzEwLi41NDM3ZmViIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDktMjkgIFBldGVyIFZhcmdhICA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0MgY29tcGlsZSBm YWlscyBvbiAzMmJpdCBwbGF0Zm9ybSB3aGVuIFJlZ2V4cCBUcmFjaW5nIGlzIGVuYWJsZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NzEzCisKKyAg ICAgICAgRml4IHRoZSBjYXN0IG9mIHBvaW50ZXIgaW4gcmVnZXhwIHRyYWNpbmcgdG8gYXZvaWQg dGhlIHdhcm5pbmcuCisKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cC5jcHA6CisgICAgICAgIChK U0M6OlJlZ0V4cDo6bWF0Y2gpOgorCiAyMDEwLTA5LTI4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAt LWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwLmNwcCBiL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvUmVnRXhwLmNwcAppbmRleCA0ODU0MDFhLi4zZWJmZTBmIDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cC5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9SZWdFeHAuY3BwCkBAIC0yNTQsNyArMjU0LDcgQEAgaW50IFJlZ0V4cDo6bWF0Y2goY29u c3QgVVN0cmluZyYgcywgaW50IHN0YXJ0T2Zmc2V0LCBWZWN0b3I8aW50LCAzMj4qIG92ZWN0b3Ip CiAgICAgICAgIGlmIChjb2RlQmxvY2suZ2V0RmFsbGJhY2soKSkKICAgICAgICAgICAgIHNwcmlu dGYoaml0QWRkciwgImZhbGxiYWNrIik7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHNwcmlu dGYoaml0QWRkciwgIjB4JTAxNGx4IiwgKHVpbnRwdHJfdCljb2RlQmxvY2suZ2V0QWRkcigpKTsK KyAgICAgICAgICAgIHNwcmludGYoaml0QWRkciwgIjB4JTAxNGx4IiwgcmVpbnRlcnByZXRfY2Fz dDx1bnNpZ25lZCBsb25nIGludD4oY29kZUJsb2NrLmdldEFkZHIoKSkpOwogI2Vsc2UKICAgICAg ICAgY29uc3QgY2hhciogaml0QWRkciA9ICJKSVQgT2ZmIjsKICNlbmRpZgotLSAKMS43LjIuMgoK