46709 2010-09-28 03:16:57 -0700 [gtk] Fedora has a different path for the liberation fonts 2010-09-28 13:19:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned mrobinson oldest_to_newest 286141 0 alex 2010-09-28 03:16:57 -0700 DRT fails with the error: Could not find font at /usr/share/fonts/truetype/ttf-liberation/LiberationMono-BoldItalic.ttf. Either install this font or file a bug at http://bugs.webkit.org if it is installed in another location. Checking the location of the fonts: % rpm -ql liberation-sans-fonts-1.05.1.20090721-2.fc12.noarch /usr/share/fonts/liberation /usr/share/fonts/liberation/LiberationSans-Bold.ttf /usr/share/fonts/liberation/LiberationSans-BoldItalic.ttf /usr/share/fonts/liberation/LiberationSans-Italic.ttf /usr/share/fonts/liberation/LiberationSans-Regular.ttf 286301 1 69062 mrobinson 2010-09-28 09:34:07 -0700 Created attachment 69062 Patch for this issue 286307 2 alex 2010-09-28 09:49:18 -0700 Looks good, I tested it in Fedora and it worked. 286480 3 69062 gustavo 2010-09-28 13:04:30 -0700 Comment on attachment 69062 Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=69062&action=review OK. > WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:187 > + needless empty line 286489 4 mrobinson 2010-09-28 13:19:25 -0700 Committed r68554: <http://trac.webkit.org/changeset/68554> 69062 2010-09-28 09:34:07 -0700 2010-09-28 13:04:30 -0700 Patch for this issue bug-46709-20100928093407.patch text/plain 5935 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1MDEyOTAzMjFmNWViODc1NmRhNjNkODY5Zjg5MmZjZTRkMDAzMGU2Li4zZjRkZWIz YzBiNThhOGI2ZWQzOWVhMmI4MDQ3MGU2YTBlZDY0N2I3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDktMjggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtndGtdIEZlZG9y YSBoYXMgYSBkaWZmZXJlbnQgcGF0aCBmb3IgdGhlIGxpYmVyYXRpb24gZm9udHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ2NzA5CisKKyAgICAgICAg V2hlbiBzZWFyY2hpbmcgZm9yIERSVCBmb250cywgYWxzbyBsb29rIGluIHRoZSBwYXRoIHdoZXJl IHRob3NlIGZvbnRzCisgICAgICAgIGFyZSBjb21tb25seSBmb3VuZCBvbiBGZWRvcmEgc3lzdGVt cy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6Cisg ICAgICAgIChpbml0aWFsaXplRm9udHMpOiBJbmNsdWRlIGxvZ2ljIGZvciBsb29raW5nIGZvciBG ZWRvcmEtc3R5bGUgZm9udCBwYXRocy4KKwogMjAxMC0wOS0yOCAgxLBzbWFpbCBEw7ZubWV6ICA8 aXNtYWlsQG5hbXRyYWMub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcu CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNw cAppbmRleCAwNzI3MGY1YjQ0ZGE2ODUzOWFlZTJhODc1NTU0M2E1OTMyMDFiZDM3Li41MjFhMGUx MWYwMTNlNDQyMGVkMzAzYWExMWQwMjIzYzA1ZjBiYWJjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTE1MCwzMSArMTUwLDU0 IEBAIHN0YXRpYyB2b2lkIGluaXRpYWxpemVGb250cygpCiAgICAgaWYgKCFGY0NvbmZpZ1BhcnNl QW5kTG9hZChjb25maWcsIHJlaW50ZXJwcmV0X2Nhc3Q8RmNDaGFyOCo+KGZvbnRDb25maWdGaWxl bmFtZS5nZXQoKSksIHRydWUpKQogICAgICAgICBnX2Vycm9yKCJDb3VsZG4ndCBsb2FkIGZvbnQg Y29uZmlndXJhdGlvbiBmaWxlIGZyb206ICVzIiwgZm9udENvbmZpZ0ZpbGVuYW1lLmdldCgpKTsK IAotICAgIHN0YXRpYyBjb25zdCBjaGFyICpjb25zdCBmb250UGF0aHNbXSA9IHsKLSAgICAgICAg Ii91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvbk1vbm8t Qm9sZEl0YWxpYy50dGYiLAotICAgICAgICAiL3Vzci9zaGFyZS9mb250cy90cnVldHlwZS90dGYt bGliZXJhdGlvbi9MaWJlcmF0aW9uTW9uby1Cb2xkLnR0ZiIsCi0gICAgICAgICIvdXNyL3NoYXJl L2ZvbnRzL3RydWV0eXBlL3R0Zi1saWJlcmF0aW9uL0xpYmVyYXRpb25Nb25vLUl0YWxpYy50dGYi LAotICAgICAgICAiL3Vzci9zaGFyZS9mb250cy90cnVldHlwZS90dGYtbGliZXJhdGlvbi9MaWJl cmF0aW9uTW9uby1SZWd1bGFyLnR0ZiIsCi0gICAgICAgICIvdXNyL3NoYXJlL2ZvbnRzL3RydWV0 eXBlL3R0Zi1saWJlcmF0aW9uL0xpYmVyYXRpb25TYW5zLUJvbGRJdGFsaWMudHRmIiwKLSAgICAg ICAgIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvblNh bnMtQm9sZC50dGYiLAotICAgICAgICAiL3Vzci9zaGFyZS9mb250cy90cnVldHlwZS90dGYtbGli ZXJhdGlvbi9MaWJlcmF0aW9uU2Fucy1JdGFsaWMudHRmIiwKLSAgICAgICAgIi91c3Ivc2hhcmUv Zm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvblNhbnMtUmVndWxhci50dGYi LAotICAgICAgICAiL3Vzci9zaGFyZS9mb250cy90cnVldHlwZS90dGYtbGliZXJhdGlvbi9MaWJl cmF0aW9uU2VyaWYtQm9sZEl0YWxpYy50dGYiLAotICAgICAgICAiL3Vzci9zaGFyZS9mb250cy90 cnVldHlwZS90dGYtbGliZXJhdGlvbi9MaWJlcmF0aW9uU2VyaWYtQm9sZC50dGYiLAotICAgICAg ICAiL3Vzci9zaGFyZS9mb250cy90cnVldHlwZS90dGYtbGliZXJhdGlvbi9MaWJlcmF0aW9uU2Vy aWYtSXRhbGljLnR0ZiIsCi0gICAgICAgICIvdXNyL3NoYXJlL2ZvbnRzL3RydWV0eXBlL3R0Zi1s aWJlcmF0aW9uL0xpYmVyYXRpb25TZXJpZi1SZWd1bGFyLnR0ZiIsCi0gICAgICAgICIvdXNyL3No YXJlL2ZvbnRzL3RydWV0eXBlL3R0Zi1kZWphdnUvRGVqYVZ1U2Fucy50dGYiLAorICAgIHN0YXRp YyBjb25zdCBjaGFyICpjb25zdCBmb250UGF0aHNbXVsyXSA9IHsKKyAgICAgICAgeyAiL3Vzci9z aGFyZS9mb250cy90cnVldHlwZS90dGYtbGliZXJhdGlvbi9MaWJlcmF0aW9uTW9uby1Cb2xkSXRh bGljLnR0ZiIsCisgICAgICAgICAgIi91c3Ivc2hhcmUvZm9udHMvbGliZXJhdGlvbi9MaWJlcmF0 aW9uTW9uby1Cb2xkSXRhbGljLnR0ZiIsIH0sCisgICAgICAgIHsgIi91c3Ivc2hhcmUvZm9udHMv dHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvbk1vbm8tQm9sZC50dGYiLAorICAgICAg ICAgICIvdXNyL3NoYXJlL2ZvbnRzL2xpYmVyYXRpb24vTGliZXJhdGlvbk1vbm8tQm9sZC50dGYi LCB9LAorICAgICAgICB7ICIvdXNyL3NoYXJlL2ZvbnRzL3RydWV0eXBlL3R0Zi1saWJlcmF0aW9u L0xpYmVyYXRpb25Nb25vLUl0YWxpYy50dGYiLAorICAgICAgICAgICIvdXNyL3NoYXJlL2ZvbnRz L2xpYmVyYXRpb24vTGliZXJhdGlvbk1vbm8tSXRhbGljLnR0ZiIsIH0sCisgICAgICAgIHsgIi91 c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvbk1vbm8tUmVn dWxhci50dGYiLAorICAgICAgICAgICIvdXNyL3NoYXJlL2ZvbnRzL2xpYmVyYXRpb24vTGliZXJh dGlvbk1vbm8tUmVndWxhci50dGYiLCB9LAorICAgICAgICB7ICIvdXNyL3NoYXJlL2ZvbnRzL3Ry dWV0eXBlL3R0Zi1saWJlcmF0aW9uL0xpYmVyYXRpb25TYW5zLUJvbGRJdGFsaWMudHRmIiwKKyAg ICAgICAgICAiL3Vzci9zaGFyZS9mb250cy9saWJlcmF0aW9uL0xpYmVyYXRpb25TYW5zLUJvbGRJ dGFsaWMudHRmIiwgfSwKKyAgICAgICAgeyAiL3Vzci9zaGFyZS9mb250cy90cnVldHlwZS90dGYt bGliZXJhdGlvbi9MaWJlcmF0aW9uU2Fucy1Cb2xkLnR0ZiIsCisgICAgICAgICAgIi91c3Ivc2hh cmUvZm9udHMvbGliZXJhdGlvbi9MaWJlcmF0aW9uU2Fucy1Cb2xkLnR0ZiIsIH0sCisgICAgICAg IHsgIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvblNh bnMtSXRhbGljLnR0ZiIsCisgICAgICAgICAgIi91c3Ivc2hhcmUvZm9udHMvbGliZXJhdGlvbi9M aWJlcmF0aW9uU2Fucy1JdGFsaWMudHRmIiwgfSwKKyAgICAgICAgeyAiL3Vzci9zaGFyZS9mb250 cy90cnVldHlwZS90dGYtbGliZXJhdGlvbi9MaWJlcmF0aW9uU2Fucy1SZWd1bGFyLnR0ZiIsCisg ICAgICAgICAgIi91c3Ivc2hhcmUvZm9udHMvbGliZXJhdGlvbi9MaWJlcmF0aW9uU2Fucy1SZWd1 bGFyLnR0ZiIsIH0sCisgICAgICAgIHsgIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxp YmVyYXRpb24vTGliZXJhdGlvblNlcmlmLUJvbGRJdGFsaWMudHRmIiwKKyAgICAgICAgICAiL3Vz ci9zaGFyZS9mb250cy9saWJlcmF0aW9uL0xpYmVyYXRpb25TZXJpZi1Cb2xkSXRhbGljLnR0ZiIs IH0sCisgICAgICAgIHsgIi91c3Ivc2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24v TGliZXJhdGlvblNlcmlmLUJvbGQudHRmIiwKKyAgICAgICAgICAiL3Vzci9zaGFyZS9mb250cy9s aWJlcmF0aW9uL0xpYmVyYXRpb25TZXJpZi1Cb2xkLnR0ZiIsIH0sCisgICAgICAgIHsgIi91c3Iv c2hhcmUvZm9udHMvdHJ1ZXR5cGUvdHRmLWxpYmVyYXRpb24vTGliZXJhdGlvblNlcmlmLUl0YWxp Yy50dGYiLAorICAgICAgICAgICIvdXNyL3NoYXJlL2ZvbnRzL2xpYmVyYXRpb24vTGliZXJhdGlv blNlcmlmLUl0YWxpYy50dGYiLCB9LAorICAgICAgICB7ICIvdXNyL3NoYXJlL2ZvbnRzL3RydWV0 eXBlL3R0Zi1saWJlcmF0aW9uL0xpYmVyYXRpb25TZXJpZi1SZWd1bGFyLnR0ZiIsCisgICAgICAg ICAgIi91c3Ivc2hhcmUvZm9udHMvbGliZXJhdGlvbi9MaWJlcmF0aW9uU2VyaWYtUmVndWxhci50 dGYiLCB9LAorICAgICAgICB7ICIvdXNyL3NoYXJlL2ZvbnRzL3RydWV0eXBlL3R0Zi1kZWphdnUv RGVqYVZ1U2Fucy50dGYiLAorICAgICAgICAgICIvdXNyL3NoYXJlL2ZvbnRzL2RlamF2dS9EZWph VnVTYW5zLnR0ZiIsIH0sCiAgICAgfTsKIAogICAgIC8vIFRPRE86IFNvbWUgdGVzdHMgdXNlIEx1 Y2lkYS4gV2Ugc2hvdWxkIGxvYWQgdGhlc2UgYXMgd2VsbCwgb25jZSBpdCBiZWNvbWVzCiAgICAg Ly8gY2xlYXIgaG93IHRvIGluc3RhbGwgdGhlc2UgZm9udHMgZWFzaWx5IG9uIEZlZG9yYS4KLSAg ICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IEdfTl9FTEVNRU5UUyhmb250UGF0aHMpOyBpKyspIHsK LSAgICAgICAgaWYgKCFnX2ZpbGVfdGVzdChmb250UGF0aHNbaV0sIEdfRklMRV9URVNUX0VYSVNU UykpCi0gICAgICAgICAgICBnX2Vycm9yKCJDb3VsZCBub3QgZmluZCBmb250IGF0ICVzLiBFaXRo ZXIgaW5zdGFsbCB0aGlzIGZvbnQgb3IgZmlsZSAiCi0gICAgICAgICAgICAgICAgICAgICJhIGJ1 ZyBhdCBodHRwOi8vYnVncy53ZWJraXQub3JnIGlmIGl0IGlzIGluc3RhbGxlZCBpbiBhbm90aGVy IGxvY2F0aW9uLiIsCi0gICAgICAgICAgICAgICAgICAgIGZvbnRQYXRoc1tpXSk7Ci0gICAgICAg IGlmICghRmNDb25maWdBcHBGb250QWRkRmlsZShjb25maWcsIHJlaW50ZXJwcmV0X2Nhc3Q8Y29u c3QgRmNDaGFyOCo+KGZvbnRQYXRoc1tpXSkpKQotICAgICAgICAgICAgZ19lcnJvcigiQ291bGQg bm90IGxvYWQgZm9udCBhdCAlcyEiLCBmb250UGF0aHNbaV0pOworICAgIGZvciAoc2l6ZV90IGZv bnQgPSAwOyBmb250IDwgR19OX0VMRU1FTlRTKGZvbnRQYXRocyk7IGZvbnQrKykgeworICAgICAg ICBib29sIGZvdW5kID0gZmFsc2U7CisgICAgICAgIGZvciAoc2l6ZV90IHBhdGggPSAwOyBwYXRo IDwgMjsgcGF0aCsrKSB7CisKKyAgICAgICAgICAgIGlmIChnX2ZpbGVfdGVzdChmb250UGF0aHNb Zm9udF1bcGF0aF0sIEdfRklMRV9URVNUX0VYSVNUUykpIHsKKyAgICAgICAgICAgICAgICBmb3Vu ZCA9IHRydWU7CisgICAgICAgICAgICAgICAgaWYgKCFGY0NvbmZpZ0FwcEZvbnRBZGRGaWxlKGNv bmZpZywgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBGY0NoYXI4Kj4oZm9udFBhdGhzW2ZvbnRdW3Bh dGhdKSkpCisgICAgICAgICAgICAgICAgICAgIGdfZXJyb3IoIkNvdWxkIG5vdCBsb2FkIGZvbnQg YXQgJXMhIiwgZm9udFBhdGhzW2ZvbnRdW3BhdGhdKTsKKyAgICAgICAgICAgICAgICBlbHNlCisg ICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorICAgICAgICB9CisKKyAg ICAgICAgaWYgKCFmb3VuZCkKKyAgICAgICAgICAgIGdfZXJyb3IoIkNvdWxkIG5vdCBmaW5kIGZv bnQgYXQgJXMuIEVpdGhlciBpbnN0YWxsIHRoaXMgZm9udCBvciBmaWxlIGEgYnVnICIKKyAgICAg ICAgICAgICAgICAgICAgImF0IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcgaWYgaXQgaXMgaW5zdGFs bGVkIGluIGFub3RoZXIgbG9jYXRpb24uIiwKKyAgICAgICAgICAgICAgICAgICAgZm9udFBhdGhz W2ZvbnRdWzBdKTsKICAgICB9CiAKICAgICAvLyBBaGVtIGlzIHVzZWQgYnkgbWFueSBsYXlvdXQg dGVzdHMuCg==