46707 2010-09-28 02:24:20 -0700 Remove unused accessibility functions from webkit. 2010-10-06 22:32:03 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 ctguil webkit-unassigned cfleizach commit-queue dglazkov oldest_to_newest 286131 0 ctguil 2010-09-28 02:24:20 -0700 Chromium no longer makes sure of WebAccessibilityCache::IsValidId and WebViewClient::focusAccessibilityObject. 290794 1 70034 ctguil 2010-10-06 22:01:30 -0700 Created attachment 70034 Patch 290797 2 70034 cfleizach 2010-10-06 22:08:09 -0700 Comment on attachment 70034 Patch r=me 290806 3 70034 commit-queue 2010-10-06 22:31:58 -0700 Comment on attachment 70034 Patch Clearing flags on attachment: 70034 Committed r69274: <http://trac.webkit.org/changeset/69274> 290807 4 commit-queue 2010-10-06 22:32:03 -0700 All reviewed patches have been landed. Closing bug. 70034 2010-10-06 22:01:30 -0700 2010-10-06 22:31:58 -0700 Patch MyPatch.txt text/plain 6983 ctguil SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjkyNjApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMDYgIENocmlz IEd1aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGFjY2Vzc2liaWxp dHkgZnVuY3Rpb25zIGZyb20gd2Via2l0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9hdHRhY2htZW50LmNnaT9idWdpZD00NjcwNworCisgICAgICAgICogcHVibGljL1dlYkFjY2Vz c2liaWxpdHlDYWNoZS5oOgorICAgICAgICAqIHB1YmxpYy9XZWJWaWV3Q2xpZW50Lmg6CisgICAg ICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVD bGllbnRJbXBsOjpmb2N1c2VkTm9kZUNoYW5nZWQpOgorICAgICAgICAqIHNyYy9XZWJBY2Nlc3Np YmlsaXR5Q2FjaGVJbXBsLmNwcDoKKyAgICAgICAgKiBzcmMvV2ViQWNjZXNzaWJpbGl0eUNhY2hl SW1wbC5oOgorCiAyMDEwLTEwLTA2ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0eUNhY2hlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5Q2FjaGUuaAkocmV2aXNpb24gNjkyNTkp CisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkFjY2Vzc2liaWxpdHlDYWNoZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01MSw3ICs1MSw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNJ bml0aWFsaXplZCgpIGNvbnN0ID0gMDsKIAogICAgIHZpcnR1YWwgV2ViQWNjZXNzaWJpbGl0eU9i amVjdCBnZXRPYmplY3RCeUlkKGludCkgPSAwOwotICAgIHZpcnR1YWwgYm9vbCBpc1ZhbGlkSWQo aW50KSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCBpbnQgYWRkT3JHZXRJZChjb25zdCBXZWJBY2Nl c3NpYmlsaXR5T2JqZWN0JiBvYmplY3QpID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgaXNDYWNoZWQo Y29uc3QgV2ViQWNjZXNzaWJpbGl0eU9iamVjdCYpID0gMDsKIApJbmRleDogV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJKHJldmlzaW9uIDY5MjU5KQorKysgV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3MiwxMCArMjcy LDYgQEAgcHVibGljOgogCiAgICAgLy8gQWNjZXNzaWJpbGl0eSAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKLSAgICAvLyBOb3RpZmllcyBl bWJlZGRlciB0aGF0IHRoZSBmb2N1cyBoYXMgY2hhbmdlZCB0byB0aGUgZ2l2ZW4KLSAgICAvLyBh Y2Nlc3NpYmlsaXR5IG9iamVjdC4KLSAgICB2aXJ0dWFsIHZvaWQgZm9jdXNBY2Nlc3NpYmlsaXR5 T2JqZWN0KGNvbnN0IFdlYkFjY2Vzc2liaWxpdHlPYmplY3QmKSB7IH0KLQogICAgIC8vIE5vdGlm aWVzIGVtYmVkZGVyIGFib3V0IGFuIGFjY2Vzc2liaWxpdHkgbm90aWZpY2F0aW9uLgogICAgIHZp cnR1YWwgdm9pZCBwb3N0QWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbihjb25zdCBXZWJBY2Nlc3Np YmlsaXR5T2JqZWN0JiwgV2ViQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbikgeyB9CiAKSW5kZXg6 IFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNjkyNTkp CisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNDgsMjggKzI0OCw2IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6Zm9jdXNlZE5v ZGVDaGFuZ2UKICAgICAgICAgICAgIGZvY3VzVVJMID0gaGl0VGVzdC5hYnNvbHV0ZUxpbmtVUkwo KTsKICAgICB9CiAgICAgbV93ZWJWaWV3LT5jbGllbnQoKS0+c2V0S2V5Ym9hcmRGb2N1c1VSTChm b2N1c1VSTCk7Ci0gICAgCi0gICAgaWYgKCFub2RlKQotICAgICAgICByZXR1cm47Ci0KLSAgICAv LyBJZiBhY2Nlc3NpYmlsaXR5IGlzIGVuYWJsZWQsIHdlIHNob3VsZCBub3RpZnkgYXNzaXN0aXZl IHRlY2hub2xvZ3kgdGhhdAotICAgIC8vIHRoZSBhY3RpdmUgQWNjZXNzaWJpbGl0eU9iamVjdCBj aGFuZ2VkLgotICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG5vZGUtPmRvY3VtZW50KCk7Ci0gICAg aWYgKCFkb2N1bWVudCkgewotICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAg cmV0dXJuOwotICAgIH0KLQotICAgIC8vIFRPRE86IFJlbW92ZSBvbmNlIHRoZSBGb2N1c2VkVUlF bGVtZW50Q2hhbmdlZCBub3RpZmljYXRpb24gaXMgaGFuZGxlZCBkb3duc3RyZWFtLgotICAgIGlm IChkb2N1bWVudCAmJiBkb2N1bWVudC0+YXhPYmplY3RDYWNoZSgpLT5hY2Nlc3NpYmlsaXR5RW5h YmxlZCgpKSB7Ci0gICAgICAgIC8vIFJldHJpZXZlIHRoZSBmb2N1c2VkIEFjY2Vzc2liaWxpdHlP YmplY3QuCi0gICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGZvY3VzZWRBY2NPYmogPQotICAg ICAgICAgICAgZG9jdW1lbnQtPmF4T2JqZWN0Q2FjaGUoKS0+Z2V0T3JDcmVhdGUobm9kZS0+cmVu ZGVyZXIoKSk7Ci0KLSAgICAgICAgLy8gQWxlcnQgYXNzaXN0aXZlIHRlY2hub2xvZ3kgdGhhdCBm b2N1cyBjaGFuZ2VkLgotICAgICAgICBpZiAoZm9jdXNlZEFjY09iaikKLSAgICAgICAgICAgIG1f d2ViVmlldy0+Y2xpZW50KCktPmZvY3VzQWNjZXNzaWJpbGl0eU9iamVjdChXZWJBY2Nlc3NpYmls aXR5T2JqZWN0KGZvY3VzZWRBY2NPYmopKTsKLSAgICB9CiB9CiAKIFBhZ2UqIENocm9tZUNsaWVu dEltcGw6OmNyZWF0ZVdpbmRvdygKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNz aWJpbGl0eUNhY2hlSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJBY2Nlc3NpYmlsaXR5Q2FjaGVJbXBsLmNwcAkocmV2aXNpb24gNjkyNTkpCisrKyBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxpdHlDYWNoZUltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMTgsMTEgKzExOCw2IEBAIFdlYkFjY2Vzc2liaWxpdHlPYmplY3QgV2ViQWNjZXNzaWJp bGl0eUMKICAgICByZXR1cm4gV2ViQWNjZXNzaWJpbGl0eU9iamVjdChpdC0+c2Vjb25kLT5hY2Nl c3NpYmlsaXR5T2JqZWN0KCkpOwogfQogCi1ib29sIFdlYkFjY2Vzc2liaWxpdHlDYWNoZUltcGw6 OmlzVmFsaWRJZChpbnQgaWQpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGlkID49IGZpcnN0T2JqZWN0 SWQ7Ci19Ci0KIHZvaWQgV2ViQWNjZXNzaWJpbGl0eUNhY2hlSW1wbDo6cmVtb3ZlKGludCBpZCkK IHsKICAgICBPYmplY3RNYXA6Oml0ZXJhdG9yIGl0ID0gbV9vYmplY3RNYXAuZmluZChpZCk7Cklu ZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxpdHlDYWNoZUltcGwuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxpdHlDYWNoZUltcGwu aAkocmV2aXNpb24gNjkyNTkpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2liaWxp dHlDYWNoZUltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUsNiBAQCBwdWJsaWM6CiAg ICAgdmlydHVhbCBib29sIGlzSW5pdGlhbGl6ZWQoKSBjb25zdCB7IHJldHVybiBtX2luaXRpYWxp emVkOyB9CiAKICAgICB2aXJ0dWFsIFdlYkFjY2Vzc2liaWxpdHlPYmplY3QgZ2V0T2JqZWN0QnlJ ZChpbnQpOwotICAgIHZpcnR1YWwgYm9vbCBpc1ZhbGlkSWQoaW50KSBjb25zdDsKICAgICB2aXJ0 dWFsIGludCBhZGRPckdldElkKGNvbnN0IFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdCYp OwogICAgIHZpcnR1YWwgYm9vbCBpc0NhY2hlZChjb25zdCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0 Jik7CiAKSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDY5MjYwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMDYgIENocmlzIEd1aWxs b3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGFjY2Vzc2liaWxpdHkgZnVu Y3Rpb25zIGZyb20gd2Via2l0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9hdHRh Y2htZW50LmNnaT9idWdpZD00NjcwNworCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vV2ViVmlld0hvc3QuY3BwOgorICAgICAgICAoV2ViVmlld0hvc3Q6OnBvc3RBY2Nlc3NpYmls aXR5Tm90aWZpY2F0aW9uKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJW aWV3SG9zdC5oOgorCiAyMDEwLTEwLTA2ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K SW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJW aWV3SG9zdC5jcHAJKHJldmlzaW9uIDY5MjU5KQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00ODUsMTMgKzQ4 NSwxMSBAQCBpbnQgV2ViVmlld0hvc3Q6Omhpc3RvcnlGb3J3YXJkTGlzdENvdW50CiAgICAgcmV0 dXJuIG5hdmlnYXRpb25Db250cm9sbGVyKCktPmVudHJ5Q291bnQoKSAtIGN1cnJlbnRJbmRleCAt IDE7CiB9CiAKLXZvaWQgV2ViVmlld0hvc3Q6OmZvY3VzQWNjZXNzaWJpbGl0eU9iamVjdChjb25z dCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0JiBvYmplY3QpCi17Ci0gICAgbV9zaGVsbC0+YWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZEVsZW1lbnQob2JqZWN0KTsKLX0KLQogdm9p ZCBXZWJWaWV3SG9zdDo6cG9zdEFjY2Vzc2liaWxpdHlOb3RpZmljYXRpb24oY29uc3QgV2ViQWNj ZXNzaWJpbGl0eU9iamVjdCYgb2JqLCBXZWJBY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9uIG5vdGlm aWNhdGlvbikKIHsKKyAgICBpZiAobm90aWZpY2F0aW9uID09IFdlYkFjY2Vzc2liaWxpdHlOb3Rp ZmljYXRpb25Gb2N1c2VkVUlFbGVtZW50Q2hhbmdlZCkKKyAgICAgICAgbV9zaGVsbC0+YWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZEVsZW1lbnQob2JqKTsKKwogICAgIGlmICht X3NoZWxsLT5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcigpLT5zaG91bGREdW1wQWNjZXNzaWJpbGl0 eU5vdGlmaWNhdGlvbnMoKSkgewogICAgICAgICBwcmludGYoIkFjY2Vzc2liaWxpdHlOb3RpZmlj YXRpb24gLSAiKTsKIApJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v V2ViVmlld0hvc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJWaWV3SG9zdC5oCShyZXZpc2lvbiA2OTI1OSkKKysrIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEy Nyw3ICsxMjcsNiBAQCBjbGFzcyBXZWJWaWV3SG9zdCA6IHB1YmxpYyBXZWJLaXQ6OldlYlZpCiAg ICAgdmlydHVhbCB2b2lkIG5hdmlnYXRlQmFja0ZvcndhcmRTb29uKGludCBvZmZzZXQpOwogICAg IHZpcnR1YWwgaW50IGhpc3RvcnlCYWNrTGlzdENvdW50KCk7CiAgICAgdmlydHVhbCBpbnQgaGlz dG9yeUZvcndhcmRMaXN0Q291bnQoKTsKLSAgICB2aXJ0dWFsIHZvaWQgZm9jdXNBY2Nlc3NpYmls aXR5T2JqZWN0KGNvbnN0IFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdCYpOwogICAgIHZp cnR1YWwgdm9pZCBwb3N0QWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbihjb25zdCBXZWJLaXQ6Oldl YkFjY2Vzc2liaWxpdHlPYmplY3QmLCBXZWJLaXQ6OldlYkFjY2Vzc2liaWxpdHlOb3RpZmljYXRp b24pOwogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJOb3RpZmljYXRpb25QcmVzZW50ZXIqIG5vdGlm aWNhdGlvblByZXNlbnRlcigpOwogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJHZW9sb2NhdGlvblNl cnZpY2UqIGdlb2xvY2F0aW9uU2VydmljZSgpOwo=