46702 2010-09-28 00:35:33 -0700 Remove unnecessary cacheFlush calls from Thumb-2 2010-09-30 01:37:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Minor --- 1 loki webkit-unassigned barraclough commit-queue oldest_to_newest 286118 0 loki 2010-09-28 00:35:33 -0700 There are several redundant cacheFlush calls in Thumb-2 JIT. 286119 1 69029 loki 2010-09-28 00:42:37 -0700 Created attachment 69029 Remove unnecessary cacheFlush calls from Thumb-2 The setPointer function calls setInt32 which calls cacheFlush on the corresponding instructions. So, there is no need for a second cacheFlush on the same address range. SunSpider: 1.007x as fast V8: 1.017x as fast 287420 2 69029 ossy 2010-09-30 01:02:02 -0700 Comment on attachment 69029 Remove unnecessary cacheFlush calls from Thumb-2 LGTM, r=me. 287428 3 69029 commit-queue 2010-09-30 01:37:39 -0700 Comment on attachment 69029 Remove unnecessary cacheFlush calls from Thumb-2 Clearing flags on attachment: 69029 Committed r68764: <http://trac.webkit.org/changeset/68764> 287429 4 commit-queue 2010-09-30 01:37:44 -0700 All reviewed patches have been landed. Closing bug. 69029 2010-09-28 00:42:37 -0700 2010-09-30 01:37:39 -0700 Remove unnecessary cacheFlush calls from Thumb-2 0001-Remove-unnecessary-cacheFlush-calls-from-Thumb-2.patch text/plain 2258 loki RnJvbSAwNjBiNmFhMWMzNjAwMGJiMTQzODdiNTg1ZmFjMjZmN2Q3N2FlYzRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVHVlLCAyOCBTZXAgMjAxMCAwOTozMDowNCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFJlbW92 ZSB1bm5lY2Vzc2FyeSBjYWNoZUZsdXNoIGNhbGxzIGZyb20gVGh1bWItMgoKU2lnbmVkLW9mZi1i eTogR2Fib3IgTG9raSA8bG9raUBpbmYudS1zemVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmggfCAgICA2IC0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YTQyNGI4Li5jNTNjYTU3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysr IGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMjgg IEdhYm9yIExva2kgIDxsb2tpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IGNhY2hlRmx1c2ggY2Fs bHMgZnJvbSBUaHVtYi0yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NjcwMgorCisgICAgICAgICogYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmg6Cisg ICAgICAgIChKU0M6OkFSTXY3QXNzZW1ibGVyOjpyZWxpbmtDYWxsKToKKyAgICAgICAgKEpTQzo6 QVJNdjdBc3NlbWJsZXI6OnJlcGF0Y2hJbnQzMik6CisgICAgICAgIChKU0M6OkFSTXY3QXNzZW1i bGVyOjpyZXBhdGNoUG9pbnRlcik6CisKIDIwMTAtMDktMjUgIEhvbGdlciBIYW5zIFBldGVyIEZy ZXl0aGVyICA8aG9sZ2VyQG1vaWppLW1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fz c2VtYmxlci5oIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgKaW5k ZXggZDk2MDU0Ni4uZWU1ZDJkNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L0FSTXY3QXNzZW1ibGVyLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNz ZW1ibGVyLmgKQEAgLTE3OTIsOCArMTc5Miw2IEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJUKHJl aW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRvKSAmIDEpOwogCiAgICAgICAgIHNldFBvaW50ZXIo cmVpbnRlcnByZXRfY2FzdDx1aW50MTZfdCo+KGZyb20pIC0gMSwgdG8pOwotCi0gICAgICAgIEV4 ZWN1dGFibGVBbGxvY2F0b3I6OmNhY2hlRmx1c2gocmVpbnRlcnByZXRfY2FzdDx1aW50MTZfdCo+ KGZyb20pIC0gNSwgNCAqIHNpemVvZih1aW50MTZfdCkpOwogICAgIH0KIAogICAgIHN0YXRpYyB2 b2lkIHJlcGF0Y2hJbnQzMih2b2lkKiB3aGVyZSwgaW50MzJfdCB2YWx1ZSkKQEAgLTE4MDEsOCAr MTc5OSw2IEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRw dHJfdD4od2hlcmUpICYgMSkpOwogICAgICAgICAKICAgICAgICAgc2V0SW50MzIod2hlcmUsIHZh bHVlKTsKLQotICAgICAgICBFeGVjdXRhYmxlQWxsb2NhdG9yOjpjYWNoZUZsdXNoKHJlaW50ZXJw cmV0X2Nhc3Q8dWludDE2X3QqPih3aGVyZSkgLSA0LCA0ICogc2l6ZW9mKHVpbnQxNl90KSk7CiAg ICAgfQogCiAgICAgc3RhdGljIHZvaWQgcmVwYXRjaFBvaW50ZXIodm9pZCogd2hlcmUsIHZvaWQq IHZhbHVlKQpAQCAtMTgxMCw4ICsxODA2LDYgQEAgcHVibGljOgogICAgICAgICBBU1NFUlQoIShy ZWludGVycHJldF9jYXN0PGludHB0cl90Pih3aGVyZSkgJiAxKSk7CiAgICAgICAgIAogICAgICAg ICBzZXRQb2ludGVyKHdoZXJlLCB2YWx1ZSk7Ci0KLSAgICAgICAgRXhlY3V0YWJsZUFsbG9jYXRv cjo6Y2FjaGVGbHVzaChyZWludGVycHJldF9jYXN0PHVpbnQxNl90Kj4od2hlcmUpIC0gNCwgNCAq IHNpemVvZih1aW50MTZfdCkpOwogICAgIH0KIAogICAgIHN0YXRpYyB2b2lkIHJlcGF0Y2hMb2Fk UHRyVG9MRUEodm9pZCogd2hlcmUpCi0tIAoxLjcuMC40Cgo=